Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Wed, Nov 25, 2015 at 08:52:09AM -0800, Fish Wang wrote: > Just a small suggestion: I think the following will work: > > - Check the version of the current operating system. > - Dynamically loading related DLLs (in this case, should be WFP-related > libraries) using LoadLibrary() only if

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

gt; Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Subject: Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns') Hi, On Wed, Nov 25, 2015 at 03:19:51PM +0100, Arne Schwabe wrote: > I am not sure if we want to ship separate WIN XP and Vista

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

On 24/11/15 18:49, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Please use the attached version. > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. Thunderbird works great in many areas, but my experience

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Wed, Nov 25, 2015 at 03:19:51PM +0100, Arne Schwabe wrote: > I am not sure if we want to ship separate WIN XP and Vista+ versions. We are in agremeent that we do *not* want that :-) - but we *do* want this patch to work around Win10 DNS brokenness, and that binary won't run on XP. Which

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Am 25.11.15 um 15:15 schrieb Selva Nair: > Hi, > > On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering > wrote: > > Hi, > > On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > > I need help with 2.3 build system. While the code

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering wrote: > Hi, > > On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > > I need help with 2.3 build system. While the code itself would compile > fine, it won't link because I can't figure out how to link libraries >

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Tue, Nov 24, 2015 at 08:49:08PM +0300, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Please use the attached version. > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. Thanks for the attachments,

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Wed, Nov 25, 2015 at 01:32:38AM -0500, Selva Nair wrote: > On Wed, Nov 25, 2015 at 12:31 AM, ValdikSS wrote: > > > It's cron2 who wanted clear ifdefs for master, because there's no WinXP > > support there. > > If WinXP support is really going away in 2.4, It

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > I need help with 2.3 build system. While the code itself would compile fine, > it won't link because I can't figure out how to link libraries available in > vista+ > only for vista+ build and do not link it for XP. Cross-build

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Tue, Nov 24, 2015 at 07:13:17PM -0500, Selva Nair wrote: > Not sure I understand this. The patch I had tested all along had ifdef > _WINNT_WIN32 >= 0x0600 around everything. So the code nicely silences > itself when built for XP (I did not try this though). I built only 64 bit > version

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

On Wed, Nov 25, 2015 at 12:31 AM, ValdikSS wrote: > It's cron2 who wanted clear ifdefs for master, because there's no WinXP > support there. If WinXP support is really going away in 2.4, agreed, ifdef WIN32 is cleaner. That apart, the patch doesn't apply to 2.3, please

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

It's cron2 who wanted clear ifdefs for master, because there's no WinXP support there. I need help with 2.3 build system. While the code itself would compile fine, it won't link because I can't figure out how to link libraries available in vista+ only for vista+ build and do not link it for XP.

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Tue, Nov 24, 2015 at 12:49 PM, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Its not a thunderbird-specific malady, almost every mail client messes up with line breaks, adds extra spaces etc. As Gert suggested please use git

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Tue, Nov 24, 2015 at 3:11 PM, Gert Doering wrote: > > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. > > Well, the 2.3 version would need all the #ifdefs around the code if not > running at VISTA level, and

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Tue, Nov 24, 2015 at 08:49:08PM +0300, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. Because you're not using git send-email :) $ git send-email --to=openvpn-devel@lists.sourceforge.net -1 will magically do everything perfectly (added options available to

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Message - From: "ValdikSS" <i...@valdikss.org.ru> To: "Gert Doering" <g...@greenie.muc.de> Cc: "openvpn-devel" <openvpn-devel@lists.sourceforge.net> Sent: Tuesday, November 24, 2015 5:49 PM Subject: Re: [Openvpn-devel] [PATCH v4-master] Add Windows DN

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

I can't figure out why Thunderbird corrupts my patches. Please use the attached version. I still need help with 2.3 build system. If somebody willing to help me, please use the attached version. On 24.11.2015 11:39, Gert Doering wrote: > Hi, > > On Thu, Nov 19, 2015 at 06:20:19PM +0300, ValdikSS

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Thu, Nov 19, 2015 at 06:20:19PM +0300, ValdikSS wrote: > This option blocks all out-of-tunnel communication on TCP/UDP port 53 (except > for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. Indeed, what Selva said - the patch is whitespace-mangled. Valdikss, could you please

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

Hi, On Thu, Nov 19, 2015 at 10:20 AM, ValdikSS wrote: > This option blocks all out-of-tunnel communication on TCP/UDP port 53 > (except > for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. > This version looks fine and works as promised (tested on Win 7 and

[Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

This option blocks all out-of-tunnel communication on TCP/UDP port 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. --- doc/openvpn.8 | 12 +++- src/openvpn/Makefile.am | 2 +- src/openvpn/init.c | 22 ++ src/openvpn/openvpn.vcxproj |