Re: [Openvpn-devel] [PATCH] Fix duplicated PUSH_REPLY options

2016-10-10 Thread Steffan Karger
Hi, On 24 September 2016 at 12:23, Lev Stipakov wrote: > Starting from > https://github.com/OpenVPN/openvpn/commit/3a5a46cf2b7f6a8b8520c2513a8054deb48bfcbe, > we add peer-id and cipher values to context->options->push_list instead of > adding those directly > to buf (as

Re: [Openvpn-devel] New SHA1-signed Windows XP installers ready for testing

2016-10-10 Thread Samuli Seppänen
Il 10/10/2016 14:37, debbie10t ha scritto: > > > On 10/10/16 10:17, Samuli Seppänen wrote: >> Hi, >> >> New Windows XP installers signed with a new SHA1 code-signing >> certificate are now available: >> >> >>

Re: [Openvpn-devel] Topics for today's (Monday, 10th Oct 2016) community meeting

2016-10-10 Thread Jonathan K. Bullard
On Mon, Oct 10, 2016 at 8:56 AM, Samuli Seppänen wrote: > > We're going to have an IRC meeting today starting at 20:00 CEST (18:00 > UTC) on #openvpn-meeting irc.freenode.net. You do not have to be > logged in to Freenode to join the channel. I can't attend the meeting, so

[Openvpn-devel] [PATCH applied] Re: Enable TCP non-linear packet ID

2016-10-10 Thread Gert Doering
ACK. Amazingly simple - "just remove all notion of TCP in the packet ID code". Your patch has been applied to the master branch. I have fixed a small whitespace error in comp.c. commit 55755e6ee56516c96525e6bf313c173653af1a4b Author: Arne Schwabe Date: Sat Sep 17 16:15:38 2016 +0200

Re: [Openvpn-devel] [PATCH] Enable -D_SVR4_2 for compilation on Solaris

2016-10-10 Thread Matthias Andree
Am 10.10.2016 um 09:39 schrieb Gert Doering: > + CPPFLAGS="$CPPFLAGS -D_XPG4_2" NAK. Description mismatches content. Please revert and reapply with proper description. -- Check out the vibrant tech community

Re: [Openvpn-devel] [PATCH] Enable -D_SVR4_2 for compilation on Solaris

2016-10-10 Thread Gert Doering
Hi, On Mon, Oct 10, 2016 at 07:23:33PM +0200, Matthias Andree wrote: > Am 10.10.2016 um 09:39 schrieb Gert Doering: > > + CPPFLAGS="$CPPFLAGS -D_XPG4_2" > NAK. Description mismatches content. Please revert and reapply with > proper description. Indeed. Silly me. So much effort for a

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen
Il 10/10/2016 18:09, debbie10t ha scritto: > Hi > > On 10/10/16 14:42, Samuli Seppänen wrote: > >> Installers with the attached patch: >> >> >>

Re: [Openvpn-devel] [PATCH v4] Remove tun-ipv6 Option. Instead assume that IPv6 is always supported.

2016-10-10 Thread Gert Doering
Hi, On Sat, Sep 17, 2016 at 12:36:16PM +0200, Arne Schwabe wrote: > @@ -1127,6 +1127,8 @@ do_ifconfig (struct tuntap *tt, >if ( do_ipv6 ) > { > #ifdef NETBSD_MULTI_AF > +#error no IPv6 support for tun interfaces on NetBSD before 4.0, upgrade your > system. > +#endif If we keep

Re: [Openvpn-devel] [PATCH v3] Use separate list for per-client push options

2016-10-10 Thread Steffan Karger
Hi, On 10-10-16 16:54, Lev Stipakov wrote: > Move client-specific push options (currently peer-id and cipher) to > separate list, which is deallocated after push_reply > has been send. This makes sure that options fit into buf, > not duplicated nor leak memory on renegotiation. Feature-ACK.

[Openvpn-devel] (no subject)

2016-10-10 Thread Leon Tanoh
172.29.29.1 -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list

[Openvpn-devel] [PATCH] Enable -D_SVR4_2 for compilation on Solaris

2016-10-10 Thread Gert Doering
Solaris' header files to not make necessary macros (like CMSG_SPACE) available unless told "this is the API level we want" - thus, do so. This fixes --multihome on OpenSolaris 11 (at least). trac #750 Signed-off-by: Gert Doering --- configure.ac |1 + 1 files changed,

[Openvpn-devel] [PATCH applied] Re: Enable -D_SVR4_2 for compilation on Solaris

2016-10-10 Thread Gert Doering
Your patch has been applied to the master branch. commit 6eaa70e80aea7dfd1b3114fcb369a8f72c19ceee Author: Gert Doering Date: Mon Oct 10 09:39:31 2016 +0200 Enable -D_SVR4_2 for compilation on Solaris Signed-off-by: Gert Doering Acked-by: Arne Schwabe

[Openvpn-devel] [PATCH applied] Re: Exclude peer-id from pulled options digest

2016-10-10 Thread Gert Doering
Your patch has been applied to the release/2.3 branch. commit 84022030dc2af8606e6a11c3dca1780419e7a534 Author: Lev Stipakov Date: Tue Oct 4 22:53:06 2016 +0300 Exclude peer-id from pulled options digest Acked-by: Steffan Karger Message-Id:

[Openvpn-devel] [PATCH applied] Re: Fix compilation in pedantic mode

2016-10-10 Thread Gert Doering
ACK. I've decided to leave the whitespace changes as they were in your patch ("git show -w" will confirm only whitespace and comments have been changed), and changed the multiline comment to "leading *" style, as discussed previously. Your patch has been applied to the release/2.3 branch.

Re: [Openvpn-devel] [PATCH] Enable -D_SVR4_2 for compilation on Solaris

2016-10-10 Thread Arne Schwabe
I cannot test Solaris but the code looks good enough, so ACK Arne Am 10.10.16 um 09:39 schrieb Gert Doering: > Solaris' header files to not make necessary macros (like CMSG_SPACE) > available unless told "this is the API level we want" - thus, do so. > > This fixes --multihome on OpenSolaris 11

[Openvpn-devel] [PATCH applied] Re: Exclude peer-id from pulled options digest

2016-10-10 Thread Gert Doering
Your patch has been applied to the master branch. commit 3cf51f613c4d0ac0982826cd2e27e1f34bcd1a83 Author: Lev Stipakov Date: Tue Oct 4 23:20:03 2016 +0300 Exclude peer-id from pulled options digest Acked-by: Steffan Karger Message-Id:

[Openvpn-devel] New SHA1-signed Windows XP installers ready for testing

2016-10-10 Thread Samuli Seppänen
Hi, New Windows XP installers signed with a new SHA1 code-signing certificate are now available: Could someone verify

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen
Il 09/10/2016 18:25, Gert Doering ha scritto: > Hi, > > On Sun, Oct 09, 2016 at 05:06:59PM +0200, Gert Doering wrote: >> Running more tests with that hunk reverted next... > > With the following patch applied on top of Heiko's patch > > diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c > index

[Openvpn-devel] [PATCH v3] Use separate list for per-client push options

2016-10-10 Thread Lev Stipakov
v3: - rebase on master v2: - Also move ifconfig and ipv6-ifconfig to separate options list Move client-specific push options (currently peer-id and cipher) to separate list, which is deallocated after push_reply has been send. This makes sure that options fit into buf, not duplicated nor leak

Re: [Openvpn-devel] Topics for today's (Monday, 10th Oct 2016) community meeting

2016-10-10 Thread Arne Schwabe
Am 10.10.16 um 16:15 schrieb Jonathan K. Bullard: > On Mon, Oct 10, 2016 at 8:56 AM, Samuli Seppänen wrote: >> We're going to have an IRC meeting today starting at 20:00 CEST (18:00 >> UTC) on #openvpn-meeting irc.freenode.net. You do not have to be >> logged in to Freenode

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread debbie10t
Hi On 10/10/16 14:42, Samuli Seppänen wrote: > Installers with the attached patch: > > >