Acked-by: Gert Doering
As discussed.
Tested with a basic client run on FreeBSD14 with DCO.
Your patch has been applied to the master and release/2.6 branch.
commit 5e79aed439d4e1b101c768aabfd695cd1c0a54ce (master)
commit 73ce6ac984e3ab496f97979e41f2a27569a432fd (release/2.6)
Author: Ilya
Hi,
> It looks much simpler to write the above 5 lines as
>
> _stprintf_s(name, name_len, TEXT("%ls #%d"), base_name, i)
Agreed.
> If (adapter_name) is false, we reach here with iResult not set, but it gets
> referenced below. Add an else { iResult = 1; } or initialize iResult to 1 at
> top?
Acked-by: Gert Doering
This is all voodoo to me, but it doesn't break compilation, doesn't
bring in unsafe pointer constructs, and people say "it makes their use
case work", so it sounds like a good fix.
Microsoft documentation on
From: Lev Stipakov
At the moment if --name is not specified, adapter names
are generated by Windows and they look a bit confusing
like "Local Area Connection 2".
This is also behavior of "Add a new virtual network
adapter" shortcuts.
This makes tapctl generate driver-specific names for
Acked-by: Gert Doering
The patch is actually quite trivial - just prevent the "if (dco)"
option checker from unsetting --dev-node...
I have not tested it beyond "stare-at-code" and "do a MinGW test compile".
Your patch has been applied to the master and release/2.6 branch.
commit
Acked-by: Selva Nair
On Fri, May 19, 2023 at 4:27 AM Lev Stipakov wrote:
> From: Lev Stipakov
>
> At the moment if --name is not specified, adapter names
> are generated by Windows and they look a bit confusing
> like "Local Area Connection 2".
>
> This is also behavior of "Add a new virtual
This is implements --peer-fingerprint command to support OpenVPN authentication
without involving a PKI.
The current implementation in OpenVPN for peer fingerprint has been already
extensively rewritten from the original submission from Jason. The commit
preserved the original author since it was
Hi,
While this bugfix should be merged, I'm a conflicted about the way these
two patches are split up. It just makes reviewing harder than it should be.
They actually form two independent changes but with one half intersecting
with the other for no reason.
On Wed, May 17, 2023 at 7:03 AM Arne
This reverts commit 423ced962db3129b4ed551c489624faba4340652, which
has Jason A. Donenfeld as author.
Jason has expressed that he does not want to be bothered with the
license change of OpenVPN and unfortunately that leaves us no alternative
other than to remove his contribution from OpenVPN in
