Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-26 Thread David Sommerseth
On 24/08/2019 21:40, Gert Doering wrote: > Hi, > > On Sat, Aug 24, 2019 at 06:04:21PM +0200, Arne Schwabe wrote: >> I want to give you an honest opionion of mine to merging WolfSSL in >> OpenVPN. Please note, that this is my personal opinion and not to be >> confused to be an official OpenVPN comm

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-24 Thread Steffan Karger
Hi, On 24-08-19 21:40, Gert Doering wrote: > On Sat, Aug 24, 2019 at 06:04:21PM +0200, Arne Schwabe wrote: >> I want to give you an honest opionion of mine to merging WolfSSL in >> OpenVPN. Please note, that this is my personal opinion and not to be >> confused to be an official OpenVPN community

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-24 Thread Gert Doering
Hi, On Sat, Aug 24, 2019 at 06:04:21PM +0200, Arne Schwabe wrote: > I want to give you an honest opionion of mine to merging WolfSSL in > OpenVPN. Please note, that this is my personal opinion and not to be > confused to be an official OpenVPN community project or OpenVPN Inc > position. Arne sum

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-24 Thread Arne Schwabe
Hey, thanks for taking your time to answer. I want to give you an honest opionion of mine to merging WolfSSL in OpenVPN. Please note, that this is my personal opinion and not to be confused to be an official OpenVPN community project or OpenVPN Inc position. For every patch we have to decide if

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-23 Thread Juliusz Sosinowicz
Hi, thank you for the feedback. To answer your questions: - Why WolfSSL in OpenVPN instead of mbed or OpenSSL wolfSSL can be compiled to use very few resources in a wide array of embedded environments. wolfSSL is FIPS ready - that is it has all the code available to be FIPS 140 validated on a

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-16 Thread Gert Doering
Hi, On Fri, Aug 16, 2019 at 05:22:27PM +0200, Antonio Quartulli wrote: > The reason why I ask is that adding a new crypto backend drastically > increases the maintenance cost for us. ... and since we're already struggling with providing proper maintenance and getting new stuff integrated in a ti

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-16 Thread Antonio Quartulli
Hi Juliusz, On 16/08/2019 16:14, Juliusz Sosinowicz wrote: > This patch adds the option to use wolfSSL as the ssl backend. To build > this patch: > > 1. wolfSSL needs to be built with the `--enable-all` configure option. > 2. OpenVPN must be built with the `--with-crypto-library=wolfssl` >    conf

Re: [Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-16 Thread Arne Schwabe
Am 16.08.19 um 16:14 schrieb Juliusz Sosinowicz: > This patch adds the option to use wolfSSL as the ssl backend. To build > this patch: > That is great and it is also a very big patch. I skimmed only through the patch. +#ifdef ENABLE_CRYPTO_WOLFSSL +o->ciphername = "AES-256-CBC"; +#else

[Openvpn-devel] [PATCH] Adding support for wolfSSL backend

2019-08-16 Thread Juliusz Sosinowicz
This patch adds the option to use wolfSSL as the ssl backend. To build this patch: 1. wolfSSL needs to be built with the `--enable-all` configure option. 2. OpenVPN must be built with the `--with-crypto-library=wolfssl` configure option. Documentation regarding the wolfSSL SSL library may be