Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-10-10 Thread Selva Nair
Hi, On Sun, Oct 7, 2018 at 3:38 AM Gert Doering wrote: > Hi, > > On Sun, Mar 04, 2018 at 12:44:02PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Openssl docs do not explicitly state these to be macros although they > > are currently defined as such. Use AC_CHECK_DECLS to

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-10-07 Thread Gert Doering
Hi, On Sun, Mar 04, 2018 at 12:44:02PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > Openssl docs do not explicitly state these to be macros although they > are currently defined as such. Use AC_CHECK_DECLS to test for these so that > both function and macro forms could be detected.

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Selva Nair
Hi, On Sun, Mar 4, 2018 at 6:22 PM, Steffan Karger wrote: > > On 05-03-18 00:13, Jeremie Courreges-Anglas wrote: >> On Sun, Mar 04 2018, Selva Nair wrote: >> --8<-- >> [...]. OpenSSL itself only provided said setters (since 2015)[2]. The >> getters

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Steffan Karger
On 05-03-18 00:13, Jeremie Courreges-Anglas wrote: > On Sun, Mar 04 2018, Selva Nair wrote: > --8<-- > [...]. OpenSSL itself only provided said setters (since 2015)[2]. The > getters were added to OpenSSL later (Sep 2017)[3]. > > [2] >

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Selva Nair
Hi, On Sun, Mar 4, 2018 at 1:48 PM, Jeremie Courreges-Anglas wrote: > On Sun, Mar 04 2018, selva.n...@gmail.com wrote: >> From: Selva Nair >> >> Openssl docs do not explicitly state these to be macros although they >> are currently defined as such. > >

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, selva.n...@gmail.com wrote: > From: Selva Nair > > Openssl docs do not explicitly state these to be macros although they > are currently defined as such. Actually they are documented as macros by OpenSSL since day 1, see NOTES. > Use AC_CHECK_DECLS to

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Mina Barret via Openvpn-devel
Great, Thank You! -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Openvpn-devel mailing list

[Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread selva . nair
From: Selva Nair Openssl docs do not explicitly state these to be macros although they are currently defined as such. Use AC_CHECK_DECLS to test for these so that both function and macro forms could be detected. Signed-off-by: Selva Nair --- Though