Hi,
On Sat, Jun 29, 2019 at 05:50:24PM +0300, Lev Stipakov wrote:
> That --allow-nonadmin functionality was included into commit 3c7f2f553 from
> yeah 2005. Here is code from tap-win32/tapdrv.c from the same commit:
Sounds like these bits were lost in the port from tap5 to tap6 - which
changed qu
Hi,
On Sat, Jun 29, 2019 at 05:34:51PM +0300, Lev Stipakov wrote:
> Indeed that registry key is confusing. If we fix it in tap6, won't we break
> existing setups, which open tap6
> from unprivileged process and do not use --allow-nonadmin?
Well, the default on installation would either have to be
Hi,
On Sat, Jun 29, 2019 at 10:35 AM Lev Stipakov wrote:
>
> Hi,
>
>> So Lev's patch proposes to do service calls for wintun *and* tap6, and
>> do so "always"? Or only if the registry key says so?
>
>
> Yep, patch always opens wintun and tap6 via service no matter what
> registry key says.
Yes,
Hi,
On Sat, Jun 29, 2019 at 10:50 AM Lev Stipakov wrote:
>
> That --allow-nonadmin functionality was included into commit 3c7f2f553 from
> yeah 2005. Here is code from tap-win32/tapdrv.c from the same commit:
>
> +#if ENABLE_NONADMIN
> + /* Read AllowNonAdmin setting from registry */
> +
That --allow-nonadmin functionality was included into commit 3c7f2f553 from
yeah 2005. Here is code from tap-win32/tapdrv.c from the same commit:
+#if ENABLE_NONADMIN
+ /* Read AllowNonAdmin setting from registry */
+ {
+ NDIS_STRING key = NDIS_STRING_CONST("AllowNonAdmin");
+
Hi,
So Lev's patch proposes to do service calls for wintun *and* tap6, and
> do so "always"? Or only if the registry key says so?
>
Yep, patch always opens wintun and tap6 via service no matter what
registry key says.
> For some reason that registry key appears to be doing nothing in
> > curren
Hi,
On Fri, Jun 28, 2019 at 05:43:13PM -0400, Selva Nair wrote:
> That's what lev's patch would do, but it wont respect the registry key
> which is "supposed" to toggle non-admin access to tap-windows6
> adapters on and off.
I'm still not following, sorry. Maybe I did not review the patch enough
Hi,
On Fri, Jun 28, 2019 at 5:03 PM Gert Doering wrote:
>
> Hi,
>
> On Fri, Jun 28, 2019 at 04:51:47PM -0400, Selva Nair wrote:
> > Would that mean we can assume that always allowing all users access to
> > the tap (say, using the service to open it) would not be a regression?
> > Or are there fo
Hi,
On Fri, Jun 28, 2019 at 04:51:47PM -0400, Selva Nair wrote:
> Would that mean we can assume that always allowing all users access to
> the tap (say, using the service to open it) would not be a regression?
> Or are there folks who use local builds of the driver and expect
> openvpn.exe to resp
On Fri, Jun 28, 2019 at 4:51 PM Selva Nair wrote:
>
> Hi,
>
> While testing a patch, I failed to toggle AllowNonAdmin access to the
> tap-adapter.
> Looking at the sources it seems we do not respect that setting.
>
> From adapter.c ~line
The quoted code was from tap-windows6/src/adapter.c ~line 4
10 matches
Mail list logo
