Re: [OpenWrt-Devel] [PATCH] swconfig: support setting SWITCH_TYPE_LINK attributes

2016-01-13 Thread Stefan Rompf
Hi, On Montag, 11. Januar 2016 23:45:39 Rafał Miłecki wrote: > > Any comments to this usage/syntax? It doesn't look too nice (this long > > quoted string as a value), but swconfig is strongly focused on simple > > values. > > One more RFC... anyone? I am not an OpenWRT core developer so I

Re: [OpenWrt-Devel] [PATCH] swconfig: support setting SWITCH_TYPE_LINK attributes

2016-01-05 Thread Stefan Rompf
Hi Rafał, > Supported syntax is inspired by ethtool. Example usage: > swconfig dev switch0 port 2 set link "duplex half speed 100 autoneg off" > > Signed-off-by: Rafał Miłecki I think that's the way to go, will try implementing set_port_link() for my good old 1043ND. Ack

Re: [OpenWrt-Devel] [PATCH 1/3] swconfig: add SWITCH_TYPE_LINK and support sending link info to user space

2015-12-20 Thread Stefan Rompf
Hi Rafał, On Mittwoch, 16. Dezember 2015 18:19:01 Rafał Miłecki wrote: > So far we were sending link data as a string. It got some drawbacks: > 1) Didn't allow writing clean user space apps reading link state. It was >needed to do some screen scraping. > 2) Forced whole PORT_LINK

Re: [OpenWrt-Devel] [PATCH v4 1/2] Add ubnt_hsr platform flag and enable for UniFi Outdoor Plus

2015-12-14 Thread Stefan Rompf
Hi Tim, > The auto-built image of 9 December 2015 for this device results in a > bricked state. TFTP recovery with a stock recovery firmware from > Ubiquity does not allow the device to boot either. try flashing the chaos calmer factory image with TFTP

Re: [OpenWrt-Devel] [PATCH][RFC] kernel: swconfig: add API for setting port link speed

2015-12-13 Thread Stefan Rompf
Hi Rafał, > int (*get_port_link)(struct switch_dev *dev, int port, >struct switch_port_link *link); > + int (*set_port_link)(struct switch_dev *dev, int port, > + enum switch_port_speed speed); this creates an assymetric API. I think

Re: [OpenWrt-Devel] [PATCH v4 0/2] Support Ubiquiti Unifi Outdoor Plus HSR filter

2015-07-13 Thread Stefan Rompf
On Dienstag, 16. Juni 2015 23:14:05 Stefan Rompf wrote: so we arrive at the fourth iteration of the patchset to support the HSR of the Ubiquiti Unifi Outdoor Plus access point. This version implements the suggestions from Felix. Ping? Stefan

Re: [OpenWrt-Devel] [PATCH v4 2/2] Add HSR tuner to ath9k

2015-06-16 Thread Stefan Rompf
Add tuner for the HSR filter of the UniFi Outdoor Plus access point. Usage of the tuner is controlled at runtime by ath9k_platform_data. The code can be enabled or disabled by a compile time option. Signed-off-by: Stefan Rompf ste...@loplof.de --- Index: package/kernel/mac80211/Makefile

[OpenWrt-Devel] [PATCH v4 0/2] Support Ubiquiti Unifi Outdoor Plus HSR filter

2015-06-16 Thread Stefan Rompf
Hi, so we arrive at the fourth iteration of the patchset to support the HSR of the Ubiquiti Unifi Outdoor Plus access point. This version implements the suggestions from Felix. We lost the feature to avoid tuning the same channel multiple times in a row, but this should not be critical. The

Re: [OpenWrt-Devel] [PATCH v4 1/2] Add ubnt_hsr platform flag and enable for UniFi Outdoor Plus

2015-06-16 Thread Stefan Rompf
Add ubnt_hsr flag to struct ath9k_platform_data and enable it for the Outdoor Plus access point so that the availability ot the HSR filter can be detected by the ath9k driver at runtime. Signed-off-by: Stefan Rompf ste...@loplof.de --- Index: package/kernel/mac80211/patches/150

Re: [OpenWrt-Devel] [PATCH v3 1/2] [mac80211] Add channel set helper callback to ath9k

2015-06-13 Thread Stefan Rompf
Hi Felix, thanks for your feedback! NACK from me for the ath9k_set_channel_helper part. This helper function needs to be passed in from the platform data, similar to how external reset is handled. From previous emails you pointed out that you guys chose this design/structure simply because

Re: [OpenWrt-Devel] [PATCH v3 1/2] [mac80211] Add channel set helper callback to ath9k

2015-06-13 Thread Stefan Rompf
Hi Felix, Maybe in this case it would be better to put the code in ath9k.ko and enable it via a Kconfig option in the mac80211 package. Then add a bool flag to the ath9k_platform_data struct to enable it only for devices that need it. sounds good to me, will create a patch... Stefan

[OpenWrt-Devel] [PATCH v3 0/2] Support Ubiquiti Unifi Outdoor Plus HSR filter

2015-06-12 Thread Stefan Rompf
Hi, this is the third iteration of the patchset to support the HSR filter of the Ubiquiti Unifi Outdoor Plus access point. The HSR is a configurable RF filter in the receive path that must be tuned according to the selected Wifi channel for the access point to work. Patch 1 adds a channel set

[OpenWrt-Devel] [PATCH v3 2/2] Add kmod-ubnt-hsr tuner for the UBNT HSR filter

2015-06-12 Thread Stefan Rompf
Add the tuner for the Ubiquiti Outdoor Plus HSR filter as a self contained kmod package. When loaded, it registers with ath9k as a channel set helper and tunes the HSR on every channel change. Signed-off-by: Stefan Rompf ste...@loplof.de --- Index: package/kernel/ubnt-hsr/Makefile

[OpenWrt-Devel] [PATCH v3 1/2] [mac80211] Add channel set helper callback to ath9k

2015-06-12 Thread Stefan Rompf
This patch adds a channel set helper callback to the ath9k driver and exports the ath9k kernel API for other packages. The registered function is called whenever ath9k changes the channel. Signed-off-by: Stefan Rompf ste...@loplof.de --- Index: package/kernel/mac80211/Makefile

[OpenWrt-Devel] [PATCH v2 2/2] Support Ubiquiti Unifi Outdoor Plus HSR filter

2015-06-08 Thread Stefan Rompf
Add kmod-ubnt-hsr package that tunes the HSR filter of the access point as a ath9k channel change helper Signed-off-by: Stefan Rompf ste...@loplof.de --- Index: package/kernel/ubnt-hsr/Makefile === --- package/kernel/ubnt-hsr

[OpenWrt-Devel] [PATCH v2 0/2] Support Ubiquiti Unifi Outdoor Plus HSR filter

2015-06-08 Thread Stefan Rompf
Hi, this patchset adds support for the HSR filter of the Ubiquiti Unifi Outdoor Plus access point. The HSR is a configurable RF filter in the receive path that must be tuned according to the selected Wifi channel for the access point to work. Patch 1 adds a channel change helper callback to

Re: [OpenWrt-Devel] [PATCH RFC] Add support for Ubiquiti Unifi Outdoor Plus

2015-06-08 Thread Stefan Rompf
Hi Kirill, hi Arjen, thanks for your feedback. I'll create a new version of the patch with your updates and suggestions. I will also try to move the HSR tuner module into it's own subdirectory below package/kernel to minimize the mac80211 patch that Felix will have to maintain. I also

[OpenWrt-Devel] [PATCH RFC] Add support for Ubiquiti Unifi Outdoor Plus

2015-06-06 Thread Stefan Rompf
hsr_mod_exit(void) ++{ ++ rtnl_lock(); ++ ath9k_register_set_channel_helper(NULL); ++ rtnl_unlock(); ++} ++ ++module_init(hsr_mod_init); ++module_exit(hsr_mod_exit); ++ ++MODULE_AUTHOR(Kirill Berezin, Stefan Rompf); ++MODULE_DESCRIPTION(Support for Ubiquiti Outdoor Plus HSR filter

Re: [OpenWrt-Devel] ar71xx: How to integrate UniFi AP Outdoor Plus HSR?

2015-06-03 Thread Stefan Rompf
(Kirill Berezin, Stefan Rompf); +MODULE_DESCRIPTION(Support for Ubiquiti Outdoor Plus HSR filter.); +MODULE_SUPPORTED_DEVICE(Ubiquiti Outdoor Plus); +MODULE_LICENSE(GPL); + diff -Nur linux/drivers/net/wireless/ath/ath9k.orig/Makefile linux/drivers/net/wireless/ath/ath9k/Makefile --- linux/drivers

Re: [OpenWrt-Devel] ar71xx: How to integrate UniFi AP Outdoor Plus HSR?

2015-06-01 Thread Stefan Rompf
Hi Kirill, An Unifi specific user space daemon listens to scan and channel change events via netlink (will check next weekend if channel change is broadcasted reliably) and tune the filter via sysfs interface accordingly like hsr.c tried. I like this idea because in this case it'll be

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-26 Thread Stefan Rompf
Hi Kirill, Updated version is in the attachment. I tried it on a real device, but I can't say that the problem was solved, but something is definitely happens. which OpenWrt image did you use? I flashed openwrt-15.05-rc1-ar71xx-generic- ubnt-unifi-outdoor-plus-squashfs-factory.bin and did not

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-26 Thread Stefan Rompf
Hi, It seems that ath9k does not even export its pins to the GPIO subsystem. ok, here we go. For the brave ones who know their pci wifi chip is at 0x1000 and don't mind bit banging io registers. Surely still all usleep() timers wrong and full of unknown side effects. But tunes the hsr

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-22 Thread Stefan Rompf
Hi, Updated version is in the attachment. I tried it on a real device, but I can't say that the problem was solved, but something is definitely happens. related question: After installing OpenWRT on the access point, do you know whether I can revert using the instructions from:

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-22 Thread Stefan Rompf
Hi Kirill, Updated version is in the attachment. I tried it on a real device, but I can't say that the problem was solved, but something is definitely happens. Unfortunately I couldn't find where a bunch of zeros were generated, so I skipped this part ))) (I tried a version with zeros, but

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-20 Thread Stefan Rompf
Hi Kirill, On Dienstag, 19. Mai 2015 15:11:31 Kirill Berezin wrote: I think that they tune an external receiver via some sort of SPI bus (GPIO pins are 5,6,7,8). Write procedure is quite simple, but I can't still get how enable works (for sure it sends a disable); it is quite possible that

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-20 Thread Stefan Rompf
Hi, -Trapping ar5416GpioSet with some hand crafted assembly code that traces calls and logs them somewhere this works. I've trapped ar5416GpioSet, putting my code into space occupied by the unused function ar5416GpioCfgInput. ar5416GpioGet is work to do. I can send the code, but it will

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-05-17 Thread Stefan Rompf
Hi Matthias, Any news here? I know a lot of people who are eager to run OpenWrt on their UAP Outdoor+ ... oh well so nearly two months have passed I must admit no news. I am/was planning to run the code in ARMSim to analyze what is sent to the filter and from where. Still want to do

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-03-21 Thread Stefan Rompf
Hi Sergey, You should be a wizard to reveal hw protocol without touching hw :) I cannot say 'Mischief managed!' by now, but it's slowly making progress ;-) Unlikely that iwconfig changes something directly, I would bet on the driver. Indeed. So far -The RF filter is controlled by the GPIO

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-03-18 Thread Stefan Rompf
On Dienstag, 17. März 2015 23:24:26 Sergey Ryazanov wrote: Interesting enough: When stopping all wifi related software on the device and creating a monitor interface, the RF filter seems to follow iwconfig channel commands (yes it is the madwifi driver). How do you realized that RF

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-03-17 Thread Stefan Rompf
Hi Sergey, If they built SPIoverGPIO or I2CoverGPIO or some other serial bus over GPIO, then you do not see any changes between channel switches. Or they could use some non GPIO interface to communicate with external filter (embedded SPI, I2C or even USB or PCI of SoC). well, GPIO has been

Re: [OpenWrt-Devel] Ubiquiti AirOS7 is based on openwrt r40432

2015-03-17 Thread Stefan Rompf
Hi Federico, On Donnerstag, 12. März 2015 13:37:37 Nemesis wrote: I went at this URL: https://www.ubnt.com/download/?group=nanobeam-ac Clicked on GPL Archive, downloaded it, extracted it, and took a look in it and found out a readme file which states: that the archive contains all GPL

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for the UniFi AP Outdoor Plus

2015-03-16 Thread Stefan Rompf
Hi, On Mittwoch, 11. März 2015 15:14:21 Shvedov Yury wrote: Thank you for your answer. We will try to solve this issue with our own forces. any progress on this? I have one of these access points available right now for hacking (as long as I do not brick it). The last hours I made those