Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-26 Thread Per Åstrand
On 2010-05-26 12:10 AM, Per ?strand wrote: Hi! I've updated the patch for wnr3500l to build against @21567. I don't have access to the router for a couple of more days, so it's untested so far. Please remove all #ifdef CONFIG_WNR3500L It makes the code harder to read and it's not acceptable

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-26 Thread Tathagata Das
I have already submitted one separate patch for sflash. Below is the link of the same. http://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg05976.html Regards, Tathagata Per Åstrand wrote: On 2010-05-26 12:10 AM, Per ?strand wrote: Hi! I've updated the patch for wnr3500l to

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-25 Thread Felix Fietkau
On 2010-05-26 12:10 AM, Per Åstrand wrote: Hi! I've updated the patch for wnr3500l to build against @21567. I don't have access to the router for a couple of more days, so it's untested so far. Please remove all #ifdef CONFIG_WNR3500L It makes the code harder to read and it's not acceptable

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-20 Thread Tathagata Das
What do you mean to say clean up the flash driver you have ? Regards, Tathagata Bernhard Loos wrote: 2010/5/17 Tathagata Das tathag...@alumnux.com: Okay, so I will start working on those drivers (serial and wired). Does current version of OpenWRT trunk supports WNR3500L ? Otherwise I need

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-20 Thread Bernhard Loos
Your patch contains a driver for the serial flash chip on the wnr3500l, but it's kinda ugly (excessive ioremaps, duplicated defines, global statics, ...). If you could clean this up, it would have a chance of getting accepted. Bernhard 2010/5/20 Tathagata Das tathag...@alumnux.com:

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-20 Thread Tathagata Das
Fine, I will clean up this serial flash driver as much as possible and submit it again. Regards, Tathagata Bernhard Loos wrote: Your patch contains a driver for the serial flash chip on the wnr3500l, but it's kinda ugly (excessive ioremaps, duplicated defines, global statics, ...). If you

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-19 Thread Bernhard Loos
2010/5/17 Tathagata Das tathag...@alumnux.com: Okay, so I will start working on those drivers (serial and wired). Does current version of OpenWRT trunk supports WNR3500L ? Otherwise I need to download latest trunk, modify it to run on WNR3500L and then concentrate on drivers. I doesn't but

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-17 Thread Bernhard Loos
2010/5/17 Tathagata Das tathag...@alumnux.com: Hi, I have used source code of version 21251. It might be possible that some fixes has been made after that version which is not reflected in my code. So if I use latest code then that issue will be resolved. The bugs are in the patch, not in the

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-17 Thread Tathagata Das
Okay, so I will start working on those drivers (serial and wired). Does current version of OpenWRT trunk supports WNR3500L ? Otherwise I need to download latest trunk, modify it to run on WNR3500L and then concentrate on drivers. If you elaborate the idea of spi master driver then it would help

Re: [OpenWrt-Devel] [PATCH] Kernel patch in trunk (version 21251) to support Netgear WNR3500L

2010-05-15 Thread Weedy
On Fri, May 14, 2010 at 4:22 AM, Tathagata Das tathag...@alumnux.com wrote: Hi, Attached is the kernel patch to support Netgear WNR3500L. All changes are made under CONFIG_WNR3500L. I have used trunk source code of version number 21251 to create this kernel patch. Regards, Tathagata