Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Inline is better for commenting the patch, as the comment can be placed directly at the discussed location. But a mangled patch is hard to apply. If it is attached it normally doesn't get mangled, but then commenting is harder as the relevant code is not shown. So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Maddes On 22.11.2010 08:52, Stefan Tomanek wrote: Please attach patches as files next time, since inlining often screws them up (in this case spaces - tabs). Although https://dev.openwrt.org/wiki/SubmittingPatches says otherwise? Send a mail to openwrt-devel at lists.openwrt.org with the following contents: [...] 4. Your actual patch, inline, not word wrapped or whitespace mangled. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Dies schrieb Matthias Buecher / Germany (m...@maddes.net): So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Can you point me to the line where any mangling took place? I just checked the list reply of my own message, which looks completely fine to me, but when checking your reply, I noticed some tabs being replaced by spaces inside the quoted patch. I don't think mutt does any mangling, since the message itself is generated by git format-patch and sent as it is. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
On 22.11.2010 09:35, Stefan Tomanek wrote: Dies schrieb Matthias Buecher / Germany (m...@maddes.net): So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Can you point me to the line where any mangling took place? I just checked the list reply of my own message, which looks completely fine to me, but when checking your reply, I noticed some tabs being replaced by spaces inside the quoted patch. I don't think mutt does any mangling, since the message itself is generated by git format-patch and sent as it is. Hadn't a look at your patch, maybe also his mail client mangles the mail when only displayed. I'm using Thunderbird 3.1 and my current settings mangle the mail when I reply. As far as I know your setup shouldn't mangle the patch. Can someone confirm? (Note to myself: finally try to setup TB correctly) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] iptables compile fix
Gr... Whatever I try it compiles now (even my own .config works)... Weird since there is nothing changed to the iptables package lately (or related things?). Only change I can think of is the update to Kubuntu 10.10 (from 10.04), but that was a while ago as well. Unfortunately I do not have a 10.04 to test this theory (and it should be be the reason as well I guess). Thanks for your help and time! Maarten On Wed, 2010-11-17 at 22:20 +0100, Bas Mevissen wrote: On 11/17/2010 10:02 PM, Maarten Bezemer wrote: Compiling iptables goes wrong after a make distclean and only modification is the target set to Marvel Orion. This evening I will send my .config file as well. It is attached Please throw away the .config file in your tree. It is wildly different from the one you get from a clean checkout. I'm not saying it is wrong, but I first want to get you going with a fresh start. Then we can see it the problem is gone. Attached is my .config file (renamed to dotconfig). You can compare them. Please note that the one you attached was in DOS line endings. So I ran dos2unix over it before comparing. Regards, ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] Compile fix for r24041
Hello,
the following patches points to a compilation problem with svn
revision r24041 and gives one possible solution.
Bye,
Joerg
Index: package/mac80211/patches/800-b43-gpio-mask-module-option.patch
===
--- package/mac80211/patches/800-b43-gpio-mask-module-option.patch
(revision 24041)
+++ package/mac80211/patches/800-b43-gpio-mask-module-option.patch
(working copy)
@@ -22,15 +22,22 @@
static int modparam_bad_frames_preempt;
module_param_named(bad_frames_preempt, modparam_bad_frames_preempt, int,
0444);
MODULE_PARM_DESC(bad_frames_preempt,
-@@ -2534,10 +2539,10 @@ static int b43_gpio_init(struct b43_wlde
+@@ -2534,17 +2534,9 @@
~B43_MACCTL_GPOUTSMSK);
b43_write16(dev, B43_MMIO_GPIO_MASK, b43_read16(dev, B43_MMIO_GPIO_MASK)
+-#ifndef CONFIG_GPIOMMC
- | 0x000F);
+-#else
+- | 0x0001);
+-#endif
+ | modparam_gpiomask);
-
mask = 0x001F;
+-#ifndef CONFIG_GPIOMMC
- set = 0x000F;
+-#else
+- set = 0x0001;
+-#endif
+ set = modparam_gpiomask;
if (dev-dev-bus-chip_id == 0x4301) {
mask |= 0x0060;
signature.asc
Description: Digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] iptables compile fix
On Mon, 22 Nov 2010 11:51:22 +0100, Maarten Bezemer m.m.beze...@utwente.nl wrote: Gr... Whatever I try it compiles now (even my own .config works)... Weird since there is nothing changed to the iptables package lately (or related things?). Only change I can think of is the update to Kubuntu 10.10 (from 10.04), but that was a while ago as well. Unfortunately I do not have a 10.04 to test this theory (and it should be be the reason as well I guess). Thanks for your help and time! OK, Happy to hear it is solved now. These things happen now and then and are difficult to reproduce and even more difficult to pin down to what is actually causing it. Anyway, thanks for the feedback. Bas. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] toolchain: introducing gcc 4.4.5 with Linaro enhancements
Hi, On Sun, 21 Nov 2010 12:37:37 +0100, Marcus Osdoba marcus.osd...@googlemail.com wrote: Currently I'm working on improved dockstar support for OpenWrt. The current toolchain 4.3.3+cs is not that up to date and linaro 4.5 branch is already included. Unfortunatly, this version does not support Marvell Feroceon (mtune=marvell-f). The Linaro version 4.4.5 does. So I added support for 4.4.5+l in OpenWrt, which can be found here: http://gitorious.org/dockstar/openwrt-trunk/commit/2fcb44e0f16a41ef409aaa9d424e473bf86eb34c http://gitorious.org/dockstar/openwrt-trunk/commit/2fcb44e0f16a41ef409aaa9d424e473bf86eb34c.patch I compiled the recent trunk with it and flashed it onto my dockstar device. Works perfectly. Feel free to demand an evidence if needed. Please consider the integration of version 4.4.5 LINARO into OpenWrt (similar to 4.5.1+l). Once done, the kirkwood platforms may point to it by default: http://gitorious.org/dockstar/openwrt-trunk/commit/b8d23a89c920f3caf8ac7b050b4dab568108f05b http://gitorious.org/dockstar/openwrt-trunk/commit/b8d23a89c920f3caf8ac7b050b4dab568108f05b.patch Talked to Linaro. The feroceon optimization has been removed from the Linaro and CS toolchains because it will never make it upstream, as Marvell didn't assign it to the FSF. I don't want to have yet another gcc version, so if you really want this optimization, please submit a patch to add only that - or we can go back to -mtune=xscale for feroceon as well. Imre ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
