Re: [OpenWrt-Devel] [PATCH 2/5] build: image: Add pad-to and pad-rootfs-squashfs helpers

2019-03-31 Thread Jo-Philipp Wich
Hi, >>> I would like to avoid adding generating padded images by default. >> >> To just save some space? We're gzipping the images by default, which makes >> image padded to 256M just 2.7M big. I find 256M overkill for testing, so >> that's why I've suggested 32M by default for QEMU padded

Re: [OpenWrt-Devel] [PATCH v3 4/7] uboot-tegra: add U-Boot for tegra boards

2019-03-31 Thread Jo-Philipp Wich
Hi Tomasz, > BTW Is there somewhere a list of packages installed on buildbots and is the > list consistent across all of them? we're slowly converging towards this: apt-get install -y \ pwgen \ locales \ buildbot-slave \ build-essential \ git-core \

Re: [OpenWrt-Devel] [PATCH] base-files/hotplug: add "dialout" user group and use it for ttyXYZ devices

2019-03-31 Thread Jo-Philipp Wich
Hi Michael, > well, it seems that the second commit did not survive (at least in master > branch)... indeed, it was broken by an improperly rebased commit: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=5209cfa534293cb6d27574b51d03bd69a5defb0c I'd be fine with a v2 which

Re: [OpenWrt-Devel] [PATCH] base-files/hotplug: add "dialout" user group and use it for ttyXYZ devices

2019-03-30 Thread Jo-Philipp Wich
Hi, the "tty" group has been introduced exactly for this purpose some time ago (1)(2). Any reason why we need "dialout" as well? ~ Jo 1: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=5523ee3459a2d346ad068ce359cdb60dcda1239d 2:

Re: [OpenWrt-Devel] [PATCH] libfstools: Output error in case of loop blkdev failure

2019-03-27 Thread Jo-Philipp Wich
Hi Petr, I suggest to rephrase the subject to something like "print error in case". I kept reading "output error" and wondered what went wrong with the output. > It took me quite some time today(while fixing squashfs+overlay on > armvirt) to find out, that I was missing support for loop block

Re: [OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-26 Thread Jo-Philipp Wich
HI, I too think that making host route installation dependent on the fwmark option is not intuitive. > So maybe we can add an explicit option 'nohostroute' instead of making > it depend on 'fwmark'? A "nohostroute" (I'd prefer "peerroute" with default "1") would make sense imho. It should also

Re: [OpenWrt-Devel] OpenWrt 19.03 plans

2019-03-21 Thread Jo-Philipp Wich
Hi, > Is there any kind of "official" roadmap/checklist available what "needs" > to be done? not that I am aware of, but from the top of my head: - make sure all targets are ported properly to 4.14 - disable all devices which cannot cannot handle the increased kernel size anymore - drop all

Re: [OpenWrt-Devel] RFC: procd patch to run as container/lxd

2019-03-20 Thread Jo-Philipp Wich
Hi, > procd causes trouble when running in a LXD container, however would be > nice to use OpenWrt as small VMs. > > There are patches [0] "fixing" the issue, but they're not really > upstream ready (for obvious reasons). > > Would it be possible to add a detection to procd if it's running in

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi, > I think the cmake.mk-link approach would be a good idea and given > previous discussions the plan is afaik to pull in Ninja first and > once that's confirmed working via CMake add support for Meson. fine with me. > Having a look at https://www.python.org/dev/peps/pep-0537/#lifespan >

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi Jan, > I'm trying to add ninja and meson to packages feed. The reason for that > is described here https://github.com/openwrt/openwrt/pull/1871 and > https://github.com/openwrt/packages/issues/8315 . great to hear that! I think eventually there should be a "tools/meson/Makefile" along with an

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi, > A number of upstream projects are beginning to use the Meson/Ninja build > system. OpenWrt's sound/mpc and libs/libmpdclient kludge around this, > and I would like to update the glib2 package. The latest version of > glib2 uses Meson/Ninja. just what the world needed, yet another build

Re: [OpenWrt-Devel] [PATCH] build: have scripts/feeds honor feed.mk of the individual feed

2019-03-07 Thread Jo-Philipp Wich
Hi, tbh I don't really like the approach of arbitrarily defining "feed.mk" to be a change source. Can we extend this to take all toplevel *.mk files into consideration? I think this falls more in line with what people would expect. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] Random PARTUUID on every rebuild

2019-03-07 Thread Jo-Philipp Wich
Hi, > Could this be a CLI parameter to make, or something that's written to > the .config? Once it is set in .config it will remain the same with every subsequent rebuild, defeating its purpose entirely. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] [PATCH] build: have scripts/feeds honor feed.mk of the individual feed

2019-03-07 Thread Jo-Philipp Wich
Hi, I do not understand the exact purpose of this patch. As far as I know, there is no "feed.mk" anywhere in the LuCI repo. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Random PARTUUID on every rebuild

2019-03-06 Thread Jo-Philipp Wich
Hi, the random PARTUUID has been chosen to ensure that a given boot grub partition (containing grub config, kernel, sysupgrade restore tarball) boots the correct corresponding rootfs in case multiple openwrt partitions are present on the device (e.g. different versions on different block

[OpenWrt-Devel] OpenWrt 18.06.2 service release

2019-02-01 Thread Jo-Philipp Wich
The OpenWrt Community is proud to announce the second service release of the stable OpenWrt 18.06 series. OpenWrt 18.06.2 incorporates a fair number of bug fixes in the network userland and the build system, as well as updates to the kernel and base packages. --- Some selected highlights of the

Re: [OpenWrt-Devel] 18.06.2 branching/builds

2019-01-30 Thread Jo-Philipp Wich
Hi, unfortunately the tag has already been created and builds are running are already running and uploading. We can bump mt76 with the next point release in a few weeks. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel

[OpenWrt-Devel] Merged: ramips: fix D-Link DIR-615 H1 switch port mapping

2019-01-30 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] A second 'make' always rebuilds something

2019-01-30 Thread Jo-Philipp Wich
Hi, please share the exact steps used to trigger the issue. Running a simple "make" after an initial build here does not trigger the recompilation of uci or the kernel. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-30 Thread Jo-Philipp Wich
Hi, > That is true. But, on the other hand, the same routine was not printing > anything if IS_TTY is not 1. I would say that this is unexpected > behaviour too. If the log file shows some error, it would be nice to see > what part was being processed. this might be, but the scope of this patch

Re: [OpenWrt-Devel] A second 'make' always rebuilds something

2019-01-30 Thread Jo-Philipp Wich
Hi, as far as I know, the Gluon build system is performing various rather invasive changes to the build system. Please see if you can replicate the same behavior with a vanilla OpenWrt build root. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] [PATCH] openwrt-18.06: ar71xx: Fix 5 GHz MAC address for Archer C60 v2

2019-01-30 Thread Jo-Philipp Wich
Hi, this patch should go through master first. It currently does not apply there. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

[OpenWrt-Devel] Merged: mbedtls: update to 2.14.1 for 18.06

2019-01-30 Thread Jo-Philipp Wich
Merged into openwrt-18.06 at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-29 Thread Jo-Philipp Wich
Hi, your patch would disable the complete output if NO_COLOR is set. That does not seem to meet the expected behavior. Looks like the fallback path should still print $(1) to stderr, just without ANSI escape sequences. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] INSTALL_SUID macro

2019-01-22 Thread Jo-Philipp Wich
Hi Daniel, I am fine with adding a fakeroot solution. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] config: enable some useful features on !SMALL_FLASH devices

2019-01-15 Thread Jo-Philipp Wich
Hi, I lean towards enabling these features by default. With the eventual switch to 4.19, most 4M boards will fall of the cliff anyway. Regards, Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH] e2fsprogs: Update to 1.43.5

2019-01-14 Thread Jo-Philipp Wich
Hi, its not about symlinks, its about the paths embedded in these generated scripts. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH 1/3] base-files: change boot & umount STOP levels -2

2019-01-13 Thread Jo-Philipp Wich
Hi Joseph, I've been thinking that we maybe should lower the STOP index even further, to at least 90. Apart from that the patch looks good. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] Notes on (dangerous ?) sysupgrade

2019-01-13 Thread Jo-Philipp Wich
Hi Reiner, > After having several unpleasant encounters using sysupgrade, I had a > quick glance at the code, after more or less successfully implementing > workarounds for incomplete sysupgrades, resulting in inconsistent systems. > My questions are: > - Is it safe, simply to kill running

Re: [OpenWrt-Devel] [PATCH] e2fsprogs: Update to 1.43.5

2019-01-13 Thread Jo-Philipp Wich
Hi, > Remove patch 000-relocatable.patch as it seems to be no longer needed. did you verify that the generated compile_et and make_cmds scripts are installed without absolute paths in the host staging directory? If not, then removing this path will result in very hard to debug SDK build

Re: [OpenWrt-Devel] [PATCH] mdadm: add new init features; documentation; bug fixes

2019-01-10 Thread Jo-Philipp Wich
Hi, comments inline. > [...] > + # partition - stateless, mdadm --assemble --scan > --config=partition; see mdadm(8) > + # uci - stateful, dynamically generated mdadm.conf via uci > array values (below), > + # stored in /var/etc/mdadm.conf > + #

Re: [OpenWrt-Devel] Do all devs follow GitHub or is list still the preferred discussion location?

2019-01-09 Thread Jo-Philipp Wich
Hi, personally I rarely visit Github PRs these days, any discussions going on there (in issues or PRs) will likely get overlooked by most devs. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] Firewall settings must be manually changed for 6to4

2018-12-30 Thread Jo-Philipp Wich
Hi, > I recently set up an OpenWrt 18.06.1 router at a place where the ISP > does not provide native IPv6, but does provide their own 6to4 > tunnelling server. I installed 6to4 and ip-full on the router and > configured WAN6, but was puzzled as to why IPv6 wasn't working until I > discovered that

Re: [OpenWrt-Devel] Removed target staging dir in SDK

2018-12-21 Thread Jo-Philipp Wich
Hi, > Why did you remove this dir? To save space on the download servers. > If we want to build custom binaries using SDK, should we use something else? Use the feeds mechanism within the SDK to build your required libaries first, e.g.: ./scripts/feeds update ./scripts/feeds install libpcap

Re: [OpenWrt-Devel] New CT firmware images

2018-12-20 Thread Jo-Philipp Wich
Hi, pushed as https://git.openwrt.org/c0248183a49a9830a4a2458e54e83fa8a3c646c9 after some smoke testing on a QCA9882 (Netgear R6100) ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH firewall3 2/2] utils: Free args in __fw3_command_pipe()

2018-12-19 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Hauke Mehrtens Acked-by: Jo-Philipp Wich ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall3 1/2] options.c, redirects.c: Fix possible buffer overflows

2018-12-19 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Hauke Mehrtens Acked-by: Jo-Philipp Wich ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] dropbear: fix dropbear startup issue

2018-12-18 Thread Jo-Philipp Wich
Hi Hans, > [...] > +boot() > +{ > + BOOT=1 > + start "@" Typo here, should likely be "$@". Otherwise Acked-by. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Missing GPG signatures

2018-12-17 Thread Jo-Philipp Wich
Hi, > It seems only Robert Call of the LibreCMC fork is consistently signing > releases > with the same key. But how is he verifying upstream...? probably by trusting https://openwrt.org/docs/guide-user/security/signatures I cross-signed the 18.06 key with the 17.01 one now and signed both

Re: [OpenWrt-Devel] [RFC] stop accepting 4/32M board patches

2018-12-15 Thread Jo-Philipp Wich
Hi, I'm against rejecting such submissions if they're self-contained enough (e.g. for DTS based targets as mentioned by Piotr). I'd favor accepting the basic board support for such boards but disabling the image generation (commented out). ~ Jo signature.asc Description: OpenPGP digital

Re: [OpenWrt-Devel] 18.06-snapshots?

2018-12-12 Thread Jo-Philipp Wich
Hi, > Just wondering if there are snapshots built for the backports etc > done onto the 18.06 tree (e.g. in preparation for 18.06.2), or after > release are there only adhoc builds for release candidates for the > point release? http://downloads.openwrt.org/releases/18.06-SNAPSHOT/ > If there

Re: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents

2018-12-07 Thread Jo-Philipp Wich
Hi, I had a brief discussion with John on this matter and was being told that the reason for this filter was to optimize boot time. When we remove the /dev filter, boot time will increase considerably on lower end devices due to the resulting hotplug-call overhead of the huge volume of

Re: [OpenWrt-Devel] [RFC] stop accepting 4/32M board patches

2018-12-06 Thread Jo-Philipp Wich
Hi, > At least for me that's the but another reason was to enable guest > network (and BTW why Luci just don't have a single button for this?). Because it has not been implemented yet. Adding the code for it would probably consume another 5-10KB uncompressed. > [...] > Let's take for example

Re: [OpenWrt-Devel] [RFC] stop accepting 4/32M board patches

2018-12-06 Thread Jo-Philipp Wich
Hi, > Even standard Luci can be easily and significantly reduced in twice just > by removing images and icons. I don't think this is true. The few icons bundled with LuCI at are approx 19KB overall while a recent mips 24kc snapshot build of luci-base is 126KB in size. So the images account for

Re: [OpenWrt-Devel] [PATCH firewall3] redirects: properly handle src_dport in SNAT rules

2018-12-06 Thread Jo-Philipp Wich
> parameter is not. > As this logic is in place to mimic the old shell script based firewall > behavior for DNAT only set port_redir in case the redirect rule is > a DNAT rule. > > Signed-off-by: Hans Dedecker Acked-by: Jo-Philipp Wich > --- > redirects.c | 2 +- > 1 f

Re: [OpenWrt-Devel] [PATCH] procd: simplify code in procd_inittab_run

2018-12-05 Thread Jo-Philipp Wich
Hi, > This is a trial to make it more obvious what the historically > grown code is actually doing. when we already refactor the code... > Signed-off-by: Michael Heimpold > --- > inittab.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/inittab.c b/inittab.c

Re: [OpenWrt-Devel] Enable security labels on ext4?

2018-11-10 Thread Jo-Philipp Wich
Hi, what is the size increase in kmod-ext4 due to this? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [RFC PATCH] build: re-enable parallelism for mksquashfs

2018-11-07 Thread Jo-Philipp Wich
Hi, > I'm not sure what you mean by the images being reproducible. It means that different mksquashfs runs with different amounts of CPUs on different hosts should yield bit-identical images having the same checksum given the same input. ~ Jo signature.asc Description: OpenPGP digital

Re: [OpenWrt-Devel] Why does perl get compiled even if it not selected by any package?

2018-11-04 Thread Jo-Philipp Wich
Hi Hannu, yes - without any dependency tweaking (e.g. by introducing conditionals like you suggested) a given source package build-depends on the union of all dependencies of all binary packages declared by the source package. The only way to mitigate that is using conditional dependencies in

Re: [OpenWrt-Devel] Add "Stale" plugin to packages feed

2018-11-01 Thread Jo-Philipp Wich
Hi Etienne, I would like that. The auto-close message should be mentioned that this closure marks not a rejection and that a user is free to reopen a rebased PR if he still wants it to go in. Regards, Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] ar71xx snapshots stuck at October 9

2018-10-23 Thread Jo-Philipp Wich
Hi, because they don't build since that date anymore. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 2/2] treewide: use wpad-basic for not small flash targets

2018-10-16 Thread Jo-Philipp Wich
Hi, > From: Mathias Kresin > > Add out of the box support for 802.11r and 802.11w to all targets not > suffering from small flash. > > Signed-off-by: Mathias Kresin > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Jo-Philipp Wich __

Re: [OpenWrt-Devel] [PATCH 1/2] hostapd: add basic variant

2018-10-16 Thread Jo-Philipp Wich
Hi, > Add a basic variant which provides WPA-PSK only, 802.11r and 802.11w. > > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Jo-Philipp Wich ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.or

Re: [OpenWrt-Devel] Sign OpenWRT 18.06 PGP key with LEDE 17.01 PGP key

2018-10-11 Thread Jo-Philipp Wich
And how did you came to trust the LEDE 17 key in the first place? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] dnsmasq stops receiving packets after network restart

2018-09-25 Thread Jo-Philipp Wich
Hi Kristian, does the same happen without "bind-dynamic" ? My hunch is that dnsmasq fails to "resubscribe" to the socket after the ifindex of br-lan changed due to the network restart (which will destroy and recreate br-lan). Maybe netlink congestion or something related to privilege dropping?

Re: [OpenWrt-Devel] dnsmasq stops receiving packets after network restart

2018-09-24 Thread Jo-Philipp Wich
Hi, whats the complete dnsmasq cmdline? ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] netifd: proto-dhcp: handle alias interfaces

2018-09-15 Thread Jo-Philipp Wich
Hi, the functionality seems arbitrary and overly specific to your use case, also the option name "alias" does not really explain the effects of setting this option. IMHO you rather should write/ship a custom /etc/hotplug.d/iface/ script which deals with downing the fallback alias interface when

Re: [OpenWrt-Devel] [PATCH] procd: Add cpu string to board detection

2018-09-15 Thread Jo-Philipp Wich
Hi, > diff --git a/system.c b/system.c > index 151f613..87ce2da 100644 > --- a/system.c > +++ b/system.c > @@ -65,6 +65,7 @@ static int system_board(struct ubus_context *ctx, struct > ubus_object *obj, > > if (!strcasecmp(key, "system type") || >

Re: [OpenWrt-Devel] Move rrdns to rpcd?

2018-09-15 Thread Jo-Philipp Wich
Hi, > why is the rrdns located under luci? because its a rpcd plugin provided by LuCI, hosted in the LuCI repo and used by LuCI. > Can we make it consistent place rrdns somewhere else? Should be doable. > Furthermore we should change the Makefile of rpcd and the cmakefile that > rrdns ist

[OpenWrt-Devel] Merged: grub2: Fix CVE-2015-8370

2018-08-22 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: bzip2: Fix CVE-2016-3189

2018-08-22 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2] build: add mkrasimage

2018-08-21 Thread Jo-Philipp Wich
Hi, > RAS_VERSION := "V1.99(OWRT.$$(shell echo $(REVISION) | sed s/^r//))C0" make that RAS_VERSION := "V1.99(OWRT.$(patsubst r%,%,$(REVISION)))C0" to avoid spawning a shell + sed process. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] [PATCH] uhttpd: add support for mutual authentication (mTLS)

2018-08-20 Thread Jo-Philipp Wich
Hi, comments inline. > From: Nuno Morais > > Optional mutual authentication (mTLS) > by providing a CA certificate through a new new flag "-M" > in order to verify client's identity. > > For B2B applications. > > This patch depends on patch > "[OpenWrt-Devel] [PATCH] ustream-ssl: add optional

[OpenWrt-Devel] OpenWrt 18.06.1 service release

2018-08-18 Thread Jo-Philipp Wich
The OpenWrt Community is proud to announce the first service release of stable OpenWrt 18.06 series, which marks the first major version after the remerger of the LEDE and OpenWrt projects. OpenWrt 18.06.1 incorporates a number of mostly security oriented fixes backported from the development

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread Jo-Philipp Wich
Hi, personally I'm opposed to the entire code load thing. First of all I was unable to reproduce the tarballs offered by Github. Github seems to use an extended tar (pax) format while we pack our SCM clones using the more traditional ustar format, however even using `tar -cp -H pax

[OpenWrt-Devel] Merged: Change the sigb buffer to be the same size as thefread

2018-08-08 Thread Jo-Philipp Wich
Merged into project/ucert.git, branch master at http://git.openwrt.org/?p=project/ucert.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall3] defaults: use a generic check_kmod() function

2018-08-07 Thread Jo-Philipp Wich
Hi, applied in https://git.openwrt.org/06fa692c80fb2beb69d23d0a2c5cf667aa12f4ad ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Drop unused kernel versions

2018-08-07 Thread Jo-Philipp Wich
Ack! ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-07 Thread Jo-Philipp Wich
Hi, > respectfully, the behaviour of the "wifi" command is one of the most > obtuse parts of openwrt's tooling. It does "something" with no > command output, and responds ~instantly.This is expected > behaviour for very few people. even "wifi asdfasdfa" returns > ~instantly, with no warning

[OpenWrt-Devel] Merged: uclient-http: Close ustream file handle only if allocated

2018-08-03 Thread Jo-Philipp Wich
Merged into project/uclient.git, branch master at http://git.openwrt.org/?p=project/uclient.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] OpenWrt 18.06.0 final

2018-08-01 Thread Jo-Philipp Wich
Hi, The OpenWrt community is proud to announce the first release of the OpenWrt 18.06 stable version series. It incorporates over 4000 commits since branching the previous LEDE 17.01 release and has been under development for well over a year. With this release, the re-merged OpenWrt project

Re: [OpenWrt-Devel] Multi build failures using today's master

2018-07-30 Thread Jo-Philipp Wich
Hi Koen, > In function 'ath10k_dfs_radar_report': > /mnt/ramdisk/koen/firmware/builds/generic_glmifi/build_dir/target-mips_24kc_musl/linux-ar71xx_generic/ath10k-ct-2018-05-30-127f9818/ath10k-4.13/wmi.c:3993:7: > error: too few arguments to function 'ar->dfs_detector->add_pulse' >   if

Re: [OpenWrt-Devel] Disclaimer for user documentation?

2018-07-30 Thread Jo-Philipp Wich
Hi, maybe it would make sense to copy one of the standard boilerplate liability remarks from one of the OSS licenses and put that as generic statement into the wiki footer. Example from Apache 2.0: "Unless required by applicable law or agreed to in writing, software distributed under the

Re: [OpenWrt-Devel] 'fw3' failed to connect to ubus

2018-07-26 Thread Jo-Philipp Wich
Hi, see https://bugs.openwrt.org/index.php?do=details_id=1693 - fixed with https://git.openwrt.org/3ee2c76ae0 (https://git.openwrt.org/aa8846bb10) Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] lede-imagebuilder-17.01.5-ar71xx-generic.Linux-x86_64 fails to build image

2018-07-19 Thread Jo-Philipp Wich
Hi again, As a workaround, run the following command once within the IB/SDK directory: sed -i -e 's,/\(usr\|lib\|etc\)/,/###/,g' ./staging_dir/host/lib/libc.so.6 This will prevent the bundled glibc from trying to dlopen() libraries on the host system which is the root cause of the assertion.

Re: [OpenWrt-Devel] lede-imagebuilder-17.01.5-ar71xx-generic.Linux-x86_64 fails to build image

2018-07-19 Thread Jo-Philipp Wich
Hi, works for me on Debian 9 und Ubuntu 18. I've got reports that it is broken on Arch which I am currently trying to install but it seems to be a pain ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH 2/2] add channel information for scan results

2018-07-15 Thread Jo-Philipp Wich
Hi, comments inline. ~ Jo > diff --git a/include/iwinfo.h b/include/iwinfo.h > index c3c25ff..b1b39a1 100644 > --- a/include/iwinfo.h > +++ b/include/iwinfo.h > @@ -145,6 +145,24 @@ struct iwinfo_crypto_entry { > uint8_t auth_suites; > uint8_t auth_algs; > }; > +struct

Re: [OpenWrt-Devel] [PATCH 1/2] add htmodelist for scan results

2018-07-15 Thread Jo-Philipp Wich
Hi, comments inline. On 07/13/2018 10:57 AM, Yury Shvedov wrote: > diff --git a/include/iwinfo.h b/include/iwinfo.h > index 929f697..c3c25ff 100644 > --- a/include/iwinfo.h > +++ b/include/iwinfo.h > @@ -154,6 +154,7 @@ struct iwinfo_scanlist_entry { > uint8_t signal; > uint8_t

Re: [OpenWrt-Devel] [PATCH 0/4] Overhaul distfeeds.conf generation

2018-07-11 Thread Jo-Philipp Wich
> This patchset implements a way to add additional distfeeds.conf entries > (src-dummy method), makes rootfs creation independent of feed enable > status, and moves from global ADD_DISABLED and ADD_COMMENTED symbols to > per-feed configuration. Acked-by: Jo-

Re: [OpenWrt-Devel] [PATCH v2] build: download code from github using archive API

2018-06-29 Thread Jo-Philipp Wich
Hi, > Looks like it's caused by the excessive python script call. This is > indeed unexpected. I just pushed a commit to disable it altogether > for now. Sorry for the inconvenience ;( is there anything preventing you from doing a change like below to wire in the github archiving script? --

Re: [OpenWrt-Devel] [PATCH v2] build: download code from github using archive API

2018-06-28 Thread Jo-Philipp Wich
Hi, > It seems to be like that script does things even if the tarballs are > already existing locally. the main problem I see is that you moved the download method detection from inline make code into the external Python script ... this will cause a lot of overhead as during the metadata

Re: [OpenWrt-Devel] [PATCH v2] build: download code from github using archive API

2018-06-28 Thread Jo-Philipp Wich
Hi Yousong, this change seems to introduce serious runtime regressions, see https://bugs.openwrt.org/index.php?do=details_id=1621 It seems to be like that script does things even if the tarballs are already existing locally. On a slightly related note, I find the name to be too generic. It

Re: [OpenWrt-Devel] [PATCH] iwinfo: add channel survey

2018-06-25 Thread Jo-Philipp Wich
Hi, yes I'd prefer to see Lua bindings implemented for that. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] iwinfo: add channel survey

2018-06-05 Thread Jo-Philipp Wich
Hi, please find code comments inline below. Do you plan to extend the Lua binding as well? Also I wonder what the intended use case of this change is... (lib)iwinfo was once meant to provide a common uniform subset of wireless information across different driver backends such as proprietary wl,

Re: [OpenWrt-Devel] SHA256 password

2018-05-29 Thread Jo-Philipp Wich
Hi Lev, the patch was added to save space. Dropping it will increase the libc size by a few kilobytes. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/listinfo/openwrt-devel

Re: [OpenWrt-Devel] FS#1567 reported: making openrwrt unusable (BT Home Hub 5) since between r6080 and r7050

2018-05-28 Thread Jo-Philipp Wich
Hi, > This does not make sense, is the alternative to write off openwrt? > Because if ADSL + PPPoA do not work, then it is useless. Indeed, if OpenWrt does not work for your device then you should look for alternatives or try to dig into the issue yourself. > As a minimum I would expect a

Re: [OpenWrt-Devel] FS#1567 reported: making openrwrt unusable (BT Home Hub 5) since between r6080 and r7050

2018-05-28 Thread Jo-Philipp Wich
Hi, > Is anyone looking into it? I doubt it, unfortunately the info in the ticket is too vague to work with. Personally I don't have any hardware to debug this. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

[OpenWrt-Devel] [RFC PATCH ustream-ssl] openssl: support OpenSSL 1.1.x API

2018-05-20 Thread Jo-Philipp Wich
SSL_library_init() and SSL_load_error_string() in favor to calling OPENSSL_init_ssl() instead, so adjust the ustream initalization to use either variant, depending on the OpenSSL version. Signed-off-by: Jo-Philipp Wich <j...@mein.io> --- ustream-io-openssl.

Re: [OpenWrt-Devel] OpenWRT mtd tooling vs mtd-utils

2018-05-18 Thread Jo-Philipp Wich
Hello David, this was actually my fault. I didn't pay close attention and assumed the code to be related to the kernel MTD subsystem. Only now after your mail I realized that it affects the OpenWrt specific formatting utility. I am very sorry for the confusion caused. Kind regards, Jo

Re: [RFC] Relocate OpenWrt mailing lists to infradead

2018-05-17 Thread Jo-Philipp Wich
Hi, the mailing lists should be moved now; lede-...@lists.infradead.org became openwrt-devel@lists.openwrt.org lede-...@lists.infradead.org became openwrt-...@lists.openwrt.org those who've been subscribed to the LEDE lists should still be subscribed as the subscription list has been kept

[OpenWrt-Devel] Merged: x86: fix bios mkimage during efi image generation

2018-03-14 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-21 Thread Jo-Philipp Wich
Hi, ACK from me as well. > ACK to enable it for packages, not sure if it makes sense for core as we > enforce this in the project git repo already, and Github is just a mirror. It does make sense to provide immediate feedback on Github pull requests I assume. ~ Jo

Re: [OpenWrt-Devel] patchwork

2018-01-18 Thread Jo-Philipp Wich
Hi John, Alex, I have no problem with closing / autorejecting open tickets in patchwork as long as they somehow remain available for future reference. > To add here. Would it be possible/desire-able to add an auto-timeout > to patchwork & github PRs, issues to close after X time ? Maybe make >

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

2018-01-14 Thread Jo-Philipp Wich
Hi Weedy, can you provide some more context lines to see which package those broken depends belong to? Thanks, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH 13/15] metadata: always resolve dependencies through provides list

2018-01-10 Thread Jo-Philipp Wich
Hi, [...] > diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl > index 980ad24dc0..41e7108322 100755 > --- a/scripts/package-metadata.pl > +++ b/scripts/package-metadata.pl > @@ -101,14 +101,16 @@ my %dep_check; > sub __find_package_dep($$) { > my $pkg = shift; >

Re: [OpenWrt-Devel] [LEDE-DEV] owrt landing page

2018-01-10 Thread Jo-Philipp Wich
Hi, I've been preparing some draft for a future landing page at https://lede-project.org/openwrt. Note that some of the linked pages are obviously still LEDE branded and the links to IRC, lists, forum need to be expanded to point to both OpenWrt and LEDE forums. Maybe someone can pick up from

[OpenWrt-Devel] [RFC 1/2] downloads.mk: introduce name-agnostic PROJECT_GIT variable

2018-01-10 Thread Jo-Philipp Wich
Introduce a name-agnostic PROJECT_GIT variable poiting to https://git.openwrt.org/ and declare LEDE_GIT and OPENWRT_GIT as aliases to it. After some transition time we can drop this alias variables. Signed-off-by: Jo-Philipp Wich <j...@mein.io> --- include/download.mk | 6 -- 1 file c

[OpenWrt-Devel] [RFC 2/2] treewide: replace LEDE_GIT with PROJECT_GIT

2018-01-10 Thread Jo-Philipp Wich
Remove LEDE_GIT references in favor to the new name-agnostic PROJECT_GIT variable. Signed-off-by: Jo-Philipp Wich <j...@mein.io> --- package/libs/librpc/Makefile | 2 +- package/libs/libubox/Makefile| 2 +- package/libs/uclient/Makefile| 2 +- packag

[OpenWrt-Devel] OpenWrt source replaced by former LEDE tree

2018-01-10 Thread Jo-Philipp Wich
Hi, following the agreed OpenWrt/LEDE re-merge procedure, we've replaced the OpenWrt Git tree with the LEDE Git tree now and archived the old repository. If you're working with older branches such as Chaos Calmer or Barrier Breaker, you do have to update your remotes in order to continue to be

Re: [OpenWrt-Devel] [RFC] A new developper documentation for OpenWrt/LEDE

2017-10-26 Thread Jo-Philipp Wich
Hi Baptiste, first of all I think that is a great initiative! > So, here is a RFC proposal of a new developer documentation based on > git and Sphinx: > > https://files.polyno.me/openwrt/doc/index.html git clone > git://git.polyno.me/openwrt-doc The layout is okay and the ASCII markup looks

<    1   2   3   4   5   6   7   8   9   10   >