Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Inline is better for commenting the patch, as the comment can be placed directly at the discussed location. But a mangled patch is hard to apply. If it is attached it normally doesn't get mangled, but then commenting is harder as the relevant code is not shown. So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Maddes On 22.11.2010 08:52, Stefan Tomanek wrote: Please attach patches as files next time, since inlining often screws them up (in this case spaces - tabs). Although https://dev.openwrt.org/wiki/SubmittingPatches says otherwise? Send a mail to openwrt-devel at lists.openwrt.org with the following contents: [...] 4. Your actual patch, inline, not word wrapped or whitespace mangled. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Dies schrieb Matthias Buecher / Germany (m...@maddes.net): So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Can you point me to the line where any mangling took place? I just checked the list reply of my own message, which looks completely fine to me, but when checking your reply, I noticed some tabs being replaced by spaces inside the quoted patch. I don't think mutt does any mangling, since the message itself is generated by git format-patch and sent as it is. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
On 22.11.2010 09:35, Stefan Tomanek wrote: Dies schrieb Matthias Buecher / Germany (m...@maddes.net): So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Can you point me to the line where any mangling took place? I just checked the list reply of my own message, which looks completely fine to me, but when checking your reply, I noticed some tabs being replaced by spaces inside the quoted patch. I don't think mutt does any mangling, since the message itself is generated by git format-patch and sent as it is. Hadn't a look at your patch, maybe also his mail client mangles the mail when only displayed. I'm using Thunderbird 3.1 and my current settings mangle the mail when I reply. As far as I know your setup shouldn't mangle the patch. Can someone confirm? (Note to myself: finally try to setup TB correctly) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
This patch upgrade the triggerhappy daemon to upstream version 0.1.6, which fixes several build and runtime issues. Signed-off-by: Stefan Tomanek stefan.tomanek+open...@wertarbyte.de --- utils/triggerhappy/Makefile |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/utils/triggerhappy/Makefile b/utils/triggerhappy/Makefile index 984708d..64deca9 100644 --- a/utils/triggerhappy/Makefile +++ b/utils/triggerhappy/Makefile @@ -6,8 +6,8 @@ include $(TOPDIR)/rules.mk PKG_NAME:=triggerhappy -PKG_VERSION:=0.1.3 -PKG_REV:=f7c42167127fb8377f99440f943ab863433b14b5 +PKG_VERSION:=0.1.6 +PKG_REV:=01bedc72451f8afd0c35649dd67c428c44a0f737 PKG_RELEASE:=1 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz @@ -15,7 +15,6 @@ PKG_SOURCE_URL:=git://github.com/wertarbyte/triggerhappy PKG_SOURCE_PROTO:=git PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) PKG_SOURCE_VERSION:=$(PKG_REV) -PKG_MD5SUM:=7da137a7d2ba1ce396231e821e68de4e include $(INCLUDE_DIR)/package.mk -- 1.7.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Dies schrieb Florian Fainelli (flor...@openwrt.org):
I/home/florian/dev/openwrt/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.31/include
-c -o trigger.o trigger.c
make[3]: *** No rule to make target `evtable_EV.h', needed by `eventnames.o'.
Stop.
I think the Makefile fails to locate linux/input.h; to do this, the following
command is run:
echo '\#include linux/input.h' | $(CC) $(CPPFLAGS) - M -E - | awk 'NR==1
{print $$2}
Any idea why this might not yield the full path to the included file when run
from the openwrt
build system?
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
This patch upgrade the triggerhappy daemon to upstream version 0.1.6, which fixes several build and runtime issues. It also explicitly specifies the path to the header file linux/input.h which is needed during compilation. Signed-off-by: Stefan Tomanek stefan.tomanek+open...@wertarbyte.de --- utils/triggerhappy/Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/triggerhappy/Makefile b/utils/triggerhappy/Makefile index 984708d..a0bde02 100644 --- a/utils/triggerhappy/Makefile +++ b/utils/triggerhappy/Makefile @@ -6,8 +6,8 @@ include $(TOPDIR)/rules.mk PKG_NAME:=triggerhappy -PKG_VERSION:=0.1.3 -PKG_REV:=f7c42167127fb8377f99440f943ab863433b14b5 +PKG_VERSION:=0.1.6 +PKG_REV:=01bedc72451f8afd0c35649dd67c428c44a0f737 PKG_RELEASE:=1 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz @@ -15,7 +15,6 @@ PKG_SOURCE_URL:=git://github.com/wertarbyte/triggerhappy PKG_SOURCE_PROTO:=git PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) PKG_SOURCE_VERSION:=$(PKG_REV) -PKG_MD5SUM:=7da137a7d2ba1ce396231e821e68de4e include $(INCLUDE_DIR)/package.mk @@ -33,6 +32,7 @@ define Package/triggerhappy/description endef MAKE_FLAGS += \ + LINUX_INPUT_H=$(TOOLCHAIN_DIR)/include/linux/input.h \ $(TARGET_CONFIGURE_OPTS) \ $(1) -- 1.7.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Committed in r24076, thanks. Please attach patches as files next time, since inlining often screws them up (in this case spaces - tabs). mirko On Mon, 2010-11-22 at 00:07 +0100, Stefan Tomanek wrote: Signed-off-by: Stefan Tomanek stefan.tomanek+open...@wertarbyte.de --- utils/triggerhappy/Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/triggerhappy/Makefile b/utils/triggerhappy/Makefile index 984708d..a0bde02 100644 --- a/utils/triggerhappy/Makefile +++ b/utils/triggerhappy/Makefile @@ -6,8 +6,8 @@ include $(TOPDIR)/rules.mk PKG_NAME:=triggerhappy -PKG_VERSION:=0.1.3 -PKG_REV:=f7c42167127fb8377f99440f943ab863433b14b5 +PKG_VERSION:=0.1.6 +PKG_REV:=01bedc72451f8afd0c35649dd67c428c44a0f737 PKG_RELEASE:=1 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz @@ -15,7 +15,6 @@ PKG_SOURCE_URL:=git://github.com/wertarbyte/triggerhappy PKG_SOURCE_PROTO:=git PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) PKG_SOURCE_VERSION:=$(PKG_REV) -PKG_MD5SUM:=7da137a7d2ba1ce396231e821e68de4e include $(INCLUDE_DIR)/package.mk @@ -33,6 +32,7 @@ define Package/triggerhappy/description endef MAKE_FLAGS += \ + LINUX_INPUT_H=$(TOOLCHAIN_DIR)/include/linux/input.h \ $(TARGET_CONFIGURE_OPTS) \ $(1) -- This email address is used for mailinglist purposes only. Non-mailinglist emails will be dropped automatically. If you want to get in contact with me personally, please mail to: mirko.vogt at nanl dot de ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] triggerhappy: update to 0.1.6
Dies schrieb Mirko Vogt (li...@nanl.de): Committed in r24076, thanks. Thanks :) Please attach patches as files next time, since inlining often screws them up (in this case spaces - tabs). Although https://dev.openwrt.org/wiki/SubmittingPatches says otherwise? Send a mail to openwrt-devel at lists.openwrt.org with the following contents: [...] 4. Your actual patch, inline, not word wrapped or whitespace mangled. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
