Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-10 Thread Ulrich Hertlein
Hi Robert, On 10/02/10 9:27 , Paul Martz wrote: #define NOTIFY(level) if (isNotifyEnabled(level)) osg::notify(level) Can we please prefix that to something like 'OSG_NOTIFY'? Please?!? Macros are one of these nasty features that happily trample all over other peoples code and don't obey

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-10 Thread Robert Osfield
Hi Ulrich, On Wed, Feb 10, 2010 at 8:13 AM, Ulrich Hertlein u.hertl...@sandbox.de wrote: On 10/02/10 9:27 , Paul Martz wrote: #define NOTIFY(level) if (isNotifyEnabled(level)) osg::notify(level) Can we please prefix that to something like 'OSG_NOTIFY'?  Please?!? Macros are one of these

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-10 Thread Robert Osfield
Hi Paul, Hi Robert -- This change is generating warnings in several places. Here's an example: 5..\..\..\src\osg\State.cpp(296) : warning C4804: '' : unsafe use of type 'bool' in operation Thanks goodness for cross platform build, the warning does reveal a typo that gcc didn't pick up on.

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-10 Thread Mourad Boufarguine
Hi Robert, A build issue under Windows was introduced in src/osgViewer/PixelBufferWin32.cpp : you forgot to replace NOTIFY by OSG_NOTIFY. Mourad On Wed, Feb 10, 2010 at 1:50 PM, Robert Osfield robert.osfi...@gmail.comwrote: Hi Paul, Hi Robert -- This change is generating warnings in

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-10 Thread Robert Osfield
Hi Mourad, On Wed, Feb 10, 2010 at 3:02 PM, Mourad Boufarguine mourad.boufargu...@gmail.com wrote: A build issue under Windows was introduced in src/osgViewer/PixelBufferWin32.cpp : you forgot to replace NOTIFY by OSG_NOTIFY. Thanks for the testing, fix now checked in. Robert.

[osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-09 Thread Robert Osfield
Hi All, Over the last week I've been looking into various issues with the DatabasePager, and one particular problem was major framerate stalls under Windows that occurred when multiple database paging threads were used (such as 8+ threads). Under Linux I had to up the number of threads to 64 to

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-09 Thread Torben Dannhauer
Hi Robert, my compiler runs, thank you very much for this improvement! Well than I 'll start to change all my notifies from osg::notify() to NOTIFY ... Thank you! Cheers, Torben -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=23868#23868

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-09 Thread Tim Moore
On Tue, Feb 9, 2010 at 10:00 PM, Jim Brooks jimbl...@gmail.com wrote: multiple threads try to write to it a ostream they contend for a mutex that Microsoft have used to implement ref counting. If the mutex is really in std::cout (not std::ostream) (???), a possible workaround might be

Re: [osg-users] Windows threadings issues + possible solution checked into svn/trunk, please test.

2010-02-09 Thread Paul Martz
Hi Robert -- This change is generating warnings in several places. Here's an example: 5..\..\..\src\osg\State.cpp(296) : warning C4804: '' : unsafe use of type 'bool' in operation 5..\..\..\src\osg\State.cpp(303) : warning C4804: '' : unsafe use of type 'bool' in operation