The replacement of that inline function with a macro removes the type-safety
offered by C++ and makes the code more accident prone. I did the
static-casts with the multiple parameters because the parameters to the
function aren't necessarily always the same type. Looking into it further, a
single
It's far more readable :) Thanks for the changes. They are
submitted to svn trunk.
Regards,
On Wed, May 25, 2011 at 4:50 PM, Ryan Pavlik rpav...@iastate.edu wrote:
The replacement of that inline function with a macro removes the type-safety
offered by C++ and makes the code more accident
Hi Ryan,
Thank you for the patches. Can you send the whole files instead of
patches, please? You can zip all files together to make it easy.
Thank you!
Best Regards,
On Tue, May 24, 2011 at 7:28 PM, Ryan Pavlik rpav...@iastate.edu wrote:
Hello all,
I've attached small patches to
The changes to osgpreview.cpp are for the first issue, while the changes to
utility.h are for the second way of solving the second issue.
Ryan
On Tue, May 24, 2011 at 12:59 PM, Javier Taibo javier.ta...@gmail.comwrote:
Hi Ryan,
Thank you for the patches. Can you send the whole files
Thanks for the fixes. Changes are now committed to svn trunk.
About the second issue, it seems a much complicated piece of code
for what it's doing. I suggest this lighter and cleaner alternative
instead of a template with three different typename parameters and the
huge expression with four
5 matches
Mail list logo
