Re: [osg-users] ShaderComposer::releaseGLObjects warning

On 27 April 2016 at 20:20, Andy Skinner wrote: > So, to be clear, we'll leave it as is? > I am happy to merge this particular one, but if there are more, then just how many places, ever single modification is a step up in code bloat for dodgy warnings sake. Robert

Re: [osg-users] ShaderComposer::releaseGLObjects warning

So, to be clear, we'll leave it as is? thanks andy Needing to put a using in lots of places across the OSG to just quieten inappropriate warnings is pretty crappy. The more superfluous code you have in your code base the less easy it is to read, the easier it to break. This makes me very

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi Andy, On 27 April 2016 at 19:09, Andy Skinner wrote: > Yes, the "using" statement does quiet the warning. > Good to hear. > > > Does that mean this is the solution, or that this just shows that there > isn't a problem? The reason I ask is that we've discussed

Re: [osg-users] ShaderComposer::releaseGLObjects warning

.org> Subject: Re: [osg-users] ShaderComposer::releaseGLObjects warning Hi Andy, On 26 April 2016 at 20:31, Andy Skinner <andy.skin...@mathworks.com<mailto:andy.skin...@mathworks.com>> wrote: Thanks for that fix. There is a remaining issue, and I'm not sure if you would see it as a bu

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi Andy, On 26 April 2016 at 20:31, Andy Skinner wrote: > Thanks for that fix. There is a remaining issue, and I'm not sure if you > would see it as a bug or a dodgy compiler warning. :) > > > > We get a similar message about osgUtil::CullVisitor::clone(). > > > >

Re: [osg-users] ShaderComposer::releaseGLObjects warning

ject: Re: [osg-users] ShaderComposer::releaseGLObjects warning On 18 April 2016 at 20:30, Robert Osfield <robert.osfi...@gmail.com<mailto:robert.osfi...@gmail.com>> wrote: Hi Jannik and Ulrich, You are right it's a bug, the missing const is an error, rather than the missing virtual

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi Alberto, On 25 April 2016 at 19:22, Alberto Luaces wrote: > Indeed it does, for example on my system the signature of the method > changes from > > _ZN3osg14ShaderComposer16releaseGLObjectsEPNS_5StateE > > to > > _ZNK3osg14ShaderComposer16releaseGLObjectsEPNS_5StateE >

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Robert Osfield writes: > On 18 April 2016 at 20:30, Robert Osfield wrote: > >> Hi Jannik and Ulrich, >> >> You are right it's a bug, the missing const is an error, rather than the >> missing virtual. I've fixed this and rewritten the implementation of >>

Re: [osg-users] ShaderComposer::releaseGLObjects warning

On 18 April 2016 at 20:30, Robert Osfield wrote: > Hi Jannik and Ulrich, > > You are right it's a bug, the missing const is an error, rather than the > missing virtual. I've fixed this and rewritten the implementation of > ShaderCompose::releaseGLObjects() const. > > I

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi Jannik and Ulrich, You are right it's a bug, the missing const is an error, rather than the missing virtual. I've fixed this and rewritten the implementation of ShaderCompose::releaseGLObjects() const. I need to do a build and test before checking it in. Thankfully ShaderComposer is a not

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi guys, On 18/04/2016 20:22, Robert Osfield wrote: > On 18 April 2016 at 17:39, Andy Skinner > wrote: > > We are getting a warning for ShaderComposer::releaseGLObjects: 'void >

Re: [osg-users] ShaderComposer::releaseGLObjects warning

Hi Robert Actually there is a bug here. The ShaderComposer::releaseGLObjects does not override because it is declared without the const specifier. Object::releaseGLObjects is declared const. > osg::Object::releaseGLObjects is virtual, but > osg::ShaderComposer::releaseGLObjects is not. Is

Re: [osg-users] ShaderComposer::releaseGLObjects warning

On 18 April 2016 at 17:39, Andy Skinner wrote: > We are getting a warning for ShaderComposer::releaseGLObjects: 'void > osg::ShaderComposer::releaseGLObjects(osg::State *)' : member function does > not override any base class virtual member function >

[osg-users] ShaderComposer::releaseGLObjects warning

We are getting a warning for ShaderComposer::releaseGLObjects: 'void osg::ShaderComposer::releaseGLObjects(osg::State *)' : member function does not override any base class virtual member function osg::Object::releaseGLObjects is virtual, but osg::ShaderComposer::releaseGLObjects is not. Is