Re: [ovs-dev] [PATCH v5] netdev-dpdk: fix ifindex assignment for DPDK ports

On 4/3/17, 5:27 AM, "ovs-dev-boun...@openvswitch.org on behalf of Przemyslaw Lal" wrote: In current implementation port_id is used as an ifindex for all netdev-dpdk interfaces. For physical DPDK

Re: [ovs-dev] [v2] ofproto: Use macros to define DPIF support fields

On Mon, Apr 3, 2017 at 5:30 PM, Joe Stringer wrote: > On 3 April 2017 at 13:30, Andy Zhou wrote: >> When adding a new field in the 'struct dpif_backer_support', the >> corresponding appctl show command should be updated to display >> the new field. Currently, there

Re: [ovs-dev] [v2] ofproto: Use macros to define DPIF support fields

On 3 April 2017 at 13:30, Andy Zhou wrote: > When adding a new field in the 'struct dpif_backer_support', the > corresponding appctl show command should be updated to display > the new field. Currently, there is nothing to remind the developer > that to update the show command.

Re: [ovs-dev] [PATCH v1] ofproto-dpif-mirror: Fix issue of reseting snaplen in mirroring

On Fri, Mar 31, 2017 at 8:09 AM, William Tu wrote: > Looks good to me, thanks for the fix. > > Acked-by: William Tu > > On Sun, Mar 26, 2017 at 8:16 PM, Zhenyu Gao wrote: >> Currently, the mirror code doesn't check new value of

Re: [ovs-dev] [PATCH] compat: Remove rpl_dev_queue_xmit() backport.

Hi Simon, I posted a patch series[1,2,3] to backport the MPLS GSO upstream commits. It would be great if you could provide some feedback on that. I have tested the backport series on kernel 4.4, and 4.9 with the similar setup as in [3]. To trigger MPLS GSO, I use iperf instead of the ping test in

[ovs-dev] [PATCH 3/3] system-traffic: Add test for mpls actions

Add ping test to verify the behavior of mpls_push/pop actions. In this test, we use the resubmit action to trigger recirulation for making sure the flow key is revalidated after mpls_push/pop. This test depends on commit 5ba0c107c51e ("datapath: Fix ovs_flow_key_update()") to behave correctly.

[ovs-dev] [PATCH 1/3] datapath: Fixups for MPLS GSO

This commit backports the following upstream commits to fix MPLS GSO in ovs datapath. It has been tested on kernel 4.4 and 4.9. Upstream commit: commit 48d2ab609b6bbecb7698487c8579bc40de9d6dfa Author: David Ahern Date: Wed Aug 24 20:10:44 2016 -0700

[ovs-dev] [PATCH 2/3] datapath: Fix ovs_flow_key_update()

Upstream commit: ovs_flow_key_update() is called when the flow key is invalid, and it is used to update and revalidate the flow key. Commit 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key") introduces mac_proto field to flow key and use it to determine whether the

[ovs-dev] Traffic fails in vhost user port

Hi, I have an OVS bridge br0 with no NICs and 1 vhost user port which is connected to a VM. But ping fails between the VM and the br0 port, either way. The stats show zero all the time. Inside the VM, tcpdump shows nothing. This is with OVS 2.7.0 and DPDK 17.02. Please indicate what could

Re: [ovs-dev] [PATCH v2 0/8] userspace: Support for L3 tunneling

I just realized that we missed to implement some of Ben's comments on patch series v1. Will fix those and resubmit v3 as soon as possible. Regards, Jan > -Original Message- > From: Zoltán Balogh > Sent: Monday, 03 April, 2017 18:28 > To: 'd...@openvswitch.org' >

Re: [ovs-dev] [PATCH 2/3] ofproto: Store meters into imap

On Fri, Mar 31, 2017 at 7:53 PM, Ben Pfaff wrote: > On Fri, Mar 31, 2017 at 01:42:02PM -0700, Andy Zhou wrote: >> Currently, meters are stored in a fixed pointer array. It is not >> very efficient since the controller, at least in theory, can >> pick any meter id (up to the limits

[ovs-dev] [v2] ofproto: Use macros to define DPIF support fields

When adding a new field in the 'struct dpif_backer_support', the corresponding appctl show command should be updated to display the new field. Currently, there is nothing to remind the developer that to update the show command. This can lead to code maintenance issues. Switch to use macros to

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

Ilya Maximets writes: > Currently, signed integer is used for 'port_id' variable and > '-1' as identifier of bad or uninitialized 'port_id'. > > This inconsistent with dpdk library and, also, in few cases, > leads to passing '-1' to dpdk functions where uint8_t expected.

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix device leak on port deletion.

Ilya Maximets writes: > Currently, once created device in dpdk will exist forever > even after del-port operation untill we manually call > 'ovs-appctl netdev-dpdk/detach ', where is not > the port's name but the name of dpdk eth device or pci address. > > Few issues

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

Ilya Maximets writes: > 'devargs' for virtual devices contains not only name but > also a list of arguments like this: > > 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' > or > 'eth_af_packet0,iface=eth0' > > We must cut off the arguments from

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

>>> >>>This whole mechanism seems very error prone. Is it possible to hang a >>>thread with the subsequent sem_post? >> >> The relay function is called by 'ovs_keepalive' thread. I didn't >> completely understand your concerns here. I would be happy to verify >> if you have any scenarios in mind

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On 1 April 2017 at 20:50, Roi Dayan wrote: > > > On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote: >> >> On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote: >>> >>> On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote: This patch series

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 3 April 2017 at 03:27, Roi Dayan wrote: > > > On 29/03/2017 20:13, Joe Stringer wrote: >> >> On 29 March 2017 at 04:50, Roi Dayan wrote: >>> >>> >>> >>> On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check-offloads tests on a

[ovs-dev] ***BULK*** E-mail Account Upgrade

E-mail Account Upgrade Your email box account needs to be Upgraded now to the latest version inother for you to receive your pending incoming messages that has

[ovs-dev] [PATCH v2 7/8] ofproto-dpif-xlate: refactor compose_output_action__

From: Jan Scheurich The very long function compose_output_action__() has been re-factored to make the different cases for output to patch-port, native tunnel port, kernel tunnel port, recirculation, or termination of a native tunnel at output to LOCAL port clearer.

[ovs-dev] [PATCH v2 8/8] userspace: add vxlan gpe support to vport

From: Georg Schmuecking This patch is based on the "datapath: enable vxlangpe creation in compat mode" from Yi Yang. It introduces an extension option "gpe" to the vxlan port in the netdev-dpdk datapath. Furthermore it introduces a new protocol header file

[ovs-dev] [PATCH v2 6/8] dpif-netlink: Don't send PACKET_TYPE to kernel

The kernel datapath does not support the packet_type match field. Instead it encodes the packet type implictly by the presence or absence of the Ethernet attribute in the flow key and mask. This patch filters the PACKET_TYPE attribute out of netlink flow key and mask to be sent to the kernel

[ovs-dev] [PATCH v2 2/8] userspace: Support for push_eth and pop_eth actions

From: Jan Scheurich Add support for actions push_eth and pop_eth to the netdev datapath and the supporting libraries. This patch relies on the support for these actions in the kernel datapath to be present. Signed-off-by: Lorand Jakab

[ovs-dev] [PATCH v2 5/8] userspace: L3 tunnel support for GRE and LISP

From: Jan Scheurich Add a boolean "layer3" configuration option for tunnel vports. The layer3 option defaults to false for all ports except LISP. GRE ports accept both true and false for "layer3". A tunnel vport configured with layer3=true receives L3 packets. which

[ovs-dev] [PATCH v2 0/8] userspace: Support for L3 tunneling

From: Jan Scheurich This patch set is part of an initiative to deal with non-Ethernet packets in OVS for advanced use cases like L3 tunneling or NSH. The initiative is centering on the new OpenFlow concepts of "Packet type-aware pipeline" (PTAP) and "Generic

[ovs-dev] [PATCH v2 4/8] ofproto-dpif-upcall: Intialize dump-seq of new flow to zero

From: Jan Scheurich This forces updating of flow stat at the next re-validation, even for flows that are being created when the revalidation has already commenced. It enables reliable testing of fast path flow stats using ovs-appctl time/warp after flow creation.

[ovs-dev] [PATCH v2 3/8] userspace: Switching of L3 packets in L2 pipeline

From: Jan Scheurich Ports have a new layer3 attribute if they send/receive L3 packets. The packet_type included in structs dp_packet and flow is considered in ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and vlan_tci, vlan_vid, vlan_pcp) now

[ovs-dev] [PATCH v2 1/8] userspace: Add packet_type in dp_packet and flow

From: Jan Scheurich This commit adds a packet_type attribute to the structs dp_packet and flow to explicitly carry the type of the packet as prepration for the introduction of the so-called packet type-aware pipeline (PTAP) in OVS. The packet_type is a big-endian 32

Re: [ovs-dev] [RFC] OpenStack Metadata API and OVN

Thanks! Very interesting 2017-04-03 19:03 GMT+03:00 Russell Bryant : > I worked with a fellow team member to come up with a proposal for how > to support the OpenStack Metadata API with OVN. The proposal requires > no additional changes to OVN itself, but I wanted to share on

[ovs-dev] [RFC] OpenStack Metadata API and OVN

I worked with a fellow team member to come up with a proposal for how to support the OpenStack Metadata API with OVN. The proposal requires no additional changes to OVN itself, but I wanted to share on this list anyway for anyone that may be interested. https://review.openstack.org/#/c/452811/

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

"Bodireddy, Bhanuprakash" writes: >>> >>> +/* >>> + * OVS Shared Memory structure >>> + * >>> + * The information in the shared memory block will be read by collectd. >>> + * */ >>> +struct dpdk_keepalive_shm { >>> +/* IPC semaphore. Posted when a core dies

Re: [ovs-dev] OVN meeting report

Hi Ben, On 23.03.2017 08:11, Ben Pfaff wrote: Hello everyone. I am not sure whether I am going to be able to attend the OVN meeting tomorrow, because I will be in another possibly distracting meeting, so I'm going to give my report here. Toward the end of last week I did a full pass of

Re: [ovs-dev] [PATCH 0/7] Add OVS DPDK keep-alive functionality

"Bodireddy, Bhanuprakash" writes: > Thanks Aaron for reviewing this patch series. My comments inline. > >> >>Hi Bhanu, >> >>Bhanuprakash Bodireddy writes: >> >>> This patch is aimed at achieving Fastpath Service Assurance in

[ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

Currently, signed integer is used for 'port_id' variable and '-1' as identifier of bad or uninitialized 'port_id'. This inconsistent with dpdk library and, also, in few cases, leads to passing '-1' to dpdk functions where uint8_t expected. Such behaviour doesn't produce any issues, but it's

[ovs-dev] [PATCH 2/3] netdev-dpdk: Fix device leak on port deletion.

Currently, once created device in dpdk will exist forever even after del-port operation untill we manually call 'ovs-appctl netdev-dpdk/detach ', where is not the port's name but the name of dpdk eth device or pci address. Few issues with current implementation: 1. Different API for

[ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

'devargs' for virtual devices contains not only name but also a list of arguments like this: 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' or 'eth_af_packet0,iface=eth0' We must cut off the arguments from this string before calling 'rte_eth_dev_get_port_by_name()'

[ovs-dev] [PATCH 0/3] Hotplug fixes & port_id refactoring

Ilya Maximets (3): netdev-dpdk: Fix double attaching of virtual devices. netdev-dpdk: Fix device leak on port deletion. netdev-dpdk: Use uint8_t for port_id. Documentation/howto/dpdk.rst | 5 +- lib/netdev-dpdk.c| 137 +++ 2 files

Re: [ovs-dev] [PATCH 5/7] utils: Introduce xusleep for subsecond granularity.

"Bodireddy, Bhanuprakash" writes: >>Bhanuprakash Bodireddy writes: >> >>> This will be used by KA framework that needs millisecond granularity. >>> >>> Signed-off-by: Bhanuprakash Bodireddy >>>

Re: [ovs-dev] [PATCH 7/7] Documentation: Update DPDK doc with Keepalive feature.

>-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >boun...@openvswitch.org] On Behalf Of Stephen Finucane >Sent: Monday, April 3, 2017 11:15 AM >To: ovs-dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 7/7] Documentation: Update DPDK doc with >Keepalive feature.

Re: [ovs-dev] [PATCH 5/7] utils: Introduce xusleep for subsecond granularity.

>Bhanuprakash Bodireddy writes: > >> This will be used by KA framework that needs millisecond granularity. >> >> Signed-off-by: Bhanuprakash Bodireddy >> >> --- > >Without this patch, builds starting at 3/7 will fail. That's

Re: [ovs-dev] [PATCH 4/7] process: Retrieve process status.

>-Original Message- >From: Aaron Conole [mailto:acon...@redhat.com] >Sent: Monday, April 3, 2017 2:00 AM >To: Bodireddy, Bhanuprakash >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 4/7] process: Retrieve process status. > >Bhanuprakash Bodireddy

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

>> >> +/* >> + * OVS Shared Memory structure >> + * >> + * The information in the shared memory block will be read by collectd. >> + * */ >> +struct dpdk_keepalive_shm { >> +/* IPC semaphore. Posted when a core dies */ >> +sem_t core_died; >> + >> +/* >> + * Relayed status of each

Re: [ovs-dev] [PATCH 1/7] dpdk: Add helper functions for DPDK keepalive.

>-Original Message- >From: Aaron Conole [mailto:acon...@redhat.com] >Sent: Monday, April 3, 2017 1:58 AM >To: Bodireddy, Bhanuprakash >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 1/7] dpdk: Add helper functions for DPDK >keepalive. >

Re: [ovs-dev] [PATCH 0/7] Add OVS DPDK keep-alive functionality

Thanks Aaron for reviewing this patch series. My comments inline. > >Hi Bhanu, > >Bhanuprakash Bodireddy writes: > >> This patch is aimed at achieving Fastpath Service Assurance in >> OVS-DPDK deployments. This commit adds support for monitoring the >> packet

[ovs-dev] [PATCH v5] netdev-dpdk: fix ifindex assignment for DPDK ports

In current implementation port_id is used as an ifindex for all netdev-dpdk interfaces. For physical DPDK interfaces using port_id as ifindex causes that '0' is set as ifindex for 'dpdk0' interface, '1' for 'dpdk1' and so on. For the DPDK vHost interfaces ifindexes are not even assigned (0 is

[ovs-dev] [PATCH v4 3/3] ovn-northd: Add logical flows to support native DNS

From: Numan Siddique OVN implements native DNS resolution which can be used to resolve the internal DNS names belonging to a logical datapath. To support this, a new table 'DNS' is added in the NB DB. A new column 'dns_records' is added in 'Logical_Switch' table which

[ovs-dev] [PATCH v4 2/3] ovn-controller: Add 'dns_lookup' action

From: Numan Siddique This patch adds a new OVN action 'dns_lookup' to support native DNS. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with 'pause' flag set. A new table 'DNS' is added in the SB DB to look up and resolve the DNS queries. When a valid

[ovs-dev] [PATCH v4 1/3] ovn-util: Add a new util function extract_ip_addresses

From: Numan Siddique An upcoming commit will use this function to extract the IP (v4 and v6) addresses from a string without a preceding eth address. Signed-off-by: Numan Siddique --- ovn/lib/ovn-util.c | 72

[ovs-dev] [PATCH v4 0/3] ovn: Native DNS support

From: Numan Siddique v3 -> v4 * PS1 (ovn-util: Add a new util function extract_ip_addresses) - Added this patch in v4 to extract the IP addresses from a string * PS2 (ovn-controller: Add 'dns_lookup' action) - Addressed the review comments and modified the DNS

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 29/03/2017 20:13, Joe Stringer wrote: On 29 March 2017 at 04:50, Roi Dayan wrote: On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check-offloads tests on a recent net-next kernel and it failed, output was not as expected:

[ovs-dev] [RFC] [PATCH 5/6] port_group: ofproto-dpif: add port_group definition and init

Signed-off-by: Matthias May --- ofproto/ofproto-dpif.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 523adad6f..32d7d69c5 100644 --- a/ofproto/ofproto-dpif.c +++

[ovs-dev] [RFC] [PATCH 3/6] port_group: bridge: set port_group in port config

Signed-off-by: Matthias May --- vswitchd/bridge.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 867a26d8d..316e4742e 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -966,6 +966,17 @@

[ovs-dev] [RFC] [PATCH 4/6] port_group: ofproto: add port_group definition

Signed-off-by: Matthias May --- ofproto/ofproto.h | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h index 1e48e1952..29d7cdb91 100644 --- a/ofproto/ofproto.h +++ b/ofproto/ofproto.h @@ -402,6 +402,7 @@ struct

[ovs-dev] [RFC] [PATCH 2/6] port_group: add documentation entry

Signed-off-by: Matthias May --- vswitchd/vswitch.xml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 14297bf9a..3a7324f5d 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -1280,6 +1280,13 @@

[ovs-dev] [RFC] [PATCH 1/6] port_group: add db definitions

Signed-off-by: Matthias May --- vswitchd/vswitch.ovsschema | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/vswitchd/vswitch.ovsschema b/vswitchd/vswitch.ovsschema index 19b49daf1..7ebcd0d6a 100644 --- a/vswitchd/vswitch.ovsschema +++

[ovs-dev] [RFC] [PATCH 0/6] Add port_group to prevent loopback between interfaces

When using openvswitch in combination with a hardware switch attached via dsa it may be desirable to prevent frames from being looped back to interfaces which reside on the same switch and are already processed by the switching fabric in hardware. This patch series achieves this by introducing a