[ovs-dev] vport-gtp: add metadata_dst support result in "netlink: Unexpected mask"

Hi, I’m experimenting with attaching metadata_dst to skb in the gtp recv path. The goal is to let ovs to meter the gtp traffic. However, I encountered the following error in ovs_flow_cmd_new : [ 411.462443] openvswitch: netlink: Unexpected mask (mask=110058, allowed=41980cc) Seems the

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, Apr 27, 2017 at 02:47:03PM -0700, William Tu wrote: > On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote: > > On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote: > >> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote: > >> > On Thu, Apr 27, 2017 at

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, 2017-04-27 at 14:47 -0700, William Tu wrote: > On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote: > > On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote: > >> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote: > >> > On Thu, Apr 27, 2017 at 04:02:10AM

Re: [ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

Good. Better than me, learning. This is an alternative solution patch for the issue reported by Raymond Burkholder and the patch submitted by Guoshuai Li. It uses the acinclude.m4 configuration file to check for the net parameter that was added to the ipv4 and ipv6 frags init functions in the

Re: [ovs-dev] [PATCH branch-2.6] travis: Fix path of DPDK directory

On 27 April 2017 at 03:18, Timothy Redaelli wrote: > Call configure with --with-dpdk=./dpdk-stable-$DPDK_VER/build > instead of --with-dpdk=./dpdk-$DPDK_VER/build > > Fixes: c007c58af492 ("docs: Use DPDK 16.07.2 stable release") > CC: Ian Stokes >

Re: [ovs-dev] [PATCH] tests: ICMP related to original direction test.

> On Apr 27, 2017, at 4:55 PM, Joe Stringer wrote: > > On 10 March 2017 at 16:10, Jarno Rajahalme wrote: >> Normally ICMPP responses are in the reply direction of a conntrack > > 's/ICMPP/ICMP/' > >> entry. This test exercises an ICMP response to the original

[ovs-dev] [PATCH v5] xlate: Use OVS_CT_ATTR_EVENTMASK.

Specify the event mask with CT commit including bits for CT features exposed at the OVS interface (mark and label changes in addition to basic creation and destruction of conntrack entries). Without this any listener of conntrack update events will typically (depending on system configuration)

Re: [ovs-dev] [PATCH] tests: ICMP related to original direction test.

On 10 March 2017 at 16:10, Jarno Rajahalme wrote: > Normally ICMPP responses are in the reply direction of a conntrack 's/ICMPP/ICMP/' > entry. This test exercises an ICMP response to the original direction > of the conntrack entry. > > Signed-off-by: Jarno Rajahalme

Re: [ovs-dev] [PATCH v3] xlate: Use OVS_CT_ATTR_EVENTMASK.

> On Apr 27, 2017, at 4:15 PM, Joe Stringer wrote: > > On 27 April 2017 at 14:48, Jarno Rajahalme > wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at the OVS interface (mark and label changes in

[ovs-dev] [PATCH v4] xlate: Use OVS_CT_ATTR_EVENTMASK.

Specify the event mask with CT commit including bits for CT features exposed at the OVS interface (mark and label changes in addition to basic creation and destruction of conntrack entries). Without this any listener of conntrack update events will typically (depending on system configuration)

Re: [ovs-dev] [PATCH v3] xlate: Use OVS_CT_ATTR_EVENTMASK.

On 27 April 2017 at 14:48, Jarno Rajahalme wrote: > Specify the event mask with CT commit including bits for CT features > exposed at the OVS interface (mark and label changes in addition to > basic creation and destruction of conntrack entries). > > Without this any listener of

[ovs-dev] [PATCH V2 4/4] travis: Update kernels to kernel.org latest

Signed-off-by: Greg Rose --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6f2b065..3a73873 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,13 +30,13 @@ env: - BUILD_ENV="-m32"

[ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

This is an alternative solution patch for the issue reported by Raymond Burkholder and the patch submitted by Guoshuai Li. It uses the acinclude.m4 configuration file to check for the net parameter that was added to the ipv4 and ipv6 frags init functions in the 4.10 Linux kernel to check whether

[ovs-dev] [PATCH V2 2/4] acinclude.m4: Add check for struct net parameter

The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 Signed-off-by: Greg Rose --- acinclude.m4 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 0d6647e..8653a30 100644 --- a/acinclude.m4 +++

[ovs-dev] [PATCH 0/4] Fixup 4.10 kernel compatability layer

* Fixes a small bug in the acinclude.m4 file * Adds check in acinclude.m4 for the frag init struct *net requirement * Fixes up the ip_fragment.c and nf_conntrack_reasm.c compat files * Updates the .travis.yml build verification script V2 - Incorporate suggestion from Joe Stringer to just return

Re: [ovs-dev] [action upcall meters 5/5] ofproto: Meter slowpath action when action upcall meters are configured

See comments below. Jarno > On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > If a slow path action is a controller action, meter it when the > controller meter is configured. For other kinds of slow path actions, > meter it when the slowpath meter is configured. > > Note,

Re: [ovs-dev] [action upcall meters 4/5] ofproto: Meter sample action when configured.

This breaks the test "ofproto-dpif - Bridge IPFIX sanity check” (currently test #1128), which appears to be the tests case that is being modified. More comments below. > On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > When slowpath meter is configured, add meter action when

Re: [ovs-dev] [action upcall meters 3/5] ofproto: Support action upcall meters

With small nits below: Acked-by: Jarno Rajahalme > On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > Allow action upcall meters, i.e. slowpath and controller meters, > to be added and displayed. > > Keep track of datapath meter ID of those action upcall meters

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > Add 'meter_ids', an id-pool object to manage datapath meter id. > > Currently, only userspace datapath supports meter, and it implements > the provider_meter_id management. Moving this function to 'backer' > allows other

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially being used uninitialized: diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 2e80db8..eb060d0 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -6564,7 +6564,7 @@ handle_meter_request(struct ofconn *ofconn,

[ovs-dev] [PATCH v3] xlate: Use OVS_CT_ATTR_EVENTMASK.

Specify the event mask with CT commit including bits for CT features exposed at the OVS interface (mark and label changes in addition to basic creation and destruction of conntrack entries). Without this any listener of conntrack update events will typically (depending on system configuration)

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote: > On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote: >> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote: >> > On Thu, Apr 27, 2017 at 04:02:10AM -0700, William Tu wrote: >> >> Before the patch, when users

Re: [ovs-dev] [PATCH v3 0/7] create tunnel devices using rtnetlink interface

On 13 April 2017 at 13:47, Eric Garver wrote: > This series adds support for the creation of tunnels using the rtnetlink > interface. This will open the possibility for new features and flags on those > vports without the need to change vport compatibility code. > > Support for STT

Re: [ovs-dev] [PATCH v3 3/7] dpif-netlink: code to create/destroy tunnel ports via rtnetlink

On 13 April 2017 at 13:47, Eric Garver wrote: > In order to be able to add those tunnels, we need to add code to create > the tunnels and add them as NETDEV vports. And when there is no support > to create them, we need to fallback to compatibility code and add them > as tunnel

Re: [ovs-dev] [PATCH v3 0/7] create tunnel devices using rtnetlink interface

On 13 April 2017 at 13:47, Eric Garver wrote: > This series adds support for the creation of tunnels using the rtnetlink > interface. This will open the possibility for new features and flags on those > vports without the need to change vport compatibility code. > > Support for STT

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

Lance Richardson writes: >> From: "Russell Bryant" >> To: "Ben Pfaff" >> Cc: "ovs dev" , "Flavio Leitner" >> , "Lance Richardson" , >> "Aaron Conole" >> Sent:

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

Hi Bhanu, Bhanuprakash Bodireddy writes: > This patch is aimed at achieving Fastpath Service Assurance in > OVS-DPDK deployments. This commit adds support for monitoring the packet > processing cores(pmd thread cores) by dispatching heartbeats at regular >

Re: [ovs-dev] [PATCH 2/4] acinclude.m4: Add check for struct net parameter

On Thu, 2017-04-27 at 14:05 -0700, Andy Zhou wrote: > On Thu, Apr 27, 2017 at 1:08 PM, Greg Rose wrote: > > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 > > > > Signed-off-by: Greg Rose > > Thanks for working on this! > > It

Re: [ovs-dev] [PATCH 2/4] acinclude.m4: Add check for struct net parameter

On Thu, Apr 27, 2017 at 1:08 PM, Greg Rose wrote: > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 > > Signed-off-by: Greg Rose Thanks for working on this! It seems odd that we only detect the signatures of a ipv6 function, then

Re: [ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

On Thu, 2017-04-27 at 13:53 -0700, Jarno Rajahalme wrote: > > On Apr 27, 2017, at 1:08 PM, Greg Rose wrote: > > > > This is an alternative solution patch for the issue reported by > > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses > > the acinclude.m4

Re: [ovs-dev] [PATCH] datapath-windows: Add missing IPCT_LABEL.

Pushed to master, Jarno > On Apr 27, 2017, at 11:07 AM, Sairam Venugopal wrote: > > Thanks for adding this in. > > Acked-by: Sairam Venugopal > > > > > > On 4/19/17, 7:01 PM, "ovs-dev-boun...@openvswitch.org on behalf of Jarno > Rajahalme"

Re: [ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

> On Apr 27, 2017, at 1:08 PM, Greg Rose wrote: > > This is an alternative solution patch for the issue reported by > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses > the acinclude.m4 configuration file to check for the net parameter > that was added

[ovs-dev] [PATCH 4/4] travis: Update kernels to kernel.org latest

Signed-off-by: Greg Rose --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6f2b065..3a73873 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,13 +30,13 @@ env: - BUILD_ENV="-m32"

[ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

This is an alternative solution patch for the issue reported by Raymond Burkholder and the patch submitted by Guoshuai Li. It uses the acinclude.m4 configuration file to check for the net parameter that was added to the ipv4 and ipv6 frags init functions in the 4.10 Linux kernel to check whether

[ovs-dev] [PATCH 1/4] acinclude.m4: Fix parenthetical balance

Parenthetical imbalance was causing some checks to not run Signed-off-by: Greg Rose --- acinclude.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 9f8e30d..0d6647e 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@

[ovs-dev] [PATCH 0/4] Fixup 4.10 kernel compatability layer

* Fixes a small bug in the acinclude.m4 file * Adds check in acinclude.m4 for the frag init struct *net requirement * Fixes up the ip_fragment.c and nf_conntrack_reasm.c compat files * Updates the .travis.yml build verification script Verified here:

[ovs-dev] [PATCH] db-ctl-base: Allow record UUIDs to be abbreviated.

This makes it easier to type ovs-vsctl, ovn-sbctl, ovn-nbctl, and vtep-ctl commands without cut-and-paste. Signed-off-by: Ben Pfaff --- NEWS | 4 lib/db-ctl-base.c | 28 ovn/utilities/ovn-nbctl.8.xml | 15

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

On Thu, Apr 27, 2017 at 03:04:43PM -0400, Russell Bryant wrote: > On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff wrote: > > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: > >> The RPM build makefile targets are helpful during development and testing, > >> but I

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

> From: "Russell Bryant" > To: "Ben Pfaff" > Cc: "ovs dev" , "Flavio Leitner" , > "Lance Richardson" , > "Aaron Conole" > Sent: Thursday, 27 April, 2017 3:04:43 PM > Subject: Re:

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff wrote: > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >> The RPM build makefile targets are helpful during development and testing, >> but I personally almost never want the tests to run when I use them. >> Leave tests on

Re: [ovs-dev] [PATCH] datapath-windows: Add missing IPCT_LABEL.

Thanks for adding this in. Acked-by: Sairam Venugopal On 4/19/17, 7:01 PM, "ovs-dev-boun...@openvswitch.org on behalf of Jarno Rajahalme" wrote: >Add the missing enum definition for IPCT_LABEL. >

Re: [ovs-dev] [PATCH v2 1/2] xlate: Use OVS_CT_ATTR_EVENTMASK.

> On Apr 27, 2017, at 10:18 AM, Joe Stringer wrote: > > On 24 April 2017 at 19:09, Jarno Rajahalme > wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at the OVS interface (mark and label changes in

Re: [ovs-dev] [PATCH] datapath: Delete conntrack entry clashing with an expectation.

> On Apr 27, 2017, at 10:36 AM, Joe Stringer wrote: > > On 26 April 2017 at 13:13, Jarno Rajahalme wrote: >> Upstream commit: >> >>commit cf5d70918877c6a6655dc1e92e2ebb661ce904fd >>Author: Jarno Rajahalme >>Date: Fri Apr 14 14:26:38

Re: [ovs-dev] [PATCH v2 2/2] datapath: nf_connlabels_replace() backport.

> On Apr 27, 2017, at 10:31 AM, Joe Stringer wrote: > > On 24 April 2017 at 19:09, Jarno Rajahalme wrote: >> Linux 4.7 changed nf_connlabels_replace() to trigger conntrack event >> for a label change only when the labels actually changed. Without >> this change an

Re: [ovs-dev] [PATCH 2/2] datapath: Add eventmask support to CT action.

> On Apr 27, 2017, at 10:15 AM, Joe Stringer wrote: > > On 24 April 2017 at 13:50, Jarno Rajahalme wrote: >> Upstream commit: >> >>commit 120645513f55a4ac5543120d9e79925d30a0156f >>Author: Jarno Rajahalme >>Date: Fri Apr 21 16:48:06

Re: [ovs-dev] [PATCH] datapath: Delete conntrack entry clashing with an expectation.

On 26 April 2017 at 13:13, Jarno Rajahalme wrote: > Upstream commit: > > commit cf5d70918877c6a6655dc1e92e2ebb661ce904fd > Author: Jarno Rajahalme > Date: Fri Apr 14 14:26:38 2017 -0700 > > openvswitch: Delete conntrack entry clashing with an

Re: [ovs-dev] [PATCH v2 2/2] datapath: nf_connlabels_replace() backport.

On 24 April 2017 at 19:09, Jarno Rajahalme wrote: > Linux 4.7 changed nf_connlabels_replace() to trigger conntrack event > for a label change only when the labels actually changed. Without > this change an update event is triggered even if the labels already > have the values they

Re: [ovs-dev] [PATCH v2 1/2] xlate: Use OVS_CT_ATTR_EVENTMASK.

On 24 April 2017 at 19:09, Jarno Rajahalme wrote: > Specify the event mask with CT commit including bits for CT features > exposed at the OVS interface (mark and label changes in addition to > basic creation and destruction of conntrack entries). > > Without this any listener of

Re: [ovs-dev] [PATCH 2/2] datapath: Add eventmask support to CT action.

On 24 April 2017 at 13:50, Jarno Rajahalme wrote: > Upstream commit: > > commit 120645513f55a4ac5543120d9e79925d30a0156f > Author: Jarno Rajahalme > Date: Fri Apr 21 16:48:06 2017 -0700 > > openvswitch: Add eventmask support to CT action. > >

Re: [ovs-dev] [PATCH 1/2] datapath: Typo fix.

On 24 April 2017 at 13:50, Jarno Rajahalme wrote: > Upstream commit: > > commit abd0a4f2b41812e9ba334945e256909e3d28da57 > Author: Jarno Rajahalme > Date: Fri Apr 21 16:48:05 2017 -0700 > > openvswitch: Typo fix. > > Fix typo in a comment. > >

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

On Tue, Apr 18, 2017 at 07:13:26PM +, Bodireddy, Bhanuprakash wrote: > >On Sun, Mar 12, 2017 at 05:33:27PM +, Bhanuprakash Bodireddy wrote: > >> The sorted subtable ranking patch introduced a classifier instance per > >> ingress port with its subtables ranked on the frequency of hits. The

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

On 3/12/17, 10:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bhanuprakash Bodireddy" wrote: The sorted subtable ranking patch introduced a classifier instance per ingress port with its subtables

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, Apr 27, 2017 at 04:02:10AM -0700, William Tu wrote: > Before the patch, when users create bridge named "default", although > ovs-vsctl fails but vswitchd in the background will keep retrying it, > causing the systemd-udev to reach 100% cpu utilization. The reason is > due to frequent

[ovs-dev] [PATCH] ovn-nbctl: Drop gratuitous indentation for "show" output.

"ovn-nbctl show" indented every line of output by at least 4 spaces, which needlessly wastes horizontal space. This drops 4 spaces of indent from each line of output. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 26 +- tests/ovn-nbctl.at

Re: [ovs-dev] [PATCH 2/2] revalidator: Improve logging for transition_ukey().

On Thu, Apr 27, 2017 at 09:24:04AM -0700, Joe Stringer wrote: > On 26 April 2017 at 18:35, Jarno Rajahalme wrote: > > > >> On Apr 26, 2017, at 6:03 PM, Joe Stringer wrote: > >> > >> There are a few cases where more introspection into ukey transitions > >> would be

Re: [ovs-dev] [PATCH 2/2] revalidator: Improve logging for transition_ukey().

On 26 April 2017 at 18:35, Jarno Rajahalme wrote: > >> On Apr 26, 2017, at 6:03 PM, Joe Stringer wrote: >> >> There are a few cases where more introspection into ukey transitions >> would be relevant for logging or assertion. Track the SOURCE_LOCATOR and >> thread id

[ovs-dev] You have just received a payment of $250.02

Congratulations! You have just received a payment of $250.02. You can view the full details of this payment in your dashboard https://dashboard.stripe. com/review We'll be here to help you with any step along the way. You can find answers to most questions and get

[ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

Port commit a6d1a2997db4: ofproto.at: Workaround a race While a barrier serializes requests from the same connection, it doesn't wait for requests from other connections to the switch. Replace the barrier with infamous "sleep 1" to workaround the problem. to the following tests:

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, 2017-04-27 at 04:02 -0700, William Tu wrote: > Before the patch, when users create bridge named "default", although > ovs-vsctl fails but vswitchd in the background will keep retrying it, > causing the systemd-udev to reach 100% cpu utilization. The reason is > due to frequent calls into

Re: [ovs-dev] [PATCH] ovn: Bump ovn-nb schema version.

On Mon, Apr 24, 2017 at 2:04 PM, Ben Pfaff wrote: > On Wed, Apr 19, 2017 at 12:41:37PM -0400, Russell Bryant wrote: >> Commit b89d25e5694b made the "router" DHCPv4 option optional instead of >> mandatory. This did not actually change the schema, but there's no good >> way for a

[ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

Before the patch, when users create bridge named "default", although ovs-vsctl fails but vswitchd in the background will keep retrying it, causing the systemd-udev to reach 100% cpu utilization. The reason is due to frequent calls into kernel's register_netdevice function, which will invoke

[ovs-dev] [PATCH branch-2.6] travis: Fix path of DPDK directory

Call configure with --with-dpdk=./dpdk-stable-$DPDK_VER/build instead of --with-dpdk=./dpdk-$DPDK_VER/build Fixes: c007c58af492 ("docs: Use DPDK 16.07.2 stable release") CC: Ian Stokes Tested-at: https://travis-ci.org/drizzt/ovs/builds/226330348 Signed-off-by: Timothy

Re: [ovs-dev] [PATCH v2 6/6] Documentation: Update DPDK doc with Keepalive feature.

>> >>    Compute NodeControllerCompute Node >> >> Collectd  <--> Ceilometer <>   Collectd >> >> OvS DPDK   OvS DPDK >> >>    +-+ >>    | VM  | >>    +--+--+ >>   \---+---/ >>   | >>    +--+---+   

Re: [ovs-dev] [PATCH v2 6/6] Documentation: Update DPDK doc with Keepalive feature.

On Wed, 2017-04-26 at 23:59 +0100, Bhanuprakash Bodireddy wrote: > OvS DPDK Keepalive feature is aimed at achieving Fastpath Service > Assurance in OVS-DPDK deployments. It adds support for monitoring the > packet processing cores(PMD thread cores) by dispatching heartbeats > at regular intervals.