Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 04:08:22AM +0800, Jiri Benc wrote: > On Mon, 30 Oct 2017 09:29:34 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 03:57:41AM +0800, Eric Garver wrote: > On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: > [...] > > +int nsh_pop(struct sk_buff *skb) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + __be16 inner_proto; > > + > > + if (!pskb_may_pull(skb,

[ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

v14->v15 - Check size in nsh_hdr_from_nlattr - Fixed four small issues pointed out By Jiri and Eric v13->v14 - Rename skb_push_nsh to nsh_push per Dave's comment - Rename skb_pop_nsh to nsh_pop per Dave's comment v12->v13 - Fix NSH header length check in set_nsh v11->v12 - Fix missing

Re: [ovs-dev] [PKG-Openstack-devel] Bug#878249: recent OVS upload

On 10/27/2017 08:52 AM, Ben Pfaff wrote: > On Thu, Oct 26, 2017 at 03:45:48PM -0700, Ben Pfaff wrote: >> I see a number of failed builds here: >> https://buildd.debian.org/status/package.php?p=openvswitch=experimental >> >> Let me analyze them: >> >> * mips, powerpc, and ppc64 should be fixed by

[ovs-dev] [PATCHv2 2/2] ovn-sbctl: Fix possible null pointer to qsort.

Clang reports possible null pointer 'lflows' passed to qsort. This is due to the checker unable to make sure whether 'lflows' gets malloc or not in the previous loop. Fix it by checking the 'n_flows' before calling qsort. Signed-off-by: William Tu ---

[ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bad memory free.

Clang reports possibly bad free of 'ofm' when it comes from the stack instead of malloc because Clang is not able to verify whether the previous if condition 'ctx->xin->xcache' still hold the same. Fix it by adding additional condition. Signed-off-by: William Tu ---

Re: [ovs-dev] [PATCH] travis: Fix OSX build on travis

On Mon, Oct 23, 2017 at 12:40 PM, Guru Shetty wrote: > On 23 October 2017 at 09:39, William Tu wrote: > >> Run "brew update" before any installs. >> This yields a clean build: >> https://travis-ci.org/williamtu/ovs-travis/builds/291616874 >> >>

[ovs-dev] [PATCHv2] acinclude: Fix SKB_GSO_UDP check.

The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. However, it falsely returns yes because grep matches SKB_GSO_UDP_TUNNEL. Thus, add space character '[:space:]' before and after it. Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") Signed-off-by: William Tu

[ovs-dev] [PATCH v2 3/5] dpif-netdev: Add CD statistics

This patch adds CD hit and miss statistics to dp_stat_type. PMD stats will show the total CD hit and miss counts. This patch depends on the first patch. CC: Darrell Ball CC: Jan Scheurich Signed-off-by: Yipeng Wang Signed-off-by: Antonio Fischetti Co-authored-by: Antonio Fischetti ---

[ovs-dev] [PATCH v2 1/5] dpif-netdev: Basic CD feature with scalar lookup.

Cuckoo distributor (CD) is a double-hash function hash table, that helps redirect packets to their corresponding subtables to avoid the sequential search of megaflow subtables. This is another layer of cache to cache flows and their corresponding subtable indexes. Different from a hash table, CD

[ovs-dev] [PATCH v2 4/5] dpif-netdev: Add adaptive CD mechanism

When there are only one subtable in the megaflow cache, CD does not benefit. In such case, CD actually hurts the performance because of the extra CD lookup process. This patch implements an adaptive turn on/off CD mechanism. The average iterated subtable count will be collected for every 5

[ovs-dev] [PATCH v2 5/5] unit-test: Add a delay for CD initialization.

This patch adds a delay during test 1215 for considering CD initialization time. CC: Darrell Ball CC: Jan Scheurich Signed-off-by: Yipeng Wang Signed-off-by: Antonio Fischetti Co-authored-by: Antonio Fischetti --- tests/ofproto-dpif.at | 3 +++ 1 file changed, 3 insertions(+) diff --git

[ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

The Datapath Classifier uses tuple space search for flow classification. The rules are arranged into a set of tuples/subtables (each with a distinct mask). Each subtable is implemented as a hash table and lookup is done with flow keys formed by selecting the bits from the packet header based on

[ovs-dev] [PATCH v2 2/5] dpif-netdev: Add AVX2 implementation for CD lookup.

This patch adds the AVX2 implementation during CD lookup. 16 entries of a bucket will be compared together with the lookup key. This patch depends on the first patch. CC: Darrell Ball CC: Jan Scheurich Signed-off-by: Yipeng Wang Signed-off-by: Antonio Fischetti Co-authored-by: Antonio

[ovs-dev] [PATCHv3 3/3] ovsdb-server.c: Fix memory leak

Valgrind testcase 2349 (ovn -- DSCP marking check) reports the leak below: 21 bytes in 21 blocks are definitely lost in loss record 24 of 362 at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x436FD4: xmalloc (util.c:120) by 0x437044: xmemdup0

[ovs-dev] [PATCHv3 1/3] ovsdb-idl: Fix memory leak

Valgrind testcase 2339 (ovn -- ipam connectivity) reports the leak below: 45 (32 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 65 of 83 at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4A6D64: xmalloc (util.c:120) by

Re: [ovs-dev] [PATCH 1/2] acinclude: Add support for grep option.

On Mon, Oct 30, 2017 at 1:04 PM, Ben Pfaff wrote: > On Mon, Oct 16, 2017 at 07:26:44AM -0700, William Tu wrote: >> Allow to pass grep's option to OVS_GREP_IFELSE. >> One use case is to pass '-w' for exact match. >> >> Signed-off-by: William Tu > > POSIX doesn't

Re: [ovs-dev] [PATCH, RFC] tests: Add a default timeout for control utilities

On Sat, Sep 02, 2017 at 08:52:38AM -0700, Ben Pfaff wrote: > On Mon, Aug 28, 2017 at 08:14:59PM +0300, Alin Gabriel Serdean wrote: > > Let's suppose that ovsdb-server is running properly, but ovs-vswitchd > > is not responsive/crashed. We try to add a port via ovs-vsctl and it will > > hang. > >

Re: [ovs-dev] [PATCH] system-traffic: Fix conntrack tests

On Mon, Oct 30, 2017 at 10:31:14AM -0700, William Tu wrote: > On Thu, Oct 26, 2017 at 2:24 PM, Yi-Hung Wei wrote: > > Three conntrack system-traffic tests are broken because of a recent > > change 7827edcaebd8 ("Add dl_type to flow metadata for correct > > interpretation of

Re: [ovs-dev] [PATCH 7/9] flow: Refactor parse_ct_state()

On Fri, Aug 25, 2017 at 03:51:17PM -0700, Yi-Hung Wei wrote: > Refactor parse_ct_state() to support different delimiters. > > Signed-off-by: Yi-Hung Wei > --- > lib/flow.c | 6 +++--- > lib/flow.h | 2 +- > ofproto/ofproto-dpif-trace.c |

Re: [ovs-dev] [PATCH 4/9] ofproto/trace: Query ct_state for conntrack recirc from DP

On Fri, Aug 25, 2017 at 03:51:14PM -0700, Yi-Hung Wei wrote: > Instead of using fixed default conntrack state 'trk|new' in > ofproto/trace for conntrack recirculation, this patch queries the > conntrack state from datapath using ct_dpif_get_info(). > > Signed-off-by: Yi-Hung Wei

Re: [ovs-dev] [PATCH 2/9] ofproto/trace: Propagate ct_zone in recirculation

On Thu, Aug 31, 2017 at 02:38:35PM -0700, Greg Rose wrote: > On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: > >This patch propagates ct_zone when ofproto/trace automatically runs > >through the recirculation process. > > > >Fixes: e6bc8e749381 ("ofproto/trace: Add support for tracing conntrack >

Re: [ovs-dev] [PATCH 1/9] ofproto/trace: Fix memory leak in oftrace_push_ct_state()

On Fri, Aug 25, 2017 at 03:51:11PM -0700, Yi-Hung Wei wrote: > Free the allocated memory in the pop function. > > Fixes: 0f2f05bbcf743 ("ofproto/trace: Add --ct-next option to ofproto/trace") > Signed-off-by: Yi-Hung Wei > --- > ofproto/ofproto-dpif-trace.c | 13

Re: [ovs-dev] [RFC PATCH v2 08/10] vswitch.xml: Detail vxlanipsec user interface.

On Fri, Aug 25, 2017 at 05:40:30PM +0100, Ian Stokes wrote: > This commit adds details to the vswitch xml regarding the use of the > vxlanipsec interface type. This patch is not intended for upstreaming > and simply seeks to solicit feedback on the user interface design of > the vxlanipsec port

Re: [ovs-dev] [RFC PATCH v2 06/10] vxlanipsec: Add userspace support for vxlan ipsec.

On Fri, Aug 25, 2017 at 05:40:28PM +0100, Ian Stokes wrote: > This patch introduces a new tunnel port type 'vxlanipsec'. This port > combines vxlan tunnelling with IPsec operating in transport mode. > > Ciphering and authentication actions ares provided by a DPDK cryptodev. > The cryptodev

Re: [ovs-dev] [RFC PATCH v2 04/10] flow: Add ESP spi value to flow struct.

On Tue, Oct 31, 2017 at 02:46:15PM -0700, Ben Pfaff wrote: > On Fri, Aug 25, 2017 at 05:40:26PM +0100, Ian Stokes wrote: > > This patch adds a field to the flow struct to represent the ESP security > > parameter index of a packet. > > > > Signed-off-by: Ian Stokes > > --- >

Re: [ovs-dev] [RFC PATCH v2 05/10] flow: Modify minflow extract to handle SPI.

On Fri, Aug 25, 2017 at 05:40:27PM +0100, Ian Stokes wrote: > The patch modifies the miniflow extract function to hande the case where > the network protocol for a packet is ESP. In this case the SPI value in > the ESP header is extracted and set in the minflow map. > > Signed-off-by: Ian Stokes

Re: [ovs-dev] [RFC PATCH v2 04/10] flow: Add ESP spi value to flow struct.

On Fri, Aug 25, 2017 at 05:40:26PM +0100, Ian Stokes wrote: > This patch adds a field to the flow struct to represent the ESP security > parameter index of a packet. > > Signed-off-by: Ian Stokes > --- > include/openvswitch/flow.h |5 + > 1 files changed, 5

Re: [ovs-dev] [RFC PATCH v2 03/10] packets: Add ESP header and trailer.

On Fri, Aug 25, 2017 at 05:40:25PM +0100, Ian Stokes wrote: > This patch introduces structs for both ESP headers and ESP trailers > along with expected size assertions. > > Signed-off-by: Ian Stokes Applied to master, thanks! ___

Re: [ovs-dev] [RFC PATCH v2 02/10] openvswitch.h: add vport to ovs_action_push_tnl.

On Fri, Aug 25, 2017 at 05:40:24PM +0100, Ian Stokes wrote: > Upon callback for building/pushing a packet header when encapsulating > for tunneling a reference to the vport in question is required to access > associated devices such as cryptodevs. This patch adds this pointer and > will enable

Re: [ovs-dev] [RFC PATCH v2 01/10] acinclude.m4: Support compilation of libIPsec.

On Fri, Aug 25, 2017 at 05:40:23PM +0100, Ian Stokes wrote: > LibIpsecMB is required to enable the use of vdev cryptodev devices in > DPDK. This patch adds a condition to check for the library when it is > detected that ONFIG_RTE_LIBRTE_PMD_AESNI_MB=y is enabled in the DPDK > config. > >

[ovs-dev] [PATCHv2 2/2] test-ovsdb: Fix memory leak (Amend comments)

v1 -> v2: range_end_atom is allocated in ovsdb_atom_from_string__() and no one is holding a reference to it at the end of do_parse_atom_strings(). It should be freed, as also pointed out by ovsdb_atom_destroy(). Valgrind report is as below: 16 bytes in 1 blocks are definitely lost in loss

[ovs-dev] [PATCHv2 1/2] ovsdb-idl: Fix memory leak (Amend comments)

v1 -> v2: When ovsdb_idl_table is freed, its indexes are not freed. Valgrind report is as below: 45 (32 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 65 of 83 at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4A6D64: xmalloc

Re: [ovs-dev] [RFC PATCH 1/2] sflow: introduce egress flow sampling

It's been a long time since there's been activity in this series. I'm not entirely following the discussion, so I'd like some guidance on how to proceed with it. For now, I'm just marking it "Deferred" in patchwork. On Mon, Sep 04, 2017 at 09:28:45AM +, Weglicki, MichalX wrote: > Hello

Re: [ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

I see that this series appears to have stalled. Should we expect a new version sometime soon? Do you need more reviews on the current version? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] xlate: normalize the actions after translation

On Mon, Oct 30, 2017 at 12:22:50PM +0100, Zoltan Balogh wrote: > When all OF actions have been translated, there could be actions at > the end of list of odp actions which are not needed to be executed. > So, the list can be normalized at the end of xlate_actions(). > > Signed-off-by: Zoltan

[ovs-dev] [PATCH 2/3] test-ovsdb: Fix memory leak

Reported by `make check-valgrind`. This patch was tested by `make check` and `make check-valgrind`. Signed-off-by: Yifeng Sun --- tests/test-ovsdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index

[ovs-dev] [PATCH 1/3] ovsdb-idl: Fix memory leak

Reported by `make check-valgrind`. This patch was tested by `make check` and `make check-valgrind`. Signed-off-by: Yifeng Sun --- lib/ovsdb-idl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 5617e08d633c..be29c92957c0 100644

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: use xlate error enum for unsupported packet type

On Mon, Aug 21, 2017 at 08:34:41AM +, Zoltán Balogh wrote: > Instead of using the value 1 a new enum should be used for indicating > translation error which occurs because of unsupported packet type. > > Signed-off-by: Zoltan Balogh > Signed-off-by: Jan Scheurich

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Mon, 30 Oct 2017 09:29:34 +0800, Yi Yang wrote: > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > +const struct nlattr *a) > +{ > + struct nshhdr *nh; > + size_t length; > + int err; > + u8 flags; > + u8 ttl; > + int i; > + > +

Re: [ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

Ben Pfaff writes: > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote: >> >> Signed-off-by: Gurucharan Shetty >> >> --- >> >>

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Tue, 31 Oct 2017 15:57:41 -0400, Eric Garver wrote: > On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: > > + if (WARN_ON(is_push_nsh && is_mask)) > > + return -EINVAL; > > OVS_NLERR() is probably more appropriate. No, not here. If this happens, it's a bug in the kernel and

Re: [ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote: > >> Signed-off-by: Gurucharan Shetty > >> --- > >> Documentation/intro/install/rhel.rst | 2 +- > >> 1 file

Re: [ovs-dev] [PATCH net-next v14] openvswitch: enable NSH support

On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: [...] > +int nsh_pop(struct sk_buff *skb) > +{ > + struct nshhdr *nh; > + size_t length; > + __be16 inner_proto; > + > + if (!pskb_may_pull(skb, NSH_BASE_HDR_LEN)) > + return -ENOMEM; > + nh = (struct nshhdr

Re: [ovs-dev] [PATCH v1 1/1] Build the JSON C extension for the Python lib

On Thu, Aug 17, 2017 at 02:14:13PM -0500, Terry Wilson wrote: > The JSON C extensions performs much better than the pure Python > version, so build it when producing RPMs. > > Signed-off-by: Terry Wilson Hi Russell, would you mind taking a look at this? It is Pythonic and

Re: [ovs-dev] [PATCH 2/2] lib/netlink: Use correct netlink max message size

On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg Rose wrote: > The maximum message size for recent Linux kernels is 32Kb and in older > kernels it is 16KB. > > See http://www.spinics.net/lists/netdev/msg431592.html > > Adjust the size checked and update a comment. > > Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH 1/2] datapath: Check maximum netlink message size

On Fri, Sep 22, 2017 at 07:44:52AM -0700, Greg Rose wrote: > In kernels < 4.9 the maximum netlink message size is 16KB. > > See http://www.spinics.net/lists/netdev/msg431592.html > > Signed-off-by: Greg Rose Thanks, applied to master, branch-2.8, and branch-2.7.

[ovs-dev] Comunicación y negociación eficaz

Las mejores técnicas para la recuperación de su cartera vencida Habilidades de cobranza altamente eficaces 10 de noviembre - MCE. Abdón Guzmán Santana Zárate9am-6pm El arte de la cobranza requiere de técnicas de negociación y habilidades para la interacción y el trato humano. El éxito de esta

Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

On Thu, Aug 17, 2017 at 12:06:25AM +0800, Xiao Liang wrote: > Poll-loop is the core to implement main loop. It should be available in > libopenvswitch. > > Signed-off-by: Xiao Liang I'm concerned about the way that this adds a definition of HANDLE in a public header. That

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

Thanks Shashank and Sai. I pushed this on master. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Wednesday, October 25, 2017 10:53 PM > To: Sairam Venugopal ;

Re: [ovs-dev] [PATCH 2/2] ipfix: Update Timestamp when flow updated

On Tue, Oct 31, 2017 at 10:08:08AM -0700, Greg Rose wrote: > On 10/24/2017 03:19 PM, Ben Pfaff wrote: > >On Tue, Jun 06, 2017 at 01:42:08PM -0700, Greg Rose wrote: > >>On 06/06/2017 08:22 AM, Ben Pfaff wrote: > >>>On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose wrote: > On 06/05/2017 06:04

[ovs-dev] [PATCH 6/6] installer-windows: Add x64 installer build via command line

Add a new variable to know on which platform we are compiling. Make the msbuild command to be aware of the platform we want to build. Shorter the msbuild parameters from `property:`->`p:`. Change slashes to double slashes so msys does not get confused. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 4/6] installer-windows: Call WIX binaries outside of MSBuild on x64

Unfortunately all WIX binaries (candle, heat, etc) are only 32 bit (up to the latest version 3.11). For performance reasons they are run as .NET assemblies inside the MSBuild process. Running 32 bit assemblies inside a 64 bit process (MSBuild) makes them segfault. Add a new option for heat to be

[ovs-dev] [PATCH 3/6] installer-windows: Resolve WIX solution build type

Until now the x64 build of the installer solution was pointing to the x86 build of the WIX project. This patch changes for them to match. Signed-off-by: Alin Gabriel Serdean --- windows/ovs-windows-installer.sln | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[ovs-dev] [PATCH 2/6] installer-windows: Remove unused entries from WIX project

Remove duplicate and obsolete entries from the installer WIX project. Found by inspection. Signed-off-by: Alin Gabriel Serdean --- .../ovs-windows-installer.wixproj | 36 -- 1 file changed, 36 deletions(-) diff --git

[ovs-dev] [PATCH 0/6] installer fixes on msbuild64

Installer fixes to allow the MSI build using msbuild(64bit variant). Alin Gabriel Serdean (6): build-windows: Suppress output from MSBuild installer-windows: Remove unused entries from WIX project installer-windows: Resolve WIX solution build type installer-windows: Call WIX binaries

Re: [ovs-dev] [PATCH 2/2] ipfix: Update Timestamp when flow updated

On 10/24/2017 03:19 PM, Ben Pfaff wrote: On Tue, Jun 06, 2017 at 01:42:08PM -0700, Greg Rose wrote: On 06/06/2017 08:22 AM, Ben Pfaff wrote: On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose wrote: On 06/05/2017 06:04 PM, Ben Pfaff wrote: From: Greg Rose

Re: [ovs-dev] [PATCH 3/2] vswitchd: Document netdev-dpdk commands.

Thanks, LGTM. -Antonio Acked-by: Antonio Fischetti > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, October 31, 2017 3:18 PM > To: ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Fischetti,

[ovs-dev] [PATCH 3/2] vswitchd: Document netdev-dpdk commands.

Signed-off-by: Ilya Maximets --- NEWS| 3 +++ lib/automake.mk | 1 + lib/netdev-dpdk-unixctl.man | 13 + manpages.mk | 2 ++ vswitchd/ovs-vswitchd.8.in | 1 + 5 files changed, 20 insertions(+) create

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.

On 31.10.2017 17:01, Fischetti, Antonio wrote: > Thanks Ilya, looks a useful debugging command, I gave it a try. > Agree with Raymond, there should be some reference in the doc somewhere. Thanks for review and testing. I've sent patch with documentation update in reply to cover-letter (with 3/2

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Tue, Oct 31, 2017 at 09:20:55AM +0200, Paul Blakey wrote: > > > On 30/10/2017 15:42, Simon Horman wrote: > > On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: > > > > > > > > > On 27/09/2017 12:08, Simon Horman wrote: > > > > On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey

[ovs-dev] [PATCH v2 4/4] ovn: Add IPv6 capability to ovn-nbctl lb-add

ovn-nbctl will now accept IPv6 addresses for load balancer VIPs and desetination addresses. In addition, the ovn-nbctl lb-list, lr-lb-list, and ls-lb-list have been modified to be able to fit IPv6 addresses on screen. Signed-off-by: Mark Michelson ---

[ovs-dev] [PATCH v2 2/4] ovn: Allow ct_lb actions to take IPv6 address arguments.

The ct_lb action previously assumed that any address arguments were IPv4. This patch expands the parsing, formatting, and encoding of ct_lb to be amenable to IPv6 addresses as well. Signed-off-by: Mark Michelson --- include/ovn/actions.h | 6 +++- ovn/lib/actions.c |

[ovs-dev] [PATCH v2 0/4] Add support for IPv6 load balancers

This patchset adds the necessary items in order to support IPv6 load balancers in OVN. No syntax has changed in ovn-nbctl or in the northbound database to support this. Appropriate tests have been added to the testsuite as well. v1 -> v2: * The patchset has been rebased and conflicts resolved.

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.

Thanks Ilya, looks a useful debugging command, I gave it a try. Agree with Raymond, there should be some reference in the doc somewhere. Beside that LGTM. Acked-by: Antonio Fischetti > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com]

Re: [ovs-dev] [PATCH 4/4] netdev-dpdk: Remove unused MAX_NB_MBUF.

Hi Ilya, I've tested all this patch-series by - running some PVP test, - checking the NUMA-awareness works and - MTU small/big changes that causes reuse/creation of a new mp It works fine. LGTM Acked-by: Antonio Fischetti > -Original Message- > From:

Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Factor out struct dpdk_mp.

Thanks Ilya, it's a good rework especially for netdev_dpdk_mempool_configure() fn. LGTM Acked-by: Antonio Fischetti ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/4] netdev-dpdk: Fix dpdk_mp leak in case of EEXIST.

LGTM Acked-by: Antonio Fischetti > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, October 30, 2017 12:53 PM > To: ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Fischetti, Antonio >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.

On 31.10.2017 14:41, Raymond Burkholder wrote: >> >> New appctl 'netdev-dpdk/get-mempool-info' implemented to get result of >> 'rte_mempool_list_dump()' function if no arguments passed and >> 'rte_mempool_dump()' if DPDK netdev passed as argument. >> >> Could be used for debugging mbuf leaks and

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.

> > New appctl 'netdev-dpdk/get-mempool-info' implemented to get result of > 'rte_mempool_list_dump()' function if no arguments passed and > 'rte_mempool_dump()' if DPDK netdev passed as argument. > > Could be used for debugging mbuf leaks and other mempool related issues. > Most useful in pair

[ovs-dev] [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.

New appctl 'netdev-dpdk/get-mempool-info' implemented to get result of 'rte_mempool_list_dump()' function if no arguments passed and 'rte_mempool_dump()' if DPDK netdev passed as argument. Could be used for debugging mbuf leaks and other mempool related issues. Most useful in pair with `grep -v

[ovs-dev] [PATCH 1/2] netdev-dpdk: Fix mempool creation with large MTU.

Currently mempool name size limited to 25 characters by RTE_MEMPOOL_NAMESIZE. netdev-dpdk tries to create mempool with the following name pattern: "ovs_%{hash}_%{socket}_%{mtu}_%{n_mbuf}". We have 3 chars for "ovs" + 4 chars for delimiters + 8 chars for hash (because it's the 32 bit integer

[ovs-dev] [PATCH 0/2] netdev-dpdk: Mempool creation failure + Appctl

This series implemented on top of my previous patch-set: * [PATCH 0/4] netdev-dpdk: mempool management: Leaks & Refactoring. https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340144.html I can rebase it on top of current master easily if needed. Patches are independent, sent

[ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

The reload procedure will trigger a script that saves the flows and tlv maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd, it sets other_config:flow-restore-wait=true (to wait till flow restore is finished), it starts ovs-vswitchd, it restore the backupped flows/tlv maps

Re: [ovs-dev] [PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Tuesday, October 31, 2017 6:46 AM >To: Kavanagh, Mark B ; d...@openvswitch.org >Subject: Re: [ovs-dev][PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t > >Thanks. I wanted to remove this function initially,

Re: [ovs-dev] [PATCH v2] tests: fix PTAP system test to check only OF stats

Hi Ben, I rebased the patch and sent v3 to the dev list: https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340225.html https://patchwork.ozlabs.org/patch/832300/ Best regards, Zoltan > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Monday, October 30, 2017

[ovs-dev] [PATCH v3] tests: fix PTAP system test to check only OF stats

It turned out, checking datapath flow statistics during system-userspace test is not reliable. Unwanted packets can be injected depending on system configuration. As a workaround, this commit removes checking statistics of datapath flows and does check OpenFlow statistics of the integrator

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On 30/10/2017 15:42, Simon Horman wrote: On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: On 27/09/2017 12:08, Simon Horman wrote: On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: On 18/09/2017 18:01, Simon Horman wrote: On Mon, Sep 18, 2017 at 07:16:03AM +0300,

Re: [ovs-dev] [PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t

Thanks. I wanted to remove this function initially, that's why I forget to replace the type here. This is important because dpdk changes the type of port_id to uint16_t for upcoming release. Acked-by: Ilya Maximets On 20.10.2017 15:37, Mark Kavanagh wrote: >