in dpdk ovs mode some ethernet which have linux interface
not need rtnetlink notifier so we can add them to blacklist.
Signed-off-by: Haifeng Lin
---
lib/netdev-dpdk.c | 5 +++
lib/netlink-notifier.c | 5 ++-
lib/rtnetlink.c| 118
@@ -1015,6 +1016,8 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
rte_eth_dev_info_get(dev->port_id, );
+rtnetlink_blacklist_add(dev->up.name); // add a ovs-dpdk
port to blacklist
+
Some DPDK port even use PMD they also have linux interface (like mellanox
On Sat, Aug 04, 2018 at 02:43:24AM +0200, Stefano Brivio wrote:
> On Fri, 3 Aug 2018 16:01:08 -0700
> Ben Pfaff wrote:
> > I would be very pleased if we could integrate a simple mechanism for
> > fairness, based for now on some simple criteria like the source port,
> > but thinking ahead to how
On Fri, 3 Aug 2018 16:01:08 -0700
Ben Pfaff wrote:
> I think that a simple mechanism for fairness is fine. The direction
> of extensibility that makes me anxious is how to decide what matters
> for fairness. So far, we've talked about per-vport fairness. That
> works pretty well for packets
On Mon, Jul 16, 2018 at 11:33:39AM -0700, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
Applied to master and branch-2.10. Thank you! Let me know if it needs
further backporting.
___
dev mailing list
d...@openvswitch.org
On Thu, Aug 02, 2018 at 08:20:58PM -0700, Darrell Ball wrote:
> The function dpctl_flush_conntrack() and other such functions with
> multiple optional arguments can be simplified by introducing a new
> function to check whether a valid datapath name is supplied as an
> argument to the functions.
>
On Fri, Aug 03, 2018 at 02:10:06PM +0800, Haifeng Lin wrote:
> in dpdk ovs mode some ether not need rtnetlink notifier
> so we can use blacklist remove ethernet from rtnetlink notifier
>
> Signed-off-by: Haifeng Lin
Can you explain the benefit of the patch?
I don't see any way for a port to be
On Wed, Aug 01, 2018 at 05:00:09PM +0300, Ilya Maximets wrote:
> Each run of the testsuite produces millions lines in a system
> log. This is completely unnecessary and makes it difficult to
> use system logs on test / build servers.
>
> This series is aimed to disable most of the syslog
On Fri, Jul 27, 2018 at 04:29:40PM +0200, Timothy Redaelli wrote:
> Currently protocol_flags is populated by the list of SSL and TLS
> protocols by hand. This means that when a new TLS version is added to
> openssl (in this case TLS v1.3 is added to openssl 1.1.1 beta)
> ovsdb-server automatically
Thanks everyone, applied to master and branch-2.10.
On Wed, Aug 01, 2018 at 02:28:03PM -0700, Martin Xu wrote:
> Thanks for fixing this.
>
> Martin
>
> On Wed, Aug 1, 2018 at 8:48 AM, Timothy Redaelli
> wrote:
>
> > [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and
> >
On Fri, Aug 03, 2018 at 08:28:08PM +0200, Timothy Redaelli wrote:
> Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with python3")
> and commit 227abb77d3d1 ("ovs-tcpundump: Fix incompatibilities with python3")
> ovs-tcpdump and ovs-tcpdump works with Python3 as well.
>
> This
On Fri, Aug 03, 2018 at 08:12:16PM +0300, aserd...@ovn.org wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/pcap-file.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/pcap-file.c b/lib/pcap-file.c index
> 981d56d48830..ea5cfa3b274e
> > 100644
> > ---
On Fri, Aug 03, 2018 at 08:23:07PM +0300, aserd...@ovn.org wrote:
>
> >
> > All the users of mf_vl_mff_mf_from_nxm_header() expect it to always
> > obtain a valid field or to report an error. In practice, it did not
> report an error
> > in the case where the field was unknown (although it did
Thanks for the comments. I resolved all of them and applied this series
to master and branch-2.10.
On Fri, Aug 03, 2018 at 08:34:53AM -0400, Mark Michelson wrote:
> For the series:
>
> Acked-by: Mark Michelson
>
> I have a couple of small notes in-line below on this particular commit
>
Thanks. Applied to master and backported as far as branch-2.6.
On Fri, Aug 03, 2018 at 08:50:37AM -0400, Mark Michelson wrote:
> Acked-by: Mark Michelson
>
> On 07/26/2018 06:43 PM, Ben Pfaff wrote:
> >Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424
> >Signed-off-by:
On Fri, Aug 03, 2018 at 06:52:41PM +0200, Stefano Brivio wrote:
> On Tue, 31 Jul 2018 15:06:57 -0700 Ben Pfaff wrote:
> > My current thought is that any fairness scheme we implement directly in
> > the kernel is going to need to evolve over time. Maybe we could do
> > something flexible with BPF
On Fri, Aug 03, 2018 at 03:06:48PM -0700, Zak Whittington wrote:
> VMware-BZ: 2158607
> Signed-off-by: Zak Whittington
> ---
> ofproto/ofproto-dpif-xlate.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> index
On Wed, Aug 01, 2018 at 04:00:59PM -0700, Martin Xu wrote:
> This patch fixes a scenario not working for RHEL7.3 in commit 89dd5819cf18.
> When multiple versions passed into the kversion for the spec file, the
> variable is used as is for the kernel module paths for command
> weak-modules
VMware-BZ: 2158607
Signed-off-by: Zak Whittington
---
ofproto/ofproto-dpif-xlate.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 01f1faf..93fbee5 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++
Bleep bloop. Greetings Zak Whittington, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: No signatures found.
Lines checked: 37, Warnings: 0, Errors: 1
Please check this
On Thu, Jul 12, 2018 at 01:37:33AM +0530, Numan Siddique wrote:
> On Wed, Jul 11, 2018 at 10:26 PM Ben Pfaff wrote:
>
> > On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote:
> > > On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff wrote:
> > >
> > > > On Wed, Jul 11, 2018 at 12:56:39AM
VMware-BZ: 2158607
---
ofproto/ofproto-dpif-xlate.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 01f1faf..93fbee5 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -5007,6 +5007,8 @@
Match the prefix and formatting.
Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.")
Cc: pshe...@ovn.org
Signed-off-by: Kevin Traynor
---
lib/netdev-dpdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 9bf2185..90a6165 100644
Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with python3")
and commit 227abb77d3d1 ("ovs-tcpundump: Fix incompatibilities with python3")
ovs-tcpdump and ovs-tcpdump works with Python3 as well.
This commit allows ovs-tcpdump and ovs-tcpundump to be installed also when
only
On Wed, Jul 25, 2018 at 05:37:22PM +0200, Jakub Sitnicki wrote:
> On Tue, Jul 24, 2018 at 07:53 PM GMT, Ben Pfaff wrote:
> > This has some flaws in the details; for example, command-line options
> > parsing is very inflexible.
> >
> > Signed-off-by: Ben Pfaff
> > ---
>
> Thank you for working on
This makes ovn-nbctl transparently use daemon mode if an appropriate
environment variable is set.
It also transforms ovn-nbctl.at so that it runs each ovn-nbctl test in
"direct" mode and in daemon mode. It uses a combination of m4 macros and
shell functions to keep from expanding the generated
This will allow selected options to be interpreted locally and others to
be passed to the daemon, when the daemon is in use.
Signed-off-by: Ben Pfaff
---
lib/command-line.c| 108 ++
lib/command-line.h| 10 +
Acked-by: Alin Gabriel Serdean
Signed-off-by: Ben Pfaff
---
lib/unixctl.c | 52
lib/unixctl.h | 2 ++
tests/daemon.at | 4 ++--
3 files changed, 32 insertions(+), 26 deletions(-)
diff --git a/lib/unixctl.c b/lib/unixctl.c
index
v1->v2:
- Applied patches 1 and 2; added ack for patch 3 (thanks Alin!)
- Polished up the daemon mode so that it works actually quite well
and added tests that show that it behaves equivalently.
Ben Pfaff (3):
unixctl: Make path to unixctl_server socket available to the client.
On Fri, Aug 03, 2018 at 06:43:03PM +0300, aserd...@ovn.org wrote:
> >
> > When this case was adapted for Windows, asb_file_name() simply didn't
> > work at all there. Now, it should work OK, and it seems like the right
> thing to
> > do, and it makes the code more straightforward too.
> >
> >
On 7/28/2018 4:00 AM, we...@ucloud.cn wrote:
From: wenxu
It makes datapath can support both ndo_add_udp_tunnel_port and
ndo_add_vxlan/geneve_port
Signed-off-by: wenxu
---
acinclude.m4 | 1 +
datapath/linux/compat/geneve.c | 41
>
> All the users of mf_vl_mff_mf_from_nxm_header() expect it to always
> obtain a valid field or to report an error. In practice, it did not
report an error
> in the case where the field was unknown (although it did report an error
in
> some other cases). This commit fixes the problem.
>
>
> Signed-off-by: Ben Pfaff
> ---
> lib/pcap-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/pcap-file.c b/lib/pcap-file.c index
981d56d48830..ea5cfa3b274e
> 100644
> --- a/lib/pcap-file.c
> +++ b/lib/pcap-file.c
> @@ -163,7 +163,7 @@ ovs_pcap_read(FILE *file,
Hi Ben,
On Tue, 31 Jul 2018 15:06:57 -0700
Ben Pfaff wrote:
> This is an awkward problem to try to solve with sockets because of the
> nature of sockets, which are strictly first-in first-out. What you
> really want is something closer to the algorithm that we use in
> ovs-vswitchd to send
On Fri, Aug 03, 2018 at 06:47:04PM +0300, aserd...@ovn.org wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> <---B<-->
> > if (error) {
> > -ovs_error(error, "could not initialize control socket %s",
> punix_path);
> [Alin Serdean] Changing the log
On 3 Aug 2018, at 18:52, Ben Pfaff mailto:b...@ovn.org>> wrote:
On Fri, Aug 03, 2018 at 03:41:55PM +, Alin Serdean wrote:
abs_file_name() believed that a file name that begins with / or contains :
is absolute and that any other file name is relative. On Windows, this is
wrong in at least
On Fri, Aug 03, 2018 at 03:41:55PM +, Alin Serdean wrote:
> >
> > abs_file_name() believed that a file name that begins with / or contains :
> > is absolute and that any other file name is relative. On Windows, this is
> > wrong in at least the following ways:
> >
> >* / and \ are
> Signed-off-by: Ben Pfaff
> ---
<---B<-->
> if (error) {
> -ovs_error(error, "could not initialize control socket %s",
punix_path);
[Alin Serdean] Changing the log message will make the following test fail:
130. daemon.at:148: testing daemon
>
> abs_file_name() believed that a file name that begins with / or contains :
> is absolute and that any other file name is relative. On Windows, this is
> wrong in at least the following ways:
>
>* / and \ are interchangeable on Windows.
>
>* A name that begins with \\ or // is also
I'm way behind, so this is really just to let you know I haven't
forgotten and will get to this when I can (possibly after the release in
mid-August). Sorry about the delay.
On Fri, Aug 03, 2018 at 10:51:39AM +0200, Bhargava Shastry wrote:
> Hello,
>
> Gentle reminder to check if the proposed
On 03.08.2018 17:44, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> Each run of the testsuite produces millions lines in a system
>> log. This is completely unnecessary and makes it difficult to
>> use system logs on test / build servers.
>>
>> This series is aimed to disable most of the
Ilya Maximets writes:
> Each run of the testsuite produces millions lines in a system
> log. This is completely unnecessary and makes it difficult to
> use system logs on test / build servers.
>
> This series is aimed to disable most of the syslog messages.
> There are still few logs that
Timothy Redaelli writes:
> [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and other
> linux distributions may use instead of bash.
>
> This commit uses, instead, a POSIX way that is compatible with any POSIX
> shell (bash, dash, busybox sh, etc).
>
> CC: Martin Xu
> Fixes:
Ian Stokes writes:
> On 7/25/2018 2:56 PM, Aaron Conole wrote:
>> 0-day Robot writes:
>>
>>> Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your
>>> patch.
>>> Thanks for your contribution.
>>>
>>> I encountered some error that I wasn't expecting. See the details below.
Acked-by: Mark Michelson
On 07/26/2018 06:43 PM, Ben Pfaff wrote:
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424
Signed-off-by: Ben Pfaff
---
lib/nx-match.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
For the series:
Acked-by: Mark Michelson
I have a couple of small notes in-line below on this particular commit
message.
On 07/26/2018 01:09 PM, Ben Pfaff wrote:
A previous commit to improve timing also caused the cluster torture test to
be skipped (unless it failed early). This is
Hello,
Gentle reminder to check if the proposed patch works :-)
Thanks,
Bhargava
On 07/30/2018 11:58 AM, Bhargava Shastry wrote:
> Any updates on the proposed patch? :-)
>
> On 07/16/2018 02:07 PM, Bhargava Shastry wrote:
>> Update: I fixed these errors in the attached patch that supersedes
On Thu, 2 Aug 2018 13:00:38 -0700
Ben Pfaff wrote:
> On Thu, Aug 02, 2018 at 11:48:26AM -0400, Aaron Conole wrote:
> > Jakub Sitnicki writes:
> >
> > > Signed-off-by: Jakub Sitnicki
> > > ---
> > >
> > > The j...@redhat.com address will be valid only until August 4th.
> >
> > :'(
> >
>
Bleep bloop. Greetings Haifeng Lin, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around
in dpdk ovs mode some ether not need rtnetlink notifier
so we can use blacklist remove ethernet from rtnetlink notifier
Signed-off-by: Haifeng Lin
---
lib/netdev-dpdk.c | 3 ++
lib/netlink-notifier.c | 5 ++-
lib/rtnetlink.c| 109
50 matches
Mail list logo
