Re: [ovs-dev] [PATCH] [PATCH] rcu: reduce RCU block time

2018-12-12 Thread Lilijun (Jerry, Cloud Networking)
Hi, Ben You're right, thanks for your help. I have got the cause of this problem: there is some mistake in my code that causes the current thread's waiter can't be inserted into &waiter->thread->waiters in the function seq_wait__(). So it can't be woke up when other threads have changed the

Re: [ovs-dev] [PATCH v4] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-12-12 Thread Han Zhou
On Wed, Dec 12, 2018 at 12:05 PM Ben Pfaff wrote: > > On Thu, Nov 15, 2018 at 05:21:47PM -0800, Han Zhou wrote: > > From: Han Zhou > > > > When adding a new chassis, if there is an old chassis with same IP > > existed in Encap table, it is allowed to be added today. However, > > allowing it to be

Re: [ovs-dev] [PATCH] nf_conntrack_proto: Fix HAVE_NET_NS_GET macro for nf_conntrack

2018-12-12 Thread Yi-Hung Wei
On Wed, Dec 12, 2018 at 1:24 PM Yifeng Sun wrote: > > In previous code, macro HAVE_NET_NS_SET is used in code but > never generated by config. This patch fixes it. > > Signed-off-by: Yifeng Sun > --- Thanks for the bug fix. It resolves compat issues for kernel between v4.10 and v4.14. Fixes: 17

Re: [ovs-dev] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 pinctrl: Check requested IP in DHCPREQUEST message

Re: [ovs-dev] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread 0-day Robot
Bleep bloop. Greetings Gregory Smith, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 pinctrl: Check requested IP in DHCPREQUEST me

[ovs-dev] [PATCH v2] OVN: add mac address only support to IPAM/MACAM

2018-12-12 Thread Lorenzo Bianconi
Add the capability to assign just L2 address to IPAM/MACAM since in the current implementation either subnet or ipv6_prefix are mandatory to enable IPAM Tested-by: Yossi Segev Signed-off-by: Lorenzo Bianconi --- Changes since v1: - fix documentation --- ovn/northd/ovn-northd.c | 8 +++- ov

Re: [ovs-dev] [PATCH] sparse: Fix incompatibility with glibc 2.28 and later.

2018-12-12 Thread Ben Pfaff
On Wed, Dec 12, 2018 at 02:37:39PM -0800, Justin Pettit wrote: > > > On Dec 12, 2018, at 9:51 AM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master. ___ dev mailing list d...@openvswitch.org htt

Re: [ovs-dev] [PATCH] sparse: Fix incompatibility with glibc 2.28 and later.

2018-12-12 Thread Justin Pettit
> On Dec 12, 2018, at 9:51 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH branch-2.9 1/1] netdev-dpdk: Fix flow control configuration.

2018-12-12 Thread Ian Stokes
From: Sugesh Chandran Currently devices that do not support configuring flow control via the eth_dev API (e.g. SRIOV VFs) will fail during configuration setup when the interface is added even if flow control is not requested. This is due to rte_eth_dev_flow_ctrl_get() being called regardless of w

[ovs-dev] [PATCH] nf_conntrack_proto: Fix HAVE_NET_NS_GET macro for nf_conntrack

2018-12-12 Thread Yifeng Sun
In previous code, macro HAVE_NET_NS_SET is used in code but never generated by config. This patch fixes it. Signed-off-by: Yifeng Sun --- acinclude.m4 | 4 ++-- datapath/linux/compat/nf_conntrack_proto.c | 8 2 files changed, 6 insertions(+), 6 deletions(-)

Re: [ovs-dev] [PATCH] OVN: add mac address only support to IPAM/MACAM

2018-12-12 Thread Lorenzo Bianconi
> > On Wed, Dec 12, 2018 at 11:53:49AM +0100, Lorenzo Bianconi wrote: > > Add the capability to assign just L2 address to IPAM/MACAM since > > in the current implementation either subnet or ipv6_prefix are mandatory > > to enable IPAM > > > > Tested-by: Yossi Segev > > Signed-off-by: Lorenzo Bianc

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

2018-12-12 Thread Ben Pfaff
If I'm not mistaken, we briefly discussed this at ovscon. It seems to me that this is a fairly complicated issue and proposal, and it might benefit from in-person discussion. I seem to recall that you are local to the Bay Area, and, if so, do you think we could take some time, perhaps next week,

Re: [ovs-dev] [PATCH] ovn: Fix indentation in TODO.

2018-12-12 Thread Ben Pfaff
Are you sure you're following up to the right patch? On Wed, Dec 12, 2018 at 09:47:30PM +0100, Daniel Alvarez wrote: > Thanks a lot folks! > How about getting it into 2.10 branch? Would that be ok? > > > On 12 Dec 2018, at 21:08, Ben Pfaff wrote: > > > >> On Thu, Sep 20, 2018 at 04:44:11PM -070

Re: [ovs-dev] [PATCH] ovn: Fix indentation in TODO.

2018-12-12 Thread Daniel Alvarez
Thanks a lot folks! How about getting it into 2.10 branch? Would that be ok? > On 12 Dec 2018, at 21:08, Ben Pfaff wrote: > >> On Thu, Sep 20, 2018 at 04:44:11PM -0700, Ben Pfaff wrote: >> Some items listed under ovsdb-server should have been top-level items. >> >> Signed-off-by: Ben Pfaff >

[ovs-dev] [PATCH] connmgr: Do not send asynchronous messages to rconns lacking protocols.

2018-12-12 Thread Ben Pfaff
There are corner cases in which an rconn might not have a defined OpenFlow protocol or version. These happen at connection startup, before the protocol version has been negotiated, and can also happen when a connection is being shut down. It's desirable to avoid these situations entirely, but so

Re: [ovs-dev] [PATCH] ovn: Fix indentation in TODO.

2018-12-12 Thread Ben Pfaff
On Thu, Sep 20, 2018 at 04:44:11PM -0700, Ben Pfaff wrote: > Some items listed under ovsdb-server should have been top-level items. > > Signed-off-by: Ben Pfaff I got tired of waiting for a review for an internal documentation update, so I applied this to master.

Re: [ovs-dev] [PATCH v1] rhel: Add 'SYSTEMD_NO_WRAP=yes' in ovs init script for SLES

2018-12-12 Thread Ben Pfaff
On Mon, Dec 10, 2018 at 06:33:19AM -0800, Martin Xu wrote: > The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES > 12 is 'SYSTEMD_NO_WRAP=yes' > > VMware-BZ: #2245358 > Signed-off-by: Martin Xu > CC: Markos Chandras > CC: Ansis Atteka > CC: Ben Pfaff Markos, for this patch

Re: [ovs-dev] [PATCH v4] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-12-12 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 05:21:47PM -0800, Han Zhou wrote: > From: Han Zhou > > When adding a new chassis, if there is an old chassis with same IP > existed in Encap table, it is allowed to be added today. However, > allowing it to be added results in problems: > > 1. The new chassis cannot work

Re: [ovs-dev] [PATCH] OVN: add mac address only support to IPAM/MACAM

2018-12-12 Thread Ben Pfaff
On Wed, Dec 12, 2018 at 11:53:49AM +0100, Lorenzo Bianconi wrote: > Add the capability to assign just L2 address to IPAM/MACAM since > in the current implementation either subnet or ipv6_prefix are mandatory > to enable IPAM > > Tested-by: Yossi Segev > Signed-off-by: Lorenzo Bianconi Hi Lorenz

Re: [ovs-dev] [PATCH v2] OVN: add selected mac address to MACAM in update_dynamic_addresses

2018-12-12 Thread Ben Pfaff
On Wed, Nov 21, 2018 at 05:03:39PM +0100, Lorenzo Bianconi wrote: > Add selected dynamic mac address to MACAM in update_dynamic_addresses > and not just in in ipam_add_port_addresses/ipam_insert_lsp_addresses > since the second approach can produce a duplicated L2 address in a > IPv6-only network i

Re: [ovs-dev] [PATCH v2] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

2018-12-12 Thread Ben Pfaff
On Tue, Dec 04, 2018 at 07:14:35PM +0100, Daniel Alvarez wrote: > Prior to this patch, GARPs announcing NAT addresses or new VIFs > were sent out to localnet ofport through an output action. > This can lead to problems since local datapaths won't get those > GARPs and ovn-controller won't update MA

Re: [ovs-dev] [PATCH v6] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread Ben Pfaff
On Wed, Dec 12, 2018 at 06:52:04PM +, Gregory Smith wrote: > Ben Pfaff wrote: > > On Wed, Dec 12, 2018 at 04:26:37PM +, Gregory Smith wrote: > > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > > > server should validate that the client's requested IP matches the >

Re: [ovs-dev] [PATCH v6] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread Gregory Smith
Ben Pfaff wrote: > On Wed, Dec 12, 2018 at 04:26:37PM +, Gregory Smith wrote: > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > > server should validate that the client's requested IP matches the > > offered IP. If not, the server should reply with a DHCPNAK. The clien

Re: [ovs-dev] [PATCH] netdev: Add comment to allow removing a workaround in the future

2018-12-12 Thread Ben Pfaff
On Fri, Nov 16, 2018 at 11:42:29AM +0100, Daniel Alvarez wrote: > This patch [0] in glibc fixes an issue which is right now workarounded > in OVS by [1]. I'm adding a comment to indicate that from glibc 2.28 > and beyond, the workaround is not needed so that we can eventually > remove it. > > [0]

[ovs-dev] [PATCH 2/2] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread Ben Pfaff
From: Gregory Smith See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the server should validate that the client's requested IP matches the offered IP. If not, the server should reply with a DHCPNAK. The client's requested IP is either specified as the Requested IP Address (option

[ovs-dev] [PATCH 1/2] dhcp: Mark dhcp_header as packed.

2018-12-12 Thread Ben Pfaff
This structure isn't performance-sensitive and making it packed simplifies thinking about access to it. CC: Gregory Smith Signed-off-by: Ben Pfaff --- lib/dhcp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dhcp.h b/lib/dhcp.h index 271e0a55b320..2feb2f4478f9 100644

Re: [ovs-dev] [PATCH v6] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread Ben Pfaff
On Wed, Dec 12, 2018 at 04:26:37PM +, Gregory Smith wrote: > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > server should validate that the client's requested IP matches the > offered IP. If not, the server should reply with a DHCPNAK. The client's > requested IP is eit

[ovs-dev] [PATCH] ovs-tcpdump: Add --span to mirror all ports on bridge.

2018-12-12 Thread Ben Pfaff
From: Martin Fong Signed-off-by: Martin Fong Signed-off-by: Ben Pfaff --- I already applied this to master; it came from https://github.com/openvswitch/ovs/pull/260. utilities/ovs-tcpdump.8.in | 3 +++ utilities/ovs-tcpdump.in | 12 +--- 2 files changed, 12 insertions(+), 3 deletio

[ovs-dev] [PATCH] sparse: Fix incompatibility with glibc 2.28 and later.

2018-12-12 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- include/sparse/automake.mk | 3 ++- include/sparse/threads.h | 27 +++ 2 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 include/sparse/threads.h diff --git a/include/sparse/automake.mk b/include/sparse/automake.mk index

[ovs-dev] Rotación Cero

2018-12-12 Thread Reducir la rotación de personal
¡Cursos TOP - Webinar interactivo - Innova learn! Innova Learn propone este webinar en el que se revisarán las bases teóricas que apoyen a los participantes en la implementación de tácticas que subsanen esta problemática que influye en la cultura organizacional de la empresa. OBJETIVO GE

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ilya Maximets > Trimis: Wednesday, December 12, 2018 6:59 PM > Către: aserd...@ovn.org; 'Ben Pfaff' > Cc: ovs-dev@openvswitch.org > Subiect: Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integrat

Re: [ovs-dev] [PATCH] ofproto: Return correct error codes from meter_set.

2018-12-12 Thread Ben Pfaff
On Thu, Nov 22, 2018 at 09:44:43AM +1300, Tony van der Peet wrote: > This routine should return enum ofperr, but in a couple of places > doesn't. When adding one more meter when the meter table is full, > this results in an incorrect error message. > > Signed-off-by: Tony van der Peet Applied to

Re: [ovs-dev] [PATCH 3/3] ovs-actions: New document describing OVS actions in detail.

2018-12-12 Thread Ben Pfaff
On Thu, Nov 08, 2018 at 09:39:55PM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff This series still applies and still needs a review. It's documentation, so it should not be difficult to review. ___ dev mailing list d...@openvswitch.org https://mai

Re: [ovs-dev] [PATCH 0/8] datapath: Pull in upstream fixes and updates

2018-12-12 Thread Gregory Rose
On 12/10/2018 11:36 AM, Ben Pfaff wrote: On Wed, Dec 05, 2018 at 10:55:44AM -0800, Greg Rose wrote: Pull in recent Linux upstream kernel updates for openvswitch core. Travis build is here: https://travis-ci.org/gvrose8192/ovs-experimental/builds/463951223 It looks like this series is fully a

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread Ilya Maximets
On 12.12.2018 19:50, aserd...@ovn.org wrote: >> -Mesaj original- >> De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ilya Maximets >> Trimis: Wednesday, December 12, 2018 6:36 PM >> Către: Ben Pfaff >> Cc: ovs-dev@openvswitch.org; Alin Gabriel Serdean >> Subiect

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ilya Maximets > Trimis: Wednesday, December 12, 2018 6:36 PM > Către: Ben Pfaff > Cc: ovs-dev@openvswitch.org; Alin Gabriel Serdean > Subiect: Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integrat

Re: [ovs-dev] [PATCH v2] ovs:group: support to insert bucket with weight value for select type

2018-12-12 Thread Ben Pfaff
On Thu, Nov 22, 2018 at 06:59:15PM +0800, solomon wrote: > After creating a group with hash select type,then we need to insert a new > bucket with weight, > But,it fails. Commands are as following: > > # ovs-ofctl -O OpenFlow15 add-group br0 "group_id=10, type=select, > selection_method=hash,f

Re: [ovs-dev] [PATCH] utilities: Add smap related command and iterator to the GDB script

2018-12-12 Thread Ben Pfaff
On Thu, Nov 22, 2018 at 04:18:14PM +0100, Eelco Chaudron wrote: > Adds "ovs_dump_smap " command > > Example output: > > Breakpoint 1, trtcm_policer_qos_construct (details=0x135bad0, > conf=0x7ffd31f5da28) at lib/netdev-dpdk.c:4154 > (gdb) ovs_dump_smap 0x135bad0 > cbs: 2048 > cir: 151800 > eir:

Re: [ovs-dev] [PATCH] ofproto-dpif: Let the dpif report when a port is a duplicate.

2018-12-12 Thread Ben Pfaff
On Wed, Dec 05, 2018 at 03:12:08PM -0200, Flavio Leitner wrote: > > Hi Ben, > > This patch introduced a regression in OSP environments using internal > ports in other netns. Their networking configuration is lost when > the service is restarted because the ports are recreated now. > > Before the

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread Ilya Maximets
On 12.12.2018 19:24, Ben Pfaff wrote: > On Wed, Dec 12, 2018 at 07:00:28PM +0300, Ilya Maximets wrote: >> On 12.12.2018 0:06, Ben Pfaff wrote: >>> On Tue, Dec 11, 2018 at 05:34:17PM +0300, Ilya Maximets wrote: CirrusCI [1] is free for open-sorce projects and provides similar to TravisCI i

[ovs-dev] [PATCH v6] pinctrl: Check requested IP in DHCPREQUEST messages

2018-12-12 Thread Gregory Smith
See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the server should validate that the client's requested IP matches the offered IP. If not, the server should reply with a DHCPNAK. The client's requested IP is either specified as the Requested IP Address (option 50), or as the ciaddr

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread Ben Pfaff
On Wed, Dec 12, 2018 at 07:00:28PM +0300, Ilya Maximets wrote: > On 12.12.2018 0:06, Ben Pfaff wrote: > > On Tue, Dec 11, 2018 at 05:34:17PM +0300, Ilya Maximets wrote: > >> CirrusCI [1] is free for open-sorce projects and provides similar > >> to TravisCI interfaces. One significant difference is

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread Ilya Maximets
On 11.12.2018 21:25, Aaron Conole wrote: > Ilya Maximets writes: > >> CirrusCI [1] is free for open-sorce projects and provides similar >> to TravisCI interfaces. One significant difference is ability >> to run tasks on FreeBSD instances. >> >> This patch adds simple configuration file to test OV

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

2018-12-12 Thread Ilya Maximets
On 12.12.2018 0:06, Ben Pfaff wrote: > On Tue, Dec 11, 2018 at 05:34:17PM +0300, Ilya Maximets wrote: >> CirrusCI [1] is free for open-sorce projects and provides similar >> to TravisCI interfaces. One significant difference is ability >> to run tasks on FreeBSD instances. >> >> This patch adds sim

Re: [ovs-dev] [dpdk-hwol PATCH v1] netdev-dpdk: support port representors

2018-12-12 Thread Ian Stokes
On 12/11/2018 11:34 PM, Ophir Munk wrote: Dpdk port representors were introduced in dpdk 18.xx. Prior to representors there was a one-to-one relationship between an rte device (e.g. PCI bus) and an eth device (a dpdk port id). With representors the relationship becomes one-to-many rte device to e

Re: [ovs-dev] [ovs-dev, dpdk-hwol, v1] netdev-dpdk: support port representors

2018-12-12 Thread Ilya Maximets
Not a full review. Just one comment inline. Best regards, Ilya Maximets. On 12.12.2018 2:34, Ophir Munk wrote: > Dpdk port representors were introduced in dpdk 18.xx. > Prior to representors there was a one-to-one relationship > between an rte device (e.g. PCI bus) and an eth device (a dpdk > por

[ovs-dev] [PATCH] Prevent kernel warning length of ovs attribute.

2018-12-12 Thread Nathanael Davison
Linux kernel commit 6e237d099fac introduced warnings when validating the length of some types. This exposed a bug in dpif-netlink.c dpif_netlink_vport_to_ofpbuf where ovs was passing the upcall pids as variable length array while the kernel was expecting a single u32. This resulted in the kernel re

[ovs-dev] [PATCH] OVN: add mac address only support to IPAM/MACAM

2018-12-12 Thread Lorenzo Bianconi
Add the capability to assign just L2 address to IPAM/MACAM since in the current implementation either subnet or ipv6_prefix are mandatory to enable IPAM Tested-by: Yossi Segev Signed-off-by: Lorenzo Bianconi --- ovn/northd/ovn-northd.c | 8 +++- ovn/ovn-nb.xml | 5 + tests/ov

[ovs-dev] Banking News Alert!

2018-12-12 Thread CEO: ROBERT E. MARLING via dev
WOODFOREST NATIONAL BANK. 4412 NORTH FREEWAY HOUSTON, TX 77022 Banking News Alert! WE APOLOGIZE FOR THE DELAY IN THE TRANSFER YOUR FUNDS, IT WAS DUE TO THE FACT THAT OUR DATABASE WAS HACKED BY HACKERS, WHO TRIED HACKING INTO OUR ENTIRE SYSTEM, WHICH RESULTED IN THE SHUTTING DOWN OF OU

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-12-12 Thread Darrell Ball
I'll respond to the individual comments soon, although some comments are answered by subsequent patches. I did notice a problem that I will fix and make adjustments for, in that the ipf context should have been per datapath. Thanks Darrell On Tue, Dec 11, 2018 at 8:15 AM Ben Pfaff wrote: > On M