Re: [ovs-dev] [PATCHv7 1/3] Improved Packet Drop Statistics in OVS

2019-02-07 Thread Anju Thomas
Thanks Ilya. I have sent the updated patch. Regards Anju -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Thursday, February 07, 2019 7:52 PM To: Anju Thomas ; Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [PATCHv7 1/3] Improved Packet Drop Statistics in

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
On Fri, Feb 8, 2019 at 4:55 AM Ben Pfaff wrote: > > On Thu, Feb 07, 2019 at 12:00:39PM +0100, Christian Ehrhardt wrote: > > [...] > > > > > case "$with_dpdk" in > > >yes) > > > DPDK_AUTO_DISCOVER="true" > > > -PKG_CHECK_MODULES([DPDK], [libdpdk], > > > -

[ovs-dev] [PATCHv8 1/3] Improved Packet Drop Statistics in OVS

2019-02-07 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Ben Pfaff
On Thu, Feb 07, 2019 at 12:00:39PM +0100, Christian Ehrhardt wrote: > [...] > > > case "$with_dpdk" in > >yes) > > DPDK_AUTO_DISCOVER="true" > > -PKG_CHECK_MODULES([DPDK], [libdpdk], > > - [DPDK_INCLUDE="$DPDK_CFLAGS"], > > -

Re: [ovs-dev] OVN: Setting custom data

2019-02-07 Thread Ben Pfaff
On Thu, Feb 07, 2019 at 02:24:08PM -0500, Mark Michelson wrote: > The general problem I have is that I'm developing a feature for OVN. When a > relevant packet arrives, I want to set some data and have that data > available the entire time that the packet is being processed. My initial > idea was

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

2019-02-07 Thread Ben Pfaff
On Thu, Feb 07, 2019 at 08:10:48PM +, Venugopal Iyer wrote: > > Also, as I mentioned the changes will mean that the ovn-controller will > > need the ovn-central > > to be updated to the changed version as well (i.e. if someone just installs > > ovs and ovn-host > > s/he can't expect it to

Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-02-07 Thread Ben Pfaff
That's helpful. On Thu, Feb 07, 2019 at 09:32:33PM +, Ankur Sharma wrote: > Hi Ben, > > My bad, should have explained the use case as well. > > Following is the use case I started with: > a. By associating identifier with connection tracker we can facilitate > debugging from connection

Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-02-07 Thread Ankur Sharma
Hi Ben, My bad, should have explained the use case as well. Following is the use case I started with: a. By associating identifier with connection tracker we can facilitate debugging from connection tracker side. b. For example, if a system has multiple OVN ACLs (Hundreds or Thousands), and we

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

2019-02-07 Thread Venugopal Iyer
Sorry, Ben, for the delay, just wanted to test out the compatibility, please see response inline prefixed with Let me know if you have further questions. thanks, -venu From: Ben Pfaff Sent: Wednesday, February 6, 2019 10:15 AM To: Venugopal Iyer Cc:

[ovs-dev] OVN: Setting custom data

2019-02-07 Thread Mark Michelson
Hi everyone, The general problem I have is that I'm developing a feature for OVN. When a relevant packet arrives, I want to set some data and have that data available the entire time that the packet is being processed. My initial idea was to use one of reg0-reg9 for this. However, those

[ovs-dev] Hi

2019-02-07 Thread KShan
Greetings, Our company have a business proposal to share with you, please kindly respond back if you need more information regarding the proposal. Sincerely, Kim Shandong h...@sanshime.com ___ dev mailing list d...@openvswitch.org

[ovs-dev] Openvswitch| RSA Conference 2019 -Leads

2019-02-07 Thread Stacy Brown
Hi, Attendees-list of RSA Conference 2019 (March 4th to 8th 2019) is available-for-purchase with contact name, company name, job title, business email-address, phone number and mailing address etc... Let me know if you'd be interested in hearing more about it. Thanks, Stacy Brown

Re: [ovs-dev] odp-util: Do not rewrite fields with the same values as matched

2019-02-07 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #57 FILE: lib/odp-util.c:7189: if (size

Re: [ovs-dev] Makefiles: Generate datapath ovs key fields macros

2019-02-07 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #69 FILE:

Re: [ovs-dev] [RFC 1/3] dpdk: Unify passing of DPDK EAL arguments.

2019-02-07 Thread Flavio Leitner
On Wed, Feb 06, 2019 at 11:33:04AM +0300, Ilya Maximets wrote: > On 05.02.2019 23:19, Flavio Leitner wrote: > > On Tue, Feb 05, 2019 at 06:43:08PM +0300, Ilya Maximets wrote: > >> Hi Flavio. > >> Thanks for taking a look. > >> > >> On 05.02.2019 15:38, Flavio Leitner wrote: > >>> > >>> Hi Ilya, >

[ovs-dev] [PATCH V3 2/2] odp-util: Do not rewrite fields with the same values as matched

2019-02-07 Thread Eli Britstein
To improve performance and avoid wasting resources for HW offloaded flows, do not rewrite fields that are matched with the same value. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/odp-util.c| 110 +- tests/mpls-xlate.at |

[ovs-dev] [PATCH V3 1/2] Makefiles: Generate datapath ovs key fields macros

2019-02-07 Thread Eli Britstein
Generate datapath ovs key fields macros as a pre-step of retrieving field information, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- .gitignore | 1 + build-aux/extract-odp-netlink-xmacros-h | 55

[ovs-dev] [PATCH V3 0/2] Do not rewrite fields with the same values as matched

2019-02-07 Thread Eli Britstein
Hi This patch set avoids unnecessary rewrite actions to fields with the same values as matched on. Patch 1 is a pre-step of generating ovs key fields macros Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly Travis link:

Re: [ovs-dev] [PATCH] travis: Fix building datapath instead of userspace with DPDK_SHARED.

2019-02-07 Thread Aaron Conole
Ilya Maximets writes: > Current script does not check build of OVS with DPDK. > It builds datapath instead: > https://travis-ci.org/openvswitch/ovs/jobs/489520695 > > CC: Ian Stokes > Fixes: edfe8d263d2e ("travis: Add dpdk shared library build.") > Signed-off-by: Ilya Maximets > --- Neat

Re: [ovs-dev] [PATCH] acinclude: Use NUMA_AWARE_HUGEPAGES too for libnuma check.

2019-02-07 Thread Ilya Maximets
On 07.02.2019 19:18, Ian Stokes wrote: > On 2/7/2019 1:00 PM, Ilya Maximets wrote: >> This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA >> disabled. This should not be a usual case. But it's possible to >> configure DPDK this way. >> > > Out of interest, with

Re: [ovs-dev] [PATCH] acinclude: Use NUMA_AWARE_HUGEPAGES too for libnuma check.

2019-02-07 Thread Ian Stokes
On 2/7/2019 1:00 PM, Ilya Maximets wrote: This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA disabled. This should not be a usual case. But it's possible to configure DPDK this way. Out of interest, with RTE_EAL_NUMA_AWARE_HUGEPAGES defined but not RTE_LIBRTE_VHOST_NUMA, does

[ovs-dev] Reply for more details

2019-02-07 Thread Miss C L Young
United Nations Headquarters New York Address: New York, NY 10017, USA Phone: +1 (646) 547-2917 Your payment File Number: (wp195uno) Attention: My name is Mrs. Carman Lapointe Young Former United Nation Under Secretary General this is to officially inform you that your name is among the people

Re: [ovs-dev] [PATCH] acinclude: Drop DPDK_EXTRA_LIB variable.

2019-02-07 Thread Ian Stokes
On 2/7/2019 12:20 PM, Ilya Maximets wrote: AC_SEARCH_LIBS enables the libraries itself: checking for library containing get_mempolicy... -lnuma checking for library containing pcap_dump... -lpcap So, they are available in LIBS. No need to add them twice. Also, DPDK_EXTRA_LIB doesn't

[ovs-dev] [PATCH] travis: Fix building datapath instead of userspace with DPDK_SHARED.

2019-02-07 Thread Ilya Maximets
Current script does not check build of OVS with DPDK. It builds datapath instead: https://travis-ci.org/openvswitch/ovs/jobs/489520695 CC: Ian Stokes Fixes: edfe8d263d2e ("travis: Add dpdk shared library build.") Signed-off-by: Ilya Maximets --- .travis/linux-build.sh | 5 +++-- 1 file

[ovs-dev] HI

2019-02-07 Thread Mathew Dudash
Hallo Ich habe diesen Brief schon früher an Sie geschickt, aber ich bin mir nicht sicher, ob Sie ihn bekommen haben, ich habe nichts von Ihnen gehört, und deshalb wiederhole ich ihn. Ich bin Rechtsanwalt Mathew Hamza. Ich wohne in Togo. Ich kontaktiere Sie in Verbindung mit dem Tod meines

Re: [ovs-dev] [PATCHv7 1/3] Improved Packet Drop Statistics in OVS

2019-02-07 Thread Ilya Maximets
On 07.02.2019 17:11, Anju Thomas wrote: > Thanks for comments Ilya. Just one question regarding the steal flag :- > >> +case OVS_ACTION_ATTR_DROP: { >> +const enum xlate_error *drop_reason = nl_attr_get(a); >> +if (*drop_reason < XLATE_MAX) { >> +

Re: [ovs-dev] [PATCHv7 1/3] Improved Packet Drop Statistics in OVS

2019-02-07 Thread Anju Thomas
Thanks for comments Ilya. Just one question regarding the steal flag :- > +case OVS_ACTION_ATTR_DROP: { > +const enum xlate_error *drop_reason = nl_attr_get(a); > +if (*drop_reason < XLATE_MAX) { > + dp_update_drop_action_counter(*drop_reason,

[ovs-dev] [PATCH] acinclude: Use NUMA_AWARE_HUGEPAGES too for libnuma check.

2019-02-07 Thread Ilya Maximets
This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA disabled. This should not be a usual case. But it's possible to configure DPDK this way. Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade") Signed-off-by: Ilya Maximets --- acinclude.m4 | 2 +- 1 file changed, 1

[ovs-dev] [PATCH] acinclude: Drop DPDK_EXTRA_LIB variable.

2019-02-07 Thread Ilya Maximets
AC_SEARCH_LIBS enables the libraries itself: checking for library containing get_mempolicy... -lnuma checking for library containing pcap_dump... -lpcap So, they are available in LIBS. No need to add them twice. Also, DPDK_EXTRA_LIB doesn't even work, because each check overwrites the

[ovs-dev] [PATCH v4 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
DPDK 18.11 builds using the more modern meson build system no more provide the -ldpdk linker script. Instead it is expected to use pkgconfig for linker options as well. This change will set DPDK_LIB from pkg-config (if pkg-config was available) and since that already carries the whole-archive

[ovs-dev] [PATCH v4 0/1] fix build with DPDK 18.11 without -ldpdk

2019-02-07 Thread Christian Ehrhardt
DPDK 18.11 can be built using the more modern meson build system. In that case it no more provides the -ldpdk linker script. Instead it is expected to use pkgconfig for linker options as well. FYI here a build log on Ubuntu 19.04 with the three patches applied:

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Luca Boccassi
On Thu, 2019-02-07 at 12:00 +0100, Christian Ehrhardt wrote: > [...] > > >  case "$with_dpdk" in > >    yes) > >  DPDK_AUTO_DISCOVER="true" > > -PKG_CHECK_MODULES([DPDK], [libdpdk], > > -  [DPDK_INCLUDE="$DPDK_CFLAGS"], > > - 

Re: [ovs-dev] OVS-DPDK public meeting

2019-02-07 Thread Kevin Traynor
Next meeting Feb 20th 1700 UTC (will cancel if OVS2.11 already released or no agenda) Attendees: Aaron, David, Alejandro, Asaf, Frikkie, Ophir, Pieter, Johann, Ian, Kevin. === GENERAL === - OVS 2.11 Release -- No blockers reported, so still heading for

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
[...] > case "$with_dpdk" in >yes) > DPDK_AUTO_DISCOVER="true" > -PKG_CHECK_MODULES([DPDK], [libdpdk], > - [DPDK_INCLUDE="$DPDK_CFLAGS"], > - [DPDK_INCLUDE="-I/usr/local/include/dpdk > -I/usr/include/dpdk"]) > +

Re: [ovs-dev] dpif-netdev:fix reload pmd's dead lock

2019-02-07 Thread Stokes, Ian
> On 31.01.2019 11:48, Lilijun wrote: > > This patch fix the dead lock when using dpdk userspace datapath. The > > problem is described as follows: > > 1) when add or delete port, the main thread will call > > reconfigure_datapath() in the function dpif_netdev_run() > > 2) Here the dp->port_mutex