[ovs-dev] [PATCH branch-2.12] lflow.c: Fix memory leak of lflow_ref_list_node->ref_name.

2019-10-30 Thread Han Zhou
The ref_name is copied in lflow_resource_add(), but forgot to free in lflow_resource_destroy_lflow(). It can be fixed by freeing it in lflow_resource_destroy_lflow(). However, this field is never really used, so just delete it from lflow_ref_list_node, together with the "type" field. Fixes:

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-10-30 Thread Han Zhou
On Wed, Oct 30, 2019 at 10:15 PM Han Zhou wrote: > > > > > > > +/* We need to make sure that at least the runtime data > > + * (e.g., local datapaths, ct zones) are fresh before > > + * calling ofctrl_put and pinctrl_run to avoid using >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-10-30 Thread Han Zhou
On Tue, Oct 29, 2019 at 8:11 AM Dumitru Ceara wrote: > > The incremental processing engine might stop a run before the > en_runtime_data node is processed. In such cases the ed_runtime_data > fields might contain pointers to already deleted SB records. For > example, if a port binding

Re: [ovs-dev] [PATCH ] travis: support ppc64le builds

2019-10-30 Thread Yanqin Wei (Arm Technology China)
Hi, We are working to support arm64 build for ovs travis CI. It is indeed to use arch: arm64 to choose cpu architecture, because travis has provided native arm64 option now. But in this patch it seems ppc64 builds run on the ppc-VM + x86 native machine. Currently arm only select a part of

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-10-30 Thread Han Zhou
On Wed, Oct 23, 2019 at 12:11 AM Dumitru Ceara wrote: > > ARP request and ND NS packets for router owned IPs were being > flooded in the complete L2 domain (using the MC_FLOOD multicast group). > However this creates a scaling issue in scenarios where aggregation > logical switches are connected

Re: [ovs-dev] [PATCHv5] netdev-linux: Detect numa node id.

2019-10-30 Thread William Tu
On Tue, Oct 29, 2019 at 9:15 AM Ilya Maximets wrote: > > On 23.10.2019 23:08, William Tu wrote: > > The patch detects the numa node id from the name of the netdev, > > by reading the '/sys/class/net//device/numa_node'. > > If not available, ex: virtual device, or any error happens, > > return

Re: [ovs-dev] [PATCH ovn v2 13/13] tutorial: Add tutorial for OVN Interconnection.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #122 FILE:

Re: [ovs-dev] [PATCH ovn v2 12/13] ovn-ctl: Support commands for interconnection.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #54 FILE: utilities/ovn-ctl:112:

Re: [ovs-dev] [PATCH ovn v2 11/13] ovn-ctl: Refactor to reduce redundant code.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #58 FILE: utilities/ovn-ctl:72:

Re: [ovs-dev] [PATCH ovn v2 09/13] ovn-ic: Interconnection port controller.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #299 FILE: ic/ovn-ic.c:637: /* XXX: Sync encap so that

Re: [ovs-dev] [PATCH ovn v2 06/13] ovn-ic: Transit switch controller.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #198 FILE: ovn-sb.xml:2297:

Re: [ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #125 FILE: ic/ovn-ic.8.xml:54:

Re: [ovs-dev] [PATCH ovn v2 03/13] ovn-isb: Interconnection southbound DB schema and CLI.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #271 FILE: ovn-isb.ovsschema:34:

Re: [ovs-dev] [PATCH ovn v2 02/13] ovn-inb: Interconnection northbound DB schema and CLI.

2019-10-30 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #349 FILE: ovn-inb.xml:35:

[ovs-dev] [PATCH RFC] cirrus: Link to Google cloud for make check-afxdp.

2019-10-30 Thread William Tu
This yml file links to my google compute engine account and create a VM with ubuntu19.10 (with kernel 5.3) so testing 'make check-afxdp' can happen. I'm looking for free GCP account for doing this, or any other suggestions are welcome. To use it, first follow the steps here to link cirrus to

Re: [ovs-dev] Use more than 200000 flows in datapath/kernel cache flows

2019-10-30 Thread Gregory Rose
On 10/30/2019 10:16 AM, Ben Pfaff wrote: On Mon, Oct 28, 2019 at 09:39:55PM -0700, Zhiwei Cen wrote: It seems I can change the limit for Openflow flows. This works: $ovs-vsctl --no-wait set Open_vSwitch . other_config:flow-limit=21 $ovs-vsctl --no-wait get Open_vSwitch .

[ovs-dev] [PATCH ovn] pinctrl.c: Fix maybe-uninitialized warnings.

2019-10-30 Thread Han Zhou
There are warnings like: === ../controller/pinctrl.c: In function ‘ipv6_ra_send’: ../controller/pinctrl.c:2393:13: error: ‘r1’ may be used uninitialized in this function [-Werror=maybe-uninitialized] memcpy([i], t1, strlen(t1)); ^ ../controller/pinctrl.c:2383:20: note:

Re: [ovs-dev] [PATCH ovn 19/19] tutorial: Add tutorial for OVN Interconnection.

2019-10-30 Thread Han Zhou
On Tue, Oct 29, 2019 at 5:49 PM aginwala wrote: > > Thanks Han for the correction. Just one more minor typo in the tutorial > below. > > I hit some roadblocks to start ic controller on different az but got my > setup running with workarounds in current code and have posted in comments > which

Re: [ovs-dev] [PATCH ovn 18/19] ovn-ctl: Support commands for interconnection.

2019-10-30 Thread Han Zhou
On Tue, Oct 29, 2019 at 5:50 PM aginwala wrote: > > > usr/share/ovn/scripts/ovn-ctl --ovn-ic-isb-db=10.x.x.x --db-isb-create-insecure-remote=yes --db-inb-create-insecure-remote=yes --ovn-ic-inb-db=10.x.x start_ic is still setting null values for inb/sb: > --ovninb-db= --ovnisb-db= Thanks for

Re: [ovs-dev] [PATCH ovs v3 2/2] netdev-dpdk: Add dpdkvdpa port

2019-10-30 Thread William Tu
On Tue, Oct 29, 2019 at 4:20 AM Noa Levy wrote: > > > > > -Original Message- > > From: William Tu [mailto:u9012...@gmail.com] > > Sent: Monday, October 28, 2019 10:46 PM > > To: Noa Levy > > Cc: ovs-dev@openvswitch.org; Oz Shlomo ; Majd > > Dibbiny ; Ameer Mahagneh > > ; Eli Britstein >

Re: [ovs-dev] [PATCH net-next v5 04/10] net: openvswitch: optimize flow mask cache hash collision

2019-10-30 Thread David Miller
From: xiangxia.m@gmail.com Date: Sat, 19 Oct 2019 16:08:38 +0800 > @@ -516,18 +519,31 @@ static struct sw_flow *flow_lookup(struct flow_table > *tbl, > u32 *index) > { > struct sw_flow *flow; > + struct sw_flow_mask *mask; > int i; Please

Re: [ovs-dev] [PATCH net-next v5 06/10] net: openvswitch: simplify the flow_hash

2019-10-30 Thread David Miller
From: xiangxia.m@gmail.com Date: Sat, 19 Oct 2019 16:08:40 +0800 > @@ -432,13 +432,9 @@ int ovs_flow_tbl_flush(struct flow_table *flow_table) > static u32 flow_hash(const struct sw_flow_key *key, >const struct sw_flow_key_range *range) > { > - int key_start =

Re: [ovs-dev] [PATCH net-next v5 02/10] net: openvswitch: convert mask list in mask array

2019-10-30 Thread David Miller
From: xiangxia.m@gmail.com Date: Sat, 19 Oct 2019 16:08:36 +0800 > @@ -611,13 +683,8 @@ struct sw_flow *ovs_flow_tbl_lookup_ufid(struct > flow_table *tbl, > > int ovs_flow_tbl_num_masks(const struct flow_table *table) > { > - struct sw_flow_mask *mask; > - int num = 0; > - > -

Re: [ovs-dev] [PATCH ovn 00/19] OVN Interconnection

2019-10-30 Thread Han Zhou
On Wed, Oct 30, 2019 at 7:51 AM Numan Siddique wrote: > > > > On Wed, Oct 30, 2019, 8:14 PM Han Zhou wrote: >> >> On Wed, Oct 30, 2019 at 4:05 AM Numan Siddique wrote: >> >> > On Mon, Oct 28, 2019 at 11:28 PM Han Zhou wrote: >> > > >> > > On Mon, Oct 28, 2019 at 7:25 AM Numan Siddique wrote:

Re: [ovs-dev] [PATCH ovn 10/19] ovn-ic: Interconnection controller with AZ registeration.

2019-10-30 Thread Han Zhou
On Tue, Oct 29, 2019 at 5:50 PM aginwala wrote: > > Thanks Han for the patches. > > On Sun, Oct 20, 2019 at 5:54 PM Han Zhou wrote: >> >> This patch introduces interconnection controller, ovn-ic, and >> implements the basic AZ registration feature: taking the AZ >> name from NB DB and create an

[ovs-dev] [PATCH ovn v2 13/13] tutorial: Add tutorial for OVN Interconnection.

2019-10-30 Thread Han Zhou
Added tutorial, and also updated NEWS and TODO. Tested-by: Aliasgar Ginwala Signed-off-by: Han Zhou --- Documentation/automake.mk | 1 + Documentation/tutorials/index.rst | 1 + Documentation/tutorials/ovn-interconnection.rst | 188

[ovs-dev] [PATCH ovn v2 12/13] ovn-ctl: Support commands for interconnection.

2019-10-30 Thread Han Zhou
Add support for managing IC-NB and IC-SB DBs, and ovn-ic daemon. Signed-off-by: Han Zhou --- utilities/ovn-ctl | 362 +++- utilities/ovn-ctl.8.xml | 91 2 files changed, 452 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH ovn v2 11/13] ovn-ctl: Refactor to reduce redundant code.

2019-10-30 Thread Han Zhou
This patch helps reducing redundant code in next patch for adding support for interconnection related DBs and daemon. Signed-off-by: Han Zhou --- utilities/ovn-ctl | 61 +++ 1 file changed, 35 insertions(+), 26 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 09/13] ovn-ic: Interconnection port controller.

2019-10-30 Thread Han Zhou
Sync interconnection logical ports and bindings between NB, SB and ISB. With this patch, the OVN interconnection works end to end. Signed-off-by: Han Zhou --- controller/binding.c | 6 +- ic/ovn-ic.c| 369 + lib/ovn-util.c

[ovs-dev] [PATCH ovn v2 08/13] ovn-ic: Interconnection gateway controller.

2019-10-30 Thread Han Zhou
Sync local and remote gateways between SB and ISB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 147 tests/ovn-ic.at | 56 + 2 files changed, 203 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index

[ovs-dev] [PATCH ovn v2 10/13] ovn.at: e2e test for OVN interconnection.

2019-10-30 Thread Han Zhou
Test with 5 AZs, each with 1 GW, 1 HV, 5 VIFs, 5 LRs, connected to 5 transit switches. Verify traffic through each TS between each pair of AZs. Signed-off-by: Han Zhou --- tests/ovn.at | 149 +++ 1 file changed, 149 insertions(+) diff

[ovs-dev] [PATCH ovn v2 03/13] ovn-isb: Interconnection southbound DB schema and CLI.

2019-10-30 Thread Han Zhou
This patch introduces OVN_IC_Southbound DB schema and the CLI ovn-isbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore |3 + automake.mk| 38 ++ debian/ovn-common.install |1 + debian/ovn-common.manpages |2 + lib/.gitignore

[ovs-dev] [PATCH ovn v2 07/13] ovn-sb: Add columns is_interconn and is_remote to Chassis.

2019-10-30 Thread Han Zhou
Support the new columns in Chassis table for OVN interconnection. Also, populate the is_interconn column according to external_ids: is-interconn key of Open_vSwitch table on the chassis. Signed-off-by: Han Zhou --- controller/chassis.c | 14 ++ northd/ovn-northd.c | 6 --

[ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

2019-10-30 Thread Han Zhou
This patch introduces interconnection controller, ovn-ic, and implements the basic AZ registration feature: taking the AZ name from NB DB and create an Availability_Zone entry in IC-SB DB. Signed-off-by: Han Zhou --- Makefile.am | 1 + ic/.gitignore| 2 + ic/automake.mk

[ovs-dev] [PATCH ovn v2 06/13] ovn-ic: Transit switch controller.

2019-10-30 Thread Han Zhou
Processing transit switches and sync between INB, ISB and NB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 113 northd/ovn-northd.c | 8 ovn-nb.xml | 10 + ovn-sb.xml | 9 + tests/ovn-ic.at | 41

[ovs-dev] [PATCH ovn v2 05/13] ovn-northd.c: Refactor allocate_tnlid.

2019-10-30 Thread Han Zhou
Move allocate_tnlid() and related interfaces to ovn_util module, so that they be reused by ovn-ic (in next patches). At the same time, define macros for the range of datapath tunnel keys, and reserve a range with ((1u << 16) - 1) keys for global transit switch datapaths, among the ((1u << 24) - 1)

[ovs-dev] [PATCH ovn v2 02/13] ovn-inb: Interconnection northbound DB schema and CLI.

2019-10-30 Thread Han Zhou
This patch introduces OVN_IC_Northbound DB schema and the CLI ovn-inbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk| 37 ++ debian/ovn-common.install | 1 + debian/ovn-common.manpages | 2 + lib/.gitignore |

[ovs-dev] [PATCH ovn v2 01/13] ovn-architecture: Add documentation for OVN interconnection feature.

2019-10-30 Thread Han Zhou
Signed-off-by: Han Zhou --- ovn-architecture.7.xml | 107 - 1 file changed, 106 insertions(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index 7966b65..56b2167 100644 --- a/ovn-architecture.7.xml +++

[ovs-dev] [PATCH ovn v2 00/13] OVN Interconnection

2019-10-30 Thread Han Zhou
The series supports interconnecting multiple OVN deployments (e.g. located at multiple data centers) through logical routers connected with tansit logical switches with overlay tunnels, managed through OVN control plane. See the ovn-architecture.rst document updates for more details, and find

[ovs-dev] [PATCH dpdk-latest] dpdk: Migrate to the new pdump API.

2019-10-30 Thread Ilya Maximets
DPDK commit 660098d61f57 ("pdump: use generic multi-process channel") switched pdump to use generic DPDK IPC instead of sockets. Old API was deprecated and removed. Updating OVS code accordingly. Signed-off-by: Ilya Maximets --- Compile tested only. BTW, does anybode uses this functionality?

Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT rules

2019-10-30 Thread Ankur Sharma
Hi Numan, Submitted a v3 yesterday, addressing all the review comments. Please take a look. Regards, Ankur -Original Message- From: Numan Siddique Sent: Monday, October 28, 2019 6:40 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use

[ovs-dev] [PATCH] travis: Enable pdump for DPDK build.

2019-10-30 Thread Ilya Maximets
OVS has support for DPDK pdump that checked in configure script. Enabling it to increase OVS build test coverage by the code guarded by DPDK_PDUMP macro. Signed-off-by: Ilya Maximets --- Travis cache should be manually cleared before pushing this change for it to have effect. .travis.yml

Re: [ovs-dev] [PATCH] Avoid indeterminate statistics in offload implementations.

2019-10-30 Thread Ilya Maximets
On 25.10.2019 20:46, Ben Pfaff wrote: A lot of the offload implementations didn't bother to initialize the statistics they were supposed to return. I don't know whether any of the callers actually use them, but it looked wrong. Found by inspection. Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add ability to set MAC address.

2019-10-30 Thread Ben Pfaff
On Wed, Oct 30, 2019 at 07:09:34PM +0100, Ilya Maximets wrote: > It is possible to set MAC address for DPDK ports by calling > rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't > use this functionality avoiding real MAC address configuration. > > With this change following command

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-10-30 Thread Ilya Maximets
On 29.08.2019 13:39, Ilya Maximets wrote: On 29.08.2019 12:52, Anil Kumar Koli wrote: Hi Ilya, Thanks for the review. Please find below the stack trace of the crash (gdb) bt #0 0x7f0a3da46c37 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1

[ovs-dev] [PATCH v2] netdev-dpdk: Add ability to set MAC address.

2019-10-30 Thread Ilya Maximets
It is possible to set MAC address for DPDK ports by calling rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't use this functionality avoiding real MAC address configuration. With this change following command will result in real MAC address update on HW NIC: ovs-vsctl set

Re: [ovs-dev] [PATCH] netdev-dpdk: Add ability to set MAC address.

2019-10-30 Thread Ilya Maximets
On 30.10.2019 18:21, Ben Pfaff wrote: On Wed, Oct 30, 2019 at 04:40:18PM +0100, Ilya Maximets wrote: It is possible to set MAC address for DPDK ports by calling rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't use this functionality avoiding real MAC address configuration. With

Re: [ovs-dev] [PATCH] lacp: warn transmit failure of lacp pdu

2019-10-30 Thread Ben Pfaff
On Mon, Oct 21, 2019 at 07:34:36PM +0530, Gowrishankar Muthukrishnan wrote: > It might be difficult to trace whether LACP PDU tx (as in > response) was successful when the pdu was not transmitted by > egress slave for various reasons (including resource contention > within NIC) and only way to

Re: [ovs-dev] [PATCH 1/1] ovsdb_execute_mutate: removed unused ovsdb_row pointer variable

2019-10-30 Thread Ben Pfaff
On Tue, Oct 29, 2019 at 02:04:58PM +0100, Damijan Skvarc wrote: > Signed-off-by: Damijan Skvarc Good catch. Applied to master, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [HELP] Question about userspace meter

2019-10-30 Thread Ben Pfaff
On Wed, Oct 30, 2019 at 11:30:48AM +0800, txfh2007 wrote: > I have been testing OVS-DPDK Rate limit using meter table these days, but > I have found the rate deviation is larger than kernel meter. My test result > is as below: You didn't mention an OVS version number or commit number. It

Re: [ovs-dev] [PATCH] netdev-dpdk: Add ability to set MAC address.

2019-10-30 Thread Ben Pfaff
On Wed, Oct 30, 2019 at 04:40:18PM +0100, Ilya Maximets wrote: > It is possible to set MAC address for DPDK ports by calling > rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't > use this functionality avoiding real MAC address configuration. > > With this change following command

Re: [ovs-dev] Use more than 200000 flows in datapath/kernel cache flows

2019-10-30 Thread Ben Pfaff
On Mon, Oct 28, 2019 at 09:39:55PM -0700, Zhiwei Cen wrote: > It seems I can change the limit for Openflow flows. > This works: > $ovs-vsctl --no-wait set Open_vSwitch . other_config:flow-limit=21 > > $ovs-vsctl --no-wait get Open_vSwitch . other_config:flow-limit > "21" That sets the

Re: [ovs-dev] [PATCH ovn v2 0/6] Add OVN IPv6 support

2019-10-30 Thread Russell Bryant
On Wed, Oct 30, 2019 at 11:56 AM Numan Siddique wrote: > On Wed, Oct 30, 2019 at 8:25 PM Russell Bryant wrote: > > > > v1 -> v2: > > - Address checkpatch warnings about line length > > - Fix a sparse error in ovn-nbctl > > - Add lflow docs in ovn-northd.8.xml > > > > [PATCH ovn v2 1/6]

Re: [ovs-dev] Use more than 200000 flows in datapath/kernel cache flows

2019-10-30 Thread Gregory Rose
On 10/28/2019 9:39 PM, Zhiwei Cen wrote: Dear ovs-dev, I'm trying to see if I can increase the number of flows supported in kernel cache. I found two relevant config options (other_config:flow-limit and upcall/flow limit). My understanding was that other_config:flow-limit is for the normal

Re: [ovs-dev] [PATCH ovn v2 0/6] Add OVN IPv6 support

2019-10-30 Thread Numan Siddique
On Wed, Oct 30, 2019 at 8:25 PM Russell Bryant wrote: > > v1 -> v2: > - Address checkpatch warnings about line length > - Fix a sparse error in ovn-nbctl > - Add lflow docs in ovn-northd.8.xml > > [PATCH ovn v2 1/6] northd: Fix table ID for IPv6 router ingress. > [PATCH ovn v2 2/6] actions:

Re: [ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

2019-10-30 Thread Ben Pfaff
On Mon, Oct 28, 2019 at 10:00:45AM +0100, David Marchand wrote: > Now that dpdk headers annotates the network header structures with > endianness [1], we can get rid of these copies. > > 1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d Oh, lovely. I was never happy with those copies but

[ovs-dev] [PATCH] netdev-dpdk: Add ability to set MAC address.

2019-10-30 Thread Ilya Maximets
It is possible to set MAC address for DPDK ports by calling rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't use this functionality avoiding real MAC address configuration. With this change following command will result in real MAC address update on HW NIC: ovs-vsctl set

Re: [ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

2019-10-30 Thread Stokes, Ian
On 10/28/2019 9:00 AM, David Marchand wrote: Now that dpdk headers annotates the network header structures with endianness [1], we can get rid of these copies. 1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d Signed-off-by: David Marchand --- include/sparse/automake.mk | 6 -

[ovs-dev] [PATCH ovn v2 5/6] system-ovn: Add IPv6 NAT test cases

2019-10-30 Thread Russell Bryant
These tests failed prior to the changes leading up to this one. Signed-off-by: Russell Bryant --- tests/system-ovn.at | 862 +++- 1 file changed, 860 insertions(+), 2 deletions(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index

[ovs-dev] [PATCH ovn v2 4/6] northd: Add lflows for IPv6 NAT.

2019-10-30 Thread Russell Bryant
Signed-off-by: Russell Bryant --- northd/ovn-northd.8.xml | 233 +--- northd/ovn-northd.c | 384 ++-- 2 files changed, 418 insertions(+), 199 deletions(-) diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml index

[ovs-dev] [PATCH ovn v2 6/6] NEWS: Add IPv6 NAT support

2019-10-30 Thread Russell Bryant
Signed-off-by: Russell Bryant --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 73045d65f..ab2f13318 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,9 @@ +Post-OVS-v2.12.0 +- + - OVN was split out from the OVS repository and is now released +

[ovs-dev] [PATCH ovn v2 3/6] ovn-nbctl: Allow IPv6 NAT rules to be added

2019-10-30 Thread Russell Bryant
Signed-off-by: Russell Bryant --- tests/ovn-nbctl.at| 41 utilities/ovn-nbctl.c | 49 --- 2 files changed, 69 insertions(+), 21 deletions(-) diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at index

[ovs-dev] [PATCH ovn v2 2/6] actions: Add IPv6 support to lflow NAT actions

2019-10-30 Thread Russell Bryant
Signed-off-by: Russell Bryant --- include/ovn/actions.h | 6 +- lib/actions.c | 35 +++ tests/ovn.at | 18 -- utilities/ovn-trace.c | 15 ++- 4 files changed, 54 insertions(+), 20 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 0/6] Add OVN IPv6 support

2019-10-30 Thread Russell Bryant
v1 -> v2: - Address checkpatch warnings about line length - Fix a sparse error in ovn-nbctl - Add lflow docs in ovn-northd.8.xml [PATCH ovn v2 1/6] northd: Fix table ID for IPv6 router ingress. [PATCH ovn v2 2/6] actions: Add IPv6 support to lflow NAT actions [PATCH ovn v2 3/6] ovn-nbctl:

[ovs-dev] [PATCH ovn v2 1/6] northd: Fix table ID for IPv6 router ingress.

2019-10-30 Thread Russell Bryant
I noticed that this table number was outdated. This is now table 3. There are a few other sections of code for this table that were all correctly referencing table 3. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH ovn 00/19] OVN Interconnection

2019-10-30 Thread Numan Siddique
On Wed, Oct 30, 2019, 8:14 PM Han Zhou wrote: > On Wed, Oct 30, 2019 at 4:05 AM Numan Siddique wrote: > > > On Mon, Oct 28, 2019 at 11:28 PM Han Zhou wrote: > > > > > > On Mon, Oct 28, 2019 at 7:25 AM Numan Siddique wrote: > > > > > > > > On Mon, Oct 21, 2019 at 6:23 AM Han Zhou wrote: > > >

Re: [ovs-dev] [PATCH ovn 00/19] OVN Interconnection

2019-10-30 Thread Han Zhou
On Wed, Oct 30, 2019 at 4:05 AM Numan Siddique wrote: > On Mon, Oct 28, 2019 at 11:28 PM Han Zhou wrote: > > > > On Mon, Oct 28, 2019 at 7:25 AM Numan Siddique wrote: > > > > > > On Mon, Oct 21, 2019 at 6:23 AM Han Zhou wrote: > > > > > > > > The series supports interconnecting multiple OVN

[ovs-dev] [PATCH 03/10] tc: Introduce tc_id to specify a tc filter

2019-10-30 Thread Roi Dayan
From: Paul Blakey Move all that is needed to identify a tc filter to a new structure, tc_id. This removes a lot of duplication in accessing/creating tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-linux.c | 6 +- lib/netdev-offload-tc.c | 208

[ovs-dev] [PATCH 01/10] match: Add match_set_ct_zone_masked helper

2019-10-30 Thread Roi Dayan
From: Paul Blakey Sets zone in match. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 2 ++ lib/match.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/openvswitch/match.h

[ovs-dev] [PATCH 09/10] tc: Move tunnel_key unset action before output ports

2019-10-30 Thread Roi Dayan
From: Paul Blakey Since OvS datapath gets packets already decapsulated from tunnel devices, it doesn't explicitly decapsulate them. So in a recirculation setup, the tunnel matching continues in the recirculation as the tunnel metadata still exists on the SKB. Tunnel key unset action unsets this

[ovs-dev] [PATCH 06/10] netdev-offload-tc: Add conntrack support

2019-10-30 Thread Roi Dayan
From: Paul Blakey Zone and ct_state first. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 2 + lib/netdev-offload-tc.c | 136 lib/tc.c| 122 +++

[ovs-dev] [PATCH 05/10] netdev-offload-tc: Add recirculation support via tc chains

2019-10-30 Thread Roi Dayan
From: Paul Blakey Each recirculation id will create a tc chain, and we translate the recirculation action to a tc goto chain action. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 1 + lib/netdev-offload-tc.c | 35 +--

[ovs-dev] [PATCH 10/10] netdev-offloads-tc: Probe recirc tc sharing feature on first recirc_id rule

2019-10-30 Thread Roi Dayan
From: Paul Blakey Since recirculations splits the datapath processing into multiple rules, and we offload them to tc, when we are done processing in tc, we need to continue in the correct recirc_id in OVS. For that, tc needs to pass the recirculation id back to OVS. We check for kernel support

[ovs-dev] [PATCH 02/10] compat: Add tc ct action and flower matches defines for older kernels

2019-10-30 Thread Roi Dayan
From: Paul Blakey Update kernel UAPI to support conntrack matches, and the tc actions ct and goto chain. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- acinclude.m4 | 6 +++--- include/linux/automake.mk| 3 ++- include/linux/pkt_cls.h | 50

[ovs-dev] [PATCH 08/10] netdev-offload-tc: Add conntrack nat support

2019-10-30 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-offload-tc.c | 104 lib/tc.c| 91 ++ lib/tc.h| 24 +++ 3 files changed, 219

[ovs-dev] [PATCH 07/10] netdev-offload-tc: Add conntrack label and mark support

2019-10-30 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 2 ++ lib/netdev-offload-tc.c | 66 + lib/tc.c| 52 ++ lib/tc.h| 6 + 4

[ovs-dev] [PATCH 04/10] netdev-offload-tc: Implement netdev tc flush via tc filter del

2019-10-30 Thread Roi Dayan
From: Paul Blakey To be consistent with our tc-ufid mapping after flush, and to support tc chains flushing in the next commit, implement flush operation via deleting all the filters we actually added and delete their mappings. This will also not delete the configured qos policing via matchall

[ovs-dev] [PATCH 00/10] Add support for offloading CT datapath rules to TC

2019-10-30 Thread Roi Dayan
The following patchset introduces hardware offload of OVS connection tracking datapath rules. OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state() matches to support connection tracking. The datapath rules are in the form of:

[ovs-dev] [PATCH] lib/tc: Fix flow dump for tunnel id equal zero

2019-10-30 Thread Roi Dayan
From: Dmytro Linkin Tunnel id 0 is not printed unless tunnel flag FLOW_TNL_F_KEY is set. Fix that by always setting FLOW_TNL_F_KEY when tunnel id is valid. Fixes: 0227bf092ee6 ("lib/tc: Support optional tunnel id") Signed-off-by: Dmytro Linkin Reviewed-by: Roi Dayan ---

Re: [ovs-dev] [PATCH ovn 0/6] Add IPv6 NAT support

2019-10-30 Thread Numan Siddique
On Wed, Oct 30, 2019 at 7:02 AM Russell Bryant wrote: > > This came up with reviewing the usage of ovn-kubernetes with IPv6. > It's more straight forward to start with using IPv6 NAT, matching the > IPv4 network topology with Kubernetes. Eventually, we'd want to allow > routable IPv6 addresses

[ovs-dev] [RFC v2] netdev-dpdk: setting VF MAC address

2019-10-30 Thread Roni Bar Yanai
On cloud topology with hardware offload, when SR-IOV is used there is an architecture limitation to configure the VF from the host. The port representor is attached to OVS, while the VF is usually configured in pass through to the VM. In such topology the MAC address of the VF is configured by

[ovs-dev] same tcp session encapsulated with different udp src port in kernel mode if packet has do ip_forward

2019-10-30 Thread ychen
Hi, when we use docker to establish tcp session, we found that the packet which must do upcall to userspace has different encapsulated udp source port with packet that only needs do datapath flow forwarding. After some code research and kprobe debug, we found the following: 1.

Re: [ovs-dev] [PATCH] dpif-netdev: Do not mix recirculation depth into RSS hash itself.

2019-10-30 Thread Ilya Maximets
On 30.10.2019 9:51, ychen wrote: Thanks! I have simply verified in our testing enviroment, and it really worked! That's good. Thank you for testing! Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn 00/19] OVN Interconnection

2019-10-30 Thread Numan Siddique
On Mon, Oct 28, 2019 at 11:28 PM Han Zhou wrote: > > On Mon, Oct 28, 2019 at 7:25 AM Numan Siddique wrote: > > > > On Mon, Oct 21, 2019 at 6:23 AM Han Zhou wrote: > > > > > > The series supports interconnecting multiple OVN deployments (e.g. > located at > > > multiple data centers) through

Re: [ovs-dev] [PATCH] dpif-netdev: Do not mix recirculation depth into RSS hash itself.

2019-10-30 Thread ychen
Thanks! I have simply verified in our testing enviroment, and it really worked! At 2019-10-24 20:32:11, "Ilya Maximets" wrote: >Mixing of RSS hash with recirculation depth is useful for flow lookup >because same packet after recirculation should match with different >datapath rule.

Re: [ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
Hi All, Please review the update patch. Changes since v10 : Corrected the spelling mistake in the commit message. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 29 October 2019 20:20 To: ovs-dev@openvswitch.org; ktray...@redhat.com; i.maxim...@ovn.org Cc: Ilya

[ovs-dev] [PATCH v11 3/3] ovs-bugtool: Script to collect the port statistics

2019-10-30 Thread Sriram Vatala via dev
Sometimes, analysing the drop statistics of the ports will be helpful in debugging. This patch adds script to collect all supported port stats which also includes the drop counters in userspace datapath. The output of this script is included in the bugtool output. Signed-off-by: Sriram Vatala

[ovs-dev] [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics

2019-10-30 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons on the userspace datapath and today there is a single counter to track packets dropped due to any of those reasons. This patch adds custom software stats for the different reasons packets may be dropped during tx/rx on the userspace

[ovs-dev] [PATCH v11 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
From: Ilya Maximets This is yet another refactoring for upcoming detailed drop stats. It allows to use single function for all the software calculated statistics in netdev-dpdk for both vhost and ETH ports. UINT64_MAX used as a marker for non-supported statistics in a same way as it's done in

Re: [ovs-dev] [PATCH v10 1/3] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-30 Thread Sriram Vatala via dev
Thanks Kevin for reviewing and acknowledging the patch. I will correct the spelling and send the updated patch. Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 25 October 2019 20:36 To: Sriram Vatala ; ovs-dev@openvswitch.org; i.maxim...@ovn.org Cc: Ilya