[ovs-dev] [PATCH ovn] expr: Combine multiple ipv4 with wildcard mask.

2021-02-06 Thread 陈供明
From: Gongming Chen In the ovn security group, each host ip corresponds to at least 4 flow tables (different connection states). As the scale of hosts using the security group increases, the ovs security group flow table will increase sharply, especially when it is applied the remote group

[ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 陈供明
From: Gongming Chen After setting the iface-id, immediately check the up status of the port binding, it will occasionally fail, especially when the port binding status is reported later. When it fails, the following will be output: Checking values in sb Port_Binding with logical_port=lsp1

Re: [ovs-dev] [PATCH ovs v2 1/3] dpif-netdev: Fix the meter buckets overflow.

2021-02-06 Thread Tonghao Zhang
On Thu, Jan 21, 2021 at 5:44 PM wrote: > > From: Tonghao Zhang > > When setting the meter rate to 4.3+Gbps, there is an overflow, the > meters don't work as expected. > > $ ovs-ofctl -O OpenFlow13 add-meter br-int "meter=1 kbps stats > bands=type=drop rate=4294968" > > Before the patch, the

[ovs-dev] 答复: 答复: [PATCH V3 3/4] Add VXLAN TCP and UDP GRO support for DPDK data path

2021-02-06 Thread 杨燚
I have sent v4 patch to remove GRO and GSO code to avoid such concern. GRO and GSO must use multi-seg mbuf, our local openstack environment has used these code but didn't see any corrupt issue, so I'm not sure what case will result in corrupt. Linearizing mbuf means copying, that will have

[ovs-dev] 答复: 答复: 答复: [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2021-02-06 Thread 杨燚
In OVS DPDK (for tap in lib/netdev-linux.c), we don't use net_tap, internal type is also tap type in OVS DPDK use case, that means all the bridge ports (i.e. br-int, ovs-netdev, br-phy, etc.) are tap, it will result in deadlock if we use PMDs to handle them. For non-bridge tap ports, PMD is

Re: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 0-day Robot
Bleep bloop. Greetings gmingchen(陈供明), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: cannot convert from eucgb2312_cn to UTF-8 fatal: could not parse patch Please check

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-06 Thread William Tu
On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote: > > > > On 2/4/2021 7:08 PM, William Tu wrote: > > On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote: > >> > >> > >> > >> On 2/3/2021 1:21 PM, William Tu wrote: > >>> Mellanox card has different XSK design. It requires users to create > >>>

Re: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 陈供明
Hi Dumitru, I have corrected the patch format and resubmitted it. Please check it. Thanks, Gongming > On Feb 7, 2021, at 12:25 AM, gmingchen(陈供明) wrote: > > From: Gongming Chen > > After setting the iface-id, immediately check the up status of the port > binding, it will occasionally fail,

[ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 陈供明
From: Gongming Chen After setting the iface-id, immediately check the up status of the port binding, it will occasionally fail, especially when the port binding status is reported later. When it fails, the following will be output: Checking values in sb Port_Binding with logical_port=lsp1

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2021-02-06 Thread William Tu
On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团 wrote: > > Thanks Ilya, net_tap PMD is handling tap device on host side, so it can > leverage vnet header to do TSO/GSO, maybe net_pmd authors don't know how to > do this, from source code, tap fd isn't enabled vnet header and TSO. > thanks,

Re: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 0-day Robot
Bleep bloop. Greetings gmingchen(陈供明), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author gmingchen(陈供明) needs to sign off. WARNING: Unexpected sign-offs from

Re: [ovs-dev] 答复: [PATCH V3 3/4] Add VXLAN TCP and UDP GRO support for DPDK data path

2021-02-06 Thread William Tu
On Tue, Oct 27, 2020 at 5:50 PM Yi Yang (杨燚)-云服务集团 wrote: > > -邮件原件- > 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ilya Maximets > 发送时间: 2020年10月27日 21:12 > 收件人: yang_y...@163.com; ovs-dev@openvswitch.org > 抄送: f...@sysclose.org; i.maxim...@ovn.org > 主题: Re: [ovs-dev] [PATCH V3

[ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test.

2021-02-06 Thread 陈供明
After setting the iface-id, immediately check the up status of the port binding, it will occasionally fail, especially when the port binding status is reported later. When it fails, the following will be output: Checking values in sb Port_Binding with logical_port=lsp1 against false... found

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: do not allow duplicated ECMP routes

2021-02-06 Thread Lorenzo Bianconi
> > Hi Lorenzo, a few comments down below. Hi Mark, thx for review. I will fix them in v2. Regards, Lorenzo > > On 2/3/21 10:54 AM, Lorenzo Bianconi wrote: > > In the current ovn-nbctl lr-route-add implementation is possible to add > > multiple duplicated routes adding --ecmp or

[ovs-dev] [PATCH v2 ovn] ovn-nbctl: do not allow duplicated ECMP routes

2021-02-06 Thread Lorenzo Bianconi
In the current ovn-nbctl lr-route-add implementation is possible to add multiple duplicated routes adding --ecmp or --ecmp-symmetric-reply option, e.g: $ovn-nbctl --ecmp-symmetric-reply lr-route-add lr0 10.244.0.7/32 172.18.0.4 $ovn-nbctl --ecmp-symmetric-reply lr-route-add lr0 10.244.0.7/32