On Wed, Sep 29, 2021 at 10:23 AM Mark Gray wrote:
>
> Add the 'inc-proc-eng' framework to northd. This does *not*
> add any incremental processing at this stage but provides the
> framework to do so. Even in this base configuration, we see an
> advantage as northd no longer processes the
The main idea is to not store list of weak references in the source
row, so they all don't need to be re-checked/updated on every
modification of that source row. The point is that source row already
knows UUIDs of all destination rows stored in the data, so there is no
much profit in storing
On Fri, Oct 15, 2021 at 2:36 AM Vladislav Odintsov
wrote:
>
>
> Regards,
> Vladislav Odintsov
>
> On 15 Oct 2021, at 08:42, Han Zhou wrote:
>
> On Thu, Oct 14, 2021 at 12:58 AM Vladislav Odintsov
> wrote:
>
>
> Hi Han,
>
> Thanks for the review.
>
> Regards,
> Vladislav Odintsov
>
> On 14 Oct
Thanks for your notes. Well because I'm much comfortable with Github
features if it's okay I continue to push further changes in Github.
The reason I add this cmdline arg is creating dedicated remotes for each
ovsdb server seems only available with cmdline. For example, I want each
ovsdb server
On 10/15/21 19:07, Michael Santana wrote:
>
>
> On 10/14/21 8:45 PM, Seena Fallah wrote:
>> Hi,
>>
>> I've made a patch in GitHub https://github.com/openvswitch/ovs/pull/371
>> Please review it.
> Hi Seena,
>
> We don't review pull request on github. The way to contribute is to send your
>
On 10/11/21 6:14 AM, Dumitru Ceara wrote:
On 10/11/21 12:01 PM, Lorenzo Bianconi wrote:
On 10/9/21 1:05 AM, Ihar Hrachyshka wrote:
This is correct, thank you for fixing it.
One comment and one question:
1) While the referred patch that suppressed LOCAL_ONLY traffic exposed
the issue, it was
Hi Ihar, thanks for the patch. It looks good by me, and thanks a bunch
for the test case.
Acked-by: Mark Michelson
On 10/15/21 10:43 AM, Ihar Hrachyshka wrote:
Without the patch, OVN doesn't flood multicast traffic to localport
ports.
Among other things, this breaks IP connectivity between
On 10/14/21 8:45 PM, Seena Fallah wrote:
Hi,
I've made a patch in GitHub https://github.com/openvswitch/ovs/pull/371
Please review it.
Hi Seena,
We don't review pull request on github. The way to contribute is to send
your patch to the mailing list. Take a look at the other patches on the
On 13/10/2021 17:46, Lorenzo Bianconi wrote:
> Introduce CoPP selftest for bfd controller action
>
> Signed-off-by: Lorenzo Bianconi
> ---
> tests/system-ovn.at | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
>
On 13/10/2021 17:46, Lorenzo Bianconi wrote:
> Introduce CoPP selftest for icmp{4,6}_error controller action
>
> Signed-off-by: Lorenzo Bianconi
> ---
> tests/ovn-northd.at | 23 +++
> tests/system-ovn.at | 21 +
> 2 files changed, 44 insertions(+)
>
>
When troubleshooting multiqueue setups, having per queue statistics helps
checking packets repartition in rx and tx queues.
Per queue statistics are exported by most DPDK drivers (with capability
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS). But since OVS only filters statistics
it exposes, there is
Le 15/10/2021 à 15:56, Ilya Maximets a écrit :
[snip]
> Not a full review, but, I think, that we should not add paddings, and
> define OVS_KEY_ATTR_IPV6_EXTHDRS before the OVS_KEY_ATTR_TUNNEL_INFO
> instead. See my comments for v6:
+1
___
dev mailing
Without the patch, OVN doesn't flood multicast traffic to localport
ports.
Among other things, this breaks IP connectivity between VIFs and
localport ports when the switch is vlan-passthru=true since we disable
local ARP responder for such switches, which breaks ARP discovery that
relies on
On 11/10/2021 17:52, mh...@redhat.com wrote:
> From: Mohammad Heib
>
> Update old OVN tables numbers to match the correct tables number
>
> Signed-off-by: Mohammad Heib
> ---
> northd/northd.c | 6 +++---
> northd/ovn-northd.8.xml | 4 ++--
> 2 files changed, 5 insertions(+), 5
The admissibility check currently log a message like (line wrapped in
this commitlog):
bond(revalidator11)|DBG|member (dpdk0): Admissibility
verdict is to drop pkt as different port is learned.active member: false,
may_enable: true enable: true LACP status:2
Fix spaces around the period character
Previously in OVS, a PMD thread running on cpu X used lcore X.
This assumption limited OVS to run PMD threads on physical cpu <
RTE_MAX_LCORE.
DPDK 20.08 introduced a new API that associates a non-EAL thread to a free
lcore. This new API does not change the thread characteristics (like CPU
On 10/14/21 23:18, Toms Atteka wrote:
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext flag.
>
> Signed-off-by: Toms Atteka
> ---
> include/uapi/linux/openvswitch.h | 16 +++-
> net/openvswitch/flow.c | 140
On 10/14/21 23:12, Cpp Code wrote:
> On Mon, Oct 4, 2021 at 11:41 PM Nicolas Dichtel
> wrote:
>>
>> Le 01/10/2021 à 22:42, Cpp Code a écrit :
>>> On Fri, Oct 1, 2021 at 12:21 AM Nicolas Dichtel
>>> wrote:
Le 30/09/2021 à 18:11, Cpp Code a écrit :
> On Wed, Sep 29, 2021 at 6:19 AM
Small comments inline, and Ilya please take a look at the first comment/request.
//Eelco
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> Some offload actions require functionality that is not netdev
> based, but dpif. For example, sFlow action requires to create
> a psample netlink socket to
On 23/09/2021 12:48, David Marchand wrote:
The admissibility check currently log a message like (line wrapped in
this commitlog):
bond(revalidator11)|DBG|member (dpdk0): Admissibility
verdict is to drop pkt as different port is learned.active member: false,
may_enable: true enable: true LACP
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> Add two sFlow offload test caes:
>
> 3: sflow offloads with sampling=1 - ping between two ports - offloads
> enabled ok
> 4: sflow offloads with sampling=2 - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Chris Mi
> ---
See some small comments below...
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> Create a unique group ID to map the sFlow info when offloading sFlow
> action to TC. When showing the offloaded datapath flows, translate the
> group ID from TC sample action to sFlow info using the mapping.
>
>
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> Process sFlow offload packet in handler thread if handler id is 0.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Eli Britstein
Thanks for the changes, looks good to me.
Acked-by: Eelco Chaudron
___
dev
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> Implement dpif-offload API for netlink datapath.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
On 12 Oct 2021, at 10:19, Chris Mi wrote:
> When offloading sample action to TC, userspace creates a unique ID
> to map sFlow action and tunnel info and passes this ID to kernel instead
> of the sFlow info. psample will send this ID and sampled packet to
> userspace. Using the ID, userspace
On 10/14/21 21:44, Michael Pattrick wrote:
> Currently ingress policing uses the basic classifier to apply traffic
> control filters.
Hi, Michael. Thanks for submitting a patch!
I'm not going to review technical details of implementation, I'll leave
this to Simon and others, but I want to make a
On 12 Oct 2021, at 6:23, Martin Varghese wrote:
> From: Martin Varghese
>
> The encap & decap actions are extended to support MPLS packet type.
> Encap & decap actions adds and removes MPLS header at start of the
> packet.
>
> The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS
>
Regards,
Vladislav Odintsov
> On 15 Oct 2021, at 08:42, Han Zhou wrote:
>
> On Thu, Oct 14, 2021 at 12:58 AM Vladislav Odintsov
> wrote:
>>
>> Hi Han,
>>
>> Thanks for the review.
>>
>> Regards,
>> Vladislav Odintsov
>>
>> On 14 Oct 2021, at 08:13, Han Zhou wrote:
>>
>>
>>
>> On Tue,
See some inline comments below…
On 14 Oct 2021, at 21:44, Michael Pattrick wrote:
> Currently ingress policing uses the basic classifier to apply traffic
> control filters.
>
> However, cls_basic was removed from the upcoming RHEL9. Basic is probably
> not the proper classifier to use when the
Hi Mike,
See some comments below…
Cheers,
Eelco
On 15 Oct 2021, at 4:05, Mike Pattrick wrote:
> Currently when a user creates an open flow group with with multiple
> buckets without specifying a selection type, the efficient dp_hash is
> only selected if there are fewer than 64 buckets. But
30 matches
Mail list logo