Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
It can happen that MAC binding physical flow is not created
on when new datapath is added to chassis.
Consider following scenario:
Chassis are set with "ovn-monitor-all=true".
T0 - The CH0 have only DP0
T1 - MAC binding table gets new update for DP1
T2 - This is reported to CH0 and ignored as
On Wed, 2022-04-27 at 01:58 +0200, Ilya Maximets wrote:
> On 4/26/22 09:14, Simon Horman wrote:
> > On Tue, Apr 19, 2022 at 01:38:33AM +, Jianbo Liu via dev wrote:
> > > On Thu, 2022-04-07 at 09:15 +, Jianbo Liu wrote:
> > > > This series is to add support for tc offloading of ovs
> > > >
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (tests/system-ovn.at).
error: could not build
UPD: I've posted a tiny series that implements (1) for your consideration here:
https://patchwork.ozlabs.org/project/ovn/list/?series=297048
It would be great if this can be backported to LTS. Seems like a low
risk featurette.
Thanks,
Ihar
On Mon, Apr 25, 2022 at 8:56 PM Ihar Hrachyshka
Reported-At: https://bugzilla.redhat.com/show_bug.cgi?id=2060310
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 ++
controller/binding.c | 13 ++---
ovn-nb.xml | 5 +
ovn-sb.xml | 5 +
tests/system-ovn.at | 4 +++-
5 files changed, 25
Signed-off-by: Ihar Hrachyshka
---
tests/system-ovn.at | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 3d2591ee9..1454f99d2 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -6338,11 +6338,15 @@ ovn-nbctl
Reported-At: https://bugzilla.redhat.com/show_bug.cgi?id=2060310
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 ++
controller/binding.c | 13 ++---
ovn-nb.xml | 5 +
ovn-sb.xml | 5 +
tests/system-ovn.at | 4 +++-
5 files changed, 25
On 4/26/22 09:14, Simon Horman wrote:
> On Tue, Apr 19, 2022 at 01:38:33AM +, Jianbo Liu via dev wrote:
>> On Thu, 2022-04-07 at 09:15 +, Jianbo Liu wrote:
>>> This series is to add support for tc offloading of ovs metering, and
>>> enhance OVS to use new kernel feature which offload tc
On 4/22/22 17:13, Eelco Chaudron wrote:
>
>
> On 22 Apr 2022, at 15:45, Harry van Haaren wrote:
>
>> The code changes here are to handle (1 << i) shifts where 'i' is the
>> packet index in the batch, and 1 << 31 is an overflow of the signed '1'.
>>
>> Fixed by adding UINT32_C() around the 1
On 4/13/22 15:52, Terry Wilson wrote:
> Before 46d44cf3b, it was technically possible to assign a monitor
> condition directly to Idl.tables[table_name].condition. If done
> before the connection was established, it would successfully apply
> the condition (where cond_change() actually would
On 4/4/22 00:26, jan.scheur...@web.de wrote:
> From: Jan Scheurich
>
> A packet received from a tunnel port with legacy_l3 packet-type (e.g.
> lisp, L3 gre, gtpu) is conceptually wrapped in a dummy Ethernet header
> for processing in an OF pipeline that is not packet-type-aware. Before
>
On 4/27/22 00:41, Ilya Maximets wrote:
> On 4/25/22 16:04, Mike Pattrick wrote:
>> On Fri, Apr 1, 2022 at 7:34 PM Paolo Valerio wrote:
>>>
>>> The test relied on the flows installed by recv_upcalls() after
>>> upcall_receive() returned ENODEV if the packet was initially
>>> originated by
On 4/25/22 16:04, Mike Pattrick wrote:
> On Fri, Apr 1, 2022 at 7:34 PM Paolo Valerio wrote:
>>
>> The test relied on the flows installed by recv_upcalls() after
>> upcall_receive() returned ENODEV if the packet was initially
>> originated by packet-out with OFPP_CONTROLLER as in_port.
>>
>>
Bleep bloop. Greetings Rosemarie O'Riorden, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#32 FILE: lib/dp-packet.h:827:
if
On 3/1/22 16:52, Andreas Karis wrote:
> Both LibreSwan and OpenSwan allow administrators to unconditionally
> force enable NAT-T for ESP. This may help to surmount restrictive
> firewalls in scenarios where IP protocol number 50 is blocked, but where
> NAT autodetection fails. Add a switch
On 4/26/22 14:31, Andreas Karis wrote:
> Hi!
>
> No worries! After some reflection, the '--force-encapsulation' patch IMO is
> not the correct way to go, but I did not know how to recall it once it was
> acknowledged ... :-(
Acknowledged doesn't mean accepted. :)
In any case, the procedure is
The function dp_netdev_pmd_flush_output_on_port() iterates over the
p->output_pkts batch directly, when it should be using the special
iterator macro, DP_PACKET_BATCH_FOR_EACH.
However, this wasn't possible because the macro could not accept
>output_pkts.
The addition of parentheses when BATCH
Add ovn-encap-df_default configuration option to set df_default on OVN tunnels.
Signed-off-by: Jochen Friedrich
---
controller/encaps.c | 8
1 file changed, 8 insertions(+)
diff --git a/controller/encaps.c b/controller/encaps.c
index ed01b1368..01b023960 100644
---
Hi Cian,
Thanks for the comments please see my replies inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, April 25, 2022 5:05 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> i.maxim...@ovn.org
> Cc: Stokes, Ian ; echau...@redhat.com;
> ktray...@redhat.com;
> From: Seamus Ryan
>
> This adds 4 new unit tests to the 'check-dpdk' subsystem that will
> test rate limiting functionality.
>
Thanks for the patch Michael, a few comments below.
I'm still conducting some testing so may have some follow up comments for full
review.
> Signed-off-by: Seamus
On 4/22/2022 8:34 AM, David Marchand wrote:
On Fri, Apr 22, 2022 at 9:24 AM Dumitru Ceara wrote:
@@ -37,14 +30,6 @@ jobs:
- compiler: clang
opts: --disable-ssl
- - compiler: gcc
-testsuite:test
-kernel:
The QEMU version requirement of >= 2.7 is for vhost-user-client ports
specifically.
Signed-off-by: Cian Ferriter
---
Documentation/topics/dpdk/vhost-user.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/topics/dpdk/vhost-user.rst
Thanks for the quick fix Dumitru,
Acked-by: Mark Michelson
I went ahead and pushed this to main.
On 4/26/22 11:35, Dumitru Ceara wrote:
When load balancers are configured there was a bug that was causing
the default IN/OUT_ACL flows to be created with a wrong priority. This
commit fixes it.
On 4/26/22 15:35, Mark Michelson wrote:
> On 4/22/22 03:11, Dumitru Ceara wrote:
>> On 4/20/22 17:58, Han Zhou wrote:
>>> Thanks Dumitru. Mark had reviewed the RFC earlier, so I will let him
>>> confirm the change again.
>>> Acked-by: Han Zhou
>>
>> Thanks, Han, for the review!
>>
>
> Thanks
When load balancers are configured there was a bug that was causing
the default IN/OUT_ACL flows to be created with a wrong priority. This
commit fixes it.
Fixes: acec066091c8 ("northd: Add new NB_Global.options:default_acl_drop
option.")
Signed-off-by: Dumitru Ceara
---
northd/northd.c | 4
On 4/26/22 16:29, Adrian Moreno wrote:
>
>
> On 4/12/22 15:29, Dumitru Ceara wrote:
>> When compiled with '-fsanitize=undefined' running 'ovsdb-client
>> --timestamp monitor Open_vSwitch' in a sandbox triggers the following
>> undefined behavior (flagged by UBSan):
>>
>>
On 4/26/22 09:03, Dumitru Ceara wrote:
On 4/21/22 21:24, Mark Michelson wrote:
Thanks Dumitru and Adrian. I rolled Dumitru's edit into patch 3 and
pushed the series to the main branch.
Hi Mark,
Shouldn't patches 1/3 and 2/3 go to branch-22.03 too?
I'm not sure anymore if we ever decided on
Thanks Ales for adding a test in this revision. Looks good to me.
Acked-by: Mark Michelson
On 4/26/22 07:42, Ales Musil wrote:
It can happen that MAC binding physical flow is not created
on when new datapath is added to chassis.
Consider following scenario:
Chassis are set with
On 4/12/22 15:29, Dumitru Ceara wrote:
When compiled with '-fsanitize=undefined' running 'ovsdb-client
--timestamp monitor Open_vSwitch' in a sandbox triggers the following
undefined behavior (flagged by UBSan):
lib/dynamic-string.c:207:38: runtime error: applying zero offset to null
On 25 Apr 2022, at 17:03, Adrian Moreno wrote:
> On 3/18/22 11:19, Eelco Chaudron wrote:
>>
>>
>> On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
>>
>>> Some openflow or dpif flows encode their arguments in lists, eg:
>>> "some_action(arg1,arg2,arg3)". In order to decode this in a way that can
On 4/22/22 03:11, Dumitru Ceara wrote:
On 4/20/22 17:58, Han Zhou wrote:
Thanks Dumitru. Mark had reviewed the RFC earlier, so I will let him
confirm the change again.
Acked-by: Han Zhou
Thanks, Han, for the review!
Thanks yall, I merged the change to main.
Ooops. Sorry about that I missed it.
Thanks for pointing this out!
I will send a patch soon to update the NEWS and .
It does make sense to add the OVS release version for them as well. I'm not
sure why we weren't doing it beforehand ...
--
Alin.
-Original Message-
From: Ilya
On 4/21/22 21:24, Mark Michelson wrote:
> Thanks Dumitru and Adrian. I rolled Dumitru's edit into patch 3 and
> pushed the series to the main branch.
>
Hi Mark,
Shouldn't patches 1/3 and 2/3 go to branch-22.03 too?
I'm not sure anymore if we ever decided on 22.03 to be the official LTS
branch
Hi!
No worries! After some reflection, the '--force-encapsulation' patch IMO is
not the correct way to go, but I did not know how to recall it once it was
acknowledged ... :-(
I would prefer to have the patch that allows the generic options instead,
so that 'options:ipsec_encapsulation=yes' can
On Tue, Apr 26, 2022 at 10:01 AM Dumitru Ceara wrote:
> On 4/26/22 07:43, Ales Musil wrote:
> > It can happen that MAC binding physical flow is not created
> > on when new datapath is added to chassis.
> >
> > Consider following scenario:
> > Chassis are set with "ovn-monitor-all=true".
> >
> >
It can happen that MAC binding physical flow is not created
on when new datapath is added to chassis.
Consider following scenario:
Chassis are set with "ovn-monitor-all=true".
T0 - The CH0 have only DP0
T1 - MAC binding table gets new update for DP1
T2 - This is reported to CH0 and ignored as
Hi Numan,
Apart from a couple of small coments below, I'm wondering if this is a good time
to surface this to ovs-*ctl commands. What do you think?
On 3/8/22 01:56, num...@ovn.org wrote:
From: Numan Siddique
ovsdb-server already supports specifying the uuid in the insert
transaction by the
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: corrupt patch at line 19
error: could not build fake ancestor
hint: Use 'git am
Fix typo in comments.
Signed-off-by: Lin Huang
---
lib/dpif-netdev-private-flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev-private-flow.h b/lib/dpif-netdev-private-flow.h
index 66016eb09..3b7a47d63 100644
--- a/lib/dpif-netdev-private-flow.h
+++
On 4/26/22 10:05, Dumitru Ceara wrote:
>> In the original form of this comment, we need to mention "OVSDB_IDL_MONITOR
>> | OVSDB_IDL_ALERT | OVSDB_IDL_TRACK | OVSDB_IDL_WRITE_CHANGED_ONLY" as
>> well, but I think it is too tedious. Maybe we can change the section from
>> "possible mode
At a first glance, change tracking should never be allowed for
write-only columns. However, some clients (e.g., ovn-northd) that are
mostly exclusive writers of a database, use change tracking to avoid
duplicating the IDL row records into a local cache when implementing
incremental processing.
On 4/26/22 11:59, Phelan, Michael wrote:
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Tuesday 26 April 2022 10:02
>> To: ovs-dev@openvswitch.org; Phelan, Michael
>>
>> Cc: i.maxim...@ovn.org; echau...@redhat.com;
>> david.march...@redhat.com; Van Haaren, Harry
>> ; Aaron
On 3/2/22 14:40, Andreas Karis wrote:
> Tunnels in LibreSwan and OpenSwan allow for many options to be set on a
> per tunnel basis. Pass through any options starting with ipsec_ to the
> connection in the configuration file. Administrators are responsible for
> picking valid key/value pairs.
>
>
On 4/5/22 22:27, Mark Michelson wrote:
Hi Mohammad,
Hi Mark,
Thank you for the review:)
I have a few findings down below, pretty minor.
On 3/30/22 14:09, Mohammad Heib wrote:
currently, when a lport with a nonempty parent_name field
is created or updated in the NBDB the ovn-controller will
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday 26 April 2022 10:02
> To: ovs-dev@openvswitch.org; Phelan, Michael
>
> Cc: i.maxim...@ovn.org; echau...@redhat.com;
> david.march...@redhat.com; Van Haaren, Harry
> ; Aaron Conole ;
> Stokes, Ian
> Subject: Re: [PATCH v2]
currently, when a lport with a nonempty parent_name field
is created or updated in the NBDB the ovn-controller will
handle this port as a container lport and will do all the
required operations to maintain this lport.
This behavior will be changed if the user has explicitly
removed the
On Wed, 13 Apr 2022 08:52:26 -0500
Terry Wilson wrote:
> Before 46d44cf3b, it was technically possible to assign a monitor
> condition directly to Idl.tables[table_name].condition. If done
> before the connection was established, it would successfully apply
> the condition (where cond_change()
On 4/22/22 15:45, Harry van Haaren wrote:
> The code changes here are to handle (1 << i) shifts where 'i' is the
> packet index in the batch, and 1 << 31 is an overflow of the signed '1'.
>
> Fixed by adding UINT32_C() around the 1 character, ensuring compiler knows
> the 1 is unsigned (and
On 4/26/22 03:10, Han Zhou wrote:
>>> Is this something that we should consider adding at some point to the
>>> Python IDL code as well? I know in the past feature support has
>>> diverged. Maybe at some point we should create a python/TODO file that
>>> lists features in the C IDL that still need
On 4/26/22 03:08, Han Zhou wrote:
> On Wed, Apr 20, 2022 at 12:31 PM Dumitru Ceara wrote:
>>
>> At a first glance, change tracking should never be allowed for
>> write-only columns. However, some clients (e.g., ovn-northd) that are
>> mostly exclusive writers of a database, use change tracking
On 4/26/22 07:43, Ales Musil wrote:
> It can happen that MAC binding physical flow is not created
> on when new datapath is added to chassis.
>
> Consider following scenario:
> Chassis are set with "ovn-monitor-all=true".
>
> T0 - The CH0 have only DP0
> T1 - MAC binding table gets new update
Hi Cian,
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, April 25, 2022 5:15 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian ; echau...@redhat.com;
> ktray...@redhat.com; i.maxim...@ovn.org; f...@sysclose.org; Van Haaren,
> Harry
> Subject: RE: [PATCH v2
On Tue, Apr 19, 2022 at 01:38:33AM +, Jianbo Liu via dev wrote:
> On Thu, 2022-04-07 at 09:15 +, Jianbo Liu wrote:
> > This series is to add support for tc offloading of ovs metering, and
> > enhance OVS to use new kernel feature which offload tc police action to
> > hardware.
> > To do
54 matches
Mail list logo
