Re: [ovs-dev] [OVN v3] OVN - Add Support for Remote Port Mirroring

2022-07-18 Thread Numan Siddique
On Wed, Jun 22, 2022 at 1:36 PM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port

[ovs-dev] [RFC ovn] Multi-chassis port + MTU behavior

2022-07-18 Thread Ihar Hrachyshka
Hi folks, looking for some advices on MTU / IP behavior for multi-chassis ports. 22.06 got the new multichassis port concept introduced where the same port may be present on multiple chassis, which can be used as a performance optimization for VM live migration, among other things. Migration

Re: [ovs-dev] [PATCH v4 9/9] debian: Add option to build without DPDK.

2022-07-18 Thread Gregory Rose
On 7/15/2022 4:01 AM, Ilya Maximets wrote: On 7/15/22 10:53, Ilya Maximets wrote: On 7/15/22 05:04, Gregory Rose wrote: On 7/14/2022 6:45 PM, Ilya Maximets wrote: On 7/14/22 17:55, Frode Nordahl wrote: From: Ilya Maximets Signed-off-by: Ilya Maximets Co-authored-by: Frode Nordahl

Re: [ovs-dev] [PATCH v5] ovsdb idl: Add the support to specify the uuid for row insert.

2022-07-18 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 108 characters long (recommended limit is 79) #119 FILE:

Re: [ovs-dev] [PATCH v4] ovsdb idl: Add the support to specify the uuid for row insert.

2022-07-18 Thread Numan Siddique
On Tue, Jul 12, 2022 at 6:02 AM Ilya Maximets wrote: > > On 6/29/22 18:57, num...@ovn.org wrote: > > From: Numan Siddique > > > > ovsdb-server allows the OVSDB clients to specify the uuid for > > the row inserts [1]. The C IDL client library is missing this > > feature. This patch adds this

[ovs-dev] [PATCH v5] ovsdb idl: Add the support to specify the uuid for row insert.

2022-07-18 Thread numans
From: Numan Siddique ovsdb-server allows the OVSDB clients to specify the uuid for the row inserts [1]. The C IDL client library is missing this feature. This patch adds this support. For each schema table, a new function is generated - insert_persistent_uuid(txn, uuid) and the users of IDL

Re: [ovs-dev] [ovs-build] |fail| pw1656877 [ovs-dev, 2/2] Prepare for post-3.0.0 (3.0.90).

2022-07-18 Thread Ilya Maximets
On 7/15/22 20:33, Ilya Maximets wrote: > On 7/15/22 20:24, Stokes, Ian wrote: >>> Looks like new MTU tests are unstable. >>> Ian, Michael, could you, please, check? >>> >>> Best regards, Ilya Maximets. >> >> Hey Ilya, >> >> Let me take a look at this, it passed our internal CI so not sure why it's

Re: [ovs-dev] [v12 00/10] Actions Infrastructure + Optimizations

2022-07-18 Thread Eelco Chaudron
On 18 Jul 2022, at 14:49, Finn, Emma wrote: >> -Original Message- >> From: Eelco Chaudron >> Sent: Monday 18 July 2022 10:41 >> To: Stokes, Ian ; Finn, Emma >> Cc: d...@openvswitch.org; Van Haaren, Harry ; >> Amber, Kumar ; i.maxim...@ovn.org >> Subject: Re: [v12 00/10] Actions

Re: [ovs-dev] [v12 00/10] Actions Infrastructure + Optimizations

2022-07-18 Thread Finn, Emma
> -Original Message- > From: Eelco Chaudron > Sent: Monday 18 July 2022 10:41 > To: Stokes, Ian ; Finn, Emma > Cc: d...@openvswitch.org; Van Haaren, Harry ; > Amber, Kumar ; i.maxim...@ovn.org > Subject: Re: [v12 00/10] Actions Infrastructure + Optimizations > > > > On 15 Jul 2022,

Re: [ovs-dev] [PATCH v2 ovn] lflow: fix possible use-after-free in add_lb_vip_hairpin_reply_action

2022-07-18 Thread Dumitru Ceara
On 7/16/22 08:45, Lorenzo Bianconi wrote: > ofpbuf_put_zeros routine can rellocate the buffer if the requested size > is bigger than buffer tailroom. Reload ol pointer before running > ofpact_finish_LEARN in order to avoid a possible use-after-free in > add_lb_vip_hairpin_reply_action routine. >

[ovs-dev] [PATCH] ci: Prefer pip3 to install unit test dependencies

2022-07-18 Thread David Marchand
While it looks like the right python3 versions of those dependencies seems to be installed in the CI, prefer calling this via pip3 like the rest of the script. Fixes: 445dceb88461 ("python: Introduce unit tests.") Signed-off-by: David Marchand --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH v5 13/17] python: introduce unit tests

2022-07-18 Thread Ilya Maximets
On 7/17/22 16:07, David Marchand wrote: > On Fri, Jul 8, 2022 at 8:09 PM Adrian Moreno wrote: >> diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh >> index a0635cf56..de741c6b4 100755 >> --- a/.ci/linux-prepare.sh >> +++ b/.ci/linux-prepare.sh >> @@ -45,6 +45,9 @@ if [ "$M32" ]; then >>

Re: [ovs-dev] [PATCH] ovsdb: Remove extra make target dependency for local-config.5.

2022-07-18 Thread Dumitru Ceara
On 7/15/22 18:04, Ilya Maximets wrote: > ovsdb/ directory should not be a dependency, otherwise the man > page is getting re-built every time unrelated files are changed. > > Fixes: 6f24c2bc769a ("ovsdb: Add Local_Config schema.") > Signed-off-by: Ilya Maximets > --- Acked-by: Dumitru Ceara

[ovs-dev] [PATCH v2 2/2] python-c-ext: fix a couple of build warnings

2022-07-18 Thread Timothy Redaelli
ovs/_json.c:67:20: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] ovs/_json.c:132:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] Signed-off-by: Timothy

[ovs-dev] [PATCH v2 0/2] fix a couple of build warnings

2022-07-18 Thread Timothy Redaelli
v1 -> v2: - Removed Python 2 support as requested by Ilya Timothy Redaelli (2): python-c-ext: Remove Python 2 support python-c-ext: fix a couple of build warnings python/ovs/_json.c | 38 +++--- 1 file changed, 3 insertions(+), 35 deletions(-) -- 2.36.1

[ovs-dev] [PATCH v2 1/2] python-c-ext: Remove Python 2 support

2022-07-18 Thread Timothy Redaelli
Since Python 2 is not supported anymore, remove Python 2 support from C extension too Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Signed-off-by: Timothy Redaelli --- python/ovs/_json.c | 34 +- 1 file changed, 1 insertion(+), 33

Re: [ovs-dev] [v12 00/10] Actions Infrastructure + Optimizations

2022-07-18 Thread Eelco Chaudron
On 15 Jul 2022, at 13:39, Stokes, Ian wrote: >> This patchset introduces actions infrastructure changes which allows >> the user to choose between different action implementations based on >> CPU ISA by using different commands. The infrastructure also >> provides a way to check the