[ovs-dev] [PATCH v2] ovs-ofctl: skip invalid flows for replace-flows

2023-05-05 Thread Wan Junjie via dev
ovs-save will do replace-flows for ovs restart. For some reason, ovs could have an invalid action, like invalid meter. Then adding flows will be stopped at the position of the first invalid flow. This could happen when ovs restart and vm related resource allocatting or destructing at the same

Re: [ovs-dev] [PATCH] dpif-netdev: Add config option for vhost tx_steering default mode

2023-05-05 Thread Ilya Maximets
On 5/3/23 00:20, Christophe Fontaine wrote: > Current tx_steering mode has to be configured on each Interface. > The global config option "vhost-tx-steering-default" allows > the user to select a default mode (thread or hash) for > all dpdkvhost ports. > > Signed-off-by: Christophe Fontaine Hi,

Re: [ovs-dev] [PATCH dpdk-latest v4 1/5] netdev-dpdk: use flow transfer proxy

2023-05-05 Thread Ilya Maximets
On 5/3/23 16:00, Ivan Malov wrote: > Hello Simon, > > This patch has me intrigued. By the looks of it, it bears uncanny > resemblance to patch [1] by another author. Is your patch based > on patch [1]? If yes, could you please comment on the following: > > 1) Your patch does not seem to

Re: [ovs-dev] [PATCH v4] ci: Separate DPDK from OVS build.

2023-05-05 Thread Ilya Maximets
On 5/4/23 19:10, David Marchand wrote: > Let's separate DPDK compilation from the rest of OVS build: > - this avoids multiple jobs building DPDK in parallel, which especially > affects builds in the dpdk-latest branch, > - we separate concerns about DPDK build requirements from OVS build >

Re: [ovs-dev] [PATCH] lib/ssl: enable TLSv1.3 if supported by SSL

2023-05-05 Thread Ilya Maximets
On 5/5/23 17:23, Ilya Maximets wrote: > Hi, Dan. Thanks for the patch! > > Looks like you've lost a commit message somewhere. > > On 5/4/23 17:47, Dan Williams wrote: >> diff --git a/lib/ssl-connect.man b/lib/ssl-connect.man >> index 6e54f77ef4d5e..896ce79c6378f 100644 >> ---

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix use-after-free when xlate_actions().

2023-05-05 Thread Ilya Maximets
On 5/5/23 03:46, wangyunjian wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@ovn.org] >> Sent: Thursday, May 4, 2023 8:32 PM >> To: wangyunjian ; d...@openvswitch.org >> Cc: i.maxim...@ovn.org; luyicai >> Subject: Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix

Re: [ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not updated error.

2023-05-05 Thread Ilya Maximets
On 5/5/23 05:15, 汪翰林 wrote: > > 在 2023/5/5 10:55, 汪翰林 写道: >> >> 在 2023/5/4 18:14, Ilya Maximets 写道: >>> On 5/4/23 12:12, Ilya Maximets wrote: On 4/11/23 11:07, 汪翰林 wrote: > 在 2023/4/7 21:20, Simon Horman 写道: >> On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote: >>> When

Re: [ovs-dev] [PATCH ovn 0/6] Improve multi-node CI tests.

2023-05-05 Thread Numan Siddique
On Fri, May 5, 2023 at 8:38 AM Ales Musil wrote: > > On Fri, May 5, 2023 at 11:25 AM Dumitru Ceara wrote: > > > Dumitru Ceara (6): > > ovn-fake-multinode-tests: Use ":main" instead of ":latest". > > ovn-fake-multinode-tests: Parallelize build stage. > >

Re: [ovs-dev] [PATCH 1/2] tests-ovsdb: switch OVSDB_START_IDLTEST to macro

2023-05-05 Thread Ilya Maximets
On 5/5/23 14:20, Stefan Hoffmann wrote: > Define bash function as macro now. Later we can extend this macro for other > usecases. > --- You missed a Sign-off here. > tests/ovsdb-idl.at | 71 +- > 1 file changed, 38 insertions(+), 33 deletions(-) > >

Re: [ovs-dev] [PATCH 2/2] test-stream: Add ssl tests for stream open block

2023-05-05 Thread Ilya Maximets
On 5/5/23 16:23, Ilya Maximets wrote: > On 5/5/23 14:26, Stefan Hoffmann wrote: >> On Fri, 2023-05-05 at 14:21 +0200, Stefan Hoffmann wrote: >>> This tests stream.c and stream.py with ssl connection at >>> CHECK_STREAM_OPEN_BLOCK. >>> For the tests, ovsdb needs to be build with libssl. >>> >>>

Re: [ovs-dev] [PATCH] lib/ssl: enable TLSv1.3 if supported by SSL

2023-05-05 Thread Ilya Maximets
Hi, Dan. Thanks for the patch! Looks like you've lost a commit message somewhere. On 5/4/23 17:47, Dan Williams wrote: > diff --git a/lib/ssl-connect.man b/lib/ssl-connect.man > index 6e54f77ef4d5e..896ce79c6378f 100644 > --- a/lib/ssl-connect.man > +++ b/lib/ssl-connect.man > @@ -1,10 +1,12 @@

[ovs-dev] [PATCH v2 ovn 2/2] Introduce IPv6 iPXE chainload support

2023-05-05 Thread Lorenzo Bianconi
Similar to IPv4 support, add IPv6 support for iPXE chainload. Acked-by: Ales Musil Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 36 ++-- lib/ovn-l7.h | 9 + northd/ovn-northd.c | 4 ++- tests/ovn.at | 78

[ovs-dev] [PATCH v2 ovn 0/2] add IPv6 iPXE chainload support

2023-05-05 Thread Lorenzo Bianconi
Changes since v1: - rely on dhcpv6_opt_header in patch 1/2 in order to simplify the ubsan sanitizer fix Lorenzo Bianconi (2): controller: fix possible unaligned accesses in DHCPv6 code Introduce IPv6 iPXE chainload support controller/pinctrl.c | 42 +--- lib/actions.c

[ovs-dev] [PATCH v2 ovn 1/2] controller: fix possible unaligned accesses in DHCPv6 code

2023-05-05 Thread Lorenzo Bianconi
According to RFC8415 [0], section 8 "Client/Server Message Formats": "Options are stored serially in the "options" field, with no padding between the options. Options are byte-aligned but are not aligned in any other way (such as on 2-byte or 4-byte boundaries)." Fix possible unaligned

Re: [ovs-dev] [PATCH ovn] tests: Retry inject-pkt in case ovn-controller is still busy.

2023-05-05 Thread Dumitru Ceara
On 5/1/23 17:41, Dumitru Ceara wrote: > On 4/28/23 13:06, Xavier Simonart wrote: >> Hi Dumitru >> > > Hi Xavier, > >> When can this "ovn-controller not ready" error happen ? Is this not only at >> startup? >> Can this not be fixed using wait_for_ports_up ? >> This "wait_for_ports_up" is missing

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
packets that arrive from other chassis resubmit to table 38 Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++

Re: [ovs-dev] [PATCH 2/2] test-stream: Add ssl tests for stream open block

2023-05-05 Thread Ilya Maximets
On 5/5/23 14:26, Stefan Hoffmann wrote: > On Fri, 2023-05-05 at 14:21 +0200, Stefan Hoffmann wrote: >> This tests stream.c and stream.py with ssl connection at >> CHECK_STREAM_OPEN_BLOCK. >> For the tests, ovsdb needs to be build with libssl. >> >> Signed-off-by: Stefan Hoffmann >> --- >>

Re: [ovs-dev] [PATCH ovn v4 3/4] ovn-nbctl: Add tier ACL options.

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 468 characters long (recommended limit is 79) #151 FILE:

Re: [ovs-dev] OVN 23.06 soft freeze today

2023-05-05 Thread Ilya Maximets
On 5/5/23 14:58, Mark Michelson wrote: > Hi everyone, > > Today is the soft freeze for the OVN 23.06 release. This means that any new > feature patches intended to be included in the 23.06 release need to be > posted today. In two weeks time, we will create the 23.06 branch of OVN, at > which

Re: [ovs-dev] OVN 23.06 soft freeze today

2023-05-05 Thread Ihar Hrachyshka
Path MTU discovery for multichassis ports on localnet attached switches: https://patchwork.ozlabs.org/project/ovn/list/?series=353374 As stated elsewhere, I consider it a bug fix to an undesired behavior of the previously added feature (albeit a sizable one, even if it's well isolated from the

Re: [ovs-dev] OVN 23.06 soft freeze today

2023-05-05 Thread Mark Michelson
On 5/5/23 08:58, Mark Michelson wrote: Hi everyone, Today is the soft freeze for the OVN 23.06 release. This means that any new feature patches intended to be included in the 23.06 release need to be posted today. In two weeks time, we will create the 23.06 branch of OVN, at which point no

Re: [ovs-dev] [PATCH v4] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-05-05 Thread Ilya Maximets
On 5/5/23 14:06, Naveen Yerramneni wrote: > Hi IIya, > > Thanks for the review. > > One question, once vswitchd DB schema is updated to store zone level limits. > OVN controller should directly update the configuration in the database , > right ? Right. ovn-controller already has a database

[ovs-dev] [PATCH ovn v4 4/4] acls: Add "pass" ACL action.

2023-05-05 Thread Mark Michelson
This allows for evaluating ACLs at the current tier to stop, and to start evaluating ACLs at the next tier. If not using tiers, or if we match on the final ACL tier, then a "pass" verdict results in the default ACL action being applied. Reported-at:

[ovs-dev] [PATCH ovn v4 3/4] ovn-nbctl: Add tier ACL options.

2023-05-05 Thread Mark Michelson
This modifies the acl-add and acl-del commands so that an ACL tier can be specified when adding or deleting ACLs. For acl-add, if the tier is specified, then the ACL created by the command will have that tier set. For acl-del, if the tier is specified, then the tier will be one of the criteria

[ovs-dev] [PATCH ovn v4 2/4] northd: Add tiered ACL support.

2023-05-05 Thread Mark Michelson
With this commit, ACLs can now be arranged in hierarchical tiers. A tier number can be assigned to an ACL. When evaluating ACLs, we first will consider ACLs at tier 0. If no matching ACL is found, then we move to tier 1. This continues until a matching ACL is found, or we reach the maximum tier.

Re: [ovs-dev] [PATCH ovn v3 4/4] acls: Add "pass" ACL action.

2023-05-05 Thread Mark Michelson
On 5/2/23 12:08, Dumitru Ceara wrote: On 4/21/23 21:51, Mark Michelson wrote: This allows for evaluating ACLs at the current tier to stop, and to start evaluating ACLs at the next tier. If not using tiers, or if we match on the final ACL tier, then a "pass" verdict results in the default ACL

Re: [ovs-dev] [PATCH ovn v3 4/4] acls: Add "pass" ACL action.

2023-05-05 Thread Mark Michelson
On 4/28/23 07:46, Ales Musil wrote: On Fri, Apr 21, 2023 at 9:52 PM Mark Michelson > wrote: This allows for evaluating ACLs at the current tier to stop, and to start evaluating ACLs at the next tier. If not using tiers, or if we match on the final ACL

[ovs-dev] OVN 23.06 soft freeze today

2023-05-05 Thread Mark Michelson
Hi everyone, Today is the soft freeze for the OVN 23.06 release. This means that any new feature patches intended to be included in the 23.06 release need to be posted today. In two weeks time, we will create the 23.06 branch of OVN, at which point no new features will be merged. The list

Re: [ovs-dev] [PATCH 1/2] tests-ovsdb: switch OVSDB_START_IDLTEST to macro

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Stefan Hoffmann, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Stefan Hoffmann needs to sign off. Lines checked: 289, Warnings: 0, Errors:

Re: [ovs-dev] [PATCH ovn 0/6] Improve multi-node CI tests.

2023-05-05 Thread Ales Musil
On Fri, May 5, 2023 at 11:25 AM Dumitru Ceara wrote: > Dumitru Ceara (6): > ovn-fake-multinode-tests: Use ":main" instead of ":latest". > ovn-fake-multinode-tests: Parallelize build stage. > ovn-fake-multinode-tests: Don't silently ignore test failures. >

Re: [ovs-dev] Proposed OVN minor release policy updates

2023-05-05 Thread Mark Michelson
On 5/5/23 05:42, Dumitru Ceara wrote: On 5/4/23 22:09, Mark Michelson wrote: Hi all, Currently, the OVN project is inconsistent with its policy for creating minor releases. In many cases, we create a .0 release and then, despite backporting changes to the branch, never create any follow-up

Re: [ovs-dev] [PATCH 2/2] test-stream: Add ssl tests for stream open block

2023-05-05 Thread Stefan Hoffmann
On Fri, 2023-05-05 at 14:21 +0200, Stefan Hoffmann wrote: > This tests stream.c and stream.py with ssl connection at > CHECK_STREAM_OPEN_BLOCK. > For the tests, ovsdb needs to be build with libssl. > > Signed-off-by: Stefan Hoffmann > --- > tests/ovsdb-idl.at | 41

[ovs-dev] [PATCH 2/2] test-stream: Add ssl tests for stream open block

2023-05-05 Thread Stefan Hoffmann
This tests stream.c and stream.py with ssl connection at CHECK_STREAM_OPEN_BLOCK. For the tests, ovsdb needs to be build with libssl. Signed-off-by: Stefan Hoffmann --- tests/ovsdb-idl.at | 41 - tests/test-stream.c | 12 +++-

[ovs-dev] [PATCH 1/2] tests-ovsdb: switch OVSDB_START_IDLTEST to macro

2023-05-05 Thread Stefan Hoffmann
Define bash function as macro now. Later we can extend this macro for other usecases. --- tests/ovsdb-idl.at | 71 +- 1 file changed, 38 insertions(+), 33 deletions(-) diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index 9d28672ef..8b1cdcdf8

Re: [ovs-dev] [PATCH ovn 2/2] Introduce IPv6 iPXE chainload support

2023-05-05 Thread Ales Musil
On Thu, May 4, 2023 at 12:15 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Similar to IPv4 support, add IPv6 support for iPXE chainload. > > Signed-off-by: Lorenzo Bianconi > --- > controller/pinctrl.c | 36 ++-- > lib/ovn-l7.h | 9 + >

Re: [ovs-dev] [PATCH v4] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-05-05 Thread Naveen Yerramneni
Hi IIya, Thanks for the review. One question, once vswitchd DB schema is updated to store zone level limits. OVN controller should directly update the configuration in the database , right ? Thanks, Naveen On 04-May-2023, at 3:33 PM, Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: On

Re: [ovs-dev] [PATCH ovn 1/2] controller: fix possible unaligned accesses in DHCPv6 code

2023-05-05 Thread Ales Musil
On Thu, May 4, 2023 at 12:14 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > According to RFC8415 [0], section 8 "Client/Server Message Formats": > "Options are stored serially in the "options" field, with no padding > between the options. Options are byte-aligned but are not

Re: [ovs-dev] [PATCH 1/7] netdev: add netdev_get_speed() to nedev API

2023-05-05 Thread Adrian Moreno
On 5/5/23 12:54, Ilya Maximets wrote: On 5/5/23 12:39, Adrian Moreno wrote: On 5/5/23 11:56, Ilya Maximets wrote: On 5/5/23 10:04, Adrian Moreno wrote: On 5/4/23 17:52, Ilya Maximets wrote: On 4/21/23 17:16, Adrian Moreno wrote: Currently, the netdev's speed is being calculated by

[ovs-dev] [PATCH v3 ovn] mirror: fix ovn mirror support with IPv6

2023-05-05 Thread Lorenzo Bianconi
Fix IPv6 support for OVN mirroring configuring properly interface type in OVS interface table Acked-by: Mark Michelson Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2168119 Fixes: ba8aa26e44cb ("OVN Remote Port Mirroring: controller changes to create ovs mirrors") Signed-off-by:

Re: [ovs-dev] [PATCH 1/7] netdev: add netdev_get_speed() to nedev API

2023-05-05 Thread Ilya Maximets
On 5/5/23 12:39, Adrian Moreno wrote: > > > On 5/5/23 11:56, Ilya Maximets wrote: >> On 5/5/23 10:04, Adrian Moreno wrote: >>> >>> >>> On 5/4/23 17:52, Ilya Maximets wrote: On 4/21/23 17:16, Adrian Moreno wrote: > Currently, the netdev's speed is being calculated by taking the link's

Re: [ovs-dev] [PATCH 1/7] netdev: add netdev_get_speed() to nedev API

2023-05-05 Thread Adrian Moreno
On 5/5/23 11:56, Ilya Maximets wrote: On 5/5/23 10:04, Adrian Moreno wrote: On 5/4/23 17:52, Ilya Maximets wrote: On 4/21/23 17:16, Adrian Moreno wrote: Currently, the netdev's speed is being calculated by taking the link's feature bits (using netdev_get_features()) and transforming them

Re: [ovs-dev] [PATCH 1/7] netdev: add netdev_get_speed() to nedev API

2023-05-05 Thread Ilya Maximets
On 5/5/23 10:04, Adrian Moreno wrote: > > > On 5/4/23 17:52, Ilya Maximets wrote: >> On 4/21/23 17:16, Adrian Moreno wrote: >>> Currently, the netdev's speed is being calculated by taking the link's >>> feature bits (using netdev_get_features()) and transforming them into >>> bps. >>> >>> This

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Wei Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ovn-architecture.7.xml). error: could not build fake

[ovs-dev] [PATCH ovn] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1318,7 +1318,7 @@ output

Re: [ovs-dev] Proposed OVN minor release policy updates

2023-05-05 Thread Dumitru Ceara
On 5/4/23 22:09, Mark Michelson wrote: > Hi all, > > Currently, the OVN project is inconsistent with its policy for creating > minor releases. In many cases, we create a .0 release and then, despite > backporting changes to the branch, never create any follow-up minor > releases. > > I propose

Re: [ovs-dev] Proposed OVN support lifetime updates

2023-05-05 Thread Dumitru Ceara
On 5/4/23 22:09, Mark Michelson wrote: > Hi all, > > A recent thread [1] had several topics of discussion come up about > proposed changes to OVN release management. This thread is specifically > to discuss the support lifetime of OVN releases. > > Current documentation discusses two ideas with

Re: [ovs-dev] [PATCH ovn 3/6] ovn-fake-multinode-tests: Don't silently ignore test failures.

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #32 FILE:

Re: [ovs-dev] [PATCH ovn 2/6] ovn-fake-multinode-tests: Parallelize build stage.

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #92 FILE:

Re: [ovs-dev] [PATCH ovn 1/6] ovn-fake-multinode-tests: Use ":main" instead of ":latest".

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #23 FILE:

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Wei Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ovn-architecture.7.xml). error: could not build fake

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1318,7 +1318,7 @@ output

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Ilya Maximets
On 5/5/23 10:57, Wei Li wrote: > Signed-off-by: Wei Li > --- > ovn-architecture.7.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index cb1064f71..86c6258e0 100644 > --- a/ovn-architecture.7.xml > +++

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1318,7 +1318,7 @@ output

Re: [ovs-dev] [PATCH ovn v3 1/2] CI: Add a couple of periodic jobs using ovn-fake-multinode.

2023-05-05 Thread Dumitru Ceara
On 5/3/23 17:17, Numan Siddique wrote: > On Thu, Mar 30, 2023 at 8:54 AM Dumitru Ceara wrote: >> >> On 3/29/23 16:01, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> This patch adds a couple of jobs using ovn-fake-multinode. >>> It first builds 2 ovn-fake-multinode container images >>>

[ovs-dev] [PATCH ovn 6/6] ci: Change all GitHub CI jobs to use ubuntu-latest.

2023-05-05 Thread Dumitru Ceara
There's no real reason to stick to 20.04 as far as I can tell. Note: I also changed the Ubuntu container Dockerfile. That one is also used by CI but potentially by other downstream entities too. Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-fake-multinode-tests.yml |4 ++--

[ovs-dev] [PATCH ovn 5/6] ovn-fake-multinode-tests: Don't compile with sparse.

2023-05-05 Thread Dumitru Ceara
This removes the need for linux-prepare.sh so we can avoid some duplication of dependency management. Suggested-by: Ales Musil Signed-off-by: Dumitru Ceara --- .ci/linux-build.sh |3 ++- .ci/linux-prepare.sh | 21 -

[ovs-dev] [PATCH ovn 4/6] ovn-fake-multinode-tests: Fix log extraction.

2023-05-05 Thread Dumitru Ceara
The paths were slightly wrong so no logs were retrieved/printed. Fixes: 6c6a7ad1c64a ("Add fake multinode system tests.") Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-fake-multinode-tests.yml |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH ovn 3/6] ovn-fake-multinode-tests: Don't silently ignore test failures.

2023-05-05 Thread Dumitru Ceara
Fixes: 6c6a7ad1c64a ("Add fake multinode system tests.") Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-fake-multinode-tests.yml | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ovn-fake-multinode-tests.yml

[ovs-dev] [PATCH ovn 2/6] ovn-fake-multinode-tests: Parallelize build stage.

2023-05-05 Thread Dumitru Ceara
This reduces the overall job duration significantly. Fixes: 033f5bebf94d ("CI: Add a couple of periodic jobs using ovn-fake-multinode.") Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-fake-multinode-tests.yml | 78 ++-- 1 file changed, 32 insertions(+), 46

[ovs-dev] [PATCH ovn 1/6] ovn-fake-multinode-tests: Use ":main" instead of ":latest".

2023-05-05 Thread Dumitru Ceara
For consistency with the rest of the job. Fixes: 033f5bebf94d ("CI: Add a couple of periodic jobs using ovn-fake-multinode.") Signed-off-by: Dumitru Ceara --- .github/workflows/ovn-fake-multinode-tests.yml |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH ovn 0/6] Improve multi-node CI tests.

2023-05-05 Thread Dumitru Ceara
Dumitru Ceara (6): ovn-fake-multinode-tests: Use ":main" instead of ":latest". ovn-fake-multinode-tests: Parallelize build stage. ovn-fake-multinode-tests: Don't silently ignore test failures. ovn-fake-multinode-tests: Fix log extraction. ovn-fake-multinode-tests:

Re: [ovs-dev] [PATCH ovn v4 1/2] ovn-controller: fixed ovn-installed not always properly added or removed.

2023-05-05 Thread Ales Musil
On Fri, Apr 28, 2023 at 1:59 PM Xavier Simonart wrote: > OVN checks whether ovn-installed is already present (in OVS) before > updating it. > This might cause ovn-installed related issues in the following case: > - (1) ovn-installed is present > - (2) we claim the interface > - (3) we update

Re: [ovs-dev] [PATCH ovn v4 2/2] ovn-controller: fixed port not always set down when unbinding interface

2023-05-05 Thread Ales Musil
On Fri, Apr 28, 2023 at 1:59 PM Xavier Simonart wrote: > When interface was unbound, the port was not always set down and the > port_binding->chassis not always removed. > > Fixes: a7c7d4519e50 ("controller: avoid recomputes triggered by SBDB > Port_Binding updates.") > Reported-at:

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Wei Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ovn-architecture.7.xml). error: could not build fake

Re: [ovs-dev] [PATCH ovn] northd: Update obsolete datapath groups instead of re-creating.

2023-05-05 Thread Ales Musil
On Wed, May 3, 2023 at 5:32 PM Ilya Maximets wrote: > Every time we add a new switch or router it may result in addition or > removal of a few datapath in datapath groups. Every time that happens, > northd will remove obsolete groups, create new groups that differ by a > few datapaths, and

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1318,7 +1318,7 @@ output

Re: [ovs-dev] [PATCH ovn v4] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-05 Thread Ales Musil
On Thu, May 4, 2023 at 6:55 PM Vladislav Odintsov wrote: > For large OVN_Southbound (or other) databases the default interval of 5000 > ms > could be not sufficient to run. This patch adds configuration of OVSDB > inactivity probes for ovn-*ctl utilities. > > Initially, on the utility start the

Re: [ovs-dev] [PATCH ovn v2] northd: fix use-after-free after lrp destroyed

2023-05-05 Thread Ales Musil
On Thu, May 4, 2023 at 1:35 PM Tao Liu wrote: > In vxlan mode with more than 2047 lrp in router, build_ports() > prints "all port tunnel ids exhausted", and frees the lrp port. > > However, lsp of type "router" connected to the lrp still holds > the pointer in port->peer. This leads to northd

[ovs-dev] [PATCH ovn] ovn-controller docs: fix typo in ovn-monitor-all description

2023-05-05 Thread Vladislav Odintsov
Make it more clear that ovn-monitor-all option has effect on OVN Southbound database rather than local OVS. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html Reported-by: Ilya Maximets Signed-off-by: Vladislav Odintsov --- controller/ovn-controller.8.xml |

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Wei Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ovn-architecture.7.xml). error: could not build fake

Re: [ovs-dev] [PATCH ovn] docs: document that vxlan is supported for encap type

2023-05-05 Thread Ales Musil
On Wed, May 3, 2023 at 10:30 PM Ihar Hrachyshka wrote: > Most of the documentation was updated when the feature was implemented, > but these two places were omitted by mistake. > > Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") > Signed-off-by: Ihar Hrachyshka > --- >

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1318,7 +1318,7 @@ output

Re: [ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Wei Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (ovn-architecture.7.xml). error: could not build fake

Re: [ovs-dev] [PATCH 1/7] netdev: add netdev_get_speed() to nedev API

2023-05-05 Thread Adrian Moreno
On 5/4/23 17:52, Ilya Maximets wrote: On 4/21/23 17:16, Adrian Moreno wrote: Currently, the netdev's speed is being calculated by taking the link's feature bits (using netdev_get_features()) and transforming them into bps. This mechanism can be both inaccurate and difficult to maintain,

[ovs-dev] [PATCH] documentation: packets that arrive from other chassis resubmit to table 38

2023-05-05 Thread Wei Li
packets that arrive from other chassis resubmit to table 38 Signed-off-by: Wei Li --- ovn-architecture.7.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index cb1064f71..86c6258e0 100644 --- a/ovn-architecture.7.xml +++

Re: [ovs-dev] [External] Re: [PATCH v10] utilities/ofctl: add-meters for save and restore

2023-05-05 Thread Wan Junjie via dev
On Thu, May 4, 2023 at 7:08 PM Ilya Maximets wrote: > > On 4/11/23 15:25, Wan Junjie via dev wrote: > > put dump-meters' result in one line so add-meters can handle. > > save and restore meters when restart ovs. > > bundle functions are not implemented in this patch. > > > > Signed-off-by: Wan

Re: [ovs-dev] [PATCH ovn 1/2] mirror: Enhance port-mirroring to support local OVS port as target.

2023-05-05 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #551 FILE: utilities/ovn-nbctl.c:276: mirror-add

[ovs-dev] [PATCH ovn 1/2] mirror: Enhance port-mirroring to support local OVS port as target.

2023-05-05 Thread Han Zhou
Today the mirror feature in OVN supports only tunnel to a remote destinations. This patch adds the support for mirroring to a local OVS port. It is particularly useful for monitoring traffic that is offloaded thus not possible to be intercepted by regular tools such as tcpdump. With this feature,

[ovs-dev] [PATCH ovn 2/2] mirror: Support "both" direction in the same mirror object.

2023-05-05 Thread Han Zhou
It is more convenient to support "both" as a keyword to indicate both directions instead of having to create two mirror objects to mirror both directions. Signed-off-by: Han Zhou --- NEWS | 3 ++- controller/mirror.c | 14 ++ ovn-nb.ovsschema |