Re: [ovs-dev] [PATCH v3 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-25 Thread Lorenzo Bianconi
> Hi Lorenzo, Hi Mark, thx for the review. > > I tried running the system test from this patch against ovn main and it > passes even without the changes in northd. I think this is because the > alice1 and foo1 ports need to be bound on different hvs to properly test the > changes in northd.

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

2023-05-25 Thread Ansis
On Fri, May 19, 2023 at 9:53 AM Russell Bryant wrote: > > The following document discusses emeritus committer status: > > https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/ > > There are several people who I would guess consider themselves > emeritus committers but have

[ovs-dev] [PATCH v3] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-25 Thread Mike Pattrick
Several xlate actions used in recursive translation currently store a large amount of information on the stack. This can result in handler threads quickly running out of stack space despite before xlate_resubmit_resource_check() is able to terminate translation. This patch reduces stack usage by

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

2023-05-25 Thread Simon Horman
On Fri, May 19, 2023 at 10:52:51AM -0400, Russell Bryant wrote: > The following document discusses emeritus committer status: > > https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/ > > There are several people who I would guess consider themselves > emeritus committers

Re: [ovs-dev] [PATCH v2] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-25 Thread Ilya Maximets
On 5/25/23 15:07, Frode Nordahl wrote: > The bareudp tests depend on specific kernel configuration to > succeed. Skip the test if the feature is not enabled in the > running kernel. > > Signed-off-by: Frode Nordahl > --- > tests/system-kmod-macros.at | 10 ++ >

Re: [ovs-dev] [PATCH] userspace: modify the width of tpa and spa

2023-05-25 Thread Ilya Maximets
On 5/25/23 13:27, Simon Horman wrote: > On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote: >> Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. >> >> Signed-off-by: yangchang > > Reviewed-by: Simon Horman The change looks good to me, but the 'userspace' part in the

Re: [ovs-dev] OVS NDP proxy / nd_options_type

2023-05-25 Thread Sesterhenn, Maximilian via dev
Hello together, I would like to follow up on this. Meanwhile I was able to find the following discussion [1] in this mailing list some time ago which looks like is about the same topic. Is this something that's currently not possible within OVS? If so, are there plans to add this? I had a

[ovs-dev] [PATCH ovn v3] controller: Ignore DNS queries with RRs

2023-05-25 Thread Brian Haley
DNS queries with optional records (RRs), for example, with cookies for EDNS, are not supported by the OVN resolver. Trying to reply will result in mangled responses that clients do not understand - the ANSWER section will contain an incorrect option. Instead, just return early when one is

[ovs-dev] [PATCH ovn 9/9] backporting-patches: Add concrete policy for where backports go.

2023-05-25 Thread Mark Michelson
This is based on discussions that have happened both on the ovs-dev mailing list as well as public IRC developer meetings. Signed-off-by: Mark Michelson --- .../contributing/backporting-patches.rst | 28 +++ 1 file changed, 28 insertions(+) diff --git

[ovs-dev] [PATCH ovn 8/9] backporting-patches: Fix inaccuracies in the document.

2023-05-25 Thread Mark Michelson
This document appears to be based on the OVS document, but things are done slightly differently in OVN. * OVN is 100% userspace, so there is no need to clarify "userspace" anywhere. * The commit message example is not how we do things in OVN. Backport commit messages are typically identical

[ovs-dev] [PATCH ovn 7/9] backporting-patches: Change "master" to "main".

2023-05-25 Thread Mark Michelson
OVN hasn't used the name "master" for quite a while, and it looks like we missed this document when the change to "main" was made. Signed-off-by: Mark Michelson --- .../internals/contributing/backporting-patches.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[ovs-dev] [PATCH ovn 5/9] release-process: Add section for standard-term support releases.

2023-05-25 Thread Mark Michelson
Signed-off-by: Mark Michelson --- Documentation/internals/release-process.rst | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/internals/release-process.rst b/Documentation/internals/release-process.rst index 7c6a72a41..1f4b90143 100644 ---

[ovs-dev] [PATCH ovn 6/9] release-policy: Document when versions receive new releases.

2023-05-25 Thread Mark Michelson
The OVN team has had no concrete policy regarding when releases are made for a given version. In the past, new releases have been made only when something critical has been found, meaning that most bug fixes applied to a given OVN version never end up in a release. This change proposes a monthly

[ovs-dev] [PATCH ovn 4/9] release-process: State release policy for LTS versions.

2023-05-25 Thread Mark Michelson
The definition of "regular releases" is being kept purposely vague in this commit because a later commit will define what the interval is for these releases. Signed-off-by: Mark Michelson --- Documentation/internals/release-process.rst | 7 --- 1 file changed, 4 insertions(+), 3

[ovs-dev] [PATCH ovn 1/9] release-process: Use more accurate example releases.

2023-05-25 Thread Mark Michelson
We don't use a four-digit major version, just the final two digits of the year. Signed-off-by: Mark Michelson --- Documentation/internals/release-process.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/internals/release-process.rst

[ovs-dev] [PATCH ovn 3/9] release-policy: Change "release" to "version" in LTS section.

2023-05-25 Thread Mark Michelson
Upcoming changes to the documentation will add documentation for standard term support versions and will document a policy for when releases are made for these versions. Our current use of "release" in the documentation is interchangeable with "version" but upcoming changes will differentiate

[ovs-dev] [PATCH ovn 2/9] release-process: Switch to two releases per year.

2023-05-25 Thread Mark Michelson
Based on discussions that have occurred on the development mailing list and public IRC meetings, we have decided to reduce OVN to having two releases per year instead of four. When OVN initially spun off from OVS, the amount of feature requests and performance improvements were happening at a

[ovs-dev] [PATCH ovn 0/9] OVN Release Policy Updates

2023-05-25 Thread Mark Michelson
The current state of development in OVN has resulted in many discussions happening about how things should change. The main points of the discussions have been: * Recent releases have been much more bare than releases made two or three years ago. * Supporting as many versions of OVN as we have

Re: [ovs-dev] [PATCH v12] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-05-25 Thread Ilya Maximets
On 5/25/23 15:37, Balazs Nemeth wrote: > The only way that stats->{n_packets,n_bytes} would decrease is due to an > overflow, or if there are bugs in how statistics are handled. In the > past, there were multiple issues that caused a jump backward. A > workaround was in place to set the statistics

Re: [ovs-dev] [PATCH v5 0/3] Support flowlabel calculation in SRv6 tunnels

2023-05-25 Thread Ilya Maximets
On 5/23/23 05:58, Nobuhiro MIKI wrote: > This patchset adds a feature to support the calculation of flowlabel in > SRv6 tunnels. > > v5: > * Write netdev_srv6_flowlabel enum to ipv6 flowlabel in header build. > * Fix docs. > * Add tests for the same flow. > v4: > * Set flowlabel on header push. >

Re: [ovs-dev] [PATCH 3/3] netdev-vport: RCU-fy tunnel config.

2023-05-25 Thread Ilya Maximets
On 5/25/23 13:51, Simon Horman wrote: > On Sat, May 20, 2023 at 02:31:20AM +0200, Ilya Maximets wrote: >> Tunnel config can be accessed by multiple threads at the same time and >> it is supposed to be protected by the netdev_vport mutex. However, >> many functions are getting direct access to it

Re: [ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

2023-05-25 Thread Brian Haley
Sorry for the top post, but I was wondering if there was a way to re-trigger the bot testing action on a patch? Somehow the testing on the v2 one failed even though v1 passed [0]. Since the only change was in the commit message seems it could just be a flaky test? Unless I'm missing something.

[ovs-dev] [PATCH ovn] ovn-controller.c: Fix assertion failure during address set update.

2023-05-25 Thread Han Zhou
When an address set is deleted and a new one is created immediately with the same name, the OVSDB deletion and creation notifications can come to ovn-controller within the same message, and the order of the deletion and addition in the IDL is undefined. In this case, if the deletion happens to be

Re: [ovs-dev] [PATCH v4] ovs-ofctl:'--bundle' option can be used with OpenFlow 1.3

2023-05-25 Thread Mike Pattrick
On Fri, Nov 4, 2022 at 2:24 AM yangchang wrote: > > From the commit 25070e045e, bundle option can be used with OpenFlow 1.3 > > Signed-off-by: yangchang Re-adding an explicit ack. From a quick search, it looks like bundles weren't included in the original OF1.3 spec, but were included in

Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Dan Williams
On Thu, 2023-05-25 at 08:38 -0500, Dan Williams wrote: > On Wed, 2023-05-24 at 11:12 +0200, Ihtisham ul Haq via dev wrote: > > Using cache improves performance of recomputation of lflows(by > > about 30%) > > > > Exising lflow cache for `matches` and `expressions` is adopted > > to include

Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Dan Williams
On Wed, 2023-05-24 at 11:12 +0200, Ihtisham ul Haq via dev wrote: > Using cache improves performance of recomputation of lflows(by > about 30%) > > Exising lflow cache for `matches` and `expressions` is adopted > to include `actions` as well. > > Co-authored-by: Felix Huettner > Signed-off-by:

[ovs-dev] [PATCH v12] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-05-25 Thread Balazs Nemeth
The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Simon Horman
On Wed, May 24, 2023 at 11:12:28AM +0200, Ihtisham ul Haq via dev wrote: > Using cache improves performance of recomputation of lflows(by > about 30%) > > Exising lflow cache for `matches` and `expressions` is adopted > to include `actions` as well. > > Co-authored-by: Felix Huettner >

Re: [ovs-dev] [PATCH 1/2] stream-ssl: Disable alerts on unexpected EOF.

2023-05-25 Thread Simon Horman
On Wed, May 17, 2023 at 06:51:04PM +0200, Ilya Maximets wrote: > OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed > to alert the application whenever the connection terminated without > a proper close_notify. And that should allow applications to take > actions to protect

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-25 Thread Simon Horman
On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: > Many OVSDB tests are not checking the server log for warnings or > errors. Some are not even using the log file. It's mostly OK as we're > usually checking the user-visible behavior. But it would also be nice > to detect some

[ovs-dev] [PATCH v2] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-25 Thread Frode Nordahl
The bareudp tests depend on specific kernel configuration to succeed. Skip the test if the feature is not enabled in the running kernel. Signed-off-by: Frode Nordahl --- tests/system-kmod-macros.at | 10 ++ tests/system-layer3-tunnels.at | 4 ++--

Re: [ovs-dev] [PATCH] ovsdb: condition: Process condition changes incrementally.

2023-05-25 Thread Simon Horman
On Thu, May 18, 2023 at 02:14:25PM +0200, Ilya Maximets wrote: > In most cases, after the condition change request, the new condition > is the same as old one plus minus a few clauses. Today, ovsdb-server > will evaluate every database row against all the old clauses and then > against all the

Re: [ovs-dev] [PATCH 3/3] netdev-vport: RCU-fy tunnel config.

2023-05-25 Thread Simon Horman
On Sat, May 20, 2023 at 02:31:20AM +0200, Ilya Maximets wrote: > Tunnel config can be accessed by multiple threads at the same time and > it is supposed to be protected by the netdev_vport mutex. However, > many functions are getting direct access to it via netdev API without > taking the mutex,

Re: [ovs-dev] [PATCH 2/3] smap: Make argument of smap_add_ipv6 constant.

2023-05-25 Thread Simon Horman
On Sat, May 20, 2023 at 02:31:19AM +0200, Ilya Maximets wrote: > The address is not getting modified inside. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 1/3] netdev-vport: Fix unsafe handling of GRE sequence number.

2023-05-25 Thread Simon Horman
On Sat, May 20, 2023 at 02:31:18AM +0200, Ilya Maximets wrote: > GRE sequence number is maintained as part of the tunnel config. > This triggers tunnel reconfiguration every time set_tunnel_config() > is called, because memset over tunnel config will never be equal to > the new config constructed

Re: [ovs-dev] [PATCH] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-25 Thread Ilya Maximets
On 5/25/23 09:19, Simon Horman wrote: > On Wed, May 24, 2023 at 09:23:59PM +0200, Ilya Maximets wrote: >> On 5/24/23 15:39, Frode Nordahl wrote: >>> The bareudp tests depend on specific kernel configuration to >>> succeed. Skip the test if the feature is not enabled in the >>> running kernel. >>>

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

2023-05-25 Thread Ales Musil
On Thu, May 25, 2023 at 10:37 AM Dumitru Ceara wrote: > Whenever an OpenFlow error is returned by OvS, trigger a reconnect of > the OpenFlow (rconn) connection. This will clear any installed OpenFlow > rules/groups. To ensure consistency, trigger a full I-P recompute too. > > An example of

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

2023-05-25 Thread Simon Horman
On Thu, May 25, 2023 at 10:37:23AM +0200, Dumitru Ceara wrote: > Whenever an OpenFlow error is returned by OvS, trigger a reconnect of > the OpenFlow (rconn) connection. This will clear any installed OpenFlow > rules/groups. To ensure consistency, trigger a full I-P recompute too. > > An example

Re: [ovs-dev] [PATCH] userspace: modify the width of tpa and spa

2023-05-25 Thread Simon Horman
On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote: > Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. > > Signed-off-by: yangchang Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v11] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-05-25 Thread Simon Horman
On Thu, May 25, 2023 at 10:58:36AM +0200, Balazs Nemeth wrote: > The only way that stats->{n_packets,n_bytes} would decrease is due to an > overflow, or if there are bugs in how statistics are handled. In the > past, there were multiple issues that caused a jump backward. A > workaround was in

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Check rx/tx descriptor sizes for device.

2023-05-25 Thread Kevin Traynor
On 24/05/2023 19:15, Ilya Maximets wrote: On 5/16/23 13:59, Kevin Traynor wrote: By default OVS configures 2048 descriptors for tx and rx queues on DPDK devices. It also allows the user to configure those values. If the values used are not acceptable to the device then queue setup would fail.

[ovs-dev] [PATCH] userspace: modify the width of tpa and spa

2023-05-25 Thread yangchang
Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. Signed-off-by: yangchang --- lib/meta-flow.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml index a1a2036..bdd12f6 100644 --- a/lib/meta-flow.xml +++

Re: [ovs-dev] [PATCH v10] netdev-dpdk: add control plane protection support

2023-05-25 Thread Robin Jarry
Hey Ilya, Ilya Maximets, May 24, 2023 at 17:05: > I had a '+' because rss and lacp are two different entities and I looked > at it as a mode of operation. i.e. RSS plus special handling for LACP. > RSS looks strange in a comma-separated list, IMO. For now, there is only LACP but if other

[ovs-dev] [PATCH v11] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-05-25 Thread Balazs Nemeth
The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

Re: [ovs-dev] [PATCH ovn v7 0/5] Implement MTU Path Discovery for multichassis ports

2023-05-25 Thread Ales Musil
On Tue, May 23, 2023 at 11:56 PM Ihar Hrachyshka wrote: > This series fixes a non-optimal behavior with some multichassis ports. > > Specifically, > > - when a multichassis port belongs to a switch that also has a localnet > port, > - because ingress and egress traffic for the port is

Re: [ovs-dev] [PATCH v10] netdev-dpdk: add control plane protection support

2023-05-25 Thread Kevin Traynor
On 24/05/2023 16:05, Robin Jarry wrote: Kevin Traynor, May 24, 2023 at 16:54: The "rss" item should be mandatory anyway. There should be no way to disable it. I assume that it is what Ilya meant with these "+" symbols. That would leave us with these examples: # lacp+bfd on separate queue, rss

[ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

2023-05-25 Thread Dumitru Ceara
Whenever an OpenFlow error is returned by OvS, trigger a reconnect of the OpenFlow (rconn) connection. This will clear any installed OpenFlow rules/groups. To ensure consistency, trigger a full I-P recompute too. An example of scenario that can result in an OpenFlow error returned by OvS follows

Re: [ovs-dev] [PATCH] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-25 Thread Simon Horman
On Wed, May 24, 2023 at 09:23:59PM +0200, Ilya Maximets wrote: > On 5/24/23 15:39, Frode Nordahl wrote: > > The bareudp tests depend on specific kernel configuration to > > succeed. Skip the test if the feature is not enabled in the > > running kernel. > > > > Signed-off-by: Frode Nordahl > >

Re: [ovs-dev] [PATCH v4] backtrace: Extend the backtrace functionality

2023-05-25 Thread Ales Musil
On Wed, May 24, 2023 at 8:31 PM Ilya Maximets wrote: > On 5/19/23 09:36, Ales Musil wrote: > > Use the backtrace functions that is provided by libc, > > this allows us to get backtrace that is independent of > > the current memory map of the process. Which in turn can > > be used for

[ovs-dev] [PATCH v5] backtrace: Extend the backtrace functionality

2023-05-25 Thread Ales Musil
Use the backtrace functions that is provided by libc, this allows us to get backtrace that is independent of the current memory map of the process. Which in turn can be used for debugging/tracing purpose. The backtrace is not 100% accurate due to various optimizations, most notably

Re: [ovs-dev] [PATCH ovn] northd: Fix address set incremental processing

2023-05-25 Thread Ales Musil
On Wed, May 24, 2023 at 1:11 PM Ilya Maximets wrote: > On 5/23/23 10:09, Ales Musil wrote: > > The incremental processing is broken for addresses > > that have mask which could "erase" portion of the address > > itself e.g. 10.16.0.47/4, after applying the mask with token > > parser the address

[ovs-dev] [PATCH ovn v2] northd: Fix address set incremental processing

2023-05-25 Thread Ales Musil
The incremental processing is broken for addresses that have mask which could "erase" portion of the address itself e.g. 10.16.0.47/4, after applying the mask with token parser the address becomes 0.0.0.0/4, which is fine for logical flows. However, for the deletion/addition to database we need