Re: [ovs-dev] [PATCH ovn 1/2] ovn-northd.c: Omit unused columns in SB_Global.

On Mon, Jun 12, 2023 at 11:05 AM Mark Michelson wrote: > > Hi Han, > > Acked-by: Mark Michelson > > I like the changes, but I don't like that patch 1 on its own results in > breaking CI. > > To whoever merges this, I suggest reversing the order of the patches. > This way CI is likely to succeed

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: fix dpif_netdev_flow_put

Hi, Simon, I guess it's not related, as my patch fixes the code in dpif-netdev.c it should has any impact on the ovsdb side. But I am not sure that. Is this test case a spike test case? Is there any testsuite log? Simon Horman 于2023年6月12日周一 22:47写道： > On Mon, Jun 12, 2023 at 02:10:17AM +,

Re: [ovs-dev] [PATCH v2] seq: Make read of the current value atomic

On 6/8/23 16:48, Simon Horman wrote: > On Mon, Jun 05, 2023 at 03:39:02PM +0200, Eelco Chaudron wrote: >> Make the read of the current seq->value atomic, i.e., not needing to >> acquire the global mutex when reading it. On 64-bit systems, this >> incurs no overhead, and it will avoid the mutex and

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On 6/12/23 22:58, Robin Jarry wrote: > Ilya Maximets, Jun 12, 2023 at 21:53: >> The build-aux/initial-tab-allowed-files seems to list most of the >> non-conventionally styled files. > > I'll have a look there. Thanks. > >> Some files with different styles are in the same subtree, so describing

Re: [ovs-dev] [PATCH v2] Add editorconfig file

Ilya Maximets, Jun 12, 2023 at 21:53: > The build-aux/initial-tab-allowed-files seems to list most of the > non-conventionally styled files. I'll have a look there. Thanks. > Some files with different styles are in the same subtree, so describing > at the root sounds better. Ack. > Well,

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: fix dpif_netdev_flow_put

On 6/12/23 16:47, Simon Horman wrote: > On Mon, Jun 12, 2023 at 02:10:17AM +, Peng He wrote: >> OVS allows overlapping megaflows, as long as the actions of these >> megaflows are equal. However, the current implementation of action >> modification relies on flow_lookup instead of ufid, this

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On 6/12/23 20:29, Robin Jarry wrote: > Hi Ilya, > > Ilya Maximets, Jun 12, 2023 at 17:47: >> I'm a bit concerned that this patch is applying the same config >> to all the .c|.h files in the repo while not all of them have >> the same coding style. The most obvious is that linux headers >> are

Re: [ovs-dev] [RFC v2 ovn] northd: sync lb applied to logical routers in sb db lb table

Hi Lorenzo, In the first version, Ilya mentioned that changing a column in the DB was not allowed. However, I think that having columns "datapath_group" and "lr_datapath_group" is not intuitive. This is especially true since ovn-sb.xml does not note that "datapath_group" only refers to

Re: [ovs-dev] [PATCH v2] Add editorconfig file

Hi Ilya, Ilya Maximets, Jun 12, 2023 at 17:47: > I'm a bit concerned that this patch is applying the same config > to all the .c|.h files in the repo while not all of them have > the same coding style. The most obvious is that linux headers > are using tabs, not spaces. Not so obvious - sFlow

Re: [ovs-dev] [PATCH ovn 1/2] ovn-northd.c: Omit unused columns in SB_Global.

Hi Han, Acked-by: Mark Michelson I like the changes, but I don't like that patch 1 on its own results in breaking CI. To whoever merges this, I suggest reversing the order of the patches. This way CI is likely to succeed after patch 1 and will definitely succeed after patch 2. This is

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Add support for DHCPv6 FQDN option

Because the FDB aging series went in, there was a small merge conflict when trying to apply this patch. I updated the ovn-sb.xml version to "20.27.4" instead of "20.27.3". I applied this patch to main. Thanks Ales! On 6/9/23 15:15, Mark Michelson wrote: Thanks for the changes Ales.

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On 6/12/23 17:15, Eelco Chaudron wrote: > > > On 12 Jun 2023, at 17:07, Mike Pattrick wrote: > >> On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: >>> >>> >>> >>> On 12 Jun 2023, at 15:11, Mike Pattrick wrote: >>> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > >

[ovs-dev] [RFC v2 ovn] northd: sync lb applied to logical routers in sb db lb table

Introduce lr_datapath_group column in the load_balancer table of the SB db. Sync load_balancers applied to logical_routers to Load_Balancer table in the SouthBound database. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2193323 Signed-off-by: Lorenzo Bianconi --- Changes since RFC v1:

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On 12 Jun 2023, at 17:07, Mike Pattrick wrote: > On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: >> >> >> >> On 12 Jun 2023, at 15:11, Mike Pattrick wrote: >> >>> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: EditorConfig is a file format and collection of text editor

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: > > > > On 12 Jun 2023, at 15:11, Mike Pattrick wrote: > > > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > >> > >> EditorConfig is a file format and collection of text editor plugins for > >> maintaining consistent coding styles

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

Simon Horman writes: > On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote: > > ... > >> >> We moved the per cpu upcall counter allocation to the existing vport >> >> alloc and free functions to solve this. >> >> >> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on

Re: [ovs-dev] [PATCH v2] Add editorconfig file

Hi Mike, Eelco, Eelco Chaudron, Jun 12, 2023 at 16:54: > I also like the idea, but the editoconfig does not seem to bring much > to the table for C. And it looks like there is not much activity on > the project. It might be better to look at clang-format, however, this > is c/c++ specific. > >

Re: [ovs-dev] [PATCH v2] ovs-save: add bindir to PATH

On Fri, Jun 17, 2022 at 05:03:46PM +0200, Adrian Moreno wrote: > If openvswitch is not installed in the default system's path ovs-save > script will fail to find the tools it requires. > > Fix this by adding $bindir to the PATH. > Refactor common path calculation into ovs-lib. > > Signed-off-by:

Re: [ovs-dev] [PATCH v3] conntrack: Extract l4 information for SCTP.

Paolo Valerio writes: > since a27d70a89 ("conntrack: add generic IP protocol support") all > the unrecognized IP protocols get handled using ct_proto_other ops > and are managed as L3 using 3 tuples. > > This patch stores L4 information for SCTP in the conn_key so that > multiple conn instances,

Re: [ovs-dev] [PATCH v11 4/8] ovsdb: Assert and check return values of `ovsdb_table_schema_get_column`

On Mon, Jun 05, 2023 at 01:30:03AM +0800, James Raphael Tiovalen wrote: > This commit adds a few null pointer assertions and checks to some return > values of `ovsdb_table_schema_get_column`. If a null pointer is > encountered in these blocks, either the assertion will fail or the > control flow

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On 12 Jun 2023, at 15:11, Mike Pattrick wrote: > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: >> >> EditorConfig is a file format and collection of text editor plugins for >> maintaining consistent coding styles between different editors and IDEs. >> >> Initialize the file following the

Re: [ovs-dev] [PATCH v3] rhel: make the version, displayed to the user, customizable

Timothy Redaelli writes: > Since on CentOS/RHEL the builds are based on stable branches and not on > tags for debugging purpose it's better to have the downstream version as > version so it's easier to know which commits are included in a build. > > This commit adds --with-version-suffix as

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: fix dpif_netdev_flow_put

On Mon, Jun 12, 2023 at 02:10:17AM +, Peng He wrote: > OVS allows overlapping megaflows, as long as the actions of these > megaflows are equal. However, the current implementation of action > modification relies on flow_lookup instead of ufid, this could result > in looking up a wrong megaflow

Re: [ovs-dev] [PATCH v2] netdev-linux: fix memory leak in qos

On Mon, Jun 12, 2023 at 4:39 AM 张祖建 wrote: > > Reported by Valgrind: > > ==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss > record 363 of 408 > ==00:00:00:46.715 951138== at 0x4848899: malloc (in > /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) >

Re: [ovs-dev] [PATCH v2] Add editorconfig file

On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > > EditorConfig is a file format and collection of text editor plugins for > maintaining consistent coding styles between different editors and IDEs. > > Initialize the file following the coding rules in >

Re: [ovs-dev] [PATCH v3] rhel: make the version, displayed to the user, customizable

On Fri, May 26, 2023 at 10:42 AM Timothy Redaelli wrote: > > Since on CentOS/RHEL the builds are based on stable branches and not on > tags for debugging purpose it's better to have the downstream version as > version so it's easier to know which commits are included in a build. > > This commit

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

On 6/7/23 12:23, Ilya Maximets wrote: > On 6/7/23 00:48, Han Zhou wrote: >> >> >> On Tue, Jun 6, 2023 at 3:08 PM Ilya Maximets > > wrote: >>> >>> On 6/6/23 22:12, Han Zhou wrote: On Tue, Jun 6, 2023 at 12:10 PM Ilya Maximets >>>

Re: [ovs-dev] [PATCH net-next] net: openvswitch: add support for l4 symmetric hashing

Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 9 Jun 2023 09:59:55 -0400 you wrote: > Since its introduction, the ovs module execute_hash action allowed > hash algorithms other than the skb->l4_hash to be used. However, > additional hash algorithms

[ovs-dev] [PATCH v2] netdev-linux: fix memory leak in qos

Reported by Valgrind: ==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss record 363 of 408 ==00:00:00:46.715 951138== at 0x4848899: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==00:00:00:46.715 951138== by 0x278E98: xmalloc__ (util.c:140)

Re: [ovs-dev] [PATCH ovn v2 1/2] tests: add make check-system-dpdk to test suite.

On 9 Jun 2023, at 17:08, Ilya Maximets wrote: > On 6/9/23 16:40, Eelco Chaudron wrote: >> Allow the ovn-system tests to run on the OVS-DPDK infrastructure, >> i.e., DPDK ports and mbuf memory. >> >> Co-authored-by: David Marchand >> Signed-off-by: David Marchand >> Signed-off-by: Eelco