Re: [ovs-dev] RFC testsuite: fmt_pkt performance improvements

2023-06-22 Thread Dumitru Ceara
On 6/9/23 18:19, Ihar Hrachyshka wrote: > This thread is to discuss improvements that would allow OVN (and maybe > OVS?) to adopt fmt_pkt (frontend to scapy packet constructor) in the test > suite. > > (For those not aware of what it is, please consult this commit: > >

Re: [ovs-dev] [PATCH v5] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-22 Thread Eelco Chaudron
On 9 Jun 2023, at 17:05, Mike Pattrick wrote: > Several xlate actions used in recursive translation currently store a > large amount of information on the stack. This can result in handler > threads quickly running out of stack space despite before > xlate_resubmit_resource_check() is able to

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-22 Thread Aaron Conole
Dumitru Ceara writes: > On 6/22/23 13:56, Aaron Conole wrote: >> Dumitru Ceara writes: >> >>> This avoids manual intervention when upstream ovn-kubernetes changes >>> its dependency versions. >>> >>> Signed-off-by: Patryk Diak >>> Co-authored-by: Patryk Diak >>> Signed-off-by: Dumitru Ceara

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Kevin Traynor
On 22/06/2023 14:06, Kevin Traynor wrote: On 21/06/2023 20:24, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Robin Jarry
Hi Kevin, Kevin Traynor, Jun 22, 2023 at 15:06: > Hi Robin, > > As discussed offline, the issue is fixed in v12. In the case where > offload has failed on device A, and device B triggers set_config the > set_config for device B will see that device B has the correct number of > queues

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Kevin Traynor
On 21/06/2023 20:24, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-22 Thread Dumitru Ceara
On 6/22/23 14:45, Dumitru Ceara wrote: > On 6/22/23 13:56, Aaron Conole wrote: >> Dumitru Ceara writes: >> >>> This avoids manual intervention when upstream ovn-kubernetes changes >>> its dependency versions. >>> >>> Signed-off-by: Patryk Diak >>> Co-authored-by: Patryk Diak >>> Signed-off-by:

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-22 Thread Dumitru Ceara
On 6/22/23 13:56, Aaron Conole wrote: > Dumitru Ceara writes: > >> This avoids manual intervention when upstream ovn-kubernetes changes >> its dependency versions. >> >> Signed-off-by: Patryk Diak >> Co-authored-by: Patryk Diak >> Signed-off-by: Dumitru Ceara >> --- > > LGTM overall. It's

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-06-22 Thread Eelco Chaudron
On 22 Jun 2023, at 13:29, Ilya Maximets wrote: > On 6/22/23 11:30, Eelco Chaudron wrote: >> >> >> On 22 Jun 2023, at 11:15, Ilya Maximets wrote: >> >>> On 6/22/23 10:50, Eelco Chaudron wrote: On 30 May 2023, at 9:32, Eelco Chaudron wrote: > On 26 May 2023, at 22:51, Ilya

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-22 Thread Aaron Conole
Dumitru Ceara writes: > This avoids manual intervention when upstream ovn-kubernetes changes > its dependency versions. > > Signed-off-by: Patryk Diak > Co-authored-by: Patryk Diak > Signed-off-by: Dumitru Ceara > --- LGTM overall. It's also the only patch to have successfully built

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-06-22 Thread Ilya Maximets
On 6/22/23 11:30, Eelco Chaudron wrote: > > > On 22 Jun 2023, at 11:15, Ilya Maximets wrote: > >> On 6/22/23 10:50, Eelco Chaudron wrote: >>> >>> >>> On 30 May 2023, at 9:32, Eelco Chaudron wrote: >>> On 26 May 2023, at 22:51, Ilya Maximets wrote: > On 5/26/23 15:09, Eelco

Re: [ovs-dev] [PATCH v1] dpif-netdev: Update meter timestamp when dp_netdev_run_meter been called.

2023-06-22 Thread miter
Hi Ilya, Thanks for reviewing our code. We have 20+ threads indeed, so taking the same meter lock makes 'now' not updated timely. Using lockless meter to police traffic will be a perfect solution. :) Thanks a lot. On 6/22/2023 6:35 AM, Ilya Maximets wrote: On 6/21/23 18:07, Ilya Maximets

Re: [ovs-dev] [PATCH v2 2/2] debian: Run system testsuites as autopkgtest.

2023-06-22 Thread Frode Nordahl
On Tue, Jun 20, 2023 at 6:09 PM Ilya Maximets wrote: > > On 6/20/23 10:08, Frode Nordahl wrote: > > The autopkgtests [0][1] are relevant in an upstream context > > because an Open vSwitch contributor may want to have a quick > > way of running the upstream system testsuites on recent > >

Re: [ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-22 Thread Frode Nordahl
On Tue, Jun 20, 2023 at 6:03 PM Ilya Maximets wrote: > > On 6/20/23 16:13, Frode Nordahl wrote: > > On Tue, Jun 20, 2023 at 3:44 PM Ilya Maximets wrote: > >> > >> On 6/20/23 10:08, Frode Nordahl wrote: > >>> Allow building the upstream Open vSwitch deb package with AF_XDP > >>> datapath enabled

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-06-22 Thread Eelco Chaudron
On 22 Jun 2023, at 11:15, Ilya Maximets wrote: > On 6/22/23 10:50, Eelco Chaudron wrote: >> >> >> On 30 May 2023, at 9:32, Eelco Chaudron wrote: >> >>> On 26 May 2023, at 22:51, Ilya Maximets wrote: >>> On 5/26/23 15:09, Eelco Chaudron wrote: > > > On 26 May 2023, at 14:03,

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-06-22 Thread Ilya Maximets
On 6/22/23 10:50, Eelco Chaudron wrote: > > > On 30 May 2023, at 9:32, Eelco Chaudron wrote: > >> On 26 May 2023, at 22:51, Ilya Maximets wrote: >> >>> On 5/26/23 15:09, Eelco Chaudron wrote: On 26 May 2023, at 14:03, Balazs Nemeth wrote: > The only way that

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-06-22 Thread Eelco Chaudron
On 30 May 2023, at 9:32, Eelco Chaudron wrote: > On 26 May 2023, at 22:51, Ilya Maximets wrote: > >> On 5/26/23 15:09, Eelco Chaudron wrote: >>> >>> >>> On 26 May 2023, at 14:03, Balazs Nemeth wrote: >>> The only way that stats->{n_packets,n_bytes} would decrease is due to an

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Reduce size of the SB monitor condition.

2023-06-22 Thread Dumitru Ceara
On 6/21/23 16:50, Han Zhou wrote: > On Wed, Jun 21, 2023 at 2:48 AM Dumitru Ceara wrote: >> >> We don't need to explicitly add port bindings that were already bound >> locally. We implicitly get those because we monitor the datapaths >> they're attached to. >> >> When performing an ovn-heater