Re: [ovs-dev] [PATCH net-next v2] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Eelco Chaudron
On 21 Sep 2023, at 21:42, Ilya Maximets wrote: > do_execute_actions() function can be called recursively multiple > times while executing actions that require pipeline forking or > recirculations. It may also be re-entered multiple times if the packet > leaves openvswitch module and re-enters

Re: [ovs-dev] [PATCH net-next v2] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Eelco Chaudron
On 21 Sep 2023, at 21:42, Ilya Maximets wrote: > do_execute_actions() function can be called recursively multiple > times while executing actions that require pipeline forking or > recirculations. It may also be re-entered multiple times if the packet > leaves openvswitch module and re-enters

Re: [ovs-dev] OVN weekly community meeting

2023-09-21 Thread Ihar Hrachyshka
+1 to the idea, and I'd recommend having someone take public notes during the calls. If the slot will fit my schedule, I can take this role unless someone else is willing to do it. Ihar On Thu, Sep 21, 2023 at 11:25 AM Dumitru Ceara wrote: > Hi all, > > As you probably know and as the ovn.org w

Re: [ovs-dev] [PATCH net-next v2] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Eric Dumazet via dev
On Thu, Sep 21, 2023 at 9:42 PM Ilya Maximets wrote: > > do_execute_actions() function can be called recursively multiple > times while executing actions that require pipeline forking or > recirculations. It may also be re-entered multiple times if the packet > leaves openvswitch module and re-en

Re: [ovs-dev] Build Issue with OVN 23.09 on Ubuntu 22.04

2023-09-21 Thread Frode Nordahl
Hello, Bram, tor. 21. sep. 2023, 20:44 skrev Bram Kranendonk via dev < ovs-dev@openvswitch.org>: > Hello OVS/OVN Developers, > > > I hope this message finds you well. I am reaching out to report an issue I > encountered while trying to build OVN version 23.09 on Ubuntu 22.04. > > > > I’ve execute

[ovs-dev] [PATCH net-next v2] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Ilya Maximets
do_execute_actions() function can be called recursively multiple times while executing actions that require pipeline forking or recirculations. It may also be re-entered multiple times if the packet leaves openvswitch module and re-enters it through a different port. Currently, there is a 256-byt

Re: [ovs-dev] [PATCH net-next] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Ilya Maximets
On 9/21/23 21:08, Eric Dumazet wrote: > On Thu, Sep 21, 2023 at 9:03 PM Ilya Maximets wrote: >> >> do_execute_actions() function can be called recursively multiple >> times while executing actions that require pipeline forking or >> recirculations. It may also be re-entered multiple times if the

Re: [ovs-dev] [PATCH net-next] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Eric Dumazet via dev
On Thu, Sep 21, 2023 at 9:03 PM Ilya Maximets wrote: > > do_execute_actions() function can be called recursively multiple > times while executing actions that require pipeline forking or > recirculations. It may also be re-entered multiple times if the packet > leaves openvswitch module and re-en

[ovs-dev] [PATCH net-next] openvswitch: reduce stack usage in do_execute_actions

2023-09-21 Thread Ilya Maximets
do_execute_actions() function can be called recursively multiple times while executing actions that require pipeline forking or recirculations. It may also be re-entered multiple times if the packet leaves openvswitch module and re-enters it through a different port. Currently, there is a 256-byt

[ovs-dev] Build Issue with OVN 23.09 on Ubuntu 22.04

2023-09-21 Thread Bram Kranendonk via dev
Hello OVS/OVN Developers, I hope this message finds you well. I am reaching out to report an issue I encountered while trying to build OVN version 23.09 on Ubuntu 22.04. I’ve executed the following steps to try to build the OVN .debs: # Clone OVN git clone https://github.com/ovn-org/ovn.gi

Re: [ovs-dev] OVN weekly community meeting

2023-09-21 Thread Mark Michelson
On 9/21/23 13:24, Han Zhou wrote: On Thu, Sep 21, 2023 at 8:25 AM Dumitru Ceara > wrote: > > Hi all, > > As you probably know and as the ovn.org website mentions [0] we have > weekly OVN IRC meetings, in #openvswitch on irc.libera.chat (the time i

Re: [ovs-dev] OVN weekly community meeting

2023-09-21 Thread Han Zhou
On Thu, Sep 21, 2023 at 8:25 AM Dumitru Ceara wrote: > > Hi all, > > As you probably know and as the ovn.org website mentions [0] we have > weekly OVN IRC meetings, in #openvswitch on irc.libera.chat (the time is > slightly wrong but that's a different issue [1]). > > In my opinion these meetings

[ovs-dev] OVN weekly community meeting

2023-09-21 Thread Dumitru Ceara
Hi all, As you probably know and as the ovn.org website mentions [0] we have weekly OVN IRC meetings, in #openvswitch on irc.libera.chat (the time is slightly wrong but that's a different issue [1]). In my opinion these meetings are useful because we (well, anyone interested) can share status upd

Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-09-21 Thread Xavier Simonart
Hi Mark Thanks for the review. See comments below. Thanks Xavier On Tue, Sep 19, 2023 at 5:29 PM Mark Michelson wrote: > Thanks for the patch set Xavier. > > With the exception of patch 13: > > Acked-by: Mark Michelson > > I'm acking the patch set, but the nature of these changes worries me.

[ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-21 Thread Lorenzo Bianconi
Introduce the capability to split multicast group openflow actions created in consider_mc_group routine in multiple buffers if the single buffer size is over netlink buffer size limits. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2232152 Signed-off-by: Lorenzo Bianconi --- controlle

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:46, Ilya Maximets wrote: > On 9/15/23 05:02, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all dimensions. >> >> Signed-off-by

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:32, Ilya Maximets wrote: > On 9/20/23 13:06, Simon Horman wrote: >> On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: >>> A conjunctive flow consists of two or more multiple flows with >>> conjunction actions. When input to the ofproto/trace command >>> matches a conju

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 20:06, Simon Horman wrote: > On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all dimensio

Re: [ovs-dev] [PATCH ovn] Rename scapy-server into scapy-server.py

2023-09-21 Thread Dumitru Ceara
On 9/20/23 17:12, Mark Michelson wrote: > I tested this locally and it cleared up the error I had seen before. > > Acked-by: Mark Michelson > Thanks, Ihar and Mark, for fixing up the CI. I pushed this to main and all stable branches. The unit tests had passed in my fork on all of these, let's

Re: [ovs-dev] [PATCH v2 1/2] flow: Add list node for the conjunctive flow.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:31, Ilya Maximets wrote: > On 9/15/23 05:02, Nobuhiro MIKI wrote: >> In subsequent patches, flows need to be grouped in >> a list and treated as a conjunctive flow. >> >> Signed-off-by: Nobuhiro MIKI > > Hi. Thanks for the patch! > See some comments below. > >> --- >> include/