On 7 Oct 2023, at 10:37, James Raphael Tiovalen wrote:
> This commit adds a non-exhaustive list of tests for some of the
> functions declared in `lib/byteq`.
>
> These unit tests have been executed via `make check` and they
> successfully passed.
>
> Acked-by: Simon Horman
> Signed-off-by: Jam
On 10/12/23 23:39, Mark Michelson wrote:
> On 10/9/23 11:15, Dumitru Ceara wrote:
>> On 9/18/23 18:46, Xavier Simonart wrote:
>>> When l3gateway ports get added, ct_zones were assigned during
>>> (ct_zones) recomputes, but not by I+P.
>>> Before this patch, test "Migration of CT zone from UUID to n
On 10/9/23 11:15, Dumitru Ceara wrote:
On 9/18/23 18:46, Xavier Simonart wrote:
When l3gateway ports get added, ct_zones were assigned during
(ct_zones) recomputes, but not by I+P.
Before this patch, test "Migration of CT zone from UUID to name"
was randomly failing, as ct_zone was not assigned
I've reviewed the series. Most of the patches are good to go, but 1)
HAVE_SCAPY macro should be applied and 2) see replies to some of the
patches with suggestions. Let me know if this was helpful.
Ihar
On Tue, Oct 10, 2023 at 8:37 PM Ihar Hrachyshka wrote:
> Thanks a lot for the series! I will
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> ...passthru=true, ND/NA responder disabled.
>
> Note that in order to be able to get the solicited node multicast
> address, we need access to the socket library. This commit imports the
>
Would scapy.utils6.in6_getLinkScopedMcastAddr serve
On 10/12/23 19:51, Mark Michelson wrote:
> Thanks Dumitru and Xavier.
>
> Acked-by: Mark Michelson
>
Thanks, Mark and Ihar, for the reviews!
I pushed this to main and backported it to 23.09, 23.06 and 23.03. I
didn't go further back because of conflicts. That's probably fine
though because t
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> This test is slower than it used to be since some of the test_ip calls
> that were backgrounded (with '&') cannot do this anymore. This is
> because there is a race condition with starting the scapy server when
> the calls are backgrounded.
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> ...passthru=true, ARP responder disabled
>
> Execution time: 2.466s
> Execution time on "main" branch: 1.751s
>
> Signed-off-by: Mark Michelson
> ---
> tests/ovn.at | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>
Thanks, all good.
Reviewed-By: Ihar Hrachyshka
On Wed, Oct 11, 2023 at 9:23 AM Dumitru Ceara wrote:
> Simulated chassis are added with ovn_attach(), ovn_az_attach() and
> start_virtual_controller(). Wait for ovn-controllers to register in the
> Southbound (create their Encap record) before co
Thanks Dumitru and Xavier.
Acked-by: Mark Michelson
On 10/11/23 09:22, Dumitru Ceara wrote:
Simulated chassis are added with ovn_attach(), ovn_az_attach() and
start_virtual_controller(). Wait for ovn-controllers to register in the
Southbound (create their Encap record) before continuing. Tha
Frode Nordahl writes:
> On Tue, Oct 3, 2023 at 9:06 PM Aaron Conole wrote:
>>
>> The conntrack cleanup and allocation code is spread across multiple
>> list invocations. This was changed in mainline code when the timeout
>> expiration lists were refactored, but backporting those fixes would
>>
Kevin Traynor, Oct 12, 2023 at 17:34:
ok, 'rss' is documented as default, so maybe we don't need to display if
it is in use by default, selected by user or as fallback.
That would make things a bit easier as 'rx-steering:' is free to use to
indicate the unsupported case.
So maybe status coul
On 12/10/2023 14:06, Jakob Meng wrote:
On 11.10.23 18:48, Kevin Traynor wrote:
On 11/10/2023 11:11, jm...@redhat.com wrote:
From: Jakob Meng
For better usability, the function pairs get_config() and
set_config() for each netdev should be symmetric: Options which are
accepted by set_config() s
On Tue, Oct 03, 2023 at 03:05:57PM -0400, Aaron Conole wrote:
> From: Peng He
>
> The patch avoids the extra allocation for nat_conn.
> Currently, when doing NAT, the userspace conntrack will use an extra
> conn for the two directions in a flow. However, each conn has actually
> the two keys for
On Thu, Oct 12, 2023 at 09:45:05AM +0200, Frode Nordahl wrote:
> On Tue, Oct 3, 2023 at 9:06 PM Aaron Conole wrote:
> >
> > The conntrack cleanup and allocation code is spread across multiple
> > list invocations. This was changed in mainline code when the timeout
> > expiration lists were refact
On 12.10.23 14:15, Kevin Traynor wrote:
> get_status for dpdkvhostuser(/client) netdev class may display
> userspace-tso status.
>
> Fixes: a5669fd51c9b ("netdev-dpdk: Drop TSO in case of conflicting virtio
> features.")
> Signed-off-by: Kevin Traynor
> ---
> vswitchd/vswitch.xml | 3 +++
> 1 fi
On 12.10.23 14:15, Kevin Traynor wrote:
> Add group for dpdkvhostuser(/client) netdev.
>
> Adding as a single group as they display the same status,
> one of which is 'mode' to indicate if it's client or server.
>
> Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_status.")
> Signed-off-by: Ke
On Tue, Oct 10, 2023 at 08:44:17PM +, Ihar Hrachyshka wrote:
> The command receives a flow string and an optional additional payload
> and produces a hex-string representation of the corresponding frame.
>
> The command is datapath-independent and may be useful in tests, where we
> may need to
On 11.10.23 18:48, Kevin Traynor wrote:
> On 11/10/2023 11:11, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for each netdev should be symmetric: Options which are
>> accepted by set_config() should be returned by get_co
get_status for dpdkvhostuser(/client) netdev class may display
userspace-tso status.
Fixes: a5669fd51c9b ("netdev-dpdk: Drop TSO in case of conflicting virtio
features.")
Signed-off-by: Kevin Traynor
---
vswitchd/vswitch.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vswitchd/vswitc
Add group for dpdkvhostuser(/client) netdev.
Adding as a single group as they display the same status,
one of which is 'mode' to indicate if it's client or server.
Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_status.")
Signed-off-by: Kevin Traynor
---
vswitchd/vswitch.xml | 28
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#100 FILE: lib/command-line.c:82:
return o
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if OVS
and OVS-DPDK would expose statistics in a machine-readable format.
Several approaches like UNIX socket, OVSDB queries and JSON output from
ovs-xxx tools have been proposed [0],[1]. This proof of concept
descr
On Tue, Oct 10, 2023 at 10:34 PM Mark Michelson wrote:
>
> ...passthru=true, ND/NA responder disabled.
>
> Note that in order to be able to get the solicited node multicast
> address, we need access to the socket library. This commit imports the
> socket library from python. To reduce the amount o
On Thu, Oct 5, 2023 at 10:24 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Introduce the capability to split multicast group openflow actions
> created in consider_mc_group routine in multiple buffers if the
> single buffer size is over netlink buffer size limits.
>
> Reported-at: ht
On Tue, Oct 3, 2023 at 9:06 PM Aaron Conole wrote:
>
> The conntrack cleanup and allocation code is spread across multiple
> list invocations. This was changed in mainline code when the timeout
> expiration lists were refactored, but backporting those fixes would
> be a rather large effort. Inst
26 matches
Mail list logo
