Re: [ovs-dev] [PATCH 1/2] appveyor: Remove reference to master branch.

Acked-by: Alin Gabriel Serdean > > On 10 Apr 2024, at 16:09, Simon Horman wrote: > > The OvS primary development branch has been renamed main > so there is no longer any need for this CI configuration > to refer to master. > > Signed-off-by: Simon Horman > --- > appveyor.yml | 1 - > 1

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

Ooops , my bad :) Sent from phone > On 8 Apr 2024, at 15:39, Ilya Maximets wrote: > > On 4/8/24 15:29, Alin Serdean wrote: >> >> The spellchecker one: >> https://github.com/openvswitch/ovs/blob/master/utilities/checkpatch.py#L115 >> <https://github.com/o

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

The spellchecker one: https://github.com/openvswitch/ovs/blob/master/utilities/checkpatch.py#L115 I don’t assume so but wanted to verify. > On 8 Apr 2024, at 13:30, Ilya Maximets wrote: > > On 4/8/24 13:26, Alin Serdean wrote: >> >> Just one question: do we have to

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

Just one question: do we have to remove the xenserver reference in the checkpatch.py? Otherwise looks good. Acked-by: Alin Gabriel Serdean > On 8 Apr 2024, at 13:06, Ilya Maximets wrote: > > Remaining bits from the OVS/OVN split. > > Fixes: 1af37d11be73 ("Remove XenServer Code") >

Re: [ovs-dev] [PATCH v2 4/4] appveyor: Build with OpenSSL 3.0.

That’s understandable, I think we should be fine for now and if someone asks for a backport we can address it then. Thank you again for all the work you put into this! Alin > > On 4 Mar 2024, at 23:44, Ilya Maximets wrote: > > On 3/1/24 22:29, Alin Serdean wrote: >> L

Re: [ovs-dev] [PATCH v2 4/4] appveyor: Build with OpenSSL 3.0.

Lgtm. Thank you so much Ilya Acked-by: Alin-Gabriel Serdean > > On 1 Mar 2024, at 22:10, Ilya Maximets wrote: > > OpenSSL 1.0.2u is long deprecated and not available for download. > So, our CI never actually downloads it and uses whatever is in the > OpenSSL-Win64 folder provided by

Re: [ovs-dev] [PATCH 3/4] m4: Fix linking with OpenSSL 1.1.0+ and 3+ on Windows.

Thank you so much for the patches and dealing with this, Ilya! Regarding the MD / MT linking for a given binary, this can work, usually, without any issues, although it will increase the memory used by the process because both runtimes have to be loaded. We are linking the rest of the

Re: [ovs-dev] [PATCH] appveyor: Move from MinGW 32bit to msys64.

Looking forward to that patch :) Thank you for migrating the CI to msys! Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean > > On 12 Feb 2024, at 13:43, Ilya Maximets wrote: > > On 2/9/24 21:47, Ilya Maximets wrote: >> AppVeyor is planning to remove support for MinGW 32bit

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

Thanks for the quick patch! Tested-by: Alin-Gabriel Serdean Acked-by: Alin-Gabriel Serdean From: Ilya Maximets Sent: Wednesday, July 19, 2023 6:14 PM To: ovs-dev@openvswitch.org Cc: Alin Serdean ; Eelco Chaudron ; Ilya Maximets Subject: [PATCH] ofproto-dpif

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

Thanks for taking care of it Ilya! Alin. Sent from phone > On 3 Jul 2023, at 14:59, Ilya Maximets wrote: > > On 7/1/23 01:55, Ilya Maximets wrote: >>> On 7/1/23 01:43, Ilya Maximets wrote: >>> On 6/8/23 12:07, Alin Serdean wrote: >>>> Ack, I

Re: [ovs-dev] [PATCH] MAINTAINERS: Add Eelco Chaudron

Welcome Eelco! Acked-by: Alin Gabriel Serdean > > On 21 Jun 2023, at 14:50, Simon Horman wrote: > > Eelco Chaudron was elected by the Open vSwitch committers yesterday. > This formalises his status as an Open vSwitch committer. > > Welcome Eelco! > > Signed-off-by: Simon Horman > --- >

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

not have something builtin for testing, I was wondering if it would make more sense switching to cmake/ctest… — Alin > On 8 Jun 2023, at 11:43, Ilya Maximets wrote: > > On 6/8/23 11:01, Alin Serdean wrote: >> >> Ack. I will try to see if I can address it by the end of th

Re: [ovs-dev] [PATCH 2/2] appveyor: Silence the git clone of pthreads4w.

Thank you for the patch! — Alin. > On 2 Jun 2023, at 12:24, Ilya Maximets wrote: > > On 5/31/23 22:29, Alin Serdean wrote: >> Acked-by: Alin Gabriel Serdean > > Thanks! I applied this one patch. > > Best regards, Ilya Maximets. > >> >>>

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

Ack. I will try to see if I can address it by the end of the week. Thanks for clarifying the questions. Would GH actions be better than appveyor? — Alin. On 2 Jun 2023, at 12:25, Ilya Maximets wrote: > > On 6/1/23 13:50, Ilya Maximets wrote: >>> On 5/31/23 23:05, Ali

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

to modernize the build system to meson or cmake. Was that effort fruitful in the end? Alin. > On 31 May 2023, at 22:41, Ilya Maximets wrote: > > On 5/31/23 22:36, Alin Serdean wrote: >> >> It would be best to change the link with the latest version of OpenSSL.

Re: [ovs-dev] [PATCH 1/2] appveyor: Don't download OpenSSL.

It would be best to change the link with the latest version of OpenSSL. That will ensure there are no mishaps . Alin. > > On 31 May 2023, at 21:23, Ilya Maximets wrote: > > OpenSSL is already available in the exact location we need it [1]. > Also, the download itself fails for a long time

Re: [ovs-dev] [PATCH 2/2] appveyor: Silence the git clone of pthreads4w.

Acked-by: Alin Gabriel Serdean > > On 31 May 2023, at 21:23, Ilya Maximets wrote: > > Git by default reports progress on stderr. This doesn't fail > the build, but upsets the powershell: > > git : Cloning into 'c:\pthreads4w-code'... > At line:3 char:1 > + git clone

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

ch. > > It is easy to re-add people in the future should any emeritus > committer desire to become active again. > > Per our policies, a vote of the majority of current committers (or > the list of maintainers prior to this change) is required to move a > committer to emeritus statu

Re: [ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

Acked-by: Alin Gabriel Serdean > > On 18 May 2023, at 15:40, Russell Bryant wrote: > > I am currently an emeritus committer, but I would like to become > active again for a short period of time to work through some > governance issues preventing us from updating our committers list >

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

Applied on master and backported until 2.9 Thank you! > On 9 Nov 2022, at 04:32, Wilson Peng wrote: > > From: Wilson Peng > > In the recent Antrea project testing, some port could not be created > on Windows. > > When doing debug, our team found there is one case happening when multiple >

Re: [ovs-dev] [PATCH] [RFC] [ovn] northd: Fix IGMP external subscriber subscribing to internal feed

> On 24 May 2022, at 00:15, Dumitru Ceara wrote: > > On 5/3/22 17:15, Alin-Gabriel Serdean wrote: >> Add localnet ports to their corresponding southbound multicast group. >> >> Update unit tests. >> >> Reported-at: https://github.com/ovn-org/ovn/issues/125 >> Reported-by: Diko Parvanov >>

Re: [ovs-dev] [PATCH v2] windows: Bump OpenSSL version

From: Ilya Maximets<mailto:i.maxim...@ovn.org> Sent: Wednesday, October 21, 2020 6:50 PM To: Alin Serdean<mailto:aserd...@cloudbasesolutions.com>; d...@openvswitch.org<mailto:d...@openvswitch.org> Cc: i.maxim...@ovn.org<mailto:i.maxim...@ovn.org>; Mark Gray<ma

Re: [ovs-dev] [PATCH v4 1/2] conntrack: Rename "master" connection to "parent" connection.

From: Ben Pfaff<mailto:b...@ovn.org> Sent: Saturday, October 17, 2020 7:36 AM To: d...@openvswitch.org<mailto:d...@openvswitch.org> Cc: Ben Pfaff<mailto:b...@ovn.org>; Alin Serdean<mailto:aserd...@cloudbasesolutions.com> Subject: [PATCH v4 1/2] conntrack: Rename "

Re: [ovs-dev] [PATCH v4 2/2] Eliminate use of term "slave" in bond, LACP, and bundle contexts.

From: Ben Pfaff<mailto:b...@ovn.org> Sent: Saturday, October 17, 2020 7:36 AM To: d...@openvswitch.org<mailto:d...@openvswitch.org> Cc: Ben Pfaff<mailto:b...@ovn.org>; Alin Serdean<mailto:aserd...@cloudbasesolutions.com> Subject: [PATCH v4 2/2] Eliminate use of te

Re: [ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'.

Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com From: Ilya Maximets Sent: Tuesday, October 13, 2020 1:02 PM To: ovs-dev@openvswitch.org; Jeff Squyres Cc:

Re: [ovs-dev] [PATCH v2 2/8] windows: Add default value for VSTUDIO_CONFIG

On 9/21/20 3:32 AM, Alin Gabriel Serdean wrote: > VSTUDIO_CONFIG is used when generating the windows installer. > > If the parameter passed to configure `--with-vstudiotarget` is not specified > to configure we default it to `Default`. > > Fixes bug: vstudiotarget/vstudiotargetver should be

Re: [ovs-dev] [PATCH] windows, tests: Strip EOL characters when passing them to tasklist

On 9/23/20 12:39 PM, Alin Gabriel Serdean wrote: > When running OVSDB cluster tests on Windows not all the ovsdb > processes are terminated. > Strip carriage return and newline of the arguments passed to the kill > command because they will cause problems when passing them to tasklist > and

Re: [ovs-dev] [PATCH] windows, tests: Modify service test

Thanks a lot for the review! It’s been some time since I proposed the patch, I think I wanted to make sure the service was deleted, but I agree with your suggestions. I sent an incremental here: https://patchwork.ozlabs.org/project/openvswitch/patch/20200923112247.738-1-aserd...@ovn.org/ Alin.

Re: [ovs-dev] [PATCH] tests: Queue for termination all OVSDB IDL pids

> > I posted a patch to strip the line endings here: > > https://patchwork.ozlabs.org/project/openvswitch/patch/20200923103955.1694-1-aserd...@ovn.org/ Thanks! I'll take a look. But anyway, patch below seems still valid (with my comments addressed) just because if one of ovsdb-servers will

Re: [ovs-dev] [PATCH] tests: Queue for termination all OVSDB IDL pids

Hi Ilya, Thank you so much for the review! You are right the PID in double quotes was not being propagated properly. I digged deeper to problem and the issue was actually a carriage return which is passed to the kill wrapper we use on Windows. This will mess up the search string we use here:

Re: [ovs-dev] [PATCH 1/2] Documentation, windows: Document how to generate the Windows installer

Thank you for the review! I addressed the comments and sent a new patchset: https://patchwork.ozlabs.org/project/openvswitch/list/?series=203406 On 9/8/20 4:04 AM, Alin Gabriel Serdean wrote: > This patch adds information on how to generate the Windows installer > which can be used to easily

Re: [ovs-dev] [PATCH] Remove duplicate include file

Thank you for the patch. Applied on master! Alin. From: Yi Li Sent: Tuesday, September 22, 2020 5:26 AM To: d...@openvswitch.org Cc: Yi Li Subject: [ovs-dev] [PATCH] Remove duplicate include file Found by

Re: [ovs-dev] [PATCH] AUTHORS: update email for Mark Gray

Applied on master. Thank you! From: Mark Gray Sent: Monday, September 7, 2020 11:45 AM To: ovs-dev@openvswitch.org Subject: [ovs-dev] [PATCH] AUTHORS: update email for Mark Gray Update email address for Mark Gray Signed-off-by: Mark

Re: [ovs-dev] Bond support on Windows OVS

/netlbfo/new-netlbfoteam?view=win10-ps but in that case from the OVS side we see one single external NIC. Thanks, Alin. From: Jinjun Gao<mailto:jinj...@vmware.com> Sent: Monday, August 24, 2020 9:09 AM To: Alin Serdean<mailto:aserd...@cloudbasesolutions.com>; Anand Kumar<

Re: [ovs-dev] [PATCH v2] datapath-windows: Update flow key in SET action

Applied on master. Thank you for the fixes and testing! Alin. From: Jinjun Gao<mailto:jinj...@vmware.com> Sent: Wednesday, July 29, 2020 6:29 AM To: d...@openvswitch.org<mailto:d...@openvswitch.org>; Alin Serdean<mailto:aserd...@cloudbasesolutions.com>; kumaran...@vmware.

Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

Thanks a lot for testing and fixing this as discussed offline. Can you please split the assignment via the form: “key->ipKey.nwDst = ipHdr->daddr = ipAttr->ipv4_dst” It confuses the SDV tool from msft for some reason:

Re: [ovs-dev] [PATCH v3] datapath-windows: Reset ct_mark/ct_label to support ALG

Acked-by: Alin Gabriel Serdean ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovs-dev v2] datapath-windows: Reset ct_mark/ct_label to support ALG

To: d...@openvswitch.org<mailto:d...@openvswitch.org>; Alin Serdean<mailto:aserd...@cloudbasesolutions.com>; kumaran...@vmware.com<mailto:kumaran...@vmware.com> Cc: Jinjun Gao<mailto:jinj...@vmware.com> Subject: [ovs-dev v2] datapath-windows: Reset ct_mark/ct_label to support ALG

Re: [ovs-dev] [PATCH v3 1/4] Eliminate use of term "slave" in bond, LACP, and bundle contexts.

From: Ben Pfaff Sent: Tuesday, July 7, 2020 7:29 PM To: d...@openvswitch.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH v3 1/4] Eliminate use of term "slave" in bond, LACP, and bundle contexts. Most of these changes should not

Re: [ovs-dev] [PATCH v3 3/4] conntrack: Rename "master" connection to "primary" connection.

From: Ben Pfaff Sent: Tuesday, July 7, 2020 7:26 PM To: d...@openvswitch.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH v3 3/4] conntrack: Rename "master" connection to "primary" connection. Signed-off-by: Ben Pfaff --- As

Re: [ovs-dev] [PATCH v3 2/4] Use primary/secondary, not master/slave, as names for OpenFlow roles.

From: Ben Pfaff Sent: Tuesday, July 7, 2020 7:26 PM To: d...@openvswitch.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH v3 2/4] Use primary/secondary, not master/slave, as names for OpenFlow roles. Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH v3 4/4] Eliminate "whitelist" and "blacklist" terms.

From: Ben Pfaff Sent: Tuesday, July 7, 2020 7:25 PM To: d...@openvswitch.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH v3 4/4] Eliminate "whitelist" and "blacklist" terms. There is one remaining use under datapath. That change

Re: [ovs-dev] [ovs-dev v2] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER

From: Jinjun Gao<mailto:jinj...@vmware.com> Sent: Tuesday, June 30, 2020 2:45 PM To: d...@openvswitch.org<mailto:d...@openvswitch.org>; Alin Serdean<mailto:aserd...@cloudbasesolutions.com> Cc: kumaran...@vmware.com<mailto:kumaran...@vmware.com>; Jinjun Gao<mailto:

Re: [ovs-dev] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER

Thanks for sending the patch. Running the command: make datapath_windows_analyze resulted in the following: ovsext\Conntrack.c(873): warning C28167: The function 'OvsCtExecute_' changes the IRQL and does not restore the IRQL before it exits. It should be annotated to reflect the change or the

Re: [ovs-dev] Windows OVS issue

0. > 0,dst=0.0.0.0,proto=0,tp_src=0,tp_dst=0),eth(src=68:4f:64:15:61:9a,dst=01:0 > 0:0c:cc:cc:cd),in_port(1),eth_type(0x05ff) [Alin Serdean] From what I can see those are packets which are missing a valid Ethernet type. > > Except for above error logs, there are also some igmp wa

Re: [ovs-dev] [PATCH] doc: document the nointegritychecks setting.

ks'. It has > following > limitations: [Alin Serdean] Actually the generated driver from our project is testsigned, which implies the host only needs the /testsigning enabled, which again is not valid under secure boot. ___ dev mailing l

Re: [ovs-dev] [RFC PATCH v1 1/3] datapath-windows: Introduce HNS OVS calls

me` on > a > HNS network which has OVS enabled. > > Signed-off-by: Alin Gabriel Serdean > --- [Alin Serdean] For future references: HNS API has been renamed to HCN (host compute networking). An API schema has been released and documented under: ht

Re: [ovs-dev] [PATCH RFC]: windows: cross-compile using mingw-w64 gcc.

ross-compile OVS for windows using gcc from mingw-w64. > > > > The patch still shows lots of warnings I haven't fixed, but now it > > > > can generate all the .exe and I tested on windows 10 (no kernel > > > > module). [Alin Serdean] The patch as is will break MSV

Re: [ovs-dev] [patch v3] datapath-windows: Append tunnel info to upcall for correct template

Thank you for the patch, applied on master! > -Original Message- > From: Alin Serdean > Sent: Tuesday, February 4, 2020 8:41 PM > To: Amber Hu ; d...@openvswitch.org > Cc: Qiong Wang ; Wenyu Zhang > ; Jinjun Gao > Subject: RE: [patch v3] datapath-windows: Append

Re: [ovs-dev] [patch v3] datapath-windows: Append tunnel info to upcall for correct template

> -Original Message- > From: Amber Hu > Sent: Tuesday, February 4, 2020 7:03 AM > To: Alin Serdean ; d...@openvswitch.org > Cc: Qiong Wang ; Wenyu Zhang > ; Jinjun Gao > Subject: [patch v3] datapath-windows: Append tunnel info to upcall for correct >

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

02b95db018ad132d3b7 Mon Sep 17 > 00:00:00 2001 > From: Amber Hu > Date: Thu, 30 Jan 2020 18:01:32 -0800 > Subject: [PATCH] datapath-windows: Append tunnel info to upcall for > correct > template > > Signed-off-by: Amber Hu [Alin

Re: [ovs-dev] [PATCH]lib/stream-windows.c: Grant Access Privilege of Named Pipe to Creator

Thank you Ning and Anand. Applied on master! Alin. > -Original Message- > From: Anand Kumar > Sent: Friday, January 24, 2020 7:22 AM > To: Ning Wu ; Alin Serdean > ; d...@openvswitch.org > Cc: Lina Li ; Roy Luo > Subject: Re: [PATCH]lib/stream-windows.c: G

Re: [ovs-dev] [PATCH]lib/stream-windows.c: Grant Access Privilege of Named Pipe to Creator

> -Original Message- > From: Ning Wu > Sent: Wednesday, January 22, 2020 10:19 AM > To: Alin Serdean ; d...@openvswitch.org; > Anand Kumar > Cc: Lina Li ; Roy Luo > Subject: [PATCH]lib/stream-windows.c: Grant Access Privilege of Named Pipe to > Creator > [

Re: [ovs-dev] [PATCH] Grant Access Privilege of Named Pipe to Creator

anuary 20, 2020 4:16 AM > To: d...@openvswitch.org; Alin Serdean > Cc: Lina Li ; Roy Luo > Subject: RE: [PATCH] Grant Access Privilege of Named Pipe to Creator > > Hi Alin, > > > > Could you please help to give some comment? > > Thanks. > > > >

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

Hi Amber, The patch fails to apply: "error: corrupt patch at line 198" Please rebase on master. Trimming the patch a bit and comments inlined. > -Original Message- > From: Amber Hu > Sent: Tuesday, January 14, 2020 7:50 AM > To: d...@openvswitch.org; Alin Ser

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

Sure. I will review it tonight. Thanks, Alin. -Original Message- From: Ben Pfaff Sent: Tuesday, January 21, 2020 7:59 PM To: Amber Hu Cc: d...@openvswitch.org; Alin Serdean ; Qiong Wang Subject: Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct

Re: [ovs-dev] datapath-windows: Don't delete internal port

Applied on master! Thank you! On 6 Dec 2019, at 16:39, Alin Serdean mailto:aserd...@cloudbasesolutions.com>> wrote: On 3 Dec 2019, at 06:38, Jinjun Gao mailto:jinj...@vmware.com>> wrote: According to the microsoft doc: https://docs.microsoft.com/en-us/windows-hardware/drivers/n

Re: [ovs-dev] datapath-windows: Don't delete internal port

> On 3 Dec 2019, at 06:38, Jinjun Gao wrote: > > According to the microsoft doc: > https://docs.microsoft.com/en-us/windows-hardware/drivers/network/hyper-v-extensible-switch-port-and-network-adapter-states > Below OID request sequence is validation: > OID_SWITCH_NIC_CONNECT ->

Re: [ovs-dev] [PATCH 2/2] backtrace: Fix 32-bit libunwind build.

On 8 Oct 2019, at 20:51, Ben Pfaff mailto:b...@ovn.org>> wrote: On Tue, Oct 08, 2019 at 06:33:10PM +0200, Ilya Maximets wrote: On 08.10.2019 18:13, William Tu wrote: On Mon, Oct 07, 2019 at 07:10:26PM +0200, Ilya Maximets wrote: On 07.10.2019 18:11, Ilya Maximets wrote: On 07.10.2019 18:07,

Re: [ovs-dev] [PATCH v1] datapath-windows: Fix updating ct label when mask is specified

Thanks a lot for the patch! I applied it on master and backported as far as I could. Alin. > On 15 Aug 2019, at 19:39, Anand Kumar via dev wrote: > > From: kumaranand > > When an existing label needs to be changed by specifing bits to be > updated using mask, instead of updating only the

Re: [ovs-dev] [PATCH] faq: Explain why select groups don't sort out packets evenly.

On 8 Mar 2019, at 03:47, Ben Pfaff mailto:b...@ovn.org>> wrote: This keeps coming up. Signed-off-by: Ben Pfaff mailto:b...@ovn.org>> — Acked-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>> ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] datapath-windows: Add guards around IpHelper adapter binding calls

Applied on master! > On 25 Mar 2019, at 19:26, Alin Serdean > wrote: > > -Original Message- > From: ovs-dev-boun...@openvswitch.org On > Behalf Of Sairam Venugopal via dev > Sent: Thursday, March 14, 2019 12:37 AM > To: ovs-dev@openvswitch.org > Subject:

Re: [ovs-dev] [PATCH] compiler: Disable BUILD_MESSAGE() when processing with sparse.

On 28 Mar 2019, at 01:11, Ben Pfaff mailto:b...@ovn.org>> wrote: sparse doesn't support _Pragma(message(x)), even though GCC does, so HAVE_PRAGMA_MESSAGE is deceptive in that case and causes pointless errors. Signed-off-by: Ben Pfaff mailto:b...@ovn.org>> --- lib/compiler.h | 4 ++— Acked-by:

Re: [ovs-dev] OVS mailing lists *sometimes* replace the From: address by the list address

> On 13 Mar 2019, at 22:47, Ben Pfaff wrote: > > On Wed, Mar 13, 2019 at 01:46:18PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >>> On Tue, Mar 12, 2019 at 09:03:19PM -0700, Ben Pfaff wrote: On Mon, Mar 11, 2019 at 12:13:23PM -0400, Aaron Conole wrote: > Ben Pfaff writes:

Re: [ovs-dev] [PATCH] datapath-windows: Fix race condition during port creation

e condition during > port creation > > > > > Hold the dispatch lock until port-add operations are completed. > > > > Found by inspection. > > > > Signed-off-by: Sairam Venugopal > [Alin Serdean] Thanks a lot for the patch! > > For some reason th

Re: [ovs-dev] [PATCH v2] Windows: Fix broken kernel userspace communication

Thanks Ben! Applied on master and backported. -- Alin > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Friday, November 16, 2018 4:36 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev]

Re: [ovs-dev] Windows: Fix broken kernel userspace communication

Yup in a couple of hours. Sent from phone > On 15 Nov 2018, at 20:27, 0-day Robot wrote: > > Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details

Re: [ovs-dev] [PATCH] Windows: Fix broken kernel userspace communication

in Gabriel Serdean > > Acked-by: Shashank Ram > > Tested-by: Shashank Ram > > Sorry we broke Windows. I apologize. [Alin Serdean] No worries. Maybe this increases the awareness about the need of a CI. > > Usually I prefer to put all the #ifdefs in a single place when

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

Thanks for the suggestion Ben. I was thinking about changing the regular open to a CreateFile on Windows with the flag: ` FILE_FLAG_DELETE_ON_CLOSE 0x0400 The file is to be deleted immediately after all of its handles are closed, which includes the specified handle and any other open or

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

I applied the patch on master and as far as it goes without conflicts. -- Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Thursday, November 15, 2018 4:52 PM > Către: 'Sairam Venugopal' ;

Re: [ovs-dev] [PATCH] treewide: Fix spelling of "receive".

Also applied on branch-2.10. — Alin. > On 27 Sep 2018, at 20:22, Ben Pfaff wrote: > > On Wed, Sep 26, 2018 at 11:03:26PM -0700, Justin Pettit wrote: >> >>> On Sep 26, 2018, at 4:12 PM, Ben Pfaff wrote: >>> >>> Signed-off-by: Ben Pfaff >> >> Ha. >> >> Acked-by: Justin Pettit > > Thanks,

Re: [ovs-dev] [PATCH 1/4] util: Fix abs_file_name() bugs on Windows.

On 3 Aug 2018, at 18:52, Ben Pfaff mailto:b...@ovn.org>> wrote: On Fri, Aug 03, 2018 at 03:41:55PM +, Alin Serdean wrote: abs_file_name() believed that a file name that begins with / or contains : is absolute and that any other file name is relative. On Windows, this is wrong in at

Re: [ovs-dev] [PATCH 1/4] util: Fix abs_file_name() bugs on Windows.

e current working directory (one > per volume letter), so trying to make a file name absolute by just prefixing > the current working directory for the current volume results in silliness. > > This patch attempts to fix the problem. > > Found by inspection. > > CC: Al

Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable code and goto labels

> Subiect: Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable > code and goto labels > > I think the correct fix may be as follows, do you mind rechecking it? > Thanks. > > diff --git a/datapath/vport.c b/datapath/vport.c index > 02f6b56d3243..fcf0fea0a245 100644 > ---

Re: [ovs-dev] [PATCHv2] dpif-netlink: Add meter support.

The incremental looks good. Thanks, Alin. Sent from phone > On 29 Jun 2018, at 20:32, Justin Pettit wrote: > > >>> On Jun 29, 2018, at 7:23 AM, Alin Serdean >>> wrote: >>> >>> On 29 Jun 2018, at 07:02, Justin Pettit wrote: >>

Re: [ovs-dev] [PATCHv2] dpif-netlink: Add meter support.

On 29 Jun 2018, at 07:02, Justin Pettit mailto:jpet...@ovn.org>> wrote: From: Andy Zhou mailto:az...@ovn.org>> To work with kernel datapath that supports meter. Signed-off-by: Andy Zhou mailto:az...@ovn.org>> Signed-off-by: Justin Pettit mailto:jpet...@ovn.org>> --- v1->v2: D'oh. Stupid

Re: [ovs-dev] [PATCH v4 2/3] datapath-windows: Implement locking in conntrack NAT.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Tuesday, June 19, 2018 8:33 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH v4 2/3] datapath-windows: Implement locking in > conntrack NAT. > > This patch

Re: [ovs-dev] [PATCH v2 0/3] Optimize conntrack performance

Thanks a lot for the series and the benchmarks . This is not an actual review. I applied the patches and ran the code analysis and I get the following: ovs\datapath-windows\ovsext\conntrack-nat.c(151): warning C28167: The function 'OvsNatCleanup' changes the IRQL and does not restore the IRQL

Re: [ovs-dev] [PATCH] datapath-windows: Add support for handling DEI bit of VLAN header

> > On 16 May 2018, at 02:38, Anand Kumar > wrote: > > > > The Drop eligible indicator(DEI) is 1 bit wide and it is part of Tag > > control information (TCI) in VLAN header, which indicates that the > > frame can be dropped during congestion. > > > > Signed-off-by: Anand Kumar > > --- > >

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

> On 27 Apr 2018, at 20:00, Anand Kumar wrote: > > The conntrack-counters ought to be incremented only if it's a new lookup > or if it's recirculated through a different zone for the first time. > > Signed-off-by: Anand Kumar Applied on master.

Re: [ovs-dev] [PATCH] ovsdb-client: Set binary on FDs when doing backup/restore

Please disregard this patch. Copy/paste error  > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Alin Gabriel Serdean > Trimis: Thursday, March 8, 2018 8:09 PM > Către: d...@openvswitch.org > Cc: Alin Gabriel Serdean >

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

lut...@cloudbasesolutions.com>; Anand Kumar <kumaran...@vmware.com>; Alin Serdean <aserd...@cloudbasesolutions.com>; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets That is not consistent with how we specify the Debug/Release flag.

Re: [ovs-dev] [PATCH v2] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Applied on master. Ty! -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele aserd...@ovn.org Trimis: Saturday, February 3, 2018 12:48 AM Către: 'Anand Kumar' ; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Looks good just a small nit: s/syn/SYN/g s/ack/ACK/g Also I would prefer if you drop the text `Invalid!`. Either just remove it or expand it, i.e.: "Invalid! ICMPhdr cannot be NULL" => "Invalid ICMP packet detected the header cannot be NULL" Thanks, Alin. -Mesaj original- De la:

Re: [ovs-dev] [PATCH v4 3/3] datapath-windows: Optimize conntrack lock implementation.

ess: 6001) if (ovsCtBucketLock[i] != NULL) { NdisFreeRWLock(ovsCtBucketLock[i]); } and applied it on master. Alin. -Mesaj original- De la: Alin Serdean Trimis: Friday, February 2, 2018 10:52 PM Către: Anand Kumar <kumaran...@vmware.c

Re: [ovs-dev] [PATCH v4 3/3] datapath-windows: Optimize conntrack lock implementation.

Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Monday, January 29, 2018 8:28 PM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v4 3/3]

Re: [ovs-dev] [PATCH v3 3/3] datapath-windows: Optimize conntrack lock implementation.

onntrackLockObj); -ovsConntrackLockObj = NULL; +for (UINT32 i = 0; i < CT_HASH_TABLE_SIZE; i++) { +if (ovsCtBucketLock[i] != NULL) { [Alin Serdean] datapath-windows\ovsext\conntrack.c(154): warning C6001: Using uninitialized memory '*ovsCtBucketLock'. +NdisFreeRWLock

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 12, 2017 12:30 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > >

Re: [ovs-dev] [PATCH 4/5] ovsdb-idl: Remove 'uuid' member of struct ovsdb_idl.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, December 8, 2017 11:24 PM > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 4/5] ovsdb-idl: Remove 'uuid'

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

hat process "update2" (IDL_S_MONITORING_COND) > or > + * "update" (IDL_S_MONITORING) notifications. */ > IDL_S_MONITORING_COND, > +IDL_S_MONITORING, > + > +/* Terminal error state that indicates that nothing useful can be done. > + * The most likely re

Re: [ovs-dev] [PATCH 2/5] ovsdb-idl: Fix indentation in a couple of places.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, December 8, 2017 11:24 PM > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 2/5] ovsdb-idl: Fix indentation

Re: [ovs-dev] [PATCH 3/5] ovsdb-idl: Fix assertion failure on error path parsing server reply.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, December 8, 2017 11:24 PM > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 3/5] ovsdb-idl: Fix assertion

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

vember 28, 2017 3:33 PM > To: d...@openvswitch.org; Alin Serdean > <aserd...@cloudbasesolutions.com> > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in > tunnel Decap > > Alin, do you think it makes sense to also apply this on 2.8? > > -- >

Re: [ovs-dev] [PATCH v1 1/3] datapath-windows: Refactor conntrack code.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Tuesday, November 14, 2017 8:48 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v1 1/3]

Re: [ovs-dev] [PATCH 0/7] Introduce high resolution sleep support.

> > > > > > >I would normally squash patch 3 (the Windows version of xnanosleep) > > >into patch 2 (the Linux version). > > > > I couldn't verify the functionality of windows implementation and hence > posted it as a separate patch for now. > > I will squash i

Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

> -Original Message- > From: Xiao Liang [mailto:shaw.l...@gmail.com] > Sent: Thursday, November 2, 2017 4:32 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: Ben Pfaff <b...@ovn.org>; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH, RFC] tests: Add a default timeout for control utilities

low dashes in function names (default > > > behavior), we shall try to define an alias to overcome dashes if the shell > allows it. > > > > > > Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org> > > > Suggested-by: Ben Pfaff <b...@ovn.org> > &

Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, October 31, 2017 9:34 PM > To: Xiao Liang <shaw.l...@gmail.com>; Alin Serdean > <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PAT

Re: [ovs-dev] [PATCH v2] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

@vmware.com>; d...@openvswitch.org > Cc: Alin Serdean <aserd...@cloudbasesolutions.com>; Gurucharan Shetty > <g...@ovn.org> > Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Update > OvsIPv4TunnelKey flags in geneve decap. > > Thanks for fixing this. > > Ali

Re: [ovs-dev] [PATCH] datapath-windows: Remove the workaround in NAT for TCP checksum

Applied to branch-2.8 as well. Thanks! > -Original Message- > From: Anand Kumar [mailto:kumaran...@vmware.com] > Sent: Monday, October 16, 2017 11:22 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; Sairam Venugopal > <vsai...@vmware.com>; d...@openvswi

  1   2   3   4   >