Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Dan Williams
On Thu, 2023-05-25 at 08:38 -0500, Dan Williams wrote: > On Wed, 2023-05-24 at 11:12 +0200, Ihtisham ul Haq via dev wrote: > > Using cache improves performance of recomputation of lflows(by > > about 30%) > > > > Exising lflow cache for `matches` and `expressions

Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Dan Williams
On Wed, 2023-05-24 at 11:12 +0200, Ihtisham ul Haq via dev wrote: > Using cache improves performance of recomputation of lflows(by > about 30%) > > Exising lflow cache for `matches` and `expressions` is adopted > to include `actions` as well. > > Co-authored-by: Felix Huettner > Signed-off-by:

Re: [ovs-dev] [PATCH] lib/ssl: enable TLSv1.3 if supported by SSL

2023-05-08 Thread Dan Williams
On Fri, 2023-05-05 at 20:08 +0200, Ilya Maximets wrote: > On 5/5/23 17:23, Ilya Maximets wrote: > > Hi, Dan.  Thanks for the patch! > > > > Looks like you've lost a commit message somewhere. > > > > On 5/4/23 17:47, Dan Williams wrote: > > > diff --git a

[ovs-dev] [PATCH] lib/ssl: enable TLSv1.3 if supported by SSL

2023-05-04 Thread Dan Williams
diff --git a/lib/ssl-connect.man b/lib/ssl-connect.man index 6e54f77ef4d5e..896ce79c6378f 100644 --- a/lib/ssl-connect.man +++ b/lib/ssl-connect.man @@ -1,10 +1,12 @@ .IP "\fB\-\-ssl\-protocols=\fIprotocols\fR" Specifies, in a comma- or space-delimited list, the SSL protocols \fB\*(PN\fR will

Re: [ovs-dev] [RFC] mcast-snopping: do not learn from well defined multicast IPv6 groups

2023-01-23 Thread Dan Williams
On Mon, 2023-01-23 at 10:01 +0100, Lorenzo Bianconi wrote: > Avoid learning Link-Local reserved multicast addresses if advertised in > a MLD reports since this interferes with Slaac IPv6 address resolution > implemented in OVN. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2154930

Re: [ovs-dev] [PATCH] ovs-lib: accept optional timeout value for upgrade_cluster

2022-12-15 Thread Dan Williams
On Thu, 2022-12-15 at 19:46 +0100, Frode Nordahl wrote: > On Thu, Dec 15, 2022 at 7:16 PM Dan Williams wrote: > > On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote: > > [ snip ] > > > > Thank you for proposing this patch! > > > > > > We've b

Re: [ovs-dev] [PATCH] ovs-lib: accept optional timeout value for upgrade_cluster

2022-12-15 Thread Dan Williams
On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote: > Hello, Dan, > > On Thu, Dec 15, 2022 at 6:57 PM Dan Williams wrote: > > > > Signed-off-by: Dan Williams > > --- > >  utilities/ovs-lib.in | 13 + > >  1 file changed, 9 insertions

[ovs-dev] [PATCH] ovs-lib: accept optional timeout value for upgrade_cluster

2022-12-15 Thread Dan Williams
Signed-off-by: Dan Williams --- utilities/ovs-lib.in | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index 13477a6a9e991..36e63312b6cba 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -475,11 +475,16

[ovs-dev] [PATCH] ovsdb-tool: clarify clustered-to-standalone help text

2022-12-15 Thread Dan Williams
Make it clear which of the DB args is the clusterd one. Signed-off-by: Dan Williams --- ovsdb/ovsdb-tool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index 60f353197bfd7..33719d38a4d09 100644 --- a/ovsdb/ovsdb-tool.c +++ b/ovsdb

[ovs-dev] [PATCH v2] ovsdb-server: don't log when memory-trim-on-compaction doesn't change

2022-12-14 Thread Dan Williams
But log at least once even if the value hasn't changed, for informational purposes. Signed-off-by: Dan Williams --- Changes since v1: - log at least once even if value doesn't change - reverse-xmas-tree local variable declarations --- ovsdb/ovsdb-server.c | 9 +++-- 1 file changed, 7

[ovs-dev] ovsdb-server: don't log when memory-trim-on-compaction doesn't change

2022-11-09 Thread Dan Williams
Signed-off-by: Dan Williams --- ovsdb/ovsdb-server.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 7a6bfe0a03c09..c073a4f9a0a07 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -1601,6 +1601,7

Re: [ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-09 Thread Dan Williams
On Tue, 2022-11-08 at 14:01 -0500, Simon Horman wrote: > On Tue, Nov 08, 2022 at 01:17:57PM -0500, Dumitru Ceara wrote: > > On 11/8/22 13:04, Dan Williams wrote: > > > If no arguments are given report the current memory trim setting. > > > > > > Signed-off-by:

[ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Dan Williams
If no arguments are given report the current memory trim setting. Signed-off-by: Dan Williams --- ovsdb/ovsdb-server.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 7a6bfe0a03c09..8c997cf5caf67 100644 --- a/ovsdb

[ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Dan Williams
If no arguments are given report the current memory trim setting. Signed-off-by: Dan Williams --- ovsdb/ovsdb-server.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 7a6bfe0a03c09..8c997cf5caf67 100644 --- a/ovsdb

Re: [ovs-dev] [PATCH ovn v2 1/6] Add chassis column to MAC_Binding table

2022-06-22 Thread Dan Williams
On Fri, 2022-06-17 at 11:07 +0200, Ales Musil wrote: > The new chassis column in MAC_Binding should > act as an "owner" order of that particular row. > This can be utilized by MAC binding aging mechanism, > where only single is responsible for that particular > record. In order to keep it

Re: [ovs-dev] [RFC ovn 0/2] Basic eBPF/XDP support in OVN.

2022-06-08 Thread Dan Williams
On Thu, 2022-06-09 at 00:41 +0800, 刘梦馨 wrote: > > Could you tell roughly how many packets were sent in a single test? > > Was > the latency measured for all the UDP packets in average? > > Let me describe my test method more clearly. In fact, we only tested > pod-to-pod performance *not*

[ovs-dev] [PATCH ovn 0/4] ovn-ctl: database path fixes and RAFT election timer passthrough

2021-12-15 Thread Dan Williams
time by allowing that value to be passed through to ovs-ctl. Dan Williams (4): ovn-ctl: use user-provided control socket paths ovn-ctl: allow overriding the database pidfile path ovn-ctl: pass database socket to ovn-*ctl init ovn-ctl: add RAFT election timer argument and pass

Re: [ovs-dev] [PATCH v5] ovsdb: provide raft and command interfaces with priority

2021-07-22 Thread Dan Williams
On Thu, 2021-07-22 at 16:03 +0100, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Set a soft time limit of "raft election timer"/2 on ovsdb > processing. > > This improves behaviour in large heavily loaded clusters. > While it cannot fully eliminate spurious raft elections >

[ovs-dev] [PATCH v4] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-25 Thread Dan Williams
Signed-off-by: Dan Williams --- v4: fix quoting of election_timer_arg v3: fix line wrapping v2: put --election-timer arg before create-cluster utilities/ovs-lib.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index

Re: [ovs-dev] [PATCH v3] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-25 Thread Dan Williams
On Thu, 2021-06-24 at 14:58 -0700, Ben Pfaff wrote: > On Wed, Jun 09, 2021 at 02:11:42PM -0500, Dan Williams wrote: > > Signed-off-by: Dan Williams > > --- > > v3: fix line wrapping > > v2: put --election-timer arg before create-cluster per Ilya > >

Re: [ovs-dev] [PATCH v3] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-23 Thread Dan Williams
On Wed, 2021-06-09 at 14:11 -0500, Dan Williams wrote: > Signed-off-by: Dan Williams > --- > v3: fix line wrapping > v2: put --election-timer arg before create-cluster per Ilya Ping on this patch? Thanks! Dan > >  utilities/ovs-lib.in | 10 -- >  1 file change

Re: [ovs-dev] Path MTU discovery on GRE interfaces

2021-06-23 Thread Dan Williams
On Wed, 2021-06-23 at 10:06 -0700, Ben Pfaff wrote: > [updating Jesse's email address] > > On Wed, Jun 23, 2021 at 04:48:29PM +0200, Matthias May via dev wrote: > > I'm currently fighting with issues where TCP/UDP frames that are > > larger than the MTU of a GRE tunnel are dropped. > > I'm aware

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

2021-06-22 Thread Dan Williams
On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: > On 6/4/21 10:00 PM, Dan Williams wrote: > > Inspried by: > > > > 3b6362d64e86b northd: Avoid memory reallocation while building lb > > rules. > > > > Signed-off-by: Dan Williams > > ---

Re: [ovs-dev] raft: print local server ID when opening RAFT database

2021-06-11 Thread Dan Williams
On Wed, 2021-05-12 at 20:40 -0500, Dan Williams wrote: > On Mon, 2021-04-05 at 10:34 -0500, Dan Williams wrote: > > Signed-off-by: Dan Williams > > Friendly ping for review on this one... Yet another ping, thanks! Dan > > Thanks! > Dan > > > --- > >  

[ovs-dev] [PATCH v3] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-09 Thread Dan Williams
Signed-off-by: Dan Williams --- v3: fix line wrapping v2: put --election-timer arg before create-cluster per Ilya utilities/ovs-lib.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index ab38ece458b7b..61a062fa992da

[ovs-dev] [PATCH v2] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-07 Thread Dan Williams
Signed-off-by: Dan Williams --- v2: put --election-timer arg before create-cluster per Ilya  utilities/ovs-lib.in | 10 --  1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index ab38ece458b7b..61a062fa992da 100644 --- a/utilities

Re: [ovs-dev] [PATCH] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-07 Thread Dan Williams
On Mon, 2021-06-07 at 20:56 +0200, Ilya Maximets wrote: > On 6/7/21 6:04 PM, Dan Williams wrote: > > > > Signed-off-by: Dan Williams > > --- > >  utilities/ovs-lib.in | 10 -- > >  1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff

[ovs-dev] [PATCH] ovs-lib: pass optional --election-timer arg to ovsdb-tool

2021-06-07 Thread Dan Williams
Signed-off-by: Dan Williams --- utilities/ovs-lib.in | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index ab38ece458b7b..d5aef8c85b3e0 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -495,15 +495,21

[ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

2021-06-04 Thread Dan Williams
Inspried by: 3b6362d64e86b northd: Avoid memory reallocation while building lb rules. Signed-off-by: Dan Williams --- NOTE: this is driven by visual inspection not perf data. But it shouldn't be worse than current code and should be better for large numbers of ACLs I think. northd/ovn

Re: [ovs-dev] [PATCH ovn] lflow-cache: Auto trim when cache size is reduced significantly.

2021-06-04 Thread Dan Williams
On Fri, 2021-06-04 at 12:00 +0200, Dumitru Ceara wrote: > Due to a bug in glibc [0], M_TRIM_THRESHOLD (default 128KB) is not > honored.  The lflow cache is one of the largest memory consumers in > ovn-controller and it used to trim memory whenever the cache was > flushed.  However, that required

Re: [ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-03 Thread Dan Williams
On Wed, 2021-06-02 at 17:02 +0100, Brendan Doyle wrote: >  From a9d3140845175edb7644b2d0d82a95bd6cf94662 Mon Sep 17 00:00:00 2001 > From: Brendan Doyle > Date: Fri, 28 May 2021 10:01:17 -0700 > Subject: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN > > This patch provides the ability to

Re: [ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-02 Thread Dan Williams
On Wed, 2021-06-02 at 09:26 +0100, Brendan Doyle wrote: > Hi, > > Just wondering what the process is here, I submitted this patch a while > ago, and I see quite a few > other patches have been submitted since. So wondering what happens > after > a patch is submitted, > how do I know if it has

Re: [ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

2021-05-25 Thread Dan Williams
On Mon, 2021-05-24 at 14:52 -0700, Ben Pfaff wrote: > On Mon, May 24, 2021 at 02:59:58PM -0500, Dan Williams wrote: > > On Mon, 2021-05-24 at 10:49 -0700, Ben Pfaff wrote: > > > On Fri, May 21, 2021 at 02:25:52PM -0500, Dan Williams wrote: > > > > After creating

[ovs-dev] [PATCH v3] ovsdb-tool: add --election-timer=ms option to 'create-cluster'

2021-05-25 Thread Dan Williams
Signed-off-by: Dan Williams --- v3: - Really address Ben's comments; use --election-timer arg to create- cluster - New election timer validation function; use it everywhere - Fold election timer changes into raft_create_cluster() v2: - Address Ben's comments; add --help and manpage docs - Write

Re: [ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

2021-05-24 Thread Dan Williams
On Mon, 2021-05-24 at 10:49 -0700, Ben Pfaff wrote: > On Fri, May 21, 2021 at 02:25:52PM -0500, Dan Williams wrote: > > After creating the new cluster database write a raft entry that > > sets the desired election timer. This allows CMSes to set the > > election timer at cl

[ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

2021-05-21 Thread Dan Williams
Signed-off-by: Dan Williams --- v2: - Address Ben's comments; add --help and manpage docs - Write raft record directly instead of using private raft.c functions NEWS | 3 ++ ovsdb/ovsdb-tool.1.in | 12 ovsdb/ovsdb-tool.c| 64

Re: [ovs-dev] [PATCH ovn 0/3] Introduce check_pkt_len for ingress traffic

2021-05-19 Thread Dan Williams
On Wed, 2021-05-19 at 17:35 +0200, Lorenzo Bianconi wrote: > In the current codebase, check_pkt_len is applied just for traffic > leaving the > ovn cluster. This series introduces the same capability for traffic > entering > the network from a gateway router or distributed gateway router port > in

Re: [ovs-dev] [PATCH] ovsdb-tool: add election timer argument to create-cluster command

2021-05-18 Thread Dan Williams
On Thu, 2021-05-13 at 10:12 -0700, Ben Pfaff wrote: > On Wed, May 12, 2021 at 08:40:43PM -0500, Dan Williams wrote: > > On Tue, 2021-04-13 at 20:50 -0500, Dan Williams wrote: > > > After creating the new cluster database write a raft entry that > > > sets the desired

Re: [ovs-dev] [PATCH] ovsdb-tool: add election timer argument to create-cluster command

2021-05-12 Thread Dan Williams
On Tue, 2021-04-13 at 20:50 -0500, Dan Williams wrote: > After creating the new cluster database write a raft entry that > sets the desired election timer. This allows CMSes to set the > election timer at cluster start and avoid an error-prone > election timer modification p

Re: [ovs-dev] raft: print local server ID when opening RAFT database

2021-05-12 Thread Dan Williams
On Mon, 2021-04-05 at 10:34 -0500, Dan Williams wrote: > Signed-off-by: Dan Williams Friendly ping for review on this one... Thanks! Dan > --- >  ovsdb/raft.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/ovsdb/raft.c b/ovsdb/raft.c > index d2ff643b27379.

[ovs-dev] [PATCH] ovsdb-tool: add election timer argument to create-cluster command

2021-04-13 Thread Dan Williams
Signed-off-by: Dan Williams --- ovsdb/ovsdb-tool.c | 30 +- ovsdb/raft.c | 2 +- ovsdb/raft.h | 8 3 files changed, 38 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index b8560f850cd08..8d029cef56df6 100644

[ovs-dev] [PATCH ovn v2 2/2] ovn-ctl: stop databases with stop_ovn_daemon()

2021-04-12 Thread Dan Williams
://bugzilla.redhat.com/1944239 Signed-off-by: Dan Williams --- utilities/ovn-ctl| 16 +--- utilities/ovn-lib.in | 24 ++-- 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index 359c9c78afda2..ff61f21d0614a 100755

[ovs-dev] [PATCH ovn v2 1/2] ovn-lib: harmonize stop_ovn_daemon() with ovs-lib

2021-04-12 Thread Dan Williams
OVN should probably be doing the same things OVS is doing here. Signed-off-by: Dan Williams --- utilities/ovn-lib.in | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-lib.in b/utilities/ovn-lib.in index 016815626fc7f..bd04d0e86322f 100644

[ovs-dev] [PATCH ovn 0/2] ovn-ctl: stop databases with stop_ovn_daemon()

2021-04-12 Thread Dan Williams
Wait for the databases to actually exit before returning to the caller of ovn-ctl. v1 -> v2 - * No code changes * Fixed stop_ovn_daemon() name in patch headers * Added "ovn" to patch subjects for correct patchwork Dan Williams (2): ovn-lib: harmonize stop_ovn_daemon()

Re: [ovs-dev] [PATCH 0/2] ovn-ctl: stop databases with stop_ovn_daemon

2021-04-12 Thread Dan Williams
On Mon, 2021-04-12 at 08:27 -0500, Dan Williams wrote: > Wait for the databases to actually exit before returning to > the caller of ovn-ctl. > > Dan Williams (2): >   ovn-lib: harmonize stop_daemon() with ovs-lib >   ovn-ctl: stop databases with stop_ovn_daemon > >  u

[ovs-dev] [PATCH 2/2] ovn-ctl: stop databases with stop_ovn_daemon

2021-04-12 Thread Dan Williams
://bugzilla.redhat.com/1944239 Signed-off-by: Dan Williams --- utilities/ovn-ctl| 16 +--- utilities/ovn-lib.in | 24 ++-- 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index 359c9c78afda2..ff61f21d0614a 100755

[ovs-dev] [PATCH 1/2] ovn-lib: harmonize stop_daemon() with ovs-lib

2021-04-12 Thread Dan Williams
OVN should probably be doing the same things OVS is doing here. Signed-off-by: Dan Williams --- utilities/ovn-lib.in | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-lib.in b/utilities/ovn-lib.in index 016815626fc7f..bd04d0e86322f 100644

[ovs-dev] [PATCH 0/2] ovn-ctl: stop databases with stop_ovn_daemon

2021-04-12 Thread Dan Williams
Wait for the databases to actually exit before returning to the caller of ovn-ctl. Dan Williams (2): ovn-lib: harmonize stop_daemon() with ovs-lib ovn-ctl: stop databases with stop_ovn_daemon utilities/ovn-ctl| 16 +--- utilities/ovn-lib.in | 40

[ovs-dev] raft: print local server ID when opening RAFT database

2021-04-05 Thread Dan Williams
Signed-off-by: Dan Williams --- ovsdb/raft.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index d2ff643b27379..7f3ee733dbcc0 100644 --- a/ovsdb/raft.c +++ b/ovsdb/raft.c @@ -1026,6 +1026,8 @@ raft_open(struct ovsdb_log *log, struct raft **raftp

Re: [ovs-dev] [PATCH ovn] docs: update various OVS references to OVN

2020-05-08 Thread Dan Williams
On Fri, 2020-05-08 at 12:46 +0530, Numan Siddique wrote: > On Fri, May 8, 2020 at 12:29 PM wrote: > > > From: Dan Williams > > > > Submitted-at: https://github.com/ovn-org/ovn/pull/40 > > Signed-off-by: Dan Williams > > Signed-off-by: Numan Siddique > &