Please ignore this email.
fbl
On 7/7/23 16:21, Flavio Leitner wrote:
From: Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote:
From: Flavio Leitner
The netdev receiving packets is supposed to provide the flags
indicating if the L4 checksum was verified and it is OK or BAD,
otherwise
From: Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote:
> From: Flavio Leitner
>
> The netdev receiving packets is supposed to provide the flags
> indicating if the L4 checksum was verified and it is OK or BAD,
> otherwise the stack will check when appropri
the reload.
This change may break existing scripts because ovs-vsctl will
start to fail when before it was succeeding. However, if an
error is printed, then it is likely that the change was not
functional anyway.
Reported-at: https://bugzilla.redhat.com/1731553
Signed-off-by: Flavio Leitner
---
On 6/30/23 12:31, Aaron Conole wrote:
Flavio Leitner writes:
Today the exit code refers to the execution of the change
in the database. However, when not using parameter --no-wait
(default), the ovs-vsctl also checks if OVSDB transactions
are successfully recorded and reload by ovs-vswitchd
ovs-vsctl will
start to fail when before it was succeeding. However, if an
error is printed, then it is likely that the change was not
functional anyway.
Reported-at: https://bugzilla.redhat.com/1731553
Signed-off-by: Flavio Leitner
---
v2:
Followed Aaron's suggestion to return EX_DATAE
On 6/26/23 16:48, Aaron Conole wrote:
Flavio Leitner writes:
Today the exit code refers to the execution of the change
in the database. However, when not using parameter --no-wait
(default), the ovs-vsctl also checks if OVSDB transactions
are successfully recorded and reload by ovs-vswitchd
rt to fail when before it was succeeding. However, if an
error is printed, then it is likely that the change was not
functional anyway.
Reported-at: https://bugzilla.redhat.com/1731553
Signed-off-by: Flavio Leitner
---
NEWS | 3 +++
tests/ovs-vsctl.at
On Mon, Mar 27, 2023 at 03:34:52PM +0200, Simon Horman wrote:
> On Wed, Mar 15, 2023 at 05:11:01PM +0800, Faicker Mo wrote:
> > Derivation cases of CVE-2020-35498:
> > 1. invalid ipv4 header total-length field
> > 2. invalid ipv6 header payload-length field
> > These may cause unwanted flow to
ution specific ways to do capability
> management as well (using for example, systemd), but they are not
> as universal to the vswitchd as a flag.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Aaron Conole
> ---
Works for me and the patch looks good now.
Thanks Aaron!
Ack
On Tue, Mar 14, 2023 at 10:46:02AM -0400, Aaron Conole wrote:
> Flavio Leitner writes:
>
> > On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote:
> >> Open vSwitch generally tries to let the underlying operating system
> >> managed the low level detail
On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote:
> Open vSwitch generally tries to let the underlying operating system
> managed the low level details of hardware, for example DMA mapping,
> bus arbitration, etc. However, when using DPDK, the underlying
> operating system yields
On Tue, Mar 07, 2023 at 12:24:37PM -0300, Flavio Leitner wrote:
> On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
> > On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
> > >
> > > Open vSwitch generally tries to let the underlying operating system
On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
> >
> > Open vSwitch generally tries to let the underlying operating system
> > managed the low level details of hardware, for example DMA mapping,
> > bus arbitration, etc.
. While TSO isn't introduced in this series, support for
> encapsulation with offload is extended.
>
> Flavio Leitner (4):
> Documentation: Document netdev offload.
> dpif-netdev: Show netdev offloading flags.
> userspace: Enable IP checksum offloading by default.
> user
On Wed, Oct 19, 2022 at 09:48:18AM -0400, Mike Pattrick wrote:
> On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote:
> >
> >
> > Hi Mike,
> >
> > Thanks for the patch.
> >
> > Does this patch need to change this line too
Hi Mike,
Thanks for the patch.
Does this patch need to change this line too?
https://github.com/openvswitch/ovs/blob/31db0e043119cf597d720d94f70ec19cf5b8b7d4/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in#L18
Wouldn't it be better to have a config option that we
can change at runtime?
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
To the set:
Acked-by: Flavio Leitner
Thanks Ilya,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
To the set:
Acked-by: Flavio Leitner
Thanks,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
To the set:
Acked-by: Flavio Leitner
Thanks Ilya,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
To the set:
Acked-by: Flavio Leitner
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
To the set:
Acked-by: Flavio Leitner
Thanks Ilya,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 3 deletions(-)
>
> --
> 2.37.3
>
--
fbl
To the set
Acked-by: Flavio Leitner
Thanks Ilya,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Sep 20, 2022 at 2:21 PM David Marchand
wrote:
> On Mon, Sep 12, 2022 at 4:47 PM Flavio Leitner wrote:
> > On Mon, Sep 12, 2022 at 5:52 AM David Marchand <
> david.march...@redhat.com> wrote:
> >> On Fri, Sep 9, 2022 at 7:58 PM Flavio Leitner wrote:
>
On Mon, Sep 12, 2022 at 5:52 AM David Marchand
wrote:
> Hi Flavio,
>
> On Fri, Sep 9, 2022 at 7:58 PM Flavio Leitner wrote:
> >
> > Thanks for working on this patch!
> >
> > It seems possible to change this patch later when the other TSO series
&g
Hi David,
Thanks for working on this patch!
It seems possible to change this patch later when the other TSO series
gets merged to disable TSO only on the affected port.
Mike, any thoughts?
I made a couple comments below.
On Fri, Sep 9, 2022 at 10:57 AM David Marchand
wrote:
> At some point
Hi,
If I recall correctly, the openvswitch-dpdk package was obsoleted
in 2016 in favor of having only one package with dpdk enabled.
Of course, upstream can decide whether it makes sense to follow
that or not.
Another thing is that openvswitch-fedora.spec should work much
better with RHEL-8
Hi Greg,
On Mon, May 23, 2022 at 09:10:36PM +0200, Ilya Maximets wrote:
> On 5/19/22 20:04, Gregory Rose wrote:
> >
> >
> > On 4/15/2022 2:42 PM, Greg Rose wrote:
> >> It is time to remove support for the OVS kernel driver and push
> >> towards use of the upstream Linux openvswitch kernel
On Mon, Jan 24, 2022 at 02:21:35PM -0500, Mike Pattrick wrote:
> On Tue, Dec 7, 2021 at 11:54 AM Flavio Leitner wrote:
> >
> > The netdev receiving packets is supposed to provide the flags
> > indicating if the IP csum was verified and it is OK or BAD,
> > otherwis
On Mon, Jan 24, 2022 at 01:39:57PM -0500, Mike Pattrick wrote:
> On Tue, Dec 7, 2021 at 11:53 AM Flavio Leitner wrote:
> >
> > Currently 'p' and 'b' and used for packets, so use
> > a convention that struct dp_packet is 'p' and
> > struct dp_packet_batch is 'b'.
>
On Thu, Feb 17, 2022 at 07:45:35PM +0100, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Feb 17, 2022 at 07:45:34PM +0100, Ilya Maximets wrote:
> Added a NEWS entry for OVSDB performance because it is user-visible.
> It was not previously mentioned since it's an aggregated result of
> various commits.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-
This is great!
Congrats to all of you that work to get this up and running.
fbl
On Tue, Feb 8, 2022 at 5:01 PM Aaron Conole wrote:
> Hi Michael,
>
> "Phelan, Michael" writes:
>
> > Hi all,
> >
> > As presented at the OVS conference in December, the AVX-512 CI is coming
> online today to test
On Tue, Jan 18, 2022 at 08:24:43PM +0100, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jan 18, 2022 at 08:24:42PM +0100, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jan 13, 2022 at 04:23:17PM +0800, Harold Huang wrote:
> From: Harold Huang
>
> When one flow is output to multiple egress ports, OVS copy the packets
> and send the copy packets to the intermediate ports. The original packets
> is sent to the last port. If the intermediate port is a dpdk
On Tue, Jan 18, 2022 at 12:27:21PM -0500, Mike Pattrick wrote:
> On Tue, Jan 18, 2022 at 11:53 AM Flavio Leitner wrote:
> >
> > On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote:
> > > On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote:
> > > >
&
On Mon, Jan 17, 2022 at 09:47:18AM -0500, Mike Pattrick wrote:
> On Fri, Jan 14, 2022 at 4:13 PM Flavio Leitner wrote:
> >
> > On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote:
> > > On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote:
> &g
On Fri, Jan 14, 2022 at 03:50:52PM -0500, Mike Pattrick wrote:
> On Fri, Jan 14, 2022 at 3:33 PM Flavio Leitner wrote:
> >
> >
> > Hi Mike,
> >
> > Thanks for working on this issue.
> >
> > On Fri, Jan 14, 2022 at 10:45:35AM -0500, Mike Patt
hen run with check-system-tso.
>
> Reported-by: Flavio Leitner
Actually, this was initially reported by Ilya.
> Signed-off-by: Mike Pattrick
> ---
> lib/conntrack.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> i
> > Cc: i.maxim...@ovn.org; Stokes, Ian ; Flavio Leitner
> > ; Kevin Traynor
> > Subject: Re: [PATCH v4 0/9] Actions Infrastructure + Optimizations
> >
> > On 1/6/22 14:11, Van Haaren, Harry wrote:
> > >> -Original Message-
> &g
>
> + cnt = netdev_dpdk_common_send(netdev, batch, );
> +
> +dropped = batch_cnt - cnt;
> +
> dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, cnt);
> if (OVS_UNLIKELY(dropped)) {
> struct netdev_dpdk_sw_stats *sw_stats = dev->sw_stats;
that.
This patch skips the tunnel tests when the userspace TSO is enabled.
Fixes: 29bb3093eb8b ("userspace: Enable TSO support for non-DPDK.")
Signed-off-by: Flavio Leitner
---
tests/system-common-macros.at | 8
tests/system-traffic.at | 17 +
tests/system-tso-macros.
]
https://doc.dpdk.org/guides/prog_guide/mbuf_lib.html#meta-information
Signed-off-by: Flavio Leitner
---
Documentation/topics/userspace-tso.rst | 12 --
lib/automake.mk| 2 -
lib/netdev-dpdk.c | 56 +++--
lib/netdev-linux.c
and finally do the work.
Finally each batch is sent in order to the netdev.
Signed-off-by: Flavio Leitner
---
lib/automake.mk | 2 +
lib/dp-packet-gso.c | 153
lib/dp-packet-gso.h | 24 +++
lib/dp-packet.h | 7 ++
lib/netdev.c| 122
-off-by: Flavio Leitner
---
lib/dp-packet.c| 1 +
lib/dp-packet.h| 27
lib/netdev-dpdk.c | 13 ++--
lib/netdev-linux.c | 78 +++---
4 files changed, 98 insertions(+), 21 deletions(-)
diff --git a/lib/dp-packet.c b/lib/dp
the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those those features without enabling TSO too.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 16 +--
lib/dp-packet.c | 23 +++-
lib/dp-packet.h | 56
lib
is not enabled.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 12 ++---
lib/dp-packet.c | 12 +
lib/dp-packet.h | 63 ---
lib/dpif.h | 2 +-
lib/flow.c | 16 --
lib
Add a new command to show the offloading features of
each data path port.
Signed-off-by: Flavio Leitner
---
lib/dpif-netdev-unixctl.man | 5
lib/dpif-netdev.c | 58 +
lib/netdev-provider.h | 3 ++
lib/netdev.c| 35
This helps to identify when it is about the flags or
the packet itself.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 8
lib/dp-packet.c | 2 +-
lib/dp-packet.h | 10 +-
lib/ipf.c | 4 ++--
lib/netdev-native-tnl.c | 4 ++--
lib
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst| 1 +
Documentation/topics/nic-offloads.rst | 95 +++
3 files changed
Rename to better represent their flags.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h| 21 +++--
lib/netdev-linux.c | 14 +++---
lib/netdev.c | 18 --
3 files changed, 22 insertions(+), 31 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp
Rename to dp_packet_ol_tx_ipv4 to align the flag.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c| 4 ++--
lib/dp-packet.h| 2 +-
lib/ipf.c | 6 +++---
lib/netdev-linux.c | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
with this patch.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.c | 342
lib/dp-packet.h | 506
2 files changed, 424 insertions(+), 424 deletions(-)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 72f6d09ac
Rename to dp_packet_ol_tcp_seg, because that is less
redundant and allows other protocols.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h| 2 +-
lib/netdev-linux.c | 2 +-
lib/netdev.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp
The name correlates better with the flag names.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c| 8
lib/dp-packet.h| 28 ++--
lib/ipf.c | 6 +++---
lib/netdev-dpdk.c | 24
lib/netdev-linux.c | 24
This represents better the state and use the same
convention as the flags.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 4 ++--
lib/dp-packet.h | 4 ++--
lib/ipf.c | 2 +-
lib/netdev-native-tnl.c | 4 ++--
4 files changed, 7 insertions(+), 7 deletions
Use the 'NETDEV_OFFLOAD_' prefix in the flags to indicate
we are talking about hardware offloading capabilities.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 20 ++--
lib/netdev-linux.c| 10 +-
lib/netdev-provider.h | 10 +-
lib/netdev.c
It seems csum is more common and shorter.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 72 +--
lib/netdev-dpdk.c | 16 +-
lib/netdev-linux.c| 8 ++---
lib/netdev-provider.h | 8 ++---
lib/netdev.c | 6 ++--
5 files
It seems csum is more common and shorter.
Signed-off-by: Flavio Leitner
---
lib/conntrack.c | 12 ++--
lib/dp-packet.h | 10 +-
lib/ipf.c | 4 ++--
lib/netdev-native-tnl.c | 4 ++--
4 files changed, 15 insertions(+), 15 deletions(-)
diff --git
details on how this
is supposed to work.
A segmentation implementation is provided (untested) to see
if the approach is good enough. Some of the challenges are
in the commit message.
The patch series currently misses the knobs to control each
feature per port. Is that desired?
Flavio Leitner
next
> refresh will set it to the new value.
>
> This is intended mostly for debugging purpose.
>
> Signed-off-by: Paolo Valerio
> ---
Acked-by: Flavio Leitner
Thanks Paolo,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail
On Thu, Nov 25, 2021 at 05:34:27PM +0100, Paolo Valerio wrote:
> Flavio Leitner writes:
>
> > On Wed, Nov 10, 2021 at 11:46:42AM +0100, Paolo Valerio wrote:
> >> with the command is now possible to change the aging time of the
> >> cache entries.
> >>
On Mon, Sep 13, 2021 at 02:36:41PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Eelco Chaudron
> > Sent: Friday, September 10, 2021 3:41 PM
> > To: Van Haaren, Harry ; i.maxim...@ovn.org;
> > Stokes, Ian ; f...@sysclose.org
> > Cc: Amber, Kumar ;
On Thu, Nov 25, 2021 at 09:22:20AM +0100, Frode Nordahl wrote:
> On Wed, Nov 24, 2021 at 9:31 PM Flavio Leitner wrote:
> >
> > On Mon, Nov 15, 2021 at 10:40:47AM +0100, Frode Nordahl wrote:
> > > On Mon, Sep 13, 2021 at 4:23 AM Frode Nordahl
> > > wrote:
>
ing.")
> Acked-by: Gaetan Rivet
> ---
If you happen to respin the series, maybe you could add
the tag Reported-at: .
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ds the entry in the cache.
>
> Signed-off-by: Paolo Valerio
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Nov 10, 2021 at 11:46:42AM +0100, Paolo Valerio wrote:
> with the command is now possible to change the aging time of the
> cache entries.
>
> For the existing entries the aging time is updated only if the
> current expiration is greater than the new one. In any case, the next
> refresh
On Wed, Nov 10, 2021 at 11:46:36AM +0100, Paolo Valerio wrote:
> Expires is modified in different threads (revalidator, pmd-rx, bfd-tx).
> It's better to use atomics for such potentially parallel write.
>
> Signed-off-by: Paolo Valerio
> ---
Acked-by:
On Mon, Nov 15, 2021 at 10:40:47AM +0100, Frode Nordahl wrote:
> On Mon, Sep 13, 2021 at 4:23 AM Frode Nordahl
> wrote:
> >
> > On Sat, Sep 11, 2021 at 10:23 PM Flavio Leitner wrote:
> > >
> > > On Fri, Sep 10, 2021 at 06:20:45PM +0200, Frode Nordahl wrote:
&g
On Tue, Nov 23, 2021 at 07:58:52PM -0300, Murilo Opsfelder Araújo wrote:
> Hi, Flavio.
>
> On 11/23/21 15:32, Flavio Leitner wrote:
> > On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote:
> > > Hi, Ilya Maximets.
> > >
> > &
On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote:
> Hi, Ilya Maximets.
>
> On 11/19/21 13:23, Ilya Maximets wrote:
> > On 11/18/21 22:19, David Christensen wrote:
> > >
> > >
> > > On 11/18/21 11:56 AM, Murilo Opsfelder Araújo wrote:
> > > > On 11/16/21 19:31, Ilya
On Tue, Nov 16, 2021 at 09:54:54PM +0100, Ilya Maximets wrote:
> On 10/25/21 16:36, Michael Santana wrote:
> > In the case that a client disables jsonrpc probes the client would fail
> > to detect if the connection to the server has dropped. To workaround
> > such case TCP keepalive is enabled.
>
a
> ---
Patch looks good and makes sense to me.
It builds fine on Windows as well.
Acked-by: Flavio Leitner
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Oct 07, 2021 at 02:35:40PM +0200, Paolo Valerio wrote:
> Tests for both ipv4 and ipv6 have been added.
Thanks for writing the unit tests.
Could you please add them as part of the patch adding the commands?
Thanks
fbl
>
> Signed-off-by: Paolo Valerio
> ---
>
Hi Paolo,
On Thu, Oct 07, 2021 at 02:35:34PM +0200, Paolo Valerio wrote:
> This is a minor issue but visible e.g. when you try to flush the neigh
> cache while the ARP flow is still present in the datapath, triggering
> the revalidation of the datapath flows which subsequntly
Typo
>
On Thu, Oct 07, 2021 at 02:35:28PM +0200, Paolo Valerio wrote:
> In case of native tunnel with bfd enabled, if the MAC address of the
> remote end's interface changes (e.g. because it got rebooted, and the
> MAC address is allocated dinamically), the BFD session will never be
> re-established.
>
On Thu, Oct 07, 2021 at 02:35:21PM +0200, Paolo Valerio wrote:
> with the command is now possible to change the ageing time of the
> cache entries.
Please start with a normal sentence using a capital letter.
> For the existing entries the ageing time is updated only if the
> current expiration
Hi Paolo,
The lookup does not change cmap, but it changes the entry which can
be used by multiple threads. In that case, we would need a mutex to
modify the entry. However, in this specific case only 'expires' is
required to change, and other fields are static. Therefore, going
with atomic op
fore joining the mcgroups.
>
> Fixes: cf114a7fce80 ("netlink linux: enable listening to all nsids")
> Cc: Flavio Leitner
> Signed-off-by: Yunjian Wang
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://
On Fri, Sep 10, 2021 at 06:23:18PM +0200, Frode Nordahl wrote:
> On Thu, Sep 9, 2021 at 10:05 PM Flavio Leitner wrote:
> >
> >
> > Hi Frode,
>
> Hello Flavio, thank you for taking the time to review.
>
> > On Wed, Aug 25, 2021 at 01:05:14PM +0200, Fr
On Fri, Sep 10, 2021 at 06:20:45PM +0200, Frode Nordahl wrote:
> On Thu, Sep 9, 2021 at 9:53 PM Flavio Leitner wrote:
> >
> >
> > Hi Frode,
> >
> > Thanks for your patch.
> > Please see my comments below.
>
> Flavio, thank you for taking the time to
Hi Frode,
On Wed, Aug 25, 2021 at 01:05:14PM +0200, Frode Nordahl wrote:
> RFC 8996 [0] deprecates the use of TLSv1 and TLSv1.1 for security
> reasons. Update our default list of protcols to be in compliance.
>
> Also add TLSv1.3 to the default list of supported protocols.
>
> 0:
Hi Frode,
Thanks for your patch.
Please see my comments below.
On Wed, Aug 25, 2021 at 01:05:13PM +0200, Frode Nordahl wrote:
> Contrary to what is stated in the documentation, when SSL
> ciphers or protocols options are omitted the default values
> will not be set. The SSL library default
gt; nl_sock_listen_all_nsid().
> >
> > Fixes: cf114a7fce80 ("netlink linux: enable listening to all nsids")
> > Cc: Flavio Leitner
> > Signed-off-by: Yunjian Wang
> > ---
> > lib/netdev-linux.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 del
in time.
>
> Ilya Maximets (2):
> Set release date for 2.16.0.
> Prepare for 2.16.1.
>
> NEWS | 5 -
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
> -
Hi,
On Tue, Jul 20, 2021 at 11:41:37AM -0700, Ben Pfaff wrote:
> The OVS review process has greatly slowed over the last few years. This
> is partly because I haven't been able to spend as much time on review,
> since I was once the most productive reviewer. Ilya has been able to
> step up
On Thu, Jul 15, 2021 at 01:39:04PM +, Ferriter, Cian wrote:
>
>
> > -Original Message-
> > From: Flavio Leitner
> > Sent: Friday 9 July 2021 18:54
> > To: Ferriter, Cian
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> > Subject:
; in the tests and a script to generate the fuzzy traffic
> type pcap to be used in fuzzy unit test.
>
> Signed-off-by: Kumar Amber
> Acked-by: Flavio Leitner
>
> ---
It looks good and works for me.
Acked-by: Flavio Leitner
Without sse4.2:
OVS-DPDK unit tests
6: OVS-DPDK -
or, hence its correctness can be easily
> tested and verified.
>
> Note that this commit is designed to easily allow addition of new
> traffic profiles in a scalable way, without code duplication for
> each traffic profile.
>
> Signed-off-by: Harry van Haaren
&g
nt. */
> +if (mfex_name_is_study) {
> +err = mfex_set_study_pkt_cnt(study_count, mfex_name);
> +if (err) {
> +ds_put_format(, "Error: failed to set study count %d for"
> + " miniflow extract implementation
; in the tests and a script to generate the fuzzy traffic
> type pcap to be used in fuzzy unit test.
>
> Signed-off-by: Kumar Amber
> Acked-by: Flavio Leitner
>
> ---
> v13:
> - fix -v in the command
> - added the configuration test case and supporting doc update
> v
On Thu, Jul 15, 2021 at 04:15:13PM +0200, Eelco Chaudron wrote:
>
> Some minor changes in output, maybe they can be done during the commit?
>
> On 15 Jul 2021, at 14:42, kumar Amber wrote:
>
> > From: Kumar Amber
> >
> > This commit introduces additional command line paramter
> > for mfex
Hi,
I have reviewed more patches, but there are some that Eelco
requested to follow up with fixes, so I am going to wait as well.
Thanks,
fbl
On Wed, Jul 14, 2021 at 07:44:33PM +0530, kumar Amber wrote:
> v12:
> - re-work the set command to sweep method
> - changes skip for unit-test to true
default-autovalidator
>
> Signed-off-by: Kumar Amber
> Co-authored-by: Harry van Haaren
> Signed-off-by: Harry van Haaren
> Acked-by: Eelco Chaudron
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https:/
run at runtime using the following command:
>
> $ ovs-appctl dpif-netdev/miniflow-parser-set study
>
> Signed-off-by: Kumar Amber
> Co-authored-by: Harry van Haaren
> Signed-off-by: Harry van Haaren
> Acked-by: Eelco Chaudron
>
> ---
Acked-by: Flavio Leitner
___
Harry van Haaren
> Acked-by: Eelco Chaudron
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s-appctl dpif-netdev/miniflow-parser-set name
>
> This allows for more performance and flexibility to the user to choose
> the miniflow implementation according to the needs.
>
> Signed-off-by: Kumar Amber
> Co-authored-by: Harry van Haaren
> Signed-off-by: Harry van H
;
> ---
This patch looks good and works for me.
Acked-by: Flavio Leitner
Thanks Kumar and Harry,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s good and works for me.
One concern is that UINT32_MAX is used as reserved number to indicate
no kernel support in OVS but the user can try to set the cache size to
that number which would be valid. However, the kernel has a netlink
policy defining a range o
it rate:4.21%
> port 0: ovs-system (internal)
> port 1: genev_sys_6081 (geneve: packet_type=ptap)
> port 2: br-int (internal)
> port 3: br-ex (internal)
> port 4: eth2
> port 5: sw1p1 (internal)
> port 6: sw0p4 (internal)
>
> Signed-off-by:
1 - 100 of 1013 matches
Mail list logo
