[ovs-dev] [PATCH] ovsdb-idl.at: Fix test failed. (writing large data via IDL with unicode)

2018-03-22 Thread Guoshuai Li
The uuidfilt command is not supported in branch 2.8 and earlier. Modify the test so that it can be tested successfully. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- This patch is for branch-2.8/branch-2.7. --- tests/ovsdb-idl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ovs-dev] [PATCH v2] ovn-controller: support MAC_Binding aging

2018-03-19 Thread Guoshuai Li
, to records timestamps and ARP send times. Time traversal cache to send ARP requests or aging. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v2: Reconstruction and Fix code for check chassis. --- ovn/controller/pinctrl.c | 353 +-- tests/

Re: [ovs-dev] [PATCH] OVN: Add support for ARP renewal and expiration.

2018-03-15 Thread Guoshuai Li
Hello Tiago Lam I'm so sorry. I didn't find you until after completing my patch. Their function is the same. https://patchwork.ozlabs.org/project/openvswitch/list/?series=33916 I can not cherry pick this patch to the master, so I just looked simple. I found our thinking is very similar.

[ovs-dev] [PATCH 1/2] ovn-controller: support MAC_Binding aging

2018-03-15 Thread Guoshuai Li
, to records timestamps and ARP send times. Time traversal cache to send ARP requests or aging. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/controller/pinctrl.c | 363 +++ 1 file changed, 363 insertions(+) diff --git a/ovn/controller/pinct

[ovs-dev] [PATCH 2/2] ovn-controller: Add MAC_Binding aging test

2018-03-15 Thread Guoshuai Li
Add a test case: The MAC_Binding ages when an ARP packet is not received. And it does not age when it receives an arp packet. 20 minutes is too long for testing, so add commands to set the MAC_Binding aging time. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/controller/pinctrl.

[ovs-dev] [PATCH v3] ctl-option: add --inactivity-probe= option in set targets commands

2018-03-12 Thread Guoshuai Li
:0.0.0.0 ovn-sbctl --inactivity-probe=3 set-connection ptcp:6642:0.0.0.0 Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/utilities/ovn-nbctl.8.xml | 6 -- ovn/utilities/ovn-nbctl.c | 11 ++- ovn/utilities/ovn-sbctl.c | 11 ++- tests/ovn-nbctl.at

Re: [ovs-dev] [PATCH v3] ovn-controller: Support multiple gateway port on a distributed router

2018-03-12 Thread Guoshuai Li
Numan On 14 February 2018 at 16:42, Ben Pfaff <b...@ovn.org <mailto:b...@ovn.org>> wrote: > Hi Guru.  Are you willing to take a look at this patch? > > Thanks, > > Ben. > > On Fri, Feb 09

[ovs-dev] [PATCH v4] ovn-controller: Support multiple gateway port on a distributed router

2018-03-12 Thread Guoshuai Li
, and the ingress port is not a gateway, it is necessary to route to the actual outgoing port. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/northd/ovn-northd.8.xml | 22 +--- ovn/northd/ovn-northd.c | 279 +--- ovn/ovn-nb.xml

Re: [ovs-dev] [PATCH v2] ovn-nb/sbctl: add inactivity probe in ovn-nb/sbctl set-connection

2018-03-12 Thread Guoshuai Li
On Thu, Mar 08, 2018 at 07:24:47PM +0800, Guoshuai Li wrote: From: Dong Jun <do...@dtdream.com> This patch can set inactivity probe for connection by command ovn-nbctl set-connection inactivity_probe=3 ptcp:6641:0.0.0.0 ovn-sbctl set-connection inactivity_probe=3 ptcp:6642:0

[ovs-dev] [PATCH] ovn-nb/sbctl: add inactivity probe in ovn-nb/sbctl set-connection

2018-03-06 Thread Guoshuai Li
From: Dong Jun <do...@dtdream.com> This patch can set inactivity probe for connection by command ovn-nbctl set-connection inactivity_probe=3 ptcp:6641:0.0.0.0 ovn-sbctl set-connection inactivity_probe=3 ptcp:6642:0.0.0.0 Signed-off-by: Guoshuai Li <l...@dtdream.com> --- o

Re: [ovs-dev] [PATCH v2] python: Fix decoding error when the received data is larger than 4096.

2018-02-28 Thread Guoshuai Li
Thanks Ben, this is really a good interface, it makes the code change is simple. A new patch: https://mail.openvswitch.org/pipermail/ovs-dev/2018-March/344845.html It looks like we should be using IncrementalDecoder:

[ovs-dev] [PATCH v4] python: Fix decoding error when the received data is larger than 4096.

2018-02-28 Thread Guoshuai Li
It can only receive 4096 bytes of data each time in jsonrpc, when there are similar and Chinese characters occupy multiple bytes, it may receive half a character, this time the decoding will be abnormal. We need to receive the completed character to decode. Signed-off-by: Guoshuai Li &l

Re: [ovs-dev] [PATCH] selinux: allow dpdkvhostuserclient sockets with newer libvirt

2018-02-26 Thread Guoshuai Li
diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index c1a774f0e..7b9c1c7a0 100644 --- a/selinux/openvswitch-custom.te.in +++ b/selinux/openvswitch-custom.te.in @@ -14,6 +14,7 @@ require { type hugetlbfs_t; type kernel_t; type

Re: [ovs-dev] [PATCH v2] python: Fix decoding error when the received data is larger than 4096.

2018-02-25 Thread Guoshuai Li
On Sun, Feb 18, 2018 at 08:51:16PM +0800, Guoshuai Li wrote: It can only receive 4096 bytes of data each time in jsonrpc, when there are similar and Chinese characters occupy multiple bytes, it may receive half a character, this time the decoding will be abnormal. We need to receive

[ovs-dev] [PATCH v3] python: Fix decoding error when the received data is larger than 4096.

2018-02-25 Thread Guoshuai Li
: Ie20c2b4632825fa8dfc60586e9b6d51a03355f4c Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/jsonrpc.py | 16 +++- tests/ovsdb-idl.at| 34 ++ 2 files changed, 45 insertions(+), 5 deletions(-) diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py index d28

Re: [ovs-dev] [PATCH] python: Fix decoding error when the received data is larger than 4096.

2018-02-18 Thread Guoshuai Li
the completed character to decode. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/jsonrpc.py | 14 +- tests/ovsdb-idl.at| 34 ++ 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py

[ovs-dev] [PATCH v2] python: Fix decoding error when the received data is larger than 4096.

2018-02-18 Thread Guoshuai Li
It can only receive 4096 bytes of data each time in jsonrpc, when there are similar and Chinese characters occupy multiple bytes, it may receive half a character, this time the decoding will be abnormal. We need to receive the completed character to decode. Signed-off-by: Guoshuai Li &l

[ovs-dev] [PATCH] python: Fix decoding error when the received data is larger than 4096.

2018-02-18 Thread Guoshuai Li
It can only receive 4096 bytes of data each time in jsonrpc, when there are similar and Chinese characters occupy multiple bytes, it may receive half a character, this time the decoding will be abnormal. We need to receive the completed character to decode. Signed-off-by: Guoshuai Li &l

Re: [ovs-dev] [PATCH] ovn-controller: Fix crash when sending GARP when openflow disconnection.

2018-02-15 Thread Guoshuai Li
Thanks for fixing the bug! I think we should not log a warning about this. It is pretty much unavoidable that sometimes the controller will be disconnected from the switch, especially at controller startup. WARN level log messages should be reserved for situations that are likely to

[ovs-dev] [PATCH v2] ovn-controller: Fix crash when sending GARP when openflow disconnection.

2018-02-15 Thread Guoshuai Li
=0x7fffc080) at ovn/controller/pinctrl.c:2069 Signed-off-by: Guoshuai Li <l...@dtdream.com> Acked-by: Mark Michelson <mmich...@redhat.com> --- ovn/controller/pinctrl.c | 38 -- tests/ovn.at | 13 + 2 files changed, 33 inser

[ovs-dev] [PATCH] ovn-controller: Fix crash when sending GARP when openflow disconnection.

2018-02-12 Thread Guoshuai Li
=0x7fffc080) at ovn/controller/pinctrl.c:2069 Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/controller/pinctrl.c | 40 ++-- tests/ovn.at | 14 ++ 2 files changed, 36 insertions(+), 18 deletions(-) diff --git a/ovn/controller/pin

[ovs-dev] [PATCH v3] ovn-controller: Support multiple gateway port on a distributed router

2018-02-08 Thread Guoshuai Li
, and the ingress port is not a gateway, it is necessary to route to the actual outgoing port. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/northd/ovn-northd.8.xml | 22 +--- ovn/northd/ovn-northd.c | 273 +--- ovn/ovn-nb.xml

[ovs-dev] [PATCH v2] ovn-controller: Support multiple gateway port on a distributed router

2018-02-08 Thread Guoshuai Li
, and the ingress port is not a gateway, it is necessary to route to the actual outgoing port. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/northd/ovn-northd.8.xml | 22 +--- ovn/northd/ovn-northd.c | 271 +--- ovn/ovn-nb.xml

[ovs-dev] [PATCH] ovn-northd: Support logical router port with config CIDR, such as 192.168.1.0/24.

2018-02-06 Thread Guoshuai Li
port without IP. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/northd/ovn-northd.c | 114 +++- ovn/ovn-nb.xml | 7 +++ tests/system-ovn.at | 8 3 files changed, 118 insertions(+), 11 deletions(-) diff --git a/ovn/nort

[ovs-dev] [PATCH] ovn-controller: processing matches precedes processing action in logical flow.

2018-02-01 Thread Guoshuai Li
tion field. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/controller/lflow.c | 63 +- tests/ovn.at | 15 +++- 2 files changed, 51 insertions(+), 27 deletions(-) diff --git a/ovn/controller/lflow.c b/ovn/controll

[ovs-dev] [PATCH] ovn-nbctl: Add QoS commands.

2018-01-26 Thread Guoshuai Li
This patch provides the command line to add/delete/list QoS rule on the logical switch. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovn/utilities/ovn-nbctl.8.xml | 36 +++ ovn/utilities/ovn-nbctl.c | 231 ++ tests/ovn-nb

Re: [ovs-dev] [PATCH v5 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2018-01-24 Thread Guoshuai Li
On Wed, Dec 06, 2017 at 12:32:39PM +0800, Guoshuai Li wrote: The structure and function of the group table and meter table are similar, refactoring code is used to extend for add the meter table. The following function as lib: table init/destroy/clear, install contents from desired, remove

[ovs-dev] [PATCH v6 2/2] ovn: OVN Support QoS meter

2018-01-24 Thread Guoshuai Li
action process openflow meter table. Now, This feature is only supported in DPDK. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- NEWS| 1 + include/ovn/actions.h | 13 - ovn/controller/lflow.c | 10 +++- ovn/controller/lflow.h

[ovs-dev] [PATCH v6 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2018-01-24 Thread Guoshuai Li
The structure and function of the group table and meter table are similar, refactoring code is used to extend for add the meter table. The following function as lib: table init/destroy/clear/lookup/remove, assign id for contents, Move the contents of desired to existing. Signed-off-by: Guoshuai

[ovs-dev] [PATCH v6 0/2] OVN Support QoS meter

2018-01-24 Thread Guoshuai Li
: rebase for ovn/ovn-nb.ovsschema conflict. v5-v6: 1. extend-table: Use iterator macro instead of create callback. 2. extend-table: Minor style fixups. Guoshuai Li (2): ovn-controller: Add extend_table instead of group_table to expand meter. ovn: OVN Support QoS meter NEWS

Re: [ovs-dev] [PATCH] The dependency between ovndb_servers-master and VirtualIP is wrong

2018-01-23 Thread Guoshuai Li
Hello, xurong, zhaojingjing: At that time, in order to avoid the problem of losing after the active/slave switchover, the slave node was promote prior to the start of the VIP.

[ovs-dev] [PATCH v5 0/2] ovn: OVN Support QoS meter

2017-12-05 Thread Guoshuai Li
Guoshuai Li (2): ovn-controller: Add extend_table instead of group_table to expand meter. ovn: OVN Support QoS meter NEWS| 1 + include/ovn/actions.h | 34 +++-- ovn/controller/lflow.c | 18 ++- ovn/controller/lflow.h | 5

[ovs-dev] [PATCH v5 2/2] ovn: OVN Support QoS meter

2017-12-05 Thread Guoshuai Li
action process openflow meter table. Now, This feature is only supported in DPDK. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- V4: 1. Fix checkpatch error. 2. The local rate variable uses uint64_t. This can support a very large rate. 3. Fix formatting mismatch issues. 4. Repair met

[ovs-dev] [PATCH v5 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2017-12-05 Thread Guoshuai Li
. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- include/ovn/actions.h | 21 + ovn/controller/lflow.c | 8 +- ovn/controller/lflow.h | 4 +- ovn/controller/ofctrl.c | 180 +--- ovn/controller/ofctrl.h | 7 +

Re: [ovs-dev] [PATCH V4 1/2] netdev-dpdk: DPDK v17.11 upgrade

2017-12-04 Thread Guoshuai Li
Hello, I tested it. It is ok for my meter patch: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341544.html This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in

Re: [ovs-dev] [PATCH v3] ovn: OVN Support QoS meter

2017-12-04 Thread Guoshuai Li
for meter action process openflow meter table. Now, This feature is only supported in DPDK. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v3: Fix bandwidth mix error. rebasing. v2: Fix Ingress/Egress Table id error. Thank you for working on this feature. New QoS features are welcome

[ovs-dev] [PATCH V4 2/2] ovn: OVN Support QoS meter

2017-12-04 Thread Guoshuai Li
action process openflow meter table. Now, This feature is only supported in DPDK. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- V4: 1. Fix checkpatch error. 2. The local rate variable uses uint64_t. This can support a very large rate. 3. Fix formatting mismatch issues. 4. Repair met

[ovs-dev] [PATCH V4 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2017-12-04 Thread Guoshuai Li
. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v4: 1. Add extend_table instead of group_table. --- include/ovn/actions.h | 21 + ovn/controller/lflow.c | 8 +- ovn/controller/lflow.h | 4 +- ovn/controller/ofctrl.c

Re: [ovs-dev] [PATCH] types: New macros ETH_ADDR_C and ETH_ADDR64_C.

2017-11-30 Thread Guoshuai Li
I also have this problem in centos. I try it, remove "-std=gnu99" for gcc is worked. [root@vNetCI ~]# gcc lgs.c [root@vNetCI ~]# [root@vNetCI ~]# gcc -std=gnu99 lgs.c lgs.c:9:15: error: initializer element is not constant = (struct eth_addr) { { .ea =  { 0x00, 0x23, 0x20, 0x00, 0x00, 0x01

Re: [ovs-dev] QoS Meters in OVSSwitch

2017-11-30 Thread Guoshuai Li
Hello, The port outside the hypervisor, Do you use dpdk-port  ?  such as:     Bridge br-agg     Port bond-agg     Interface "agg-dpdk-1"     type: dpdk     options: {dpdk-devargs=":02:00.0", n_rxq="4"}     Interface "agg-dpdk-2"    

Re: [ovs-dev] [PATCH v2] netdev-linux: Do not remove ingress qdisc when policing is never enabled.

2017-11-30 Thread Guoshuai Li
On Thu, Nov 16, 2017 at 02:18:26PM +0800, Guoshuai Li wrote: rate limiting may be implemented in other ways (such as nova/libvirt), ovs never enable policing. I think ovs need not control qdisc, such as remove qdisk added by other. Signed-off-by: Guoshuai Li <l...@dtdream.com> Sign

Re: [ovs-dev] [PATCH] netdev-linux: do not remove ingress qdisc when disable policing.

2017-11-15 Thread Guoshuai Li
I'm sorry for my mistake. I did not think so much I actually want to express the meaning is tc qdisc should not be operated when never enabled policing. Because my question is this:    step1. Configure the tc command at the ovs-port   # tc qdisc add dev ovs-port ingress   # tc qdisc

[ovs-dev] [PATCH v2] netdev-linux: Do not remove ingress qdisc when policing is never enabled.

2017-11-15 Thread Guoshuai Li
rate limiting may be implemented in other ways (such as nova/libvirt), ovs never enable policing. I think ovs need not control qdisc, such as remove qdisk added by other. Signed-off-by: Guoshuai Li <l...@dtdream.com> Signed-off-by: huweihua <h...@dtdream.com> --- v2: Fix cannot disa

Re: [ovs-dev] [PATCH v2] ovn: OVN Support QoS meter

2017-11-13 Thread Guoshuai Li
On Wed, Sep 20, 2017 at 07:52:34PM +0800, Guoshuai Li wrote: ovn-northd modify: add bandwidth column in NB's QOS table. add QOS_METER stages in Logical switch ingress/egress. add set_meter() action in SB's LFlow table. ovn-controller modify: add meter_table for meter action process openflow

[ovs-dev] [PATCH v3] ovn: OVN Support QoS meter

2017-11-13 Thread Guoshuai Li
action process openflow meter table. Now, This feature is only supported in DPDK. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v3: Fix bandwidth mix error. rebasing. v2: Fix Ingress/Egress Table id error. --- NEWS| 1 + include/ovn/actions.h

Re: [ovs-dev] [PATCH] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-11-13 Thread Guoshuai Li
On Fri, Nov 03, 2017 at 02:41:54PM -0700, Ben Pfaff wrote: On Fri, Oct 13, 2017 at 10:09:51PM +0800, Guoshuai Li wrote: When sending a localnet port with vlan, the GARP packet needs push_vlan. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v3: Add garp-vlan test. v2: Add

[ovs-dev] [PATCH] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-11-13 Thread Guoshuai Li
When sending a localnet port with vlan, the GARP packet needs push_vlan. Signed-off-by: Guoshuai Li <l...@dtdream.com> Signed-off-by: Ben Pfaff <b...@ovn.org> --- This patch is to resolve the conflicts for cherry-pick to branch-2.7/branch-2.6 https://mail.openvswitch.org/pipermail/

[ovs-dev] [PATCH] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-10-13 Thread Guoshuai Li
When sending a localnet port with vlan, the GARP packet needs push_vlan. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- v3: Add garp-vlan test. v2: Add check vlan vaid. Add update localnet vlan tag process. --- ovn/controller/pinctrl.c | 16 +--- tests/

[ovs-dev] [PATCH] netdev-linux: do not remove ingress qdisc when disable policing.

2017-10-13 Thread Guoshuai Li
rate limiting may be implemented in other ways (such as nova), this time need to disable rate limiting. I think it should not remove tc qdisk when ingress_policing_burst is disabled. Signed-off-by: Guoshuai Li <l...@dtdream.com> Co-authored-by: huweihua <h...@dtdream.com> --- lib/ne

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Use separate thread for packet-in processing.

2017-09-26 Thread Guoshuai Li
This is very useful to me. I found a problem in my use: In the ovn-controller and the south of the database connection,when the ovn-controller as a passive service, the SB as a client, such as configured to ovs-vsctl set Open_vSwitch . external-ids:ovn-remote=ptcp:6644:0.0.0.0 ovn-sbctl

[ovs-dev] [PATCH v3] dpif-netdev: Set MAX_RECIRC_DEPTH to 6.

2017-09-22 Thread Guoshuai Li
. This has an WARN: dpif_netdev(pmd36)|WARN|Packet dropped. Max recirculation depth exceeded. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index ca74df8c7..a0f620a5c

Re: [ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

2017-09-21 Thread Guoshuai Li
te: On 9/20/17, 4:45 AM, "Guoshuai Li" <l...@dtdream.com> wrote: yes, Distributed gateway. I config my gateway router port with 'redirect-chassis'option in ovn-nb. Logical_Router_Port table _uuidenabled externa

Re: [ovs-dev] [PATCH v2] ovn: OVN Support QoS meter

2017-09-21 Thread Guoshuai Li
Pelayo write: I thought we didn't have meters yet in OvS switch implementation (beyond openflow protocol support) as per: http://docs.openvswitch.org/en/latest/faq/qos/ Has this changed in master? On Wed, Sep 20, 2017 at 1:52 PM, Guoshuai Li <l...@dtdream.com <mailto:l...@dtdream.com&g

[ovs-dev] [PATCH v2] dpif-netdev: Set MAX_RECIRC_DEPTH to 6.

2017-09-21 Thread Guoshuai Li
In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than 5. Scenes: VM ping self floating IP, or VM ping Floating IP of VMs with the same network. It need process UNDNAT SNAT in LRouter egress and UNSNAT DNAT in LRouter ingress, and output to geneve tunnel also need recirc. This

[ovs-dev] [PATCH v2] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-09-20 Thread Guoshuai Li
When sending a localnet port with vlan, the GARP packet needs push_vlan. --- v2: Add check vlan vaid. Add update localnet vlan tag process. --- ovn/controller/pinctrl.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/ovn/controller/pinctrl.c

[ovs-dev] [PATCH v2] ovn: OVN Support QoS meter

2017-09-20 Thread Guoshuai Li
ovn-northd modify: add bandwidth column in NB's QOS table. add QOS_METER stages in Logical switch ingress/egress. add set_meter() action in SB's LFlow table. ovn-controller modify: add meter_table for meter action process openflow meter table. This feature is only supported in DPDK. --- v2: Fix

Re: [ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

2017-09-20 Thread Guoshuai Li
s=0/0x3,ttl=62)),2 在 2017/9/20 9:23, Darrell Ball : Distributed gateway ? What do the kernel datapath flows look like ? On 9/18/17, 11:29 PM, "ovs-dev-boun...@openvswitch.org on behalf of Guoshuai Li" <ovs-dev-boun...@openvswitch.org on behalf of l...@dtdream.com> wrote: In an

[ovs-dev] [PATCH] ovn: OVN Support QoS meter

2017-09-19 Thread Guoshuai Li
ovn-northd modify: add bandwidth column in NB's QOS table. add QOS_METER stages in Logical switch ingress/egress. add set_meter() action in SB's LFlow table. ovn-controller modify: add meter_table for meter action process openflow meter table. This feature is only supported in DPDK. --- NEWS

[ovs-dev] [PATCH] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-09-19 Thread Guoshuai Li
When sending a localnet port with vlan, the GARP packet needs push_vlan. --- ovn/controller/pinctrl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/ovn/controller/pinctrl.c b/ovn/controller/pinctrl.c index 469a35586..cf4f1331a 100644 ---

[ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

2017-09-19 Thread Guoshuai Li
In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than 5. Scenes: VM ping self floating IP, or VM ping Floating IP of VMs with the same network. It need process UNDNAT SNAT in LRouter egress and UNSNAT DNAT in LRouter ingress, and output to geneve tunnel also need recirc. This

Re: [ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

2017-04-27 Thread Guoshuai Li
Good. Better than me, learning. This is an alternative solution patch for the issue reported by Raymond Burkholder and the patch submitted by Guoshuai Li. It uses the acinclude.m4 configuration file to check for the net parameter that was added to the ipv4 and ipv6 frags init functions

Re: [ovs-dev] [PATCH] compat: Fix build error in kernel 4.10.0

2017-04-26 Thread Guoshuai Li
I try remove "nf_defrag_ipv{4|6}_enabl", and then test by lsmod: stack@devstack:~$ lsmod | grep defrag nf_defrag_ipv6 36864 1 nf_conntrack_ipv6 nf_defrag_ipv4 16384 1 nf_conntrack_ipv4 stack@devstack:~$ lsmod | grep conntrack nf_conntrack_ipv6 20480 1 nf_defrag_ipv6

Re: [ovs-dev] [PATCH] compat: Fix build error in kernel 4.10.0

2017-04-26 Thread Guoshuai Li
Thanks all, I'm considering rolling the following incremental into this patch, does this make sense? looks good to me ~~ diff --git a/datapath/linux/compat/ip_fragment.c b/datapath/linux/compat/ip_fragment.c index efa86fcfae1b..de08f6c6744e 100644 --- a/datapath/linux/compat/ip_fragment.c +++

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

2017-04-25 Thread Guoshuai Li
Sure, here it is: make -C /lib/modules/4.11.0-rc7+/build M=/home/gvrose/prj/ovs/datapath/linux modules make[4]: Entering directory `/home/gvrose/prj/net-next' CC [M] /home/gvrose/prj/ovs/datapath/linux/actions.o CC [M] /home/gvrose/prj/ovs/datapath/linux/conntrack.o CC [M]

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

2017-04-25 Thread Guoshuai Li
I did not use 4.11.rc7. My kernel of ubuntu17.04 is 4.10.0 . Can you share the build error log? Even with your patch applied I still run into compilation errors on the 4.11.rc7 upstream kernel. Perhaps there is more to do. I'll get the Debian distro as well and look into a fix there.

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

2017-04-25 Thread Guoshuai Li
I have the same problem with you, and I am troubled by this problem for a day. I wrote a patch that can be build in the 4.10 kernel: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331419.html boun...@openvswitch.org] On Behalf Of Greg Rose Sent: Tuesday, April 25, 2017 11:57

[ovs-dev] [PATCH] compat: Fix build error in kernel 4.10.0

2017-04-25 Thread Guoshuai Li
/ovs-dev/2017-April/331411.html Signed-off-by: Guoshuai Li <l...@dtdream.com> --- datapath/linux/compat/ip_fragment.c| 14 ++ datapath/linux/compat/nf_conntrack_reasm.c | 14 ++ 2 files changed, 28 insertions(+) diff --git a/datapath/linux/compat/ip_fra

[ovs-dev] [PATCH] ovn-detrace: Add ovn-detrace to fedora rpm package.

2017-04-23 Thread Guoshuai Li
Otherwise, through the "make rpm-fedora" build fedora package will be error: error: Installed (but unpackaged) file(s) found: /usr/bin/ovn-detrace /usr/share/man/man1/ovn-detrace.1.gz Signed-off-by: Guoshuai Li <l...@dtdream.com> --- rhel/openvswitch-fedora.spec.in | 2 ++

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-18 Thread Guoshuai Li
Sorry, This patch "git am" error, Please use this: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331034.html On Sun, Apr 9, 2017 at 3:23 PM, Mickey Spiegel <mickeys@gmail.com <mailto:mickeys@gmail.com>> wrote: On Thu, Apr 6, 2017 at 7

[ovs-dev] [PATCH] system-ovn.at: Add test for ping other router's port on distributed router

2017-04-18 Thread Guoshuai Li
Signed-off-by: Guoshuai Li <l...@dtdream.com> --- tests/system-ovn.at | 101 tests/system-traffic.at | 20 ++ 2 files changed, 121 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index dd62bd1..68da38a

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-18 Thread Guoshuai Li
On Sun, Apr 9, 2017 at 3:23 PM, Mickey Spiegel <mickeys@gmail.com <mailto:mickeys@gmail.com>> wrote: On Thu, Apr 6, 2017 at 7:34 AM, Guoshuai Li <l...@dtdream.com <mailto:l...@dtdream.com>> wrote:

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-06 Thread Guoshuai Li
revese my topology: +-++ | VM 172.16.1.7 | +-++ | +-++ |

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-06 Thread Guoshuai Li
revese my topology: +-++ | VM 172.16.1.7 | +-++ | +-++ | Logical Switch |

[ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-06 Thread Guoshuai Li
Hi All, I am having a problem for ovn and need help, thanks. I created two logical routes and connected the two LogicalRoutes through a external LogicalSwitch (connected to the external network) . And then LogicalRoute-1 connected to the VM through the internal LogicalSwitch . my

[ovs-dev] [PATCH v4] ovn: Modify the DHCPv4 router option to optional

2017-03-06 Thread Guoshuai Li
Co-authored-by: Dong Jun <do...@dtdream.com> Signed-off-by: Guoshuai Li <l...@dtdream.com> Acked-by: Numan Siddique <nusid...@redhat.com> --- NEWS| 2 ++ ovn/northd/ovn-northd.c | 10 +++--- ovn/ovn-nb.xml | 16 3 files chan

[ovs-dev] [PATCH V2] ovn: Modify the DHCPV4 router option to optional

2017-03-06 Thread Guoshuai Li
Co-authored-by: Dong Jun <do...@dtdream.com> Signed-off-by: Guoshuai Li <l...@dtdream.com> --- NEWS| 2 ++ ovn/northd/ovn-northd.c | 10 +++--- ovn/ovn-nb.xml | 3 ++- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/NEWS b/NEWS i

Re: [ovs-dev] [PATCH] Support multiple logical routing port configuration "redirect-chassis" on a distributed router

2017-02-27 Thread Guoshuai Li
Hi Mickey, Thanks for review. This is a quick preliminary review. I will review this in more detail tomorrow afternoon. On Mon, Feb 27, 2017 at 5:12 AM, Guoshuai Li <l...@dtdream.com <mailto:l...@dtdream.com>> wrote: The main application scenario of this patch is that t

[ovs-dev] [PATCH] Support multiple logical routing port configuration "redirect-chassis" on a distributed router

2017-02-27 Thread Guoshuai Li
flow table is generated based on the external IP lookup distributed router port, otherwise not generated. When the destination address of the packet is an external IP of the NAT rule, and the ingress port is not a gateway, it is necessary to route the actual outgoing port. Signed-off-by: Guoshuai Li

[ovs-dev] [PATCH] python: Fix Chinese characters UnicodeEncodeError exception

2017-02-20 Thread Guoshuai Li
The OVSDB client may send or recv Chinese characters. So we should use UTF-8 encoding data for send or recv by default. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/jsonrpc.py | 9 - python/ovs/stream.py | 8 2 files changed, 8 insertions(+), 9 del

[ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

2017-01-11 Thread Guoshuai Li
The default slave node connect to the master node using TCP, and the pacemaker can not modify the protocol and port of the connection. Add pacemaker parameters to support the connection of the slave node to the master node using a different protocol and port. Signed-off-by: Guoshuai Li &l

[ovs-dev] [PATCH] python: Catch exception "SSL.SysCallError" for send by SSL.

2017-01-06 Thread Guoshuai Li
When OVSDB server is aborted, the SSL send function will throw SSL.SysCallError exception, which we need to catch and return it's -errno. While SSL.WantWriteError exception needs to return -EAGAIN based on its parent class, not EAGAIN Signed-off-by: Guoshuai Li <l...@dtdream.com> --- pyth

Re: [ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

2017-01-05 Thread Guoshuai Li
On Thu, Jan 05, 2017 at 09:58:11AM -0500, Russell Bryant wrote: On Wed, Jan 4, 2017 at 6:41 PM, Ben Pfaff <b...@ovn.org> wrote: On Sun, Jan 01, 2017 at 07:04:55PM +0800, Guoshuai Li wrote: stream_or_pstream_needs_probes always return 0. This causes TCP/SSL connection not be

[ovs-dev] [PATCH] python: Add TCP/SSL probes for OVSDB python lib

2017-01-05 Thread Guoshuai Li
stream_or_pstream_needs_probes always return 0. This causes TCP/SSL connection not be probed, and no reconnect when the connection is aborted Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/stream.py | 32 +++- 1 file changed, 23 insertions

Re: [ovs-dev] [PATCH v5] ovn-ctl: add support for SSL nb/sb db connections

2017-01-04 Thread Guoshuai Li
From: "Guoshuai Li" <l...@dtdream.com> To: "Numan Siddique" <nusid...@redhat.com>, "Ben Pfaff" <b...@ovn.org> Cc: "ovs dev" <d...@openvswitch.org> Sent: Tuesday, December 27, 2016 9:14:33 AM Subject: Re: [ovs-dev] [PATCH v5] ovn-ct

Re: [ovs-dev] [PATCH v6] ovn-ctl: add support for SSL nb/sb db connections

2017-01-04 Thread Guoshuai Li
on 2017/1/4 23:36, Lance Richardson say: From: "Guoshuai Li" <l...@dtdream.com> To: "Lance Richardson" <lrich...@redhat.com>, b...@ovn.org, russ...@ovn.org, nusid...@redhat.com, d...@openvswitch.org Sent: Tuesday, January 3, 2017 8:58:40 PM Subject: Re: [

[ovs-dev] [PATCH] ovsdb: fix data loss when OVSDB replication from itself

2017-01-02 Thread Guoshuai Li
Delete the local database after receiving the master data, this is safer for data. This patch is used by HA cluster that have no way to control the order of resources, such as kubernetes. Signed-off-by: Guoshuai Li <l...@dtdream.com> --- ovsdb/replication.

[ovs-dev] [PATCH] OVN: fix OCF symbolic link lost after ovn-common upgrade

2016-12-22 Thread Guoshuai Li
The directory "/usr/lib/ocf/resource.d/ovn/" is only removed on uninstall and can not be removed while upgrading Signed-off-by: Guoshuai Li <l...@dtdream.com> --- rhel/openvswitch-fedora.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

[ovs-dev] [PATCH] python: Currently stream supported SSL

2016-12-08 Thread Guoshuai Li
Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/stream.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index b43e105..d81bedb 100644 --- a/python/ovs/stream.py +++ b/python/ovs/stream.py @@ -104,7 +104,7 @@

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

2016-12-07 Thread Guoshuai Li
On 2016/12/8 5:36, Andy Zhou wrote: On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li <l...@dtdream.com <mailto:l...@dtdream.com>> wrote: When the master node's OVNDB process fails, the local node demote to the slave. Failure cause is that the OVNDB process is stop,

[ovs-dev] [PATCH V3] python: Fix The SSL connection is not reconnected when the OVSDB Server is restarted

2016-12-06 Thread Guoshuai Li
errno. And the recv() function also throws the exception OpenSSL.SSL.ZeroReturnError when the peer's SSL connection is normal closed. This exception refers to TCP connection normal closed, return (0, "") Signed-off-by: Guoshuai Li <l...@dtdream.com> --- python/ovs/stream.py |

[ovs-dev] [PATCH] ovn: Fix the duplicate code: start) ovsdb_server_start; ;

2016-12-06 Thread Guoshuai Li
In 341 line already have this code --- ovn/utilities/ovndb-servers.ocf | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn/utilities/ovndb-servers.ocf index 72c0cf4..1cf6f20 100755 --- a/ovn/utilities/ovndb-servers.ocf +++ b/ovn/utilities/ovndb-servers.ocf @@

[ovs-dev] [PATCH V2] python: Fix The SSL connection is not reconnected when the OVSDB Server is restarted

2016-12-04 Thread Guoshuai Li
When the SSL connection is disconnected by the peer the client's do_handshake() function throws the exception OpenSSL.SSL.SysCallError we need to catch the exception and return the exception errno so that the SSL connection can be reconnected. And the recv() function throws the exception

[ovs-dev] [PATCH] python: Fix The SSL connection is not reconnected when the OVSDB Server is restarted

2016-12-04 Thread Guoshuai Li
When the SSL connection is disconnected by the peer the client's do_handshake() function throws the exception OpenSSL.SSL.SysCallError we need to catch the exception and return the exception errno so that the SSL connection can be reconnected. And the recv() function throws the exception

[ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

2016-12-02 Thread Guoshuai Li
PCS man page says role=Stopped/Started/Master/Slave. A role can be master or slave (if no role is specified, it defaults to 'started'). Command line "$pcs constraint colocation add ovndb_servers-master with master VirtualIP" means that the Started role node of ovsdb follows the master node of