nor the mask width. And the first
match will win.
Please clarify this. And in which sense OVS relies on this behavior?
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, 18 October 2022 21:40
> To: Eelco Chaudron ; d...@openvswitch.org
> Cc: i.maxim...@
:15
To: lic...@chinatelecom.cn
Cc: Jan Scheurich
Subject: RE: RE: [ovs-dev] [PATCH v5] dpif-netdev: Allow cross-NUMA polling on
selected ports
Hello Cheng,
With cross-numa enabled, we flatten the PMD list across NUMAs and select
the least loaded PMD. Thus I would not like to consider the c
> I found this one though:
> https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-
> 45444731-805e1f47a2a28e92=1=1fbc0307-e0af-4087-98ef-
> d9dbff40359a=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fopenvs
> witch%2Fpatch%2F20220403222617.31688-1-jan.scheurich%40web.de%2F
>
>
From: Jan Scheurich
A packet received from a tunnel port with legacy_l3 packet-type (e.g.
lisp, L3 gre, gtpu) is conceptually wrapped in a dummy Ethernet header
for processing in an OF pipeline that is not packet-type-aware. Before
transmission of the packet to another legacy_l3 tunnel port
screws up the patch ☹.
Any chance that you could pick the PATCH v2 manually and feed it through the
process? I doubt that I will find a solution to my mailing issues soon.
Thanks, Jan
> -Original Message-
> From: 0-day Robot
> Sent: Monday, 4 April, 2022 09:56
> To: Jan Scheur
From: Jan Scheurich
A packet received from a tunnel port with legacy_l3 packet-type (e.g.
lisp, L3 gre, gtpu) is conceptually wrapped in a dummy Ethernet header
for processing in an OF pipeline that is not packet-type-aware. Before
transmission of the packet to another legacy_l3 tunnel port
Hi Kevin,
This was a bit of a misunderstanding. We didn't check your RFC patch carefully
enough to realize that you had meant to encompass our cross-numa-polling
function in that RFC patch. Sorry for the confusion.
I wouldn't say we are particularly keen on upstreaming exactly our
> Thanks for sharing your experience with it. My fear with the proposal is that
> someone turns this on and then tells us performance is worse and/or OVS
> assignments/ALB are broken, because it has an impact on their case.
>
> In terms of limiting possible negative effects,
> - it can be opt-in
Hi Kevin,
> > We have done extensive benchmarking and found that we get better overall
> PMD load balance and resulting OVS performance when we do not statically
> pin any rx queues and instead let the auto-load-balancing find the optimal
> distribution of phy rx queues over both NUMA nodes to
atapath option as in
> your
> patch. Why not adapt our original patch to the latest OVS code base? We can
> help you with that.
> >
> > BR, Jan
> >
>
> Hi, Jan Scheurich
>
> We can achieve the static setting of pinning a phy port by combining pmd-rxq-
> isolate
> >
> > Btw, this patch is similar in functionality to the one posted by
> > Anurag [0] and there was also some discussion about this approach here [1].
> >
>
> Thanks for pointing this out.
> IMO, setting interface cross-numa would be good for phy port but not good for
> vhu. Since vhu can be
> > In our patch series we decided to skip the check on cross-numa polling
> > during
> auto-load balancing. The rationale is as follows:
> >
> > If the estimated PMD-rxq distribution includes cross-NUMA rxq assignments,
> the same must apply for the current distribution, as none of the
> >> +If using ``pmd-rxq-assign=group`` PMD threads with *pinned* Rxqs can
> >> +be
> >> +*non-isolated* by setting::
> >> +
> >> + $ ovs-vsctl set Open_vSwitch . other_config:pmd-rxq-isolate=false
> >
> > Is there any specific reason why the new pmd-rxq-isolate option should be
> limited to the
> -Original Message-
> From: dev On Behalf Of Kevin Traynor
> Sent: Thursday, 8 July, 2021 15:54
> To: d...@openvswitch.org
> Cc: david.march...@redhat.com
> Subject: [ovs-dev] [PATCH v4 2/7] dpif-netdev: Make PMD auto load balance
> use common rxq scheduling.
>
> PMD auto load balance
> -Original Message-
> From: dev On Behalf Of Kevin Traynor
> Sent: Thursday, 8 July, 2021 15:54
> To: d...@openvswitch.org
> Cc: david.march...@redhat.com
> Subject: [ovs-dev] [PATCH v4 6/7] dpif-netdev: Allow pin rxq and non-isolate
> PMD.
>
> Pinning an rxq to a PMD with
LGTM.
Acked-by: Jan Scheurich
> -Original Message-
> From: Martin Varghese
> Sent: Wednesday, 9 June, 2021 15:36
> To: d...@openvswitch.org; i.maxim...@ovn.org; Jan Scheurich
>
> Cc: Martin Varghese
> Subject: [PATCH] tests: Fixed L3 over patch port tests
>
> -Original Message-
> From: Martin Varghese
> Sent: Monday, 7 June, 2021 16:47
> To: Ilya Maximets
> Cc: d...@openvswitch.org; echau...@redhat.com; Jan Scheurich
> ; Martin Varghese
>
> Subject: Re: [ovs-dev] [PATCH v2] Fix redundant datapath set ethernet
in
patchworks.
Otherwise, LGTM.
Acked-by: Jan Scheurich
/Jan
> -Original Message-
> From: Varghese, Martin (Nokia - IN/Bangalore)
>
> Sent: Monday, 3 May, 2021 15:25
> To: Jan Scheurich
> Subject: RE: [PATCH] Fix redundant datapath set ethernet action with NSH
> Decap
>
> -Original Message-
> From: Martin Varghese
> Sent: Tuesday, 13 April, 2021 16:20
> To: Jan Scheurich
> Cc: Eelco Chaudron ; d...@openvswitch.org;
> pshe...@ovn.org; martin.vargh...@nokia.com
> Subject: Re: [PATCH v4 1/2] Encap & Decap actions for MPLS packet
for understanding the design principles behind the
implementation and some specifics for Ethernet and NSH encap/decap use cases.
Please find some more answers/comments below.
BR, Jan
> -Original Message-
> From: Martin Varghese
> Sent: Wednesday, 7 April, 2021 10:43
> To: J
, if you could provide a minimal example for
reproducing the problem.
BR, Jan
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, 6 April, 2021 10:55
> To: Martin Varghese ; Jan Scheurich
>
> Cc: d...@openvswitch.org; pshe...@ovn.org; martin.vargh...@nokia
LGTM. Please back-port to stable branches.
Acked-by: Jan Scheurich
/Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, 14 October, 2020 18:14
> To: ovs-dev@openvswitch.org; Jan Scheurich
> Cc: Ben Pfaff ; Ilya Maximets
> Subject: [PATCH v2] ofp-e
> >> Fix that by clearing padding bytes while encoding, and checking that
> >> these bytes are all zeros on decoding.
> >
> > Is the latter strictly necessary? It may break existing controllers that do
> > not
> initialize the padding bytes to zero.
> > Wouldn't it be sufficient to just zero the
Hi Ilya,
Good catch. One comment below.
/Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, 13 October, 2020 21:02
> To: ovs-dev@openvswitch.org; Jan Scheurich
> Cc: Ben Pfaff ; Yi Yang ; Ilya Maximets
>
> Subject: [PATCH] ofp-ed-props: Fix using
> -Original Message-
> From: Flavio Leitner
> On Tue, Sep 22, 2020 at 01:22:58PM +0200, Ilya Maximets wrote:
> > On 9/19/20 3:07 PM, Flavio Leitner wrote:
> > > The EMC is not large enough for current production cases and they
> > > are scaling up, so this change switches over from EMC to
Even simpler solution to the problem.
Acked-by: Jan Scheurich
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, 24 October, 2019 14:32
> To: ovs-dev@openvswitch.org
> Cc: Ian Stokes ; Kevin Traynor ;
> Jan Scheurich ; ychen103...@163.com; Ilya
>
Hi,
You have pointed out an interesting issue in the netdev datapath implementation
(not sure in how far the same applies also to the kernel datapath).
Conceptually, the dp_hash of a packet should be based on the current packet's
flow. It should not change if the headers remain unchanged.
For
> >
> > I am afraid it is not a valid assumption that there will be similarly large
> number of OVS PMD threads as there are queues.
> >
> > In OpenStack deployments the OVS is typically statically configured to use a
> few dedicated host CPUs for PMDs (perhaps 2-8).
> >
> > Typical Telco VNF VMs,
Hi Ilya,
> >
> > With a simple pvp setup of mine.
> > 1c/2t poll two physical ports.
> > 1c/2t poll four vhost ports with 16 queues each.
> > Only one queue is enabled on each virtio device attached by the guest.
> > The first two virtio devices are bound to the virtio kmod.
> > The last
Hi Ilya,
OK with me!
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, 19 March, 2019 12:08
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Kevin Traynor ; Ilya Maximets
> ; Jan Scheurich
> Subject: [PATCH] dpif-netdev-perf: Fix millis
Hi Ilya,
Thanks for spotting this. I believe your fix is correct.
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, 18 March, 2019 14:01
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Kevin Traynor ; Ilya Maximets
> ; Jan Scheurich
> Subject
a TLV-structural perspective).
I believe for MD2 metadata specified in an OF encap_nsh action we do ensure the
generated TLV structure is correct.
I hope this helps.
BR, Jan
> -Original Message-
> From: Ben Pfaff
> Sent: Thursday, 27 December, 2018 19:55
> To: Yife
Hi Zang,
Thanks for reporting this bug. As I see it, the check on dp_hash != 0 in
ofproto-dpif-xlate.c is there to guarantee that a dp_hash value has been
computed for the packet once before, not necessarily that a new one is computed
for each translated select group. That's why a check for a
> Have you considered making this token bucket per-port instead of
> per-pmd? As I read it, a greedy port can exhaust all the tokens from a
> particular PMD, possibly leading to an unfair performance for that PMD
> thread. Am I just being overly paranoid?
> [manu] Yes, this is
The user-space part for packet drop stats should be generic and work with any
dpif datapath.
So, if someone implemented the equivalent drop stats functionality in the
kernel datapath that would be very welcome.
We in Ericsson cannot do that currently due to license restrictions.
Regards, Jan
> > I was planning to if the community agreed it was warranted.
> >
> > However the general feeling expressed at the past few community calls is
> > that the next move should be to DPDK 18.11 LTS and I tend to agree with
> > this.
> >
> > The main advantage of this is the DPDK LTS lifecycle
on
even if one or more buckets are non-live.
Xlation is further simplified by storing some derived select group state
at group construction in struct group-dpif in a form better suited for
xlation purposes.
Adapted the unit test case for dp_hash select group accordingly.
Signed-off-by: Jan Scheuri
selection method "hash" with an empty list of fields in the
Group properties of the OpenFlow 1.5 Group Mod message.
Update the documentation about selection method in the ovs-ovctl man page.
Revise and complete the ofproto-dpif unit tests cases for select groups.
Signed-off-by: Jan
.
A new dpif_backer_support field 'max_hash_alg' is introduced to reflect
the highest hash algorithm a datapath supports in the dp_hash action.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Signed-off-by: Nitin Katiyar <nitin.kati...@ericsson.com>
Co-authored-by: Nitin Katiyar
n logging from INFO to DBG.
- Revised, completed and detailed select group unit test cases in
ofproto-dpif.
- Updated selection_method documentation in ovs-ofctl man page.
- Added NEWS item.
Jan Scheurich (3):
userspace datapath: Add OVS_HASH_L4_SYMMETRIC dp_hash algorithm
of
>
> Thanks for working on this.
>
> I get the following test failure with this applied (with or without the
> incremental changes I suggested for patch 2).
>
> Will you take a look?
>
The test should verify that only one of the buckets is hit when the packets
have no entropy in the custom
>
> Thanks a lot.
>
> I don't think that the new 'aux' member in ofputil_bucket is too
> useful. It looks to me like the only use of it could be kept just as
> easily in struct webster.
>
> group_setup_dp_hash_table() uses floating-point arithmetic for good
> reasons, but it seems to me that
' separator so
that is not part of the commit message.
>
> Signed-off-by: Manohar K C
> <manohar.krishnappa.chidambarasw...@ericsson.com>
> CC: Jan Scheurich <jan.scheur...@ericsson.com>
> ---
> Documentation/howto/dpdk.rst | 21 +++
selection method "hash" with an empty list of fields in the
Group properties of the OpenFlow 1.5 Group Mod message.
Update the documentation about selection method in the ovs-ovctl man page.
Revise and complete the ofproto-dpif unit tests cases for select groups.
Signed-off-by: Jan
.
A new dpif_backer_support field 'max_hash_alg' is introduced to reflect
the highest hash algorithm a datapath supports in the dp_hash action.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Signed-off-by: Nitin Katiyar <nitin.kati...@ericsson.com>
Co-authored-by: Nitin Katiyar
- Added NEWS item.
Jan Scheurich (3):
userspace datapath: Add OVS_HASH_L4_SYMMETRIC dp_hash algorithm
ofproto-dpif: Improve dp_hash selection method for select groups
ofproto-dpif: Use dp_hash as default selection method
NEWS | 2 +
datap
on
even if one or more buckets are non-live.
Xlation is further simplified by storing some derived select group state
at group construction in struct group-dpif in a form better suited for
xlation purposes.
Adapted the unit test case for dp_hash select group accordingly.
Signed-off-by: Jan Scheuri
> > I hope that Clang is intelligent enough to recognize this. If not, I
> > wouldn't know how to fix it other than by removing OVS_REQUIRES(s-
> > >stats_mutex) from pmd_perf_stats_clear_lock() and just rely on comments.
> >
> > BR, Jan
>
> Thanks Jan, that resolves the issue and there's a clear
Hi,
Thanks, everyone, for re-opening the discussion around the new packet mempool
handling for 2.10.
Before we agree on what to actually implement I’d like to summarize my
understanding of the requirements that have been discussed so far. Based on
those I want to share some thoughts about
ow to fix it other than by removing OVS_REQUIRES(s->stats_mutex) from
pmd_perf_stats_clear_lock() and just rely on comments.
BR, Jan
> -Original Message-
> From: Stokes, Ian [mailto:ian.sto...@intel.com]
> Sent: Wednesday, 25 April, 2018 11:55
> To: Jan Scheurich <jan
metrics to supervise the rx queue fill level for DPDK
vhostuser ports.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Acked-by: Billy O'Mahony <billy.o.mah...@intel.com>
---
lib/dpif-netdev.c | 2 +-
lib/netdev-bsd.c | 8 +++-
lib/netdev-dpd
Tx packets: 2399607 (2381 Kpps)
Tx batches:171400 (14.00 pkts/batch)
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Acked-by: Billy O'Mahony <billy.o.mah...@intel.com>
---
NEWS| 4 +
lib/automake.mk | 1 +
lib/dpif-ne
case this can lead OVS to detect another
suspicious iteration caused by logging.
If more than 100 iterations around a suspicious iteration have been
logged once, OVS falls back to the safe default values (-b 5/-a 5/-ne)
to avoid that logging itself causes continuos further logging.
Signed-off-by: Jan
807c157 (Bhanu).
* No other changes compared to v2.
v1 -> v2:
* Rebased to OVS master (commit 7468ec788).
* No other changes compared to v1.
Jan Scheurich (3):
netdev: Add optional qfill output parameter to rxq_recv()
dpif-netdev: Detailed performance stats for PMDs
dpif-netdev: Detection
> How about this approach, which should cleanly eliminate the warning?
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index e1a5c097f3aa..362339a4abb4 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -4780,22 +4780,17 @@
en [mailto:ychen103...@163.com]
Sent: Tuesday, 17 April, 2018 13:22
To: Jan Scheurich <jan.scheur...@ericsson.com>
Cc: d...@openvswitch.org; Nitin Katiyar <nitin.kati...@ericsson.com>;
b...@ovn.org
Subject: Re:[PATCH v2 2/3] ofproto-dpif: Improve dp_hash selection method for
select grou
> >
> > OK.
> >
> > I am going to sit on this for a few days and see whether anyone reports
> > unusual issues. If nothing arises, I'll backport as far as reasonable.
>
> I backported to branch-2.9 and branch-2.8.
Thanks, Ben.
___
dev mailing list
selection method "hash" with an empty list of fields in the
Group properties of the OpenFlow 1.5 Group Mod message.
Update the documentation about selection method in the ovs-ovctl man page.
Revise and complete the ofproto-dpif unit tests cases for select groups.
Signed-off-by: Jan
on
even if one or more buckets are non-live.
Xlation is further simplified by storing some derived select group state
at group construction in struct group-dpif in a form better suited for
xlation purposes.
Adapted the unit test case for dp_hash select group accordingly.
Signed-off-by: Jan Scheuri
.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Signed-off-by: Nitin Katiyar <nitin.kati...@ericsson.com>
Co-authored-by: Nitin Katiyar <nitin.kati...@ericsson.com>
---
datapath/linux/compat/include/linux/openvswitch.h | 4 +++
lib/flow.c
ovs-ofctl man page
- Added NEWS item
Jan Scheurich (3):
userspace datapath: Add OVS_HASH_L4_SYMMETRIC dp_hash algorithm
ofproto-dpif: Improve dp_hash selection method for select groups
ofproto-dpif: Use dp_hash as default selection method
NEWS
Just sent the adjusted version for 2.8.
/Jan
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, 13 April, 2018 20:19
> To: Jan Scheurich <jan.scheur...@ericsson.com>
> Cc: d...@openvswitch.org; yi.y.y...@intel.com
> Subject: Re: [PATCH
itting a datapath pop action.
Fixes: f839892a2 ("OF support and translation of generic encap and decap")
Fixes: 1fc11c594 ("Generic encap and decap support for NSH")
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
lib/odp-util.c | 16
() operations in a sequence of three
chained groups to test the correct handling of encap() actions in
group buckets recently fixed in commit ce4a16ac0.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
tests/nsh.at | 143 +++
a5b3e2a6f2 to the preliminary
NSH
support in OVS 2.8.
Jan Scheurich (2):
xlate: Correct handling of double encap() actions
nsh: Add unit test for double NSH encap and decap
lib/odp-util.c | 16 ++---
lib/odp-util.h | 1 +
ofproto/ofproto-dpif-xlate.c | 7
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Thursday, 12 April, 2018 18:37
>
> On Thu, Apr 12, 2018 at 05:32:11PM +0200, Jan Scheurich wrote:
> > If the caller provides a non-NULL qfill pointer and the netdev
> > implemementation support
> > I would not say this is expected behavior.
> >
> > It seems that you are executing on a somewhat slower system (tsc clock
> > seems to be 100/us = 0.1 GHz) and that, even with only 5
> lines logged before and after, the logging output is causing so much slow
> down of the PMD that it
nfigurable.
* Several bugfixes.
v2 -> v3:
* Rebased to OVS master (commit 3728b3b).
* Non-trivial adaptation to struct dp_netdev_pmd_thread.
- refactored in commit a807c157 (Bhanu).
* No other changes compared to v2.
v1 -> v2:
* Rebased to OVS master (commit 7468ec788).
* No other changes com
metrics to supervise the rx queue fill level for DPDK
vhostuser ports.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Acked-by: Billy O'Mahony <billy.o.mah...@intel.com>
---
lib/dpif-netdev.c | 2 +-
lib/netdev-bsd.c | 8 +++-
lib/netdev-dpd
case this can lead OVS to detect another
suspicious iteration caused by logging.
If more than 100 iterations around a suspicious iteration have been
logged once, OVS falls back to the safe default values (-b 5/-a 5/-ne)
to avoid that logging itself causes continuos further logging.
Signed-off-by: Jan
Tx packets: 2399607 (2381 Kpps)
Tx batches:171400 (14.00 pkts/batch)
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
Acked-by: Billy O'Mahony <billy.o.mah...@intel.com>
---
NEWS| 4 +
lib/automake.mk | 1 +
lib/dpif-ne
> > The bond of openvswitch has not good performance.
>
> Any examples?
For example, balance-tcp bond mode for L34 load sharing still requires a
recirculation after dp_hash.
I believe that it would definitely be interesting to compare bond performance
between DPDK bonding and OVS bonding with
Hi Tonghao,
Thanks for working on this. That was on my backlog to try out for a while.
One immediate feedback: This is a pure OVS user space patch. Please remove the
"net-next" tag from your patches in the next version. "net-next" is reserved
for OVS kernel module patches that are first
bly a side effect of
this.
I will try to reproduce and investigate. I will have a look at the detection
logic to see if this can be avoided.
BR, Jan
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Tuesday, 27 March, 2018 16:05
> To: Jan
into your ofproto_group_unref question.
Regards, Jan
From: ychen [mailto:ychen103...@163.com]
Sent: Wednesday, 11 April, 2018 06:16
To: Jan Scheurich <jan.scheur...@ericsson.com>
Cc: d...@openvswitch.org; Nitin Katiyar <nitin.kati...@ericsson.com>
Subject: Re:[PATCH 2/3] ofproto-dpif: Imp
> -Original Message-
> From: Yang, Yi Y [mailto:yi.y.y...@intel.com]
> Sent: Sunday, 08 April, 2018 10:27
> To: Jan Scheurich <jan.scheur...@ericsson.com>; d...@openvswitch.org
> Subject: RE: [PATCH] ofp-actions: Correct execution of encap/decap actions in
> action set
&
ailto:b...@ovn.org]
> Sent: Friday, 06 April, 2018 18:36
> To: Jan Scheurich <jan.scheur...@ericsson.com>
> Cc: d...@openvswitch.org; yi.y.y...@intel.com
> Subject: Re: [PATCH v2 0/2] Correct handling of double encap and decap actions
>
> On Fri, Apr 06, 2018 at 09:35:48AM -0700,
> > @@ -1846,11 +1846,24 @@ netdev_dpdk_vhost_rxq_recv(struct netdev_rxq *rxq,
> > batch->count = nb_rx;
> > dp_packet_batch_init_packet_fields(batch);
> >
> > +if (qfill) {
> > +if (nb_rx == NETDEV_MAX_BURST) {
> > +/* The DPDK API returns a uint32_t which often
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, 04 April, 2018 22:28
>
> Oh, that's weird. It's as if I didn't read the patch. Maybe I just
> read some preliminary version in another thread.
>
> Anyway, you're totally right. I applied this to master.
> >
> > This fix should be backported OVS 2.8 and 2.9
>
> This seems tricky. Do you plan to write a test?
Hi Ben,
I have just posted v2 where I have added an NSH unit test for double NSH plus
Ethernet encapsulation.
The test also covers encap() actions in group buckets.
BR, Jan
489)
- Added NSH unit test with double encap
Jan Scheurich (2):
xlate: Correct handling of double encap() actions
nsh: Add unit test for double NSH encap and decap
lib/odp-util.c | 16 ++---
lib/odp-util.h | 1 +
ofproto/ofproto-dpif-xlate.c | 7 ++-
tests/nsh
() operations in a sequence of three
chained groups to test the correct handling of encap() actions in
group buckets recently fixed in commit ce4a16ac0.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
tests/nsh.at | 143 +++
itting a datapath pop action.
Fixes: f839892a2 ("OF support and translation of generic encap and decap")
Fixes: 1fc11c594 ("Generic encap and decap support for NSH")
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
lib/odp-util.c | 16
an.balogh@gmail.com>
Co-authored-by: Jan Scheurich <jan.scheur...@ericsson.com>
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
include/sparse/netinet/in.h | 10 +++
ofproto/ofproto-dpif-xlate.c | 147 --
tests/tunne
ed-off-by: Zoltan Balogh <zoltan.balogh@gmail.com>
Co-authored-by: Jan Scheurich <jan.scheur...@ericsson.com>
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
tests/tunnel-push-pop-ipv6.at | 14 +++---
tests/tunnel-push-pop.at | 24 -
Currently, OVS snoops any ARP or ND packets in any bridge and populates
the tunnel neighbor cache with the retrieved data. For instance, when
ARP reply originated by a tenant is received on an overlay bridge, the
ARP packet is snooped and tunnel neighbor cache is filled with tenant
addresses,
Thanks Ben,
I hope what my patch does is precisely what you suggest. I had the same
thoughts when I had a closer look at the code.
Regards, Jan
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, 04 April, 2018 19:20
> To: Jan Scheurich
ecuted as zero is not a valid value of the ovs_seq.
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
ofproto/ofproto-dpif-upcall.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
i
03-28T18:41:24.997Z|00028|dpif(revalidator6)|DBG|system@ovs-system:
flow_dump_destroy success
> -Original Message-
> From: Jan Scheurich
> Sent: Wednesday, 04 April, 2018 01:52
> To: Zoltán Balogh <zoltan.bal...@ericsson.com>; Justin Pettit
> <jpet...@ovn.o
t; From: Zoltán Balogh
> Sent: Friday, 02 February, 2018 15:42
> To: Justin Pettit <jpet...@ovn.org>; Ben Pfaff <b...@ovn.org>
> Cc: g...@ovn.org; d...@openvswitch.org; Jan Scheurich
> <jan.scheur...@ericsson.com>
> Subject: RE: [ovs-dev] [PATCH v3 3/3] xlate: call tnl_
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Tuesday, 03 April, 2018 20:36
>
> On Mon, Mar 26, 2018 at 09:36:27AM +0200, Jan Scheurich wrote:
> > The actions encap, decap and dec_nsh_ttl were wrongly flagged as set_field
> > actions in o
data
packet from remote VTEP? since we can fetch tun_src and outer mac sa from the
data packet.
At 2018-03-28 04:41:12, "Jan Scheurich"
<jan.scheur...@ericsson.com<mailto:jan.scheur...@ericsson.com>> wrote:
>Hi Ychen,
>
>Funny! Again we are already worki
Hi Ychen,
Funny! Again we are already working on a solution for problem 1.
In our scenario the situation arises with a tunnel next hop being a VRRP switch
pair. The switch sends periodic gratuitous ARPs (GARPs) to announce the VRRP
IP but OVS native tunneling doesn't snoop on GARPs, only on
> -Original Message-
> From: Stokes, Ian [mailto:ian.sto...@intel.com]
> Sent: Tuesday, 27 March, 2018 16:21
> To: Ilya Maximets <i.maxim...@samsung.com>; Jan Scheurich
> <jan.scheur...@ericsson.com>; d...@openvswitch.org
> Cc: ktray...@redhat.com
Hi Ilya,
This patch is the upstream version of a fix we implemented downstream a year
ago to fix the issue with massive packet drop of OVS-DPDK on Fortville NICs.
The root cause of this packet drop was the extended blocking of the
ovs-vswitchd by the i40e PMD during the
he end - but
> you asked for checkpatch changes, so I improved and ran it against your
> patch and found some stuff for which I have an opinion. :) Maybe
> nothing to hold up merging but cleanup stuff.
>
> Jan Scheurich <jan.scheur...@ericsson.com> writes:
>
> &g
itting a datapath pop action.
Fixes: f839892a2 ("OF support and translation of generic encap and decap")
Fixes: 1fc11c594 ("Generic encap and decap support for NSH")
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
This fix should be backported O
actions.
Fixes: f839892a ("OF support and translation of generic encap and decap")
Fixes: 491e05c2 ("nsh: add dec_nsh_ttl action")
Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
---
The fix should be backported to OVS 2.9 and OVS 2.8 (without the case
for OFP
Thanks for the confirmation Yi. I will post the fix straight away.
The other fix for double encap() is also ready.
BR, Jan
> -Original Message-
> From: Yang, Yi [mailto:yi.y.y...@intel.com]
> Sent: Monday, 26 March, 2018 03:42
> To: Jan Scheurich <jan.scheur...@ericss
om: Yang, Yi [mailto:yi.y.y...@intel.com]
> Sent: Friday, 23 March, 2018 08:55
> To: Jan Scheurich <jan.scheur...@ericsson.com>
> Cc: d...@openvswitch.org; Zoltán Balogh <zoltan.bal...@ericsson.com>
> Subject: Re: OVS will hit an assert if encap(nsh) is done in bucket of group
1 - 100 of 481 matches
Mail list logo
