Re: [ovs-dev] [PATCH] srv6: Fix misaligned writes to segment list.

2024-05-19 Thread Nobuhiro MIKI
;odp: Add SRv6 tunnel actions.") > Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.") > Signed-off-by: Ilya Maximets > --- > lib/netdev-native-tnl.c | 5 ++--- > lib/odp-util.c | 4 ++-- > 2 files changed, 4 insertions(+), 5 deletions(-) Hi Ilya, Thank

[ovs-dev] [PATCH ovn] Documentation: Fix broken links in ovn-sandbox.rst.

2024-02-06 Thread Nobuhiro MIKI
Signed-off-by: Nobuhiro MIKI --- Documentation/tutorials/ovn-sandbox.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/tutorials/ovn-sandbox.rst b/Documentation/tutorials/ovn-sandbox.rst index 2b574c02f153..decc8abb397a 100644

[ovs-dev] [PATCH v6 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-11-15 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Acked-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- v6: * Support multiple tables with resubmit action

Re: [ovs-dev] [PATCH v5 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-11-15 Thread Nobuhiro MIKI
On 2023/11/15 5:41, Ilya Maximets wrote: > On 11/7/23 08:30, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all di

[ovs-dev] [PATCH v5 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-11-06 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Acked-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/classifier.c | 51

Re: [ovs-dev] [PATCH v4 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-11-06 Thread Nobuhiro MIKI
On 2023/11/02 5:39, Ilya Maximets wrote: > On 10/30/23 06:00, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all dimensi

[ovs-dev] [PATCH v4 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-29 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Signed-off-by: Nobuhiro MIKI --- v4: * Fix conj_id matching * Fix priority matching * Add a new test v3

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-29 Thread Nobuhiro MIKI
On 2023/10/25 17:45, Simon Horman wrote: > On Tue, Oct 24, 2023 at 10:40:43PM +0200, Ilya Maximets wrote: >> On 10/3/23 09:41, Nobuhiro MIKI wrote: >>> On 2023/10/02 20:41, Simon Horman wrote: >>>> + Mike Pattrick >>>> >>>> On Mon,

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-29 Thread Nobuhiro MIKI
On 2023/10/25 5:37, Ilya Maximets wrote: > On 9/25/23 11:09, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all dimensi

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-03 Thread Nobuhiro MIKI
On 2023/10/02 20:41, Simon Horman wrote: > + Mike Pattrick > > On Mon, Sep 25, 2023 at 06:09:00PM +0900, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >>

[ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-09-25 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Signed-off-by: Nobuhiro MIKI --- v3: * Remove struct flow changes. * Use struct 'cls_rule' instead of struct

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:46, Ilya Maximets wrote: > On 9/15/23 05:02, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs flows of all dimensi

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:32, Ilya Maximets wrote: > On 9/20/23 13:06, Simon Horman wrote: >> On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: >>> A conjunctive flow consists of two or more multiple flows with >>> conjunction actions. When input to the ofprot

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 20:06, Simon Horman wrote: > On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it

Re: [ovs-dev] [PATCH v2 1/2] flow: Add list node for the conjunctive flow.

2023-09-21 Thread Nobuhiro MIKI
On 2023/09/20 21:31, Ilya Maximets wrote: > On 9/15/23 05:02, Nobuhiro MIKI wrote: >> In subsequent patches, flows need to be grouped in >> a list and treated as a conjunctive flow. >> >> Signed-off-by: Nobuhiro MIKI > > Hi. Thanks for the patch! > See some c

[ovs-dev] [PATCH v2 1/2] flow: Add list node for the conjunctive flow.

2023-09-14 Thread Nobuhiro MIKI
In subsequent patches, flows need to be grouped in a list and treated as a conjunctive flow. Signed-off-by: Nobuhiro MIKI --- include/openvswitch/flow.h | 9 ++--- lib/dpif-netdev-extract-avx512.c | 2 +- lib/flow.c | 20 ++-- lib/flow.h

[ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-14 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Signed-off-by: Nobuhiro MIKI --- lib/classifier.c | 38 - lib

[ovs-dev] [PATCH v2 0/2] Support conjunctive match in trace.

2023-09-14 Thread Nobuhiro MIKI
v2: * Reimplemented v1 with a safer and cleaner approach, since v1 was a messy implementation that rewrote const variables. Nobuhiro MIKI (2): flow: Add list node for the conjunctive flow. ofproto-dpif-trace: Support detailed output for conjunctive match. include/openvswitch/flow.h

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-12 Thread Nobuhiro MIKI
On 2023/09/12 19:34, Simon Horman wrote: > On Thu, Sep 07, 2023 at 03:08:41PM +0900, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it

[ovs-dev] [PATCH 1/1] ofproto-dpif-trace: Support detailed output for conjunctive match.

2023-09-07 Thread Nobuhiro MIKI
A conjunctive flow consists of two or more multiple flows with conjunction actions. When input to the ofproto/trace command matches a conjunctive flow, it outputs flows of all dimensions. Signed-off-by: Nobuhiro MIKI --- lib/classifier.c | 35 +++ lib

[ovs-dev] [PATCH 1/1] tests: Add clang-analyzer-results to gitignore.

2023-08-18 Thread Nobuhiro MIKI
Fixes: 30b79363b967 ("Makefile.am: Add clang static analysis support") Signed-off-by: Nobuhiro MIKI --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 83b1cb3b489e..3a8c45975645 100644 --- a/tests/.gitignore +++ b/tests/

[ovs-dev] [PATCH v5 3/3] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-22 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 35

[ovs-dev] [PATCH v5 2/3] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-22 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 13

[ovs-dev] [PATCH v5 1/3] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-22 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 23

[ovs-dev] [PATCH v5 0/3] Support flowlabel calculation in SRv6 tunnels

2023-05-22 Thread Nobuhiro MIKI
(sparse). v2: * Fix building error. Nobuhiro MIKI (3): netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header. netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header. userspace: Add new option srv6_flowlabel in SRv6 tunnel. lib/netdev-native-tnl.c | 63

Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-22 Thread Nobuhiro MIKI
On 2023/05/22 20:41, Ilya Maximets wrote: > On 5/22/23 07:05, Nobuhiro MIKI wrote: >> On 2023/05/20 10:12, Ilya Maximets wrote: >>> On 5/20/23 02:34, Ilya Maximets wrote: >>>> On 5/16/23 07:33, Nobuhiro MIKI wrote: >>>>> It supports flowlabel base

Re: [ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-22 Thread Nobuhiro MIKI
On 2023/05/22 12:09, Nobuhiro MIKI wrote: > On 2023/05/20 3:56, Ilya Maximets wrote: >> On 5/16/23 07:33, Nobuhiro MIKI wrote: >>> For tunnels such as SRv6, some popular vendor appliances support >>> IPv6 flowlabel based load balancing. In preparation for OVS to >>

Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-21 Thread Nobuhiro MIKI
On 2023/05/20 10:12, Ilya Maximets wrote: > On 5/20/23 02:34, Ilya Maximets wrote: >> On 5/16/23 07:33, Nobuhiro MIKI wrote: >>> It supports flowlabel based load balancing by controlling the flowlabel >>> of outer IPv6 header, which is already implemented in Linux k

Re: [ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-21 Thread Nobuhiro MIKI
On 2023/05/20 3:56, Ilya Maximets wrote: > On 5/16/23 07:33, Nobuhiro MIKI wrote: >> For tunnels such as SRv6, some popular vendor appliances support >> IPv6 flowlabel based load balancing. In preparation for OVS to >> support it, this patch modifies the encapsulation to al

[ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-15 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- include/linux/openvswitch.h | 3

[ovs-dev] [PATCH v4 0/2] Support flowlabel calculation in SRv6 tunnels

2023-05-15 Thread Nobuhiro MIKI
This patchset adds a feature to support the calculation of flowlabel in SRv6 tunnels. v4: * Set flowlabel on header push. * Fix docs. * Use RSS hash. v3: * Fix building error (sparse). v2: * Fix building error. Nobuhiro MIKI (2): netdev-native-tnl: Add ipv6_label param

[ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-15 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 23

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 20:50, Ilya Maximets wrote: > On 5/11/23 12:39, Nobuhiro MIKI wrote: >> On 2023/05/11 6:33, Ilya Maximets wrote: >>> On 5/9/23 11:38, Nobuhiro MIKI wrote: >>>> It supports flowlabel based load balancing by controlling the flowlabel >>>&

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 6:33, Ilya Maximets wrote: > On 5/9/23 11:38, Nobuhiro MIKI wrote: >> It supports flowlabel based load balancing by controlling the flowlabel >> of outer IPv6 header, which is already implemented in Linux kernel as >> seg6_flowlabel sysctl [1]. >> >

Re: [ovs-dev] [PATCH v3 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 5:56, Ilya Maximets wrote: > On 5/9/23 11:37, Nobuhiro MIKI wrote: >> For tunnels such as SRv6, some popular vendor appliances support >> IPv6 flowlabel based load balancing. In preparation for OVS to >> support it, this patch modifies the encapsulation to al

[ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-09 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- lib/flow.c| 24

[ovs-dev] [PATCH v3 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-09 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 14

[ovs-dev] [PATCH v3 0/2] Support flowlabel calculation in SRv6 tunnels

2023-05-09 Thread Nobuhiro MIKI
This patchset adds a feature to support the calculation of flowlabel in SRv6 tunnels. v3: * Fix building error (sparse). v2: * Fix building error. Nobuhiro MIKI (2): netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header. userspace: Add new option srv6_flowlabel in SRv6 tunnel

[ovs-dev] [PATCH v2 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-08 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- lib/flow.c| 24

[ovs-dev] [PATCH v2 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-08 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 14

[ovs-dev] [PATCH v2 0/2] Support flowlabel calculation in SRv6 tunnels

2023-05-08 Thread Nobuhiro MIKI
This patchset adds a feature to support the calculation of flowlabel in SRv6 tunnels. v2: * Fix building error. Nobuhiro MIKI (2): netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header. userspace: Add new option srv6_flowlabel in SRv6 tunnel. lib/flow.c

[ovs-dev] [PATCH 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-08 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 14

[ovs-dev] [PATCH 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-08 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- lib/flow.c| 26

[ovs-dev] [PATCH 0/2] Support flowlabel calculation in SRv6 tunnels

2023-05-08 Thread Nobuhiro MIKI
This patchset adds a feature to support the calculation of flowlabel in SRv6 tunnels. Nobuhiro MIKI (2): netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header. userspace: Add new option srv6_flowlabel in SRv6 tunnel. lib/flow.c| 26 lib

[ovs-dev] [PATCH 1/1] doc: Fix the list of supported tunnels in README.

2023-04-12 Thread Nobuhiro MIKI
Without distinguishing between IPv4 and IPv6, such as GRE and GRE-IPv6, nine types of tunneling are currently supported. Signed-off-by: Nobuhiro MIKI --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index a60a314feb34..e6c0d3d3061d

[ovs-dev] [PATCH 1/1] vswitch.xml: Add description of SRv6 tunnel and related options.

2023-03-30 Thread Nobuhiro MIKI
The description of SRv6 was missing in vswitch.xml, which is used to generate the man page, so this patch adds it. Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.") Signed-off-by: Nobuhiro MIKI --- vswitchd/vswitch.xml | 39 --- 1 file c

Re: [ovs-dev] [PATCH v12 0/5] userspace: Add SRv6 tunnel support.

2023-03-29 Thread Nobuhiro MIKI
On 2023/03/30 6:17, Ilya Maximets wrote: > On 3/29/23 07:51, Nobuhiro MIKI wrote: >> v12: >> * Fix nw_proto after encap. >> * Fix to check nw_proto in system-traffic.at. >> * Remove OVS_UNUSED annotation. >> v11: >> * Fix comments. >> * Clean up con

[ovs-dev] [PATCH v12 4/5] userspace: Add SRv6 tunnel support.

2023-03-29 Thread Nobuhiro MIKI
datapath. It uses `remote_ip` and `local_ip` options as with existing tunnel protocols. It also adds a dedicated `srv6_segs` option to define a sequence of routers called segment list. Signed-off-by: Nobuhiro MIKI --- Documentation/faq/configuration.rst | 21 + Documentation/faq/releases.rst

[ovs-dev] [PATCH v12 5/5] odp: Add SRv6 tunnel actions.

2023-03-29 Thread Nobuhiro MIKI
This patch adds ODP actions for SRv6 and its tests. Signed-off-by: Nobuhiro MIKI --- lib/odp-util.c| 70 +++ python/ovs/flow/odp.py| 8 python/ovs/tests/test_odp.py | 16 tests/odp.at | 12 +- tests

[ovs-dev] [PATCH v12 2/5] tnl-ports: Support multiple nw_protos.

2023-03-29 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 80 + 1 file changed, 48 insertions

[ovs-dev] [PATCH v12 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-29 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

[ovs-dev] [PATCH v12 0/5] userspace: Add SRv6 tunnel support.

2023-03-29 Thread Nobuhiro MIKI
hon/ovs/flow/odp.py and python/ovs/tests/test_odp.py. * fix coding style. * add build-time assertion on the structure size. v5: * rebased on latest master v4: * fix alignment on cast v3: * fix alignment on cast v2: * fix pointer arithmetic Nobuhiro MIKI (5): tests: Define new ADD_VETH_NS macro.

[ovs-dev] [PATCH v12 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs().

2023-03-29 Thread Nobuhiro MIKI
;rt_hdr" are properly parsed inside this function. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 ++-- lib/flow.c | 48 +--- lib/flow.h | 3 ++- lib/ipf.c | 15 --- lib/packets.h | 9 + 5 files changed,

Re: [ovs-dev] [PATCH v11 4/5] userspace: Add SRv6 tunnel support.

2023-03-28 Thread Nobuhiro MIKI
On 2023/03/28 21:31, Ilya Maximets wrote: > On 3/28/23 08:42, Nobuhiro MIKI wrote: >> SRv6 (Segment Routing IPv6) tunnel vport is responsible >> for encapsulation and decapsulation the inner packets with >> IPv6 header and an extended header called SRH >> (Segmen

[ovs-dev] [PATCH v11 5/5] odp: Add SRv6 tunnel actions.

2023-03-28 Thread Nobuhiro MIKI
This patch adds ODP actions for SRv6 and its tests. Signed-off-by: Nobuhiro MIKI --- lib/odp-util.c| 70 +++ python/ovs/flow/odp.py| 8 python/ovs/tests/test_odp.py | 16 tests/odp.at | 12 +- tests

[ovs-dev] [PATCH v11 4/5] userspace: Add SRv6 tunnel support.

2023-03-28 Thread Nobuhiro MIKI
datapath. It uses `remote_ip` and `local_ip` options as with existing tunnel protocols. It also adds a dedicated `srv6_segs` option to define a sequence of routers called segment list. Signed-off-by: Nobuhiro MIKI --- Documentation/faq/configuration.rst | 21 + Documentation/faq/releases.rst

[ovs-dev] [PATCH v11 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs().

2023-03-28 Thread Nobuhiro MIKI
;rt_hdr" are properly parsed inside this function. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 ++-- lib/flow.c | 48 +--- lib/flow.h | 3 ++- lib/ipf.c | 15 --- lib/packets.h | 9 + 5 files changed,

[ovs-dev] [PATCH v11 0/5] userspace: Add SRv6 tunnel support.

2023-03-28 Thread Nobuhiro MIKI
structure size. v5: * rebased on latest master v4: * fix alignment on cast v3: * fix alignment on cast v2: * fix pointer arithmetic Nobuhiro MIKI (5): tests: Define new ADD_VETH_NS macro. tnl-ports: Support multiple nw_protos. flow: Support rt_hdr in parse_ipv6_ext_hdrs(). userspace: Add SRv6 tu

[ovs-dev] [PATCH v11 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-28 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

[ovs-dev] [PATCH v11 2/5] tnl-ports: Support multiple nw_protos.

2023-03-28 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 80 + 1 file changed, 48 insertions

Re: [ovs-dev] [PATCH v10 4/5] userspace: Add SRv6 tunnel support.

2023-03-27 Thread Nobuhiro MIKI
On 2023/03/24 22:10, Ilya Maximets wrote: > On 3/24/23 11:05, Nobuhiro MIKI wrote: >> SRv6 (Segment Routing IPv6) tunnel vport is responsible >> for encapsulation and decapsulation the inner packets with >> IPv6 header and an extended header called SRH >> (Segmen

Re: [ovs-dev] [PATCH v9 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-27 Thread Nobuhiro MIKI
On 2023/03/24 21:06, Simon Horman wrote: > On Fri, Mar 24, 2023 at 01:03:00PM +0100, Ilya Maximets wrote: >> On 3/23/23 03:57, Nobuhiro MIKI wrote: >>> On 2023/03/22 21:21, Simon Horman wrote: >>>> On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote: >&g

[ovs-dev] [PATCH v10 4/5] userspace: Add SRv6 tunnel support.

2023-03-24 Thread Nobuhiro MIKI
datapath. It uses `remote_ip` and `local_ip` options as with existing tunnel protocols. It also adds a dedicated `srv6_segs` option to define a sequence of routers called segment list. Signed-off-by: Nobuhiro MIKI --- Documentation/faq/configuration.rst | 21 + Documentation/faq/releases.rst

[ovs-dev] [PATCH v10 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs().

2023-03-24 Thread Nobuhiro MIKI
;rt_hdr" are properly parsed inside this function. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 ++-- lib/flow.c | 48 +--- lib/flow.h | 3 ++- lib/ipf.c | 15 --- lib/packets.h | 9 + 5 files changed,

[ovs-dev] [PATCH v10 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-24 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

[ovs-dev] [PATCH v10 5/5] odp: Add SRv6 tunnel actions.

2023-03-24 Thread Nobuhiro MIKI
This patch adds ODP actions for SRv6 and its tests. Signed-off-by: Nobuhiro MIKI --- lib/odp-util.c| 70 +++ python/ovs/flow/odp.py| 8 python/ovs/tests/test_odp.py | 16 tests/odp.at | 12 +- tests

[ovs-dev] [PATCH v10 2/5] tnl-ports: Support multiple nw_protos.

2023-03-24 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 83 ++--- 1 file changed, 51 insertions

[ovs-dev] [PATCH v10 0/5] userspace: Add SRv6 tunnel support.

2023-03-24 Thread Nobuhiro MIKI
s/flow/odp.py and python/ovs/tests/test_odp.py. * fix coding style. * add build-time assertion on the structure size. v5: * rebased on latest master v4: * fix alignment on cast v3: * fix alignment on cast v2: * fix pointer arithmetic Nobuhiro MIKI (5): tests: Define new ADD_VETH_NS macro. tnl

Re: [ovs-dev] [PATCH v9 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-22 Thread Nobuhiro MIKI
On 2023/03/22 21:21, Simon Horman wrote: > On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote: >> Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. >> If it exists, the first address is retrieved. >> >> Signed-off-by: Nobuhiro MIKI >

Re: [ovs-dev] [PATCH v9 2/5] tnl-ports: Support multiple nw_protos.

2023-03-22 Thread Nobuhiro MIKI
On 2023/03/22 20:59, Simon Horman wrote: > On Wed, Mar 15, 2023 at 03:07:22PM +0900, Nobuhiro MIKI wrote: >> In some tunnels, inner packet needs to support both IPv4 >> and IPv6. Therefore, this patch improves to allow two >> protocols to be tied together in one tunnel

Re: [ovs-dev] [PATCH v9 5/5] odp: Add SRv6 tunnel actions.

2023-03-22 Thread Nobuhiro MIKI
On 2023/03/22 8:43, Ilya Maximets wrote: > On 3/22/23 00:41, Ilya Maximets wrote: >> On 3/15/23 07:07, Nobuhiro MIKI wrote: >>> This patch adds ODP actions for SRv6 and its tests. >>> >>> Signed-off-by: Nobuhiro MIKI >>>

Re: [ovs-dev] [PATCH v9 4/5] userspace: Add SRv6 tunnel support.

2023-03-22 Thread Nobuhiro MIKI
On 2023/03/22 8:15, Ilya Maximets wrote: > On 3/15/23 07:07, Nobuhiro MIKI wrote: >> SRv6 (Segment Routing IPv6) tunnel vport is responsible >> for encapsulation and decapsulation the inner packets with >> IPv6 header and an extended header called SRH >> (Segmen

[ovs-dev] [PATCH v9 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-15 Thread Nobuhiro MIKI
Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. If it exists, the first address is retrieved. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 +++- lib/flow.c | 26 -- lib/flow.h | 3 ++- lib/ipf.c | 12 lib

[ovs-dev] [PATCH v9 4/5] userspace: Add SRv6 tunnel support.

2023-03-15 Thread Nobuhiro MIKI
datapath. It uses `remote_ip` and `local_ip` options as with existing tunnel protocols. It also adds a dedicated `srv6_segs` option to define a sequence of routers called segment list. Signed-off-by: Nobuhiro MIKI --- Documentation/faq/configuration.rst | 21 Documentation/faq/releases.rst

[ovs-dev] [PATCH v9 5/5] odp: Add SRv6 tunnel actions.

2023-03-15 Thread Nobuhiro MIKI
This patch adds ODP actions for SRv6 and its tests. Signed-off-by: Nobuhiro MIKI --- lib/odp-util.c| 56 +++ python/ovs/flow/odp.py| 8 + python/ovs/tests/test_odp.py | 16 ++ tests/odp.at | 1 + tests

[ovs-dev] [PATCH v9 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-15 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

[ovs-dev] [PATCH v9 2/5] tnl-ports: Support multiple nw_protos.

2023-03-15 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 67 + 1 file changed, 45 insertions

[ovs-dev] [PATCH v9 0/5] userspace: Add SRv6 tunnel support.

2023-03-15 Thread Nobuhiro MIKI
on the structure size. v5: * rebased on latest master v4: * fix alignment on cast v3: * fix alignment on cast v2: * fix pointer arithmetic Nobuhiro MIKI (5): tests: Define new ADD_VETH_NS macro. tnl-ports: Support multiple nw_protos. flow: Support rt_hdr in parse_ipv6_ext_hdrs__(). userspace

[ovs-dev] [PATCH v8 5/5] userspace: Add SRv6 tunnel support.

2023-03-14 Thread Nobuhiro MIKI
datapath. It uses `remote_ip` and `local_ip` options as with existing tunnel protocols. It also adds a dedicated `srv6_segs` option to define a sequence of routers called segment list. Signed-off-by: Nobuhiro MIKI --- Documentation/faq/configuration.rst | 21 Documentation/faq/releases.rst

[ovs-dev] [PATCH v8 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-14 Thread Nobuhiro MIKI
Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. If it exists, the first address is retrieved. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 +++- lib/flow.c | 26 -- lib/flow.h | 3 ++- lib/ipf.c | 12 lib

[ovs-dev] [PATCH v8 4/5] odp: Add SRv6 tunnel actions.

2023-03-14 Thread Nobuhiro MIKI
Add the corresponding ODP actions and tests in this patch before implementing SRv6 tunnel in userspace datapath. Signed-off-by: Nobuhiro MIKI --- include/linux/openvswitch.h | 1 + lib/odp-util.c | 56 lib/packets.h| 11

[ovs-dev] [PATCH v8 2/5] tnl-ports: Support multiple nw_protos.

2023-03-14 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 67 + 1 file changed, 45 insertions

[ovs-dev] [PATCH v8 0/5] userspace: Add SRv6 tunnel support.

2023-03-14 Thread Nobuhiro MIKI
: * rebased on latest master v4: * fix alignment on cast v3: * fix alignment on cast v2: * fix pointer arithmetic Nobuhiro MIKI (5): tests: Define new ADD_VETH_NS macro. tnl-ports: Support multiple nw_protos. flow: Support rt_hdr in parse_ipv6_ext_hdrs__(). odp: Add SRv6 tunnel actions

[ovs-dev] [PATCH v8 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-14 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

Re: [ovs-dev] [PATCH v7 1/1] userspace: Add SRv6 tunnel support.

2023-03-13 Thread Nobuhiro MIKI
On 2023/03/14 6:20, Ilya Maximets wrote: > On 3/10/23 11:07, Nobuhiro MIKI wrote: >> On 2023/03/10 18:17, Simon Horman wrote: >>> On Fri, Mar 10, 2023 at 02:49:06PM +0900, Nobuhiro MIKI wrote: >>>> On 2023/01/17 18:41, Nobuhiro MIKI wrote: >>>>

Re: [ovs-dev] [PATCH v7 1/1] userspace: Add SRv6 tunnel support.

2023-03-10 Thread Nobuhiro MIKI
On 2023/03/10 18:17, Simon Horman wrote: > On Fri, Mar 10, 2023 at 02:49:06PM +0900, Nobuhiro MIKI wrote: >> On 2023/01/17 18:41, Nobuhiro MIKI wrote: >>> SRv6 (Segment Routing IPv6) tunnel vport is responsible >>> for encapsulation and decapsulation the inner p

Re: [ovs-dev] [PATCH v7 1/1] userspace: Add SRv6 tunnel support.

2023-03-09 Thread Nobuhiro MIKI
On 2023/01/17 18:41, Nobuhiro MIKI wrote: > SRv6 (Segment Routing IPv6) tunnel vport is responsible > for encapsulation and decapsulation the inner packets with > IPv6 header and an extended header called SRH > (Segment Routing Header). See spec in: > > https://datatracker

Re: [ovs-dev] [PATCH v6 3/5] ofproto: Fix mam page for tunnel related commands.

2023-03-05 Thread Nobuhiro MIKI
On 2023/03/03 19:01, Eelco Chaudron wrote: > > > On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > >> Fixed the manual page to indicate that both IPv4/IPv6 >> are supported. Also added missing pkt_mark on one side >> and fixed the "gw" and "bridge"

[ovs-dev] [PATCH v7 5/5] route-table: Retrieving the preferred source address from Netlink.

2023-03-05 Thread Nobuhiro MIKI
IB and OVS route table cache by retrieving the RTA_PREFSRC attribute of Netlink messages. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c | 6 +++--- lib/ovs-router.h | 3 ++- lib/route-table.c | 16 +++- te

[ovs-dev] [PATCH v7 4/5] ovs-router: Introduce src option in ovs/route/add command.

2023-03-05 Thread Nobuhiro MIKI
Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- NEWS| 3 ++ lib/ovs-router.c| 86 + ofproto/ofproto-tnl-unixctl.man | 5 +- tests/ovs-router.at | 80 +- 4 files cha

[ovs-dev] [PATCH v7 3/5] ofproto: Fix mam page for tunnel related commands.

2023-03-05 Thread Nobuhiro MIKI
Fixed the manual page to indicate that both IPv4/IPv6 are supported. Also added missing pkt_mark on one side and fixed the "gw" and "bridge" notation quirks. Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c| 6 +++--- ofproto/ofp

[ovs-dev] [PATCH v7 1/5] netdev-dummy: Support multiple IP addresses.

2023-03-05 Thread Nobuhiro MIKI
This is useful in test cases where multiple IPv4/IPv6 addresses are assigned together. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/netdev-dummy.c | 70 +- 1 file changed, 44 insertions(+), 26 deletions

[ovs-dev] [PATCH v7 2/5] ovs-router: Cleanup parser for ovs/route/add command.

2023-03-05 Thread Nobuhiro MIKI
be parsed in any order. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c| 53 + tests/ovs-router.at | 27 +++ 2 files changed, 52 insertions(+), 28 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v7 0/5] Add support for preffered src address in ovs-router

2023-03-05 Thread Nobuhiro MIKI
addresses - Add validation and unit tests for ovs/route/add - Refactor parsing for optional parameters in ovs/route/add command v2: - Add NEWS Nobuhiro MIKI (5): netdev-dummy: Support multiple IP addresses. ovs-router: Cleanup parser for ovs/route/add command. ofproto: Fix mam page for tunnel

[ovs-dev] [PATCH v6 4/5] ovs-router: Introduce src option in ovs/route/add command.

2023-03-01 Thread Nobuhiro MIKI
Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- NEWS| 3 ++ lib/ovs-router.c| 86 + ofproto/ofproto-tnl-unixctl.man | 5 +- tests/ovs-router.at | 80 +- 4 files cha

[ovs-dev] [PATCH v6 2/5] ovs-router: Cleanup parser for ovs/route/add command.

2023-03-01 Thread Nobuhiro MIKI
be parsed in any order. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c| 53 + tests/ovs-router.at | 27 +++ 2 files changed, 52 insertions(+), 28 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v6 5/5] route-table: Retrieving the preferred source address from Netlink.

2023-03-01 Thread Nobuhiro MIKI
IB and OVS route table cache by retrieving the RTA_PREFSRC attribute of Netlink messages. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c | 6 +++--- lib/ovs-router.h | 3 ++- lib/route-table.c | 16 +++- te

[ovs-dev] [PATCH v6 1/5] netdev-dummy: Support multiple IP addresses.

2023-03-01 Thread Nobuhiro MIKI
This is useful in test cases where multiple IPv4/IPv6 addresses are assigned together. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/netdev-dummy.c | 70 +- 1 file changed, 44 insertions(+), 26 deletions

[ovs-dev] [PATCH v6 0/5] Add support for preffered src address in ovs-router

2023-03-01 Thread Nobuhiro MIKI
and unit tests for ovs/route/add - Refactor parsing for optional parameters in ovs/route/add command v2: - Add NEWS Nobuhiro MIKI (5): netdev-dummy: Support multiple IP addresses. ovs-router: Cleanup parser for ovs/route/add command. ofproto: Fix mam page for tunnel related commands. ovs-router

[ovs-dev] [PATCH v6 3/5] ofproto: Fix mam page for tunnel related commands.

2023-03-01 Thread Nobuhiro MIKI
Fixed the manual page to indicate that both IPv4/IPv6 are supported. Also added missing pkt_mark on one side and fixed the "gw" and "bridge" notation quirks. Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c| 4 ++-- ofproto/ofproto

  1   2   >