Re: [ovs-dev] [PATCH v7] Configurable Link State Change (LSC) detection mode

2018-05-15 Thread Róbert Mulik
Hi Ian, Thanks for the review and the updates. It's fine with me. Regards, Robert > -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Thursday, May 10, 2018 4:20 PM > To: Róbert Mulik <robert.mu...@ericsson.com>; d...@openvswitch.org >

[ovs-dev] [PATCH v7] Configurable Link State Change (LSC) detection mode

2018-04-23 Thread Róbert Mulik
It is possible to set LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. For detailed description and usage see the dpdk install documentation. Signed-off-by: Robert Mulik

[ovs-dev] [PATCH v6] Configurable Link State Change (LSC) detection mode

2018-03-05 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more processor time is needed, since the OVS repeatedly reads the link state with a

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-02-28 Thread Róbert Mulik
> -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Wednesday, February 21, 2018 1:29 PM > To: Róbert Mulik <robert.mu...@ericsson.com>; ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v5] Configurable Link State Change (

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-02-21 Thread Róbert Mulik
atch and the default value remains the same as it always was (poll mode) and also the documentation tells what the default value is, I don't really see the importance of this implementation. > > I did a quick visual review below, and will wait for v6 with the above > change, and do another te

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-02-16 Thread Róbert Mulik
15, 2018 6:10 PM To: Róbert Mulik <robert.mu...@ericsson.com>; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode Hi Robert, Could you please in the future add version information to the patch so that we can see the changes to pr

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-02-16 Thread Róbert Mulik
Hi Jan, This is the diff between v4 and v5. Regards, Robert diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 14a6684..e3872e7 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -634,47 +634,34 @@ Link

[ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

2018-02-15 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more processor time is needed, since the OVS repeatedly reads the link state with a

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-02-05 Thread Róbert Mulik
rsion: "2.9.90" -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Monday, February 05, 2018 3:31 PM To: Róbert Mulik <robert.mu...@ericsson.com>; d...@openvswitch.org Cc: Stokes, Ian <ian.sto...@intel.com>; Eelco Chaudron <echau...@redhat.c

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-02-05 Thread Róbert Mulik
Hi Ilya, As I see you are concerned if the code is working, also Eelco mentioned that the configuration change didn't take effect for him, so I retested the patch. I added 2 different types of NICs to OVS on the same server: 1 product: 82599ES 10-Gigabit SFI/SFP+ Network Connection It uses

[ovs-dev] [ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-02-02 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more processor time is needed, since the OVS repeatedly reads the link state with a

Re: [ovs-dev] [ovs-dev, v3] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-25 Thread Róbert Mulik
Hi Ilya, Thanks for the review! For this question: "Is there a reason why we should be able to configure default value in runtime? I think that we could make this boot-time option and move all the related code to lib/dpdk.{c,h} just like for vhost iommu support. IMHO, user should know if most

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-24 Thread Róbert Mulik
Hi Eelco and Ian, Thank you for the comments. I uploaded patch v3 based on them. There is only one comment I have problem with: "This function is not catching this sequence: ovs-vsctl set interface dpdk0 options:dpdk-lsc-interrupt=true ovs-vsctl remove interface dpdk0 options

[ovs-dev] [PATCH v3] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-24 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more processor time is needed, since the OVS repeatedly reads the link state with a

[ovs-dev] [PATCH v2] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-19 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. Global settings Service restart is necessary for the global settings to take effect. Command to set

Re: [ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode

2017-12-06 Thread Róbert Mulik
Hi Ilya, Thank you for the comments, I try to refactor the code according to them. Regards, Robert -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Wednesday, December 06, 2017 12:40 PM To: ovs-dev@openvswitch.org; Róbert Mulik <robert.mu...@ericsson.

[ovs-dev] [PATCH] LACP: Check active partner sys id

2017-12-06 Thread Róbert Mulik
A reboot of one switch in an MC-LAG bond makes all bond links to go down, causing a total connectivity loss for 3 seconds. Packet capture shows that spurious LACP PDUs are sent to OVS with a different MAC address (partner system id) during the final stages of the MC-LAG switch reboot. The current

[ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode

2017-12-06 Thread Róbert Mulik
It is possible to set LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. Global settings Service restart is necessary for the global settings to take effect. Command to set

Re: [ovs-dev] [PATCH v5 1/6] netdev-dpdk: fix management of pre-existing mempools.

2017-10-13 Thread Róbert Mulik
Hi Antonio, I verified this patch too and it seems to be working fine. The mempool issue is fixed and there is no problem with changing the MTU size either. Thank you for the fix! Regards, Robert ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management with vhu client.

2017-10-10 Thread Róbert Mulik
Hi Antonio, Last week I run into this mempool issue during the development of a new feature. I have made a bugfix, but then we saw yours too, so I tested if it solves my problem. It did, but I realized another problem with it. The mempool name generation is partly based on the MTU size, which