Re: [ovs-dev] [PATCH v1] doc: Remove experimental tag for SMC cache.

2019-07-17 Thread Wang, Yipeng1
>-Original Message- >From: Stokes, Ian >Sent: Thursday, July 4, 2019 3:40 AM >To: Ilya Maximets ; Wang, Yipeng1 >; d...@openvswitch.org; Ben Pfaff > >Subject: Re: [PATCH v1] doc: Remove experimental tag for SMC cache. > >On 7/4/2019 11:12 AM, Ilya Maximets wr

Re: [ovs-dev] [PATCH 2/2] dpif-netdev-perf: Print SMC statistics.

2018-09-27 Thread Wang, Yipeng1
Thank you Ilya for adding this! Besides the small comment, otherwise Acked-by: Yipeng Wang >-Original Message- >From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Wednesday, September 26, 2018 10:19 AM >To: ovs-dev@openvswitch.org >Cc: Jan Scheurich ; Stoke

Re: [ovs-dev] [PATCH v6] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

2018-08-28 Thread Wang, Yipeng1
>-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of Ilya Maximets >Sent: Wednesday, August 22, 2018 8:33 AM >To: Stokes, Ian ; Vishal Deep Ajmera >; d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v6] dpif-netdev: Avoid

Re: [ovs-dev] [PATCH] dpif-netdev: Fix zero length keys insertion to EMC.

2018-07-25 Thread Wang, Yipeng1
Thanks Ilya for pointing it out. It should be inserted after key length calculation. Acked-by: Yipeng Wang >-Original Message- >From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Wednesday, July 25, 2018 9:10 AM >To: ovs-dev@openvswitch.org; Wang, Yipeng1 &g

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-09 Thread Wang, Yipeng1
Thanks for the comments, please see my reply inlined. I made all the changes you suggested and included in v5 which I will send out soon. >> diff --git a/lib/cmap.c b/lib/cmap.c >> index 07719a8..db1c806 100644 >> --- a/lib/cmap.c >> +++ b/lib/cmap.c >> @@ -373,6 +373,79 @@ cmap_find(const

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-05 Thread Wang, Yipeng1
Thanks for the comments, please see my reply inlined. >I've checked the latest patch and the performance results I get are similar to >the ones give in the previous patches. Also >enabling/disabling the DFC on the fly works as expected. > >The main query I have regards the slow sweep for SMC >

Re: [ovs-dev] [PATCH] dpcls: cache miniflow blocks during lookup

2018-06-18 Thread Wang, Yipeng1
Hi, Harry, This is a good observation and there is definitely some "duplicated calculation" there. Actually when we were designing our "CD" distributor structure, we found this overhead and we tried to cache the first hash value in "CD" thus to totally bypass the first hash calculation. But

Re: [ovs-dev] [PATCH] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

2018-06-18 Thread Wang, Yipeng1
Hi, I looked into the code and the logic seems good to me. But reordering in dataplane also has performance implications especially considering non-TCP traffic. Also, the packets came to OvS may already been out-of-ordered. Could you provide some performance data points showing when all EMC

Re: [ovs-dev] dpcls: Miniflow match of packet and subtable

2018-06-15 Thread Wang, Yipeng1
y carefully. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, June 15, 2018 12:39 PM > To: Van Haaren, Harry > Cc: jpet...@ovn.org; William Tu ; > db...@vmware.com; Gobriel, Sameh ; Wang, > Yipeng1 ; ovs-dev@openvswitch.org > Subj

Re: [ovs-dev] dpcls: Miniflow match of packet and subtable

2018-06-01 Thread Wang, Yipeng1
the same hashing range, it should work I think. I add guys that I believe are more experts on miniflow extraction and megaflow translation to the CC list. Thanks Yipeng >-Original Message- >From: Van Haaren, Harry >Sent: Friday, June 1, 2018 2:30 AM >To: Wang, Yipeng1 ; ovs-d

Re: [ovs-dev] [PATCH 0/3] dpif-netdev: Combine CD and DFC patch for datapath refactor

2018-03-21 Thread Wang, Yipeng1
patch set. We will post version 2 and new results soon. Thanks Yipeng >-Original Message- >From: O Mahony, Billy >Sent: Thursday, March 8, 2018 2:31 AM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org; Wang, >Yipeng1 <yipeng1.w...@intel.com>;

Re: [ovs-dev] [RFC 4/4] dpif-netdev.c: Add indirect table

2018-02-26 Thread Wang, Yipeng1
Thanks for the comments, reply inlined: >-Original Message- >From: Bodireddy, Bhanuprakash >Sent: Friday, February 23, 2018 1:06 PM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org; >jan.scheur...@ericsson.com >Cc: Tai, Charlie <charlie@in

Re: [ovs-dev] [RFC 3/4] dpif-netdev: Use way-associative cache

2018-02-26 Thread Wang, Yipeng1
Thanks for the comments. Reply inlined: >-Original Message- >From: Bodireddy, Bhanuprakash >Sent: Friday, February 23, 2018 12:56 PM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org; >jan.scheur...@ericsson.com >Cc: Tai, Charlie <charlie@in

Re: [ovs-dev] [RFC 1/4] dpif-netdev: Refactor datapath flow cache

2018-02-26 Thread Wang, Yipeng1
Bhanu, thanks for the comment. Please see my comments inlined. And Jan please feel free to add more. >-Original Message- >From: Bodireddy, Bhanuprakash >Sent: Tuesday, February 20, 2018 1:10 PM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch

Re: [ovs-dev] [RFC 2/4] dpif-netdev: Fix EMC key length

2018-02-26 Thread Wang, Yipeng1
csson.com] >Sent: Wednesday, February 21, 2018 12:09 AM >To: Bodireddy, Bhanuprakash <bhanuprakash.bodire...@intel.com>; Wang, Yipeng1 ><yipeng1.w...@intel.com>; >d...@openvswitch.org >Cc: Tai, Charlie <charlie@intel.com> >Subject: RE: [ovs-dev] [RFC 2/

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-11 Thread Wang, Yipeng1
>-Original Message- >[Wang, Yipeng] >Yes, with 2-hash function and 16 entries per bucket, CD has much less misses >in general. > >As first step to combine both CD and DFC, I incorporated the signature and >way-associative structure from CD into DFC. I just did >simple prototype without

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-09 Thread Wang, Yipeng1
Hi, Jan, Please find my reply inlined >-Original Message- >> >> [Wang, Yipeng] In my test, I compared the proposed EMC with current EMC with >> same 16k entries. >> If I turned off THP, the current EMC will cause many TLB misses because of >> its larger entry size, which I profiled with

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-09 Thread Wang, Yipeng1
>-Original Message- >> I think this is an interesting idea. >> >> One caveat is that in this case we use the rules' field to infer the flows' >> field. If the rule >> does not consider a field within which the flow has high entropy, it still >> does not help. >> Or if the rule considers

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-08 Thread Wang, Yipeng1
I think this is an interesting idea. One caveat is that in this case we use the rules' field to infer the flows' field. If the rule does not consider a field within which the flow has high entropy, it still does not help. Or if the rule considers many fields but the flow does not have high

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-04 Thread Wang, Yipeng1
for the hash table structures in OvS. What do you think? >-Original Message- >From: Fischetti, Antonio >Sent: Wednesday, January 3, 2018 1:13 AM >To: William Tu <u9012...@gmail.com>; Wang, Yipeng1 ><yipeng1.w...@intel.com> >Cc: d...@openvswitch.org; Tai, Charlie &l

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2018-01-02 Thread Wang, Yipeng1
Hi, William, Thanks for the comment. You are right. If the RSS hash does not consider the fields that matter, the situation you mentioned could happen. There are two design options for CD as you may find, when the signatures collide, we could either replace the existing entry (the current

Re: [ovs-dev] [PATCH v4 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

2017-12-22 Thread Wang, Yipeng1
-1.33% 100k-20t-3.81% 1M-1t -3.25% 1M-3t -2.75% 1M-5t -1.98% 1M-10t -1.78% 1M-20t -0.60% Tested-by: Yipeng Wang <yipeng1.w...@intel.com> Thanks Yipeng >-Origina

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-21 Thread Wang, Yipeng1
in a week or two. Thank Yipeng > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Monday, November 20, 2017 9:39 AM > To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org > Cc: Gobriel, Sameh <sameh.gobr...@intel.

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-07 Thread Wang, Yipeng1
We are waiting for more comments before reworking this patchset. Please feel free to post any comment. Thanks! > -Original Message- > From: Wang, Yipeng1 > Sent: Tuesday, October 31, 2017 4:40 PM > To: d...@openvswitch.org > Cc: Wang, Yipeng1 <yipeng1.w...@intel.co

Re: [ovs-dev] [PATCH v2 1/5] dpif-netdev: Basic CD feature with scalar lookup.

2017-11-07 Thread Wang, Yipeng1
considered as part of the future version to include. Thanks > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, November 3, 2017 11:00 AM > To: Wang, Yipeng1 <yipeng1.w...@intel.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [P

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-07 Thread Wang, Yipeng1
gt; To: Wang, Yipeng1 <yipeng1.w...@intel.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor > implementation > > Is this something that should be included in the repo? > > On Fri, Nov 03, 2017 at 04:14:56PM +, Wan

Re: [ovs-dev] [PATCH v2 5/5] unit-test: Add a delay for CD initialization.

2017-11-07 Thread Wang, Yipeng1
Thank you for the comments. We will incorporate your suggestion in V3. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, November 3, 2017 10:57 AM > To: Wang, Yipeng1 <yipeng1.w...@intel.com> > Cc: d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-03 Thread Wang, Yipeng1
ports = tx_ports) #wait for 20 seconds time.sleep(20) #write rx pps to stdio sys.stdout.write(str("RX PPS: ")+str(int(c.get_stats(my_ports)[1]["rx_pps"])) + str("\n")) #stop the traffic c.stop(ports=my_ports) c.disconne

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify emc replacement policy.

2017-07-28 Thread Wang, Yipeng1
Good catch. But I think the hash comparison is to "randomly" choose one of the two entries to replace when both entries are live. Your change would always replace the first one in such case. It might cause some thrashing issue for certain traffic. Meanwhile, to my experience, the original "hash

Re: [ovs-dev] [PATCH 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-07-11 Thread Wang, Yipeng1
thought on this patch. Thanks Yipeng > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, July 7, 2017 6:37 PM > To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/5] dpif-netde

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

2017-05-02 Thread Wang, Yipeng1
. Thank you. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Wednesday, April 26, 2017 10:04 PM > To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org > Cc: Tai, Charlie <charlie@intel.com>; Wang, Ren <ren.w..

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

2017-04-14 Thread Wang, Yipeng1
Thank you Darrell for the comments. Please take a look at my reply inlined. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Thursday, April 13, 2017 10:36 PM > To: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

2017-04-11 Thread Wang, Yipeng1
<antonio.fische...@intel.com> Cc: Wang, Yipeng1 <yipeng1.w...@intel.com>; d...@openvswitch.org; jan.scheur...@ericsson.com Subject: Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search Thanks for your contribution! I haven’t looked at t