Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-11 Thread aserdean
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 12, 2017 12:40 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > >

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-11 Thread Ben Pfaff
@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > > > > On Mon, Dec 11, 2017 at 08:23:44PM +, Alin Serdean wrote: > > > LGTM. Just two nits. > > > > > > +/* Terminal error state that indicates that nothing u

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-11 Thread Alin Serdean
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 12, 2017 12:30 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > >

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-11 Thread Ben Pfaff
On Mon, Dec 11, 2017 at 08:23:44PM +, Alin Serdean wrote: > LGTM. Just two nits. > > +/* Terminal error state that indicates that nothing useful can be done. > > + * The most likely reason is that the database server doesn't actually > > have > [Alin Serdean] doesn't have, maybe?

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-11 Thread Alin Serdean
LGTM. Just two nits. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, December 8, 2017 11:24 PM > To: d...@openvswitch.org > Cc: Ben Pfaff <b...@ovn.org> > Subject:

[ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

2017-12-08 Thread Ben Pfaff
This change documents the IDL state machine, adds other comments, and fixes a spelling error in a comment. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 57 ++--- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git