Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-08 Thread Ben Pfaff
On Wed, May 08, 2019 at 11:41:16AM +0300, Ilya Maximets wrote: > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(), for possible portability benefit. This is because > >> the structures involved have

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-08 Thread Ilya Maximets
On 08.05.2019 12:20, Darrell Ball wrote: > > > On Wed, May 8, 2019 at 1:41 AM Ilya Maximets > wrote: > > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(),

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-08 Thread Darrell Ball
On Wed, May 8, 2019 at 1:41 AM Ilya Maximets wrote: > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(), for possible portability benefit. This is because > >> the structures involved have padding and

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-08 Thread Ilya Maximets
> On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: >> There are a few cases where structure copy can be replaced by >> memcpy(), for possible portability benefit. This is because >> the structures involved have padding and elements of the >> structure are used to generate hashes. >>

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-06 Thread Ben Pfaff
On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > There are a few cases where structure copy can be replaced by > memcpy(), for possible portability benefit. This is because > the structures involved have padding and elements of the > structure are used to generate hashes. > >

[ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

2019-05-02 Thread Darrell Ball
There are a few cases where structure copy can be replaced by memcpy(), for possible portability benefit. This is because the structures involved have padding and elements of the structure are used to generate hashes. Signed-off-by: Darrell Ball --- lib/conntrack.c | 21 -