Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

On 5/17/2018 9:04 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check". I get a lot of unexpected failures. At first

Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

On 5/17/2018 9:59 PM, Gregory Rose wrote: On 5/17/2018 9:04 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check".  I

[ovs-dev] Question: why ovs flush all datapath flows when destroying br/ofproto?

Hi all, In my test, there are many VMs sending and receiving random flows using ovs. Per VM has one virtio-net NIC and connect to ovs bridge named such as br-plyXXX. These ovs bridges br-plyXXX are all connected to br-int using patch port. All VM's traffic can generate about 200 thousand

[ovs-dev] Bug in OVS2.8.0+DPDK17.05+Intel_82599_IXGBE sriov?

Hi all, I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is ixgbevf-4.0.3. I use sriov follow like this: echo 1 > /sys/bus/pci/devices/:01:00.0/max_vfs Then test l3fwd-vf demo, it is OK. Then test OVS2.8.0, and assign pf for ovs like this: ovs-vsctl add-port br_t

Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: > This series of patches is the backport of the Linux kernel upstream > ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check". I get a lot of unexpected failures. At first I thought I might have introduced

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hi Ben, I was working on the code changes and I can think of two approaches we can take to prevent this crash in the dpdk datapath. 1. Today the dp_packet module that we have is never return any error . The only error handling it is by assert using OVS_NOT_REACHED(). Should we go ahead and

[ovs-dev] [PATCH v1 2/2] Fix packet drops on LACP bond after link up

2/2: Fix packet drops on LACP bond after link up Problem: On certain Fortville NICs it has been observed that PHY UP detection can get delayed (sometimes up to 4-5 secs). When the driver fails to fetch PHY status as UP even though its actually UP, LACP packets can get exchanged and LACP

[ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

From: Numan Siddique When a node 'A' in the pacemaker cluster running OVN db servers in master is brought down ungracefully ('echo b > /proc/sysrq_trigger' for example), pacemaker is not able to promote any other node to master in the cluster. When pacemaker selects a node

[ovs-dev] [PATCH v1 1/2] Fix packet drops on LACP bond after link up

1/2: Fix packet drops on LACP bond after link up Problem: During port DOWN->UP of link (slave) in a LACP bond, after receiving the LACPDU with SYNC set for both actor and partner, the bond-slave remains "disabled" until OVS main thread runs LACP state machine and eventually "enables" the

Re: [ovs-dev] [dpdk-dev] How to dump DPDK log?

On 5/17/2018 3:41 AM, Sam wrote: > Oh, it should be user1,8 in dpdk-17.05 Yes, loglevel numbers are converted to more human readable format in this release, old releases are using numbers. > > OMG > > 2018-05-17 10:26 GMT+08:00 Sam >: >

Re: [ovs-dev] Je mailbox is bijna vol

?Je inbox heeft de opslaglimiet bijna overschreden. Het kan geen e-mails verzenden en ontvangen als deze wordt overschreden en uw e-mailaccount wordt opgeschort van onze server. Om dit probleem te voorkomen, vergroot u de grootte van uw postvakquotum automatisch door op

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Thanks Lucas, this makes sense. There is something that this patch is fixing and I'm not sure why. Maybe someone can shed some light: Using datapath from OVS master, and a setup where we have a physical interface connected to an OVS bridge (br-ex) connected to another OVS bridge (br-int) through

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

On Thu, May 17, 2018 at 12:27 PM, wrote: > From: Lucas Alvares Gomes > > The commit [0] partially fixed the problem but in RHEL 7.5 neither > .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for > vport-internal_dev.c. > > As pointed

Re: [ovs-dev] [RFC v6 00/11] Support multi-segment mbufs

Hello. Thanks for working on this. But it seems that this patch completely breaks build without dpdk. There are a lot of places where dpdk functions in use regardless of define DPDK_NETDEV. Beside that I see that you're allocating new mbufs inside generic dp_packet_* functions. But, in context of

Re: [ovs-dev] [PATCH 0/2] dpdk: refactor the initialization step

> Aaron Conole writes: > > > Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort > > in that case. When that occurs, ovs-vswitchd will be restarted by the > > monitor and immediately abort. This is rather unfriendly to users, > > who would prefer to

Re: [ovs-dev] [PATCH v2] datapath: compat: Fix build on RHEL 7.5

On Fri, 11 May 2018 10:32:12 -0700, Yi-Hung Wei wrote: > --- a/datapath/linux/compat/geneve.c > +++ b/datapath/linux/compat/geneve.c > @@ -1271,7 +1271,11 @@ static const struct net_device_ops geneve_netdev_ops = > { > .ndo_stop = geneve_stop, > .ndo_start_xmit =

Re: [ovs-dev] URGENT ! - Notice of new claim for fire accident on 16 May 2018

Dear Sir, With reference to the above captioned matter, please see the attached preliminary report. We look forward to receiving your Immediate Advice. Kind regards, Lauder Shao (Ms.) MSc, ACII, Associate of the Association of Average Adjusters Senior Manager Ven Kova Adjusting New

[ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

From: Lucas Alvares Gomes The commit [0] partially fixed the problem but in RHEL 7.5 neither .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for vport-internal_dev.c. As pointed out by commit [0], the ndo_change_mtu function pointer has been moved from

Re: [ovs-dev] [PATCH 0/2] dpdk: refactor the initialization step

Aaron Conole writes: > Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in > that case. When that occurs, ovs-vswitchd will be restarted by the > monitor and immediately abort. This is rather unfriendly to users, who > would prefer to possibly correct

Re: [ovs-dev] [PATCH 4/7] Add OpenFlow extensions for group support in OpenFlow 1.0.

On Wed, May 16, 2018 at 10:37:15PM -0700, Justin Pettit wrote: > > > > On May 10, 2018, at 4:24 PM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > --- > > include/openflow/openflow-1.5.h | 3 +- > > include/openvswitch/ofp-errors.h | 54 +

[ovs-dev] [PATCH 2/2] ofp-print: Move significant formatting code into more specific .c files.

Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-bundle.h | 11 +- include/openvswitch/ofp-connection.h | 18 +- include/openvswitch/ofp-ipfix.h | 5 + include/openvswitch/ofp-match.h | 9 +- include/openvswitch/ofp-meter.h | 12 +

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Handle ENOTSUP for rte_eth_dev_set_mtu.

> > The function rte_eth_dev_set_mtu is not supported for all DPDK drivers. > Currently if it is not supported we return an error in > dpdk_eth_dev_queue_setup. There are two issues with this. > > (i) A device can still function even if rte_eth_dev_set_mtu is not > supported albeit with the

[ovs-dev] [PATCH 1/2] ofp-bundle: Minor style fixes for header.

Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-bundle.h | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/include/openvswitch/ofp-bundle.h b/include/openvswitch/ofp-bundle.h index f19996663a74..78a44d6f0088 100644 ---

[ovs-dev] [PATCH] Avoid tunneling for VLAN packets redirected to a gateway chassis

From: Venkata Anil When a vm on a vlan tenant network sends traffic to an external network, it is tunneled from host chassis to gateway chassis. In the earlier discussion [1], Russel (also in his doc [2]) suggested if we can figure out a way for OVN to do this redirect to

[ovs-dev] Obtenga Recursos Federales

Introducción: En la actualidad el autoempleo y el emprendimiento son considerados una de las mejores maneras de generar ingresos. Muchas veces tenemos la idea y los conocimientos para iniciar, pero nos hace falta el recurso monetario necesario para la inversión inicial. Ese empujón que nos

[ovs-dev] [PATCH] ovsdb-idl: Correct singleton insert logic

When inserting data into a "singleton" table (one that has maxRows == 1), there is a check that ensures that the table is currently empty before inserting the row. The intention is to prevent races where multiple clients might attempt to insert rows at the same time. The problem is that this

Re: [ovs-dev] [PATCH] ovsdb: Use new ovsdb_log_write_and_free().

On Thu, May 17, 2018 at 11:07:32AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Thanks for the cleanup. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

On Thu, May 17, 2018 at 4:27 AM, wrote: > From: Lucas Alvares Gomes > > The commit [0] partially fixed the problem but in RHEL 7.5 neither > .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for > vport-internal_dev.c. > Thanks Lucas

[ovs-dev] [PATCH] ovsdb: Use new ovsdb_log_write_and_free().

Signed-off-by: Justin Pettit --- ovsdb/ovsdb-tool.c | 14 +++--- tests/test-ovsdb.c | 3 +-- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index 61ee6b377b6f..c2ad2310c234 100644 --- a/ovsdb/ovsdb-tool.c +++

[ovs-dev] [PATCH 1/2] ovsdb: Improve torture test for clusters.

This test is supposed to be parameterized, but one of the loops didn't honor the parameterization and just had hardcoded values. Also, the output comparison didn't work properly for more than 100 client sets (n1 > 100), so this adds some explicit sorting to the mix. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH] netdev-dpdk: fix check for "net_nfp" driver

Currently the check of "net_nfp" driver while enabling scatter compares only the first 6 bytes, but "net_nfp" is 7 bytes long. This change fixes the check by comparing the first 7 bytes. CC: Pablo Cascón CC: Simon Horman Fixes:

[ovs-dev] [PATCH 2/2] ovsdb: Improve timing in cluster torture test.

Until now the timing in the cluster torture test has been pretty inaccurate because it just worked by calling "sleep 1" in a loop that did other things. The longer those other things too, the more inaccurate it got. This commit changes to using a separate process for timing. It still won't be

[ovs-dev] [PATCH V2 01/41] compat: Remove unsupported kernel compat code

Anything less than 3.10 isn't supported since a couple of releases ago so remove the dead code. Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/etherdevice.h | 30 -- datapath/linux/compat/include/linux/if_vlan.h | 11 ---

[ovs-dev] [PATCH V2 00/41] Add ERSPAN support

This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. The first patch does some cleanup of unsupported kernel code. The remaining patches in the series begin the backport of the ERSPAN code. As part of the ERSPAN backport it was necessary to fixup the

[ovs-dev] [PATCH V2 03/41] gre: fix goto statement typo

From: William Tu Upstream commit: commit e3d0328c76dde0b957f62f8c407b79f1d8fe3ef8 Author: William Tu Date: Tue Aug 22 17:04:05 2017 -0700 gre: fix goto statement typo Fix typo: pnet_tap_faied. Signed-off-by: William Tu

[ovs-dev] [PATCH V2 04/41] gre: refactor the gre_fb_xmit

From: William Tu Upstream commit: commit 862a03c35ed76c50a562f7406ad23315f7862642 Author: William Tu Date: Fri Aug 25 09:21:27 2017 -0700 gre: refactor the gre_fb_xmit The patch refactors the gre_fb_xmit function, by creating

[ovs-dev] [PATCH V2 05/41] compat/gre: add collect_md mode

From: William Tu commit 1a66a836da630cd70f3639208da549b549ce576b Author: William Tu Date: Fri Aug 25 09:21:28 2017 -0700 gre: add collect_md mode to ERSPAN tunnel Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to

[ovs-dev] [PATCH V2 06/41] ip_gre: check packet length and mtu correctly in erspan tx

From: William Tu Upstream commit: commit f192970de860d3ab90aa9e2a22853201a57bde78 Author: William Tu Date: Thu Oct 5 12:07:12 2017 -0700 ip_gre: check packet length and mtu correctly in erspan tx Similarly to early patch for

[ovs-dev] [PATCH V2 02/41] gre: introduce native tunnel support for ERSPAN

From: William Tu Upstream commit: commit 84e54fe0a5eaed696dee4019c396f8396f5a908b Author: William Tu Date: Tue Aug 22 09:40:28 2017 -0700 gre: introduce native tunnel support for ERSPAN The patch adds ERSPAN type II tunnel support.

[ovs-dev] [PATCH V2 07/41] ip_gre: get key from session_id correctly in erspan_rcv

From: Xin Long Upstream commit: commit 935a9749a36828af0e8be224a5cd4bc758112c34 Author: Xin Long Date: Sun Oct 1 22:00:53 2017 +0800 ip_gre: get key from session_id correctly in erspan_rcv erspan only uses the first 10 bits of

[ovs-dev] [PATCH V2 08/41] ip_gre: set tunnel hlen properly in erspan_tunnel_init

From: Xin Long Upstream commit: commit c122fda271717f4fc618e0a31e833941fd5f1efd Author: Xin Long Date: Sun Oct 1 22:00:55 2017 +0800 ip_gre: set tunnel hlen properly in erspan_tunnel_init According to __gre_tunnel_init,

[ovs-dev] [PATCH V2 09/41] ip_gre: erspan device should keep dst

From: Xin Long Upstream commit: commit c84bed440e4e11a973e8c0254d0dfaccfca41fb0 Author: Xin Long Date: Sun Oct 1 22:00:56 2017 +0800 ip_gre: erspan device should keep dst The patch 'ip_gre: ipgre_tap device should keep dst'

[ovs-dev] [PATCH V2 10/41] ip_gre: Refactor the erpsan tunnel code.

From: William Tu Upstream commit: commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f Author: William Tu Date: Thu Nov 30 11:51:27 2017 -0800 ip_gre: Refector the erpsan tunnel code. Move two erspan functions to header file, erspan.h,

[ovs-dev] [PATCH V2 12/41] ip_gre: fix wrong return value of erspan_rcv

From: Haishuang Yan Upstream commit: commit c05fad5713b81b049ec6ac4eb2d304030b1efdce Author: Haishuang Yan Date: Fri Dec 15 10:46:16 2017 +0800 ip_gre: fix wrong return value of erspan_rcv If

[ovs-dev] [PATCH V2 11/41] compat/erspan: refactor existing erspan code

From: William Tu Upstream commit: commit 1d7e2ed22f8d9171fa8b629754022f22115b3f03 Author: William Tu Date: Wed Dec 13 16:38:55 2017 -0800 net: erspan: refactor existing erspan code The patch refactors the existing erspan

[ovs-dev] [PATCH V2 13/41] ip_gre: erspan: reload pointer after pskb_may_pull

From: William Tu Upstream commit: commit d91e8db5b629a3c8c81db4dc317a66c7b5591821 Author: William Tu Date: Fri Dec 15 14:27:44 2017 -0800 net: erspan: reload pointer after pskb_may_pull pskb_may_pull() can change skb->data, so we

[ovs-dev] [PATCH V2 17/41] compat: Fixups for some compile warnings and errors

A lot of code has been pulled in. Fix it up to make sure it compiles correctly. Signed-off-by: Greg Rose --- datapath/linux/compat/gre.c | 23 datapath/linux/compat/include/net/gre.h | 47 -

[ovs-dev] [PATCH V2 14/41] ip_gre: remove the incorrect mtu limit for ipgre tap

From: Xin Long Upstream commit: commit cfddd4c33c254954927942599d299b3865743146 Author: Xin Long Date: Mon Dec 18 14:24:35 2017 +0800 ip_gre: remove the incorrect mtu limit for ipgre tap ipgre tap driver calls ether_setup(),

[ovs-dev] [PATCH V2 16/41] compat: Add #define for gre_handle_offloads

Fixes compile errors on some 4.x kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index f849971..b1493e0 100644 ---

[ovs-dev] [PATCH V2 15/41] compat: Move function to header

tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on some kernels. Move it from ip_gre.c to the common header. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/gre.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[ovs-dev] [PATCH V2 21/41] datapath: erspan: introduce erspan v2 for ip_gre

From: William Tu Upstream commit: commit f551c91de262ba36b20c3ac19538afb4f4507441 Author: William Tu Date: Wed Dec 13 16:38:56 2017 -0800 net: erspan: introduce erspan v2 for ip_gre The patch adds support for erspan version 2.

[ovs-dev] [PATCH V2 22/41] compat: erspan: use bitfield instead of mask and offset

From: William Tu Upstream commit: commit c69de58ba84f480879de64571d9dae5102d10ed6 Author: William Tu Date: Thu Jan 25 13:20:09 2018 -0800 net: erspan: use bitfield instead of mask and offset Originally the erspan fields are defined

[ovs-dev] [PATCH V2 20/41] datapath: Use correct tunnel receive for ip6gre

During backports of ip6 gre I used ovs_ip_tunnel_rcv() for the ip6gre_rcv() function but that is wrong because it processes ipv4 tunnels. Use the correct backported ip6 tunnel receive in ip6 tunnel.c ip6_tnl_rcv(). Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH V2 19/41] datapath: Add dellink op to ip6gre and ip6erspan tap ops

Fix an oversight in the ip6gre_tap_ops and ip6erspan_tap_ops in which the .dellink field was not initialized leading to bugs when trying to remove and re-add those type of ports. Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 2 ++ 1 file changed, 2

[ovs-dev] [PATCH V2 25/41] userspace: add gre sequence number support.

From: William Tu The patch adds support for gre sequence number. Default is disable. When enable with 'options:seq=true', the outgoing gre packet will have its sequence number incremented by one. Signed-off-by: William Tu --- lib/netdev-native-tnl.c |

[ovs-dev] [PATCH V2 24/41] netdev-native-tnl: refactor the tunnel push header.

From: William Tu The patch adds additional 'struct netdev *' to the native tunnel's push_header() interface. This is used for later GRE sequence number support. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 6 -- lib/netdev-native-tnl.h |

[ovs-dev] [PATCH V2 23/41] datapath: add erspan version I and II support

From: William Tu Upstream commit: commit fc1372f89ffe1f58b589643b75f679e452350703 Author: William Tu Date: Thu Jan 25 13:20:11 2018 -0800 openvswitch: add erspan version I and II support The patch adds support for openvswitch to

[ovs-dev] [PATCH V2 27/41] erspan: add kernel datapath support

From: William Tu pass check, check-kernel (4.16-rc4), check-system-userspace Signed-off-by: William Tu --- lib/dpif-netlink-rtnl.c | 20 +++--- lib/dpif-netlink.c| 3 + lib/odp-util.c| 150

[ovs-dev] [PATCH V2 29/41] erspan: auto detect truncated packets.

From: William Tu Upstream commit: commit 1baf5ebf8954d9bff8fa4e7dd6c416a0cebdb9e2 Author: William Tu Date: Fri Apr 27 14:16:32 2018 -0700 erspan: auto detect truncated packets. Currently the truncated bit is set only when the

[ovs-dev] [PATCH V2 28/41] openvswitch: fix vport packet length check.

From: William Tu Upstream commit: commit 46e371f0e78a82186a83cbcb4f4b8850417c7dd5 Author: William Tu Date: Wed Mar 7 15:38:48 2018 -0800 openvswitch: fix vport packet length check. When sending a packet to a tunnel device, the

[ovs-dev] [PATCH V2 30/41] ip6gre: Add ip6gre vport type

Add handlers for OVS_VPORT_TYPE_IP6GRE Cc: Ben Pfaff Signed-off-by: Greg Rose --- V2 - Folded in additional change from Ben Pfaff as per his suggestion. --- lib/dpif-netlink-rtnl.c | 4 +++- lib/dpif-netlink.c | 7 +-- lib/netdev-native-tnl.c | 8

[ovs-dev] [PATCH V2 26/41] userspace: add erspan tunnel support.

From: William Tu ERSPAN is a tunneling protocol based on GRE tunnel. The patch add erspan tunnel support for ovs-vswitchd with userspace datapath. Configuring erspan tunnel is similar to gre tunnel, but with additional erspan's parameters. Matching a flow on erspan's

[ovs-dev] [PATCH V2 31/41] lib/dpif-netlink: Fix miscompare of gre ports

In netdev_to_ovs_vport_type() it checks for netdev types matching "gre" with a strstr(). This makes it match ip6gre as well and return OVS_VPORT_TYPE_GRE, which is clearly wrong. Move the usage of strstr() *after* all the exact matches with strcmp() to avoid the problem permanently because when

[ovs-dev] [PATCH V2 33/41] ip6gre: add erspan v2 to tunnel lookup

From: William Tu Upstream commit: commit 3b04caab81649a9e8d5375b919b6653d791951df Author: William Tu Date: Fri Mar 9 07:34:40 2018 -0800 ip6gre: add erspan v2 to tunnel lookup The patch adds the erspan v2 proto in

[ovs-dev] [PATCH V2 34/41] ip6erspan: improve error handling for erspan version number.

From: William Tu Upstream commit: commit d6aa71197ffcb68850bfebfc3fc160abe41df53b Author: William Tu Date: Fri Mar 9 07:34:41 2018 -0800 ip6erspan: improve error handling for erspan version number. When users fill in incorrect

[ovs-dev] [PATCH V2 32/41] erspan: Add flow-based erspan options

The patch add supports for flow-based erspan options. The erspan_ver, erspan_idx, erspan_dir, and erspan_hwid can be set as "flow" so that its value is set by the openflow rule, instead of statically configured at port creation time. Signed-off-by: William Tu --- V2 - A

[ovs-dev] [PATCH V2 35/41] ip6erspan: make sure enough headroom at xmit.

From: William Tu Upstream commit: commit e41c7c68ea771683cae5a7f81c268f38d7912ecb Author: William Tu Date: Fri Mar 9 07:34:42 2018 -0800 ip6erspan: make sure enough headroom at xmit. The patch adds skb_cow_header() to ensure enough

[ovs-dev] [PATCH V2 40/41] gre: Resolve gre receive issues

On newer Linux kernels or on older kernels such as Red Hat that backport from newer upstream Linux kernel releases the built-in gre kernel module will interfere with OVS gre code in the receive path. Fix this up by placing the gre kernel code within the openvswitch driver so it will not have to

[ovs-dev] [PATCH V2 37/41] erspan: set bso when truncated bit is set.

From: William Tu Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10

[ovs-dev] [PATCH V2 39/41] rhel: Enable ERSPAN features for RHEL 7.x

Enable ERSPAN on RHEL 7.x Signed-off-by: Greg Rose --- acinclude.m4| 15 ++- datapath/linux/compat/ip6_gre.c | 13 ++--- datapath/linux/compat/ip_gre.c | 12 ++-- 3 files changed, 26 insertions(+), 14 deletions(-) diff

[ovs-dev] [PATCH V2 38/41] tunnel: add support for erspan and ip6erspan type.

From: William Tu This patch adds support for erspan and ip6erspan. Signed-off-by: William Tu --- lib/odp-util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 2109fac..d7b5bcd 100644 ---

[ovs-dev] [PATCH V2 36/41] erspan: auto detect truncated ipv6 packets.

From: William Tu Upstream commit: commit d5db21a3e6977dcb42cee3d16cd69901fa66510a Author: William Tu Date: Fri May 11 05:49:47 2018 -0700 erspan: auto detect truncated ipv6 packets. Currently the truncated bit is set only when 1)

[ovs-dev] [PATCH V2 41/41] erspan: fix invalid erspan version.

From: William Tu ERSPAN only support version 1 and 2. When packets send to an erspan device which does not have proper version number set, drop the packet. In real case, we observe multicast packets sent to the erspan pernet device, erspan0, which does not have erspan

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Daniel Alvarez Sanchez writes: > Thanks Lucas, this makes sense. There is something that this patch is > fixing and I'm not sure why. > Maybe someone can shed some light: > > Using datapath from OVS master, and a setup where we have a physical > interface connected to > an

[ovs-dev] [PATCH] datapath: compat: Fix ndo_size in RHEL 7.5 backport

If 'ndo_size' is not set in 'struct net_device_ops', RHEL kernel will not make use of functions in 'struct net_device_ops_extended'. Fixes: 39ca338374ab ("datapath: compat: Fix build on RHEL 7.5") Reported-by: Jiri Benc Reported-at:

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Aaron Conole writes: > lucasago...@gmail.com writes: > >> From: Lucas Alvares Gomes >> >> The commit [0] partially fixed the problem but in RHEL 7.5 neither >> .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for >> vport-internal_dev.c.

[ovs-dev] [PATCH 01/41] compat: Remove unsupported kernel compat code

Anything less than 3.10 isn't supported since a couple of releases ago so remove the dead code. Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/etherdevice.h | 30 -- datapath/linux/compat/include/linux/if_vlan.h | 11 ---

[ovs-dev] [PATCH 00/41] Add ERSPAN support

This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. The first patch does some cleanup of unsupported kernel code. The remaining patches in the series begin the backport of the ERSPAN code. As part of the ERSPAN backport it was necessary to fixup the

[ovs-dev] [PATCH 02/41] gre: introduce native tunnel support for ERSPAN

From: William Tu Upstream commit: commit 84e54fe0a5eaed696dee4019c396f8396f5a908b Author: William Tu Date: Tue Aug 22 09:40:28 2017 -0700 gre: introduce native tunnel support for ERSPAN The patch adds ERSPAN type II tunnel support.

[ovs-dev] [PATCH 08/41] ip_gre: set tunnel hlen properly in erspan_tunnel_init

From: Xin Long Upstream commit: commit c122fda271717f4fc618e0a31e833941fd5f1efd Author: Xin Long Date: Sun Oct 1 22:00:55 2017 +0800 ip_gre: set tunnel hlen properly in erspan_tunnel_init According to __gre_tunnel_init,

[ovs-dev] [PATCH 07/41] ip_gre: get key from session_id correctly in erspan_rcv

From: Xin Long Upstream commit: commit 935a9749a36828af0e8be224a5cd4bc758112c34 Author: Xin Long Date: Sun Oct 1 22:00:53 2017 +0800 ip_gre: get key from session_id correctly in erspan_rcv erspan only uses the first 10 bits of

[ovs-dev] [PATCH 10/41] ip_gre: Refactor the erpsan tunnel code.

From: William Tu Upstream commit: commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f Author: William Tu Date: Thu Nov 30 11:51:27 2017 -0800 ip_gre: Refector the erpsan tunnel code. Move two erspan functions to header file, erspan.h,

[ovs-dev] [PATCH 12/41] ip_gre: fix wrong return value of erspan_rcv

From: Haishuang Yan Upstream commit: commit c05fad5713b81b049ec6ac4eb2d304030b1efdce Author: Haishuang Yan Date: Fri Dec 15 10:46:16 2017 +0800 ip_gre: fix wrong return value of erspan_rcv If

[ovs-dev] [PATCH 14/41] ip_gre: remove the incorrect mtu limit for ipgre tap

From: Xin Long Upstream commit: commit cfddd4c33c254954927942599d299b3865743146 Author: Xin Long Date: Mon Dec 18 14:24:35 2017 +0800 ip_gre: remove the incorrect mtu limit for ipgre tap ipgre tap driver calls ether_setup(),

[ovs-dev] [PATCH 13/41] ip_gre: erspan: reload pointer after pskb_may_pull

From: William Tu Upstream commit: commit d91e8db5b629a3c8c81db4dc317a66c7b5591821 Author: William Tu Date: Fri Dec 15 14:27:44 2017 -0800 net: erspan: reload pointer after pskb_may_pull pskb_may_pull() can change skb->data, so we

[ovs-dev] [PATCH 16/41] compat: Add #define for gre_handle_offloads

Fixes compile errors on some 4.x kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index f849971..b1493e0 100644 ---

[ovs-dev] [PATCH 15/41] compat: Move function to header

tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on some kernels. Move it from ip_gre.c to the common header. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/gre.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[ovs-dev] [PATCH 22/41] netdev-native-tnl: refactor the tunnel push header.

From: William Tu The patch adds additional 'struct netdev *' to the native tunnel's push_header() interface. This is used for later GRE sequence number support. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 6 -- lib/netdev-native-tnl.h |

[ovs-dev] [PATCH 21/41] datapath: add erspan version I and II support

From: William Tu Upstream commit: commit fc1372f89ffe1f58b589643b75f679e452350703 Author: William Tu Date: Thu Jan 25 13:20:11 2018 -0800 openvswitch: add erspan version I and II support The patch adds support for openvswitch to

[ovs-dev] [PATCH 27/41] erspan: auto detect truncated packets.

From: William Tu Upstream commit: commit 1baf5ebf8954d9bff8fa4e7dd6c416a0cebdb9e2 Author: William Tu Date: Fri Apr 27 14:16:32 2018 -0700 erspan: auto detect truncated packets. Currently the truncated bit is set only when the

[ovs-dev] [PATCH 29/41] lib/dpif-netlink: Fix miscompare of gre ports

In netdev_to_ovs_vport_type() it checks for netdev types matching "gre" with a strstr(). This makes it match ip6gre as well and return OVS_VPORT_TYPE_GRE, which is clearly wrong. Move the usage of strstr() *after* all the exact matches with strcmp() to avoid the problem permanently because when

[ovs-dev] [PATCH 28/41] ip6gre: Add ip6gre vport type

Add handlers for OVS_VPORT_TYPE_IP6GRE Signed-off-by: Greg Rose --- lib/dpif-netlink-rtnl.c | 4 +++- lib/dpif-netlink.c | 7 +-- lib/netdev-native-tnl.c | 5 - lib/netdev-vport.c | 4 lib/odp-util.c | 9 +++-- lib/tnl-ports.c |

[ovs-dev] [PATCH 25/41] erspan: add kernel datapath support

From: William Tu pass check, check-kernel (4.16-rc4), check-system-userspace Signed-off-by: William Tu --- lib/dpif-netlink-rtnl.c | 20 +++--- lib/dpif-netlink.c| 3 + lib/odp-util.c| 150

[ovs-dev] [PATCH 33/41] ip6gre: add erspan v2 to tunnel lookup

From: William Tu Upstream commit: commit 3b04caab81649a9e8d5375b919b6653d791951df Author: William Tu Date: Fri Mar 9 07:34:40 2018 -0800 ip6gre: add erspan v2 to tunnel lookup The patch adds the erspan v2 proto in

[ovs-dev] [PATCH 32/41] datapath: Use correct tunnel receive for ip6gre

During backports of ip6 gre I used ovs_ip_tunnel_rcv() for the ip6gre_rcv() function but that is wrong because it processes ipv4 tunnels. Use the correct backported ip6 tunnel receive in ip6 tunnel.c ip6_tnl_rcv(). Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH 34/41] ip6erspan: improve error handling for erspan version number.

From: William Tu Upstream commit: commit d6aa71197ffcb68850bfebfc3fc160abe41df53b Author: William Tu Date: Fri Mar 9 07:34:41 2018 -0800 ip6erspan: improve error handling for erspan version number. When users fill in incorrect

[ovs-dev] [PATCH 35/41] ip6erspan: make sure enough headroom at xmit.

From: William Tu Upstream commit: commit e41c7c68ea771683cae5a7f81c268f38d7912ecb Author: William Tu Date: Fri Mar 9 07:34:42 2018 -0800 ip6erspan: make sure enough headroom at xmit. The patch adds skb_cow_header() to ensure enough

[ovs-dev] [PATCH 36/41] erspan: auto detect truncated ipv6 packets.

From: William Tu Upstream commit: commit d5db21a3e6977dcb42cee3d16cd69901fa66510a Author: William Tu Date: Fri May 11 05:49:47 2018 -0700 erspan: auto detect truncated ipv6 packets. Currently the truncated bit is set only when 1)

[ovs-dev] [PATCH 39/41] rhel: Enable ERSPAN features for RHEL 7.x

Enable ERSPAN on RHEL 7.x Signed-off-by: Greg Rose --- acinclude.m4| 15 ++- datapath/linux/compat/ip6_gre.c | 13 ++--- datapath/linux/compat/ip_gre.c | 12 ++-- 3 files changed, 26 insertions(+), 14 deletions(-) diff

[ovs-dev] [PATCH 37/41] erspan: set bso when truncated bit is set.

From: William Tu Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10

  1   2   >