Re: [ovs-dev] [PATCH ovn v2 1/4] Honor allow-related priority when stateless present

2021-06-02 Thread Han Zhou
On Tue, Jun 1, 2021 at 2:38 PM Ihar Hrachyshka wrote: > > For each allow-stateless ACL, a rule was added earlier in the pipeline > that circumvented setting REGBIT_CONNTRACK_DEFRAG regardless of > whether other, e.g. allow-related ACLs with higher priority were > present. > > Now, when

[ovs-dev] [PATCH ovn] ovn-controller: Fix port-group incremental processing.

2021-06-02 Thread Han Zhou
When SB port-group (per DP) is deleted and added back and the notification to ovn-controller include both operations in a reversed order, the current change handler in ovn-controller would end up deleting the SB port-group in the local cache, which in turn result in missing flows, and even worse

Re: [ovs-dev] [PATCH ovn v8 1/4] ovn-controller: Split logical flow and physical flow processing.

2021-06-02 Thread Han Zhou
On Tue, Jun 1, 2021 at 5:10 PM Numan Siddique wrote: > > On Sun, May 30, 2021 at 11:45 PM wrote: > > > > From: Numan Siddique > > > > Presently, the 'flow_output' engine node recomputes physical > > flows by calling physical_run() in the 'physical_flow_changes' > > handler in some scenarios.

Re: [ovs-dev] [PATCH] tests: Fix PKIDIR checks in AT_SKIP.

2021-06-02 Thread Han Zhou
On Tue, Jun 1, 2021 at 11:42 AM Ben Pfaff wrote: > > In Autotest, [xyz] just expands to xyz. To get [xyz] in output, we > need [[xyz]] in input. > > I spotted this based on "expr" reporting an error in testsuite output. > > Signed-off-by: Ben Pfaff > --- > tests/ovsdb-server.at | 4 ++-- > 1

Re: [ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-02 Thread Brendan Doyle
Hi, Just wondering what the process is here, I submitted this patch a while ago, and I see quite a few other patches have been submitted since. So wondering what happens after a patch is submitted, how do I know if it has been accepted/rejected/need more work, and how does it make it into the

Re: [ovs-dev] [PATCH v4] conntrack: document all-zero IP SNAT behavior and add a test case

2021-06-02 Thread Dumitru Ceara
On 6/2/21 3:34 PM, Eelco Chaudron wrote: > Currently, conntrack in the kernel has an undocumented feature referred > to as all-zero IP address SNAT. Basically, when a source port > collision is detected during the commit, the source port will be > translated to an ephemeral port. If there is no

Re: [ovs-dev] [External] : Re: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-02 Thread Brendan Doyle
On 02/06/2021 15:42, Dan Williams wrote: On Wed, 2021-06-02 at 09:26 +0100, Brendan Doyle wrote: Hi, Just wondering what the process is here, I submitted this patch a while ago, and I see quite a few other patches have been submitted since. So wondering what happens after a patch is

Re: [ovs-dev] [PATCH v4] conntrack: document all-zero IP SNAT behavior and add a test case

2021-06-02 Thread Aaron Conole
Eelco Chaudron writes: > Currently, conntrack in the kernel has an undocumented feature referred > to as all-zero IP address SNAT. Basically, when a source port > collision is detected during the commit, the source port will be > translated to an ephemeral port. If there is no collision, no SNAT

Re: [ovs-dev] [PATCH] tests: Fix PKIDIR checks in AT_SKIP.

2021-06-02 Thread Ben Pfaff
On Tue, Jun 01, 2021 at 11:32:59PM -0700, Han Zhou wrote: > On Tue, Jun 1, 2021 at 11:42 AM Ben Pfaff wrote: > > > > In Autotest, [xyz] just expands to xyz. To get [xyz] in output, we > > need [[xyz]] in input. > > > > I spotted this based on "expr" reporting an error in testsuite output. > > >

Re: [ovs-dev] [PATCH ovn v8 1/4] ovn-controller: Split logical flow and physical flow processing.

2021-06-02 Thread Numan Siddique
On Wed, Jun 2, 2021 at 2:22 AM Han Zhou wrote: > > On Tue, Jun 1, 2021 at 5:10 PM Numan Siddique wrote: > > > > On Sun, May 30, 2021 at 11:45 PM wrote: > > > > > > From: Numan Siddique > > > > > > Presently, the 'flow_output' engine node recomputes physical > > > flows by calling

[ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-02 Thread Brendan Doyle
From a9d3140845175edb7644b2d0d82a95bd6cf94662 Mon Sep 17 00:00:00 2001 From: Brendan Doyle Date: Fri, 28 May 2021 10:01:17 -0700 Subject: [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN This patch provides the ability to configure proxy ARP IPs on a Logical Switch Router port. The IPs

Re: [ovs-dev] [PATCH ovn] ovn-northd.c: Add proxy ARP support to OVN

2021-06-02 Thread Dan Williams
On Wed, 2021-06-02 at 09:26 +0100, Brendan Doyle wrote: > Hi, > > Just wondering what the process is here, I submitted this patch a while > ago, and I see quite a few > other patches have been submitted since. So wondering what happens > after > a patch is submitted, > how do I know if it has

[ovs-dev] [PATCH v4] conntrack: document all-zero IP SNAT behavior and add a test case

2021-06-02 Thread Eelco Chaudron
Currently, conntrack in the kernel has an undocumented feature referred to as all-zero IP address SNAT. Basically, when a source port collision is detected during the commit, the source port will be translated to an ephemeral port. If there is no collision, no SNAT is performed. This patchset

Re: [ovs-dev] [v12 07/16] dpif-netdev: Add command to get dpif implementations.

2021-06-02 Thread Stokes, Ian
> This commit adds a new command to retrieve the list of available > DPIF implementations. This can be used by to check what implementations > of the DPIF are available in any given OVS binary. > > Usage: > $ ovs-appctl dpif-netdev/dpif-get > > Signed-off-by: Harry van Haaren Thanks

Re: [ovs-dev] [v12 12/16] dpif-netdev/dpcls: Specialize more subtable signatures.

2021-06-02 Thread Stokes, Ian
> From: Harry van Haaren > > This commit adds more subtables to be specialized. The traffic > pattern here being matched is VXLAN traffic subtables, which commonly > have (5,3), (9,1) and (9,4) subtable fingerprints. > Thanks Cian/Harry. My thoughts here is that this patch could have been

Re: [ovs-dev] [v12 06/16] dpif-netdev: Add command to switch dpif implementation.

2021-06-02 Thread Stokes, Ian
> This commit adds a new command to allow the user to switch > the active DPIF implementation at runtime. A probe function > is executed before switching the DPIF implementation, to ensure > the CPU is capable of running the ISA required. For example, the > below code will switch to the AVX512

Re: [ovs-dev] [v12 09/16] docs/dpdk/bridge: Add dpif performance section.

2021-06-02 Thread Stokes, Ian
> This section details how two new commands can be used to list and select > the different dpif implementations. It also details how a non default > dpif implementation can be tested with the OVS unit test suite. > > Add NEWS updates for the dpif-netdev.c refactor and the new dpif >

Re: [ovs-dev] [v12 08/16] dpif-netdev: Add a partial HWOL PMD statistic.

2021-06-02 Thread Stokes, Ian
> It is possible for packets traversing the userspace datapath to match a > flow before hitting on EMC by using a mark ID provided by a NIC. Add a > PMD statistic for this hit. > > Signed-off-by: Cian Ferriter Thanks for the Patch Cian, comments inline. So I have a general query here. In the

Re: [ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-02 Thread 0-day Robot
Bleep bloop. Greetings Toms Atteka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #28 FILE: lib/tun-metadata.c:831: } else { Lines

Re: [ovs-dev] [PATCH] ovs-save: Fix awk command to return highest ofp version.

2021-06-02 Thread Ben Pfaff
On Tue, Jun 01, 2021 at 12:47:19PM +, lin huang wrote: > The quotes for strings like "br0" had been removed.In ovs-save file > get_highest_ofp_version function still using quotes as field separator. > That is, get_highest_ofp_version() always return OpenFlow14 version string, > not the highest

[ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-02 Thread Toms Atteka
This optimization caused FLOW_TNL_F_UDPIF flag not to be used in hash calculation for geneve tunnel when revalidating flows which resulted in different cache hash values and incorrect behaviour. Added test to prevent regression. Reported-at: https://github.com/vmware-tanzu/antrea/issues/897

Re: [ovs-dev] [v2 v2 0/6] MFEX Infrastructure + Optimizations

2021-06-02 Thread Van Haaren, Harry
Hi Jean, Thanks for the good news – indeed great that you have reproduced the performance benefits! 1.20x is a good result, and in-line with expectations for the 1st Generation Xeon/Skylake CPUs being tested. For 3rd generation Xeon/Icelake CPUs there is some additional benefits due to

Re: [ovs-dev] openvswitch 2.15 [re]start losing bridge IP

2021-06-02 Thread Ben Pfaff
On Wed, Jun 02, 2021 at 12:01:24AM +, venugopal iyer via dev wrote: > Hi, Ben et. al.: > When we moved from 2.14.0 to 2.15.0 we noticed a change in behavior. A 2.14.0 > openvswitch restart (even explicit stop followed by start) didn't lose the > existing bridge IP (local bridge port).

Re: [ovs-dev] [v12 10/16] dpif-netdev/dpcls: Refactor function names to dpcls.

2021-06-02 Thread Stokes, Ian
> From: Harry van Haaren > > This commit refactors the function names from netdev_* > namespace to the dpcls_* namespace, as they are only used > by dpcls code. With the name change, it becomes more obvious > that the functions belong to dpcls functionality, and in the >