Re: [ovs-dev] [PATCH ovn] fix typo

On 7/8/22 08:21, Zhukov Igor wrote: > I looked at > https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c > Found fixed typo: "webserer" => "webserver" > I decided to grep "webserer" and found another such word. Hi Igor, Thanks for the patch! > > From

[ovs-dev] [PATCH ovn v2] pinctrl.c: Add delay after ARP packet

The ovn-controller had a race condition over MAC binding table with other controllers. When multiple controllers received GARP from single source usually the one who was able to win the race put it into SB. The others got transaction error which triggered full recompute even if it's not needed.

Re: [ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations

On 7 Jul 2022, at 17:38, Emma Finn wrote: > This patchset introduces actions infrastructure changes which allows > the user to choose between different action implementations based on > CPU ISA by using different commands. The infrastructure also > provides a way to check the correctness of

Re: [ovs-dev] [v6 0/9] Add support for ovs metering with tc offload

On Fri, 2022-07-08 at 11:32 +0200, Eelco Chaudron wrote: > > > On 8 Jul 2022, at 4:25, Jianbo Liu wrote: > > > On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: > > > > > > > > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > > > > > This series is to add support for tc offloading of

Re: [ovs-dev] [v7 9/9] doc: Add meter offload topic document

On 8 Jul 2022, at 12:04, Jianbo Liu wrote: > On Fri, 2022-07-08 at 11:29 +0200, Eelco Chaudron wrote: >> On 8 Jul 2022, at 5:06, Jianbo Liu wrote: >> >>> Fow now, add introduction and the limitation of meter offload. >> >> “Fow” should be For, but I guess this can be fixed at commit time. >> >

Re: [ovs-dev] [v7 9/9] doc: Add meter offload topic document

On 8 Jul 2022, at 5:06, Jianbo Liu wrote: > Fow now, add introduction and the limitation of meter offload. “Fow” should be For, but I guess this can be fixed at commit time. > Signed-off-by: Jianbo Liu Changes look good to me, and thanks for adding this initial documentation. Acked-by: Eelco

Re: [ovs-dev] [v7 4/9] netdev-linux: Add functions to manipulate tc police action

On 8 Jul 2022, at 5:06, Jianbo Liu wrote: > Add helpers to add, delete and get stats of police action with > the specified index. > > Signed-off-by: Jianbo Liu One small change request below. The rest looks fine! If you make the change, you can add my Acked-by. > --- > lib/netdev-linux.c

Re: [ovs-dev] [v7 8/9] dpif-netlink: Offloading meter to tc police action

On 8 Jul 2022, at 5:06, Jianbo Liu wrote: > OVS meters are created in advance and openflow rules refer to them by > their unique ID. New tc_police API is used to offload them. By calling > the API, police actions are created and meters are mapped to them. > These actions then can be used in tc

[ovs-dev] [PATCH v3 09/10] debian: Add libc dependency for python3-openvswitch.

Fixes: ("debian: Fix build of python json C extension.") Signed-off-by: Frode Nordahl --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 1fb504482..28d206ae0 100644 --- a/debian/control +++ b/debian/control @@ -285,6 +285,7 @@ Depends:

[ovs-dev] [PATCH v3 10/10] ci: add lintian step.

The Debian lintian tool is useful outside the scope of Debian packaging, and detects issues with the shipped product itself. Checks include executables, spelling errors in binaries, manual pages, missing manual pages etc. At this point in time failing on error level makes sense, and at some

[ovs-dev] [PATCH ovn] fix typo

I looked at https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c Found fixed typo: "webserer" => "webserver" I decided to grep "webserer" and found another such word. Signed-off-by: Igor Zhukov Acked-by: Dumitru Ceara --- tests/system-ovn.at | 2 +- 1 file changed, 1

[ovs-dev] [v8 5/9] netdev-offload-tc: Implement meter offload API for tc

For dpif-netlink, meters are mapped by tc to police actions with one-to-one relationship. Implement meter offload API to set/get/del the police action, and a hmap is used to save the mappings. An id-pool is used to manage all the available police indexes, which are 0x1000-0x1fff, reserved

[ovs-dev] [v8 2/9] tc: Add support parsing tc police action

Add function to parse police action from netlink message. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 4 +++ lib/tc.c| 54 + lib/tc.h| 5 3 files changed, 63 insertions(+) diff

[ovs-dev] [v8 0/9] Add support for ovs metering with tc offload

This series is to add support for tc offloading of ovs metering, and enhance OVS to use new kernel feature which offload tc police action to hardware. To do the offloading, new APIs for meter are added in netdev-offload, and OVS meters are mapped to tc police actions with one-to-one relationship

[ovs-dev] [v8 3/9] netdev-linux: Refactor put police action netlink message

To reuse the code for manipulating police action, move the common initialization code to a function, and change PPS parameters as meter pktps is in unit of packet per second. null_police is redundant because either BPS or PPS, not both, can be configured in one message. So the police passed in to

[ovs-dev] [v8 1/9] netdev-offload: Add meter offload API

Add API to offload meter to HW, and the corresponding functions to call the meter callbacks from all the registered flow API providers. The interfaces are like those related to meter in dpif_class, in order to pass necessary info to HW. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron ---

[ovs-dev] [v8 6/9] netdev-offload-tc: Cleanup police actions with reserved indexes on startup

As the police actions with indexes of 0x1000-0x1fff are reserved for meter offload, to provide a clean environment for OVS, these reserved police actions should be deleted on startup. So dump all the police actions, delete those actions with indexes in this range. Signed-off-by: Jianbo

Re: [ovs-dev] [v7 9/9] doc: Add meter offload topic document

On Fri, 2022-07-08 at 11:29 +0200, Eelco Chaudron wrote: > On 8 Jul 2022, at 5:06, Jianbo Liu wrote: > > > Fow now, add introduction and the limitation of meter offload. > > “Fow” should be For, but I guess this can be fixed at commit time. > Ah, sorry, I pushed so soon and missed this. Will

Re: [ovs-dev] [v6 0/9] Add support for ovs metering with tc offload

On 8 Jul 2022, at 11:58, Jianbo Liu wrote: > On Fri, 2022-07-08 at 11:32 +0200, Eelco Chaudron wrote: >> >> >> On 8 Jul 2022, at 4:25, Jianbo Liu wrote: >> >>> On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > This

Re: [ovs-dev] [PATCH v3 10/10] ci: add lintian step.

Hello, Ales, On Fri, Jul 8, 2022 at 12:13 PM Ales Musil wrote: > Hi Frode, > > thank you for the patch. I have one concern, how much time does this add > to the overall run? > Having it in this step means that it will be executed for every job from > the matrix. IMO it would be better to have >

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose wrote: > > xenserver/openvswitch-xen.spec.in > > This is a bit of an issue. Does anyone even use xenserver anymore? > All of the documentation and build instructions are really old and > I wonder of they work anymore. I have no xenserver build

Re: [ovs-dev] [v6 0/9] Add support for ovs metering with tc offload

On 8 Jul 2022, at 4:25, Jianbo Liu wrote: > On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: >> >> >> On 2 Jul 2022, at 5:18, Jianbo Liu wrote: >> >>> This series is to add support for tc offloading of ovs metering, >>> and >>> enhance OVS to use new kernel feature which offload tc

[ovs-dev] [v8 8/9] dpif-netlink: Offloading meter to tc police action

OVS meters are created in advance and openflow rules refer to them by their unique ID. New tc_police API is used to offload them. By calling the API, police actions are created and meters are mapped to them. These actions then can be used in tc filter rules by the index. Signed-off-by: Jianbo Liu

[ovs-dev] [v8 9/9] doc: Add meter offload topic document

Fow now, add introduction and the limitation of meter offload. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron --- Documentation/automake.mk | 1 + Documentation/howto/index.rst | 1 + Documentation/howto/tc-offload.rst | 114 + 3 files changed,

[ovs-dev] [v8 4/9] netdev-linux: Add functions to manipulate tc police action

Add helpers to add, delete and get stats of police action with the specified index. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron --- lib/netdev-linux.c | 147 + lib/netdev-linux.h | 6 ++ lib/tc.c | 118

[ovs-dev] [v8 7/9] netdev-offload-tc: Offloading rules with police actions

When offloading rule, tc should be filled with police index, instead of meter id. As meter is mapped to police action, and the mapping is inserted into meter_id_to_police_idx hmap, this hmap is used to find the police index. Besides, the reverse mapping between meter id and police index is also

Re: [ovs-dev] [PATCH v3 10/10] ci: add lintian step.

Hi Frode, thank you for the patch. I have one concern, how much time does this add to the overall run? Having it in this step means that it will be executed for every job from the matrix. IMO it would be better to have lint as separate. Thanks, Ales On Fri, Jul 8, 2022 at 11:55 AM Frode Nordahl

Re: [ovs-dev] [v8 4/9] netdev-linux: Add functions to manipulate tc police action

On 8 Jul 2022, at 11:55, Jianbo Liu wrote: > Add helpers to add, delete and get stats of police action with > the specified index. > > Signed-off-by: Jianbo Liu > Acked-by: Eelco Chaudron > --- Explicitly ACKing after testing with the new memset changes. Acked-by: Eelco Chaudron

Re: [ovs-dev] [v8 9/9] doc: Add meter offload topic document

On 8 Jul 2022, at 11:55, Jianbo Liu wrote: > Fow now, add introduction and the limitation of meter offload. Note to whoever commits this patch, can you change the “Fow” above to “For” > Signed-off-by: Jianbo Liu > Acked-by: Eelco Chaudron > ---

Re: [ovs-dev] [PATCH ovn] fix typo

Bleep bloop. Greetings Zhukov Igor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 21 error: could not build fake ancestor hint: Use 'git am

Re: [ovs-dev] [v8 9/9] doc: Add meter offload topic document

Bleep bloop. Greetings Jianbo Liu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #99 FILE:

Re: [ovs-dev] [v7 9/9] doc: Add meter offload topic document

On Fri, 2022-07-08 at 12:10 +0200, Eelco Chaudron wrote: > > > On 8 Jul 2022, at 12:04, Jianbo Liu wrote: > > > On Fri, 2022-07-08 at 11:29 +0200, Eelco Chaudron wrote: > > > On 8 Jul 2022, at 5:06, Jianbo Liu wrote: > > > > > > > Fow now, add introduction and the limitation of meter offload.

[ovs-dev] [PATCH ovn] fix typo

I looked at https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c Found fixed typo: "webserer" => "webserver" I decided to grep "webserer" and found another such word. >From b1d7d16289ffa28f76c4a7803e369a5e287ffdc5 Mon Sep 17 00:00:00 2001 From: Igor Zhukov Date: Fri, 8

[ovs-dev] [PATCH] man: Fix various typos across manual pages

As reported by Debian lintian. Signed-off-by: Frode Nordahl --- lib/db-ctl-base.man | 2 +- lib/dpctl.man| 2 +- ovsdb/ovsdb-tool.1.in| 6 +++--- utilities/ovs-ofctl.8.in | 6 +++--- utilities/ovs-vsctl.8.in | 2 +- vswitchd/vswitch.xml | 4 ++-- 6 files changed, 11

[ovs-dev] [PATCH] utilities/bashcomp: Fix incorrect file mode

The bash completion scripts shipped with Open vSwitch currently have the executable bit set. This is problematic because the files do not start with a shebang and as such a user may end up executing them using the wrong shell. When installed in a system the bash shell will source these files and

[ovs-dev] [PATCH] Fix spelling error exposed in binaries.

As reported by Debian lintinan. Signed-off-by: Frode Nordahl --- lib/daemon-unix.c| 4 ++-- lib/ovsdb-idl.c | 2 +- lib/perf-counter.c | 2 +- ofproto/ofproto-dpif-sflow.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/daemon-unix.c

[ovs-dev] [PATCH ovn] ovn-nbctl: Fix priority arg of lrp-set-gateway-chassis

When the lrp-set-gateway-chassis was followed by chained command (--) the command tried to parse -- as priority when the priority was not specified. Check if the command argument count is actually 4 instead of checking argv[3]. Reported-at: https://bugzilla.redhat.com/2102930 Signed-off-by: Ales

[ovs-dev] [PATCH] tests: Add test for later IPv6 fragments nw_proto=44

This is a regression test to make sure that all later IPv6 fragments have proto=44 in the flow key, and that there are not any later IPv6 frag flows that do not have it. Previously, the way that later IPv6 fragments' nw_proto field is parsed in the kernel was changed to equal the next_header

[ovs-dev] [PATCH] acinclude: Fix double -Werror.

We're adding -Werror argument twice to every compiler invocation, if configured with --enable-Werror. The reason is the double expansion of the OVS_ENABLE_WERROR macro. It's called once from the top level in configure.ac and the second time from the AC_REQUIRE while checking CXX compatibility.

Re: [ovs-dev] User space connection tracking benchmarks

Paolo Valerio writes: > Paolo Valerio writes: > >> Ilya Maximets writes: >> >>> On 6/20/22 23:57, Paolo Valerio wrote: Ilya Maximets writes: > On 6/7/22 11:39, Robin Jarry wrote: >> Paolo Valerio, Jun 05, 2022 at 19:37: >>> Just a note that may be useful. >>> After

Re: [ovs-dev] [PATCH] acinclude: Fix double -Werror.

On Fri, Jul 8, 2022 at 3:34 PM Ilya Maximets wrote: > We're adding -Werror argument twice to every compiler invocation, > if configured with --enable-Werror. The reason is the double > expansion of the OVS_ENABLE_WERROR macro. It's called once from > the top level in configure.ac and the

[ovs-dev] [PATCH v5 15/17] python: add unit tests for openflow parsing

Add unit tests for OFPFlow class and ip-port range decoder Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/automake.mk| 4 +- python/ovs/tests/test_decoders.py | 130 python/ovs/tests/test_ofp.py | 534 ++ 3 files

[ovs-dev] [PATCH v5 16/17] python: add unit tests to datapath parsing

Add unit tests to datapath flow parsing. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/automake.mk | 1 + python/ovs/tests/test_odp.py | 527 +++ 2 files changed, 528 insertions(+) create mode 100644 python/ovs/tests/test_odp.py

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/8/22 17:37, Ben Pfaff wrote: > On Fri, Jul 8, 2022 at 1:53 AM David Marchand > wrote: > > On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose > wrote: > > > xenserver/openvswitch-xen.spec.in >

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/8/2022 12:00 PM, Ilya Maximets wrote: On 7/8/22 17:37, Ben Pfaff wrote: On Fri, Jul 8, 2022 at 1:53 AM David Marchand mailto:david.march...@redhat.com>> wrote: On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: > >

Re: [ovs-dev] [PATCH ovn] fix typo

Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Igor Zhukov needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn] fix typo

Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 21 error: could not build fake ancestor hint: Use 'git am

[ovs-dev] [PATCH v5 00/17] python: add flow parsing library

While troubleshooting or developing new features in OVS, a considerable amount of time is spent analyzing flows (whether that's Openflow flows or datapath flows). Currently, OVS has tools to dump flows with different levels of verbosity as well as to filter flows prior to dumping them, e.g:

[ovs-dev] [PATCH v5 01/17] python: add generic Key-Value parser

Most of ofproto and dpif flows are based on key-value pairs. These key-value pairs can be represented in several ways, eg: key:value, key=value, key(value). Add the following classes that allow parsing of key-value strings: * KeyValue: holds a key-value pair * KeyMetadata: holds some metadata

[ovs-dev] [PATCH v5 05/17] build-aux: generate ofp field decoders

Based on meta-field information extracted by extract_ofp_fields, autogenerate the right decoder to be used. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- build-aux/automake.mk| 6 ++- build-aux/gen_ofp_field_decoders | 69

[ovs-dev] [PATCH v5 02/17] python: add mask, ip and eth decoders

Add more decoders that can be used by KVParser. For IPv4 and IPv6 addresses, create a new class that wraps netaddr.IPAddress. For Ethernet addresses, create a new class that wraps netaddr.EUI. For Integers, create a new class that performs basic bitwise mask comparisons netaddr is added as a new

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/8/22 22:07, Gregory Rose wrote: > > > On 7/8/2022 12:00 PM, Ilya Maximets wrote: >> On 7/8/22 17:37, Ben Pfaff wrote: >>> On Fri, Jul 8, 2022 at 1:53 AM David Marchand >> > wrote: >>> >>> On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose >>

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On Fri, Jul 8, 2022 at 12:00 PM Ilya Maximets wrote: > On 7/8/22 17:37, Ben Pfaff wrote: > > On Fri, Jul 8, 2022 at 1:53 AM David Marchand > wrote: > > > > On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose > wrote: > > > >

[ovs-dev] [PATCH v5 06/17] python: add flow base class

It simplifies the implementation of different types of flows by creating the concept of Section (e.g: match, action) and automatic accessors for all the provided Sections Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/automake.mk | 1 + python/ovs/flow/flow.py | 125

[ovs-dev] [PATCH v5 04/17] build-aux: split extract-ofp-fields

In order to be able to reuse the core extraction logic, split the command in two parts. The core extraction logic is moved to python/build while the command that writes the different files out of the extracted field info is kept in build-aux. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno

[ovs-dev] [PATCH v5 09/17] python: add flow filtering syntax

Based on pyparsing, create a very simple filtering syntax. It supports basic logic statements (and, &, or, ||, not, !), numerical operations (<, >), equality (=, !=), and masking (~=). The latter is only supported in certain fields (IntMask, EthMask, IPMask). Masking operation is semantically

[ovs-dev] [PATCH v5 17/17] python: add unit tests for filtering engine

Add unit test for OFFilter class. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/automake.mk | 1 + python/ovs/tests/test_filter.py | 221 2 files changed, 222 insertions(+) create mode 100644 python/ovs/tests/test_filter.py

[ovs-dev] [PATCH v5 08/17] python: add ovs datapath flow parsing

A ODPFlow is a Flow with the following sections: ufid info (e.g: bytes, packets, dp, etc) match actions Only three datapath actions require special handling: gre: because it has double parenthesis geneve: because it supports many concatenated lists of options nat: we reuse the decoder used for

[ovs-dev] [PATCH v5 03/17] python: add list parser

Some openflow or dpif flows encode their arguments in lists, eg: "some_action(arg1,arg2,arg3)". In order to decode this in a way that can be then stored and queried, add ListParser and ListDecoders classes that parse lists into KeyValue instances. The ListParser / ListDecoders mechanism is quite

[ovs-dev] [PATCH v5 11/17] tests: verify flows in ofp-actions are parseable

Create a small helper script and check that flows used in ofp-actions.at are parseable. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- tests/automake.mk | 2 ++ tests/ofp-actions.at | 18 + tests/test-ofparse.py | 45 +++

[ovs-dev] [PATCH v5 07/17] python: introduce OpenFlow Flow parsing

Introduce OFPFlow class and all its decoders. Most of the decoders are generic (from decoders.py). Some have special syntax and need a specific implementation. Decoders for nat are moved to the common decoders.py because it's syntax is shared with other types of flows (e.g: dpif flows).

[ovs-dev] [PATCH v5 12/17] tests: verify flows in odp.at are parseable

Create a small helper script and check that flows tested in odp.at are parseable. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- tests/automake.mk | 2 ++ tests/odp.at | 11 +++ tests/test-dpparse.py | 45 +++ 3 files

[ovs-dev] [PATCH v5 10/17] python: add a json encoder to flow fields

The json encoder can be used to convert Flows to json. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/ovs/flow/decoders.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/python/ovs/flow/decoders.py b/python/ovs/flow/decoders.py index 73d28e057..7378d4176

[ovs-dev] [PATCH v5 13/17] python: introduce unit tests

Use pytest to run unit tests as part of the standard testsuite. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- .ci/linux-prepare.sh| 3 + Documentation/intro/install/general.rst | 4 ++ python/automake.mk | 9 ++-

[ovs-dev] [PATCH v5 14/17] python: add unit tests for ListParser

Add unit tests for ListParser class. Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno --- python/automake.mk| 3 +- python/ovs/tests/test_list.py | 66 +++ 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644

[ovs-dev] [PATCH V3 6/7] acinclude.m4: Remove support for building the OVS kernel module

Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been deprecated. Now is the time to fully discontinue support for building the openvswitch kernel driver.

[ovs-dev] [PATCH V2 0/8] Remove OVS kernel driver

It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-april/393292.html Changes in V2: * Removed the Linux datapath and fixed up various Makefiles to

[ovs-dev] [PATCH V3 3/7] aux:utilities: Remove references to the Linux datapath

Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux/initial-tab-allowed-files | 1 - utilities/docker/debian/build-kernel-modules.sh | 13 - utilities/ovs-dev.py

[ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation

As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 5 +- .../contributing/backporting-patches.rst | 7 +++ Documentation/intro/install/fedora.rst

[ovs-dev] [PATCH V3 5/7] tests: Remove support for check-kmod test

The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose --- tests/automake.mk | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index b29cb783e..3496f9002 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -343,12

[ovs-dev] [PATCH V3 2/7] rhel: Remove kernel mode spec

Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 Vagrantfile | 9 +- poc/playbook-centos-builder.yml | 8 -- poc/playbook-fedora-builder.yml | 13 ---

[ovs-dev] [PATCH V3 1/7] Disable unsupported kernel builds

Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose --- .github/workflows/build-and-test.yml | 53 1 file changed, 53 deletions(-) diff --git a/.github/workflows/build-and-test.yml

Re: [ovs-dev] [PATCH V3 3/7] aux:utilities: Remove references to the Linux datapath

On 7/8/2022 1:03 PM, Greg Rose wrote: Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux/initial-tab-allowed-files | 1 - utilities/docker/debian/build-kernel-modules.sh | 13

[ovs-dev] [PATCH ovn] fix typo

Signed-off-by: Igor Zhukov Acked-by: Dumitru Ceara --- tests/system-ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 1cabf1f31..4a8fdede8 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -4505,7 +4505,7 @@

Re: [ovs-dev] [PATCH ovn] fix typo

On 7/8/22 17:32, Zhukov Igor wrote: > Thank you Aaron Conole! > Sorry for so many attempts for such simple patch . > I think I know one reason why this issue might be: I sent this email from my > home email: fsb4...@yandex.ru > > I also resent the patch from my work email, but I can't change my

Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation

On 7/8/22 22:03, Greg Rose wrote: > As of Open vSwitch release 2.18 the OVS kernel module is no longer > supported. Pull the documentation references. > > Signed-off-by: Greg Rose > --- > Documentation/faq/releases.rst| 5 +- > .../contributing/backporting-patches.rst |

[ovs-dev] [PATCH v2] tests: Add test for later IPv6 fragments nw_proto=44

This is a regression test to make sure that all later IPv6 fragments have proto=44 in the flow key, and that there are not any later IPv6 frag flows that do not have it. Previously, the way that later IPv6 fragments' nw_proto field is parsed in the kernel was changed to equal the next_header

Re: [ovs-dev] [PATCH v5 3/3] system-dpdk: Add unit test for user configured mempools.

Hi Kevin, Thanks for the patch, one comment below, let me know your thoughts. > -Original Message- > From: dev On Behalf Of Kevin Traynor > Sent: Friday, June 24, 2022 3:43 PM > To: d...@openvswitch.org > Cc: david.march...@redhat.com > Subject: [ovs-dev] [PATCH v5 3/3] system-dpdk:

Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: Add shared mempool config.

Hi Kevin, Thanks for the patch. LGTM in general, couple of minor comments/thoughts inline. > +struct user_mempool_config { > +int adj_mtu; > +int socket_id; > +}; > + > +static struct user_mempool_config *user_mempools = NULL; static int > +n_user_mempools; Should we consider

Re: [ovs-dev] [PATCH V2 3/8] rhel: Remove RHEL 6 kernel module spec

On 7/8/2022 9:14 AM, Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 poc/playbook-centos-builder.yml | 8 -- rhel/automake.mk | 10 ---

Re: [ovs-dev] [PATCH V3 3/7] aux:utilities: Remove references to the Linux datapath

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: datapath/linux/compat/socket.c datapath/linux/compat/stt.c datapath/linux/compat/udp.c

Re: [ovs-dev] [PATCH V3 4/7] Make: Remove the Linux datapath

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V3 6/7] acinclude.m4: Remove support for building the OVS kernel module

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V3 5/7] tests: Remove support for check-kmod test

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/8/22 21:54, Ben Pfaff wrote: > On Fri, Jul 8, 2022 at 12:00 PM Ilya Maximets > wrote: > > On 7/8/22 17:37, Ben Pfaff wrote: > > On Fri, Jul 8, 2022 at 1:53 AM David Marchand > mailto:david.march...@redhat.com> >

[ovs-dev] [PATCH ovn] fix typo

Signed-off-by: Igor Zhukov Acked-by: Dumitru Ceara --- tests/system-ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 1cabf1f31..4a8fdede8 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -4505,7 +4505,7 @@

[ovs-dev] [PATCH ovn 1/2] Split out code to handle port binding db updates

This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 248 ++- 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/controller/binding.c

[ovs-dev] [PATCH ovn 2/2] controller: throttle port claim attempts

When multiple chassis are fighting for the same port (requested-chassis is not set, e.g. for gateway ports), they may produce an unreasonable number of chassis field updates in a very short time frame (hundreds of updates in several seconds). This puts unnecessary load on OVN as well as any db

Re: [ovs-dev] User space connection tracking benchmarks

Aaron Conole writes: > Paolo Valerio writes: > >> Paolo Valerio writes: >> >>> Ilya Maximets writes: >>> On 6/20/22 23:57, Paolo Valerio wrote: > Ilya Maximets writes: > >> On 6/7/22 11:39, Robin Jarry wrote: >>> Paolo Valerio, Jun 05, 2022 at 19:37: Just a

[ovs-dev] [PATCH V2 1/8] Disable unsupported kernel builds

Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose --- .github/workflows/build-and-test.yml | 53 1 file changed, 53 deletions(-) diff --git a/.github/workflows/build-and-test.yml

[ovs-dev] [PATCH V2 6/8] acinclude.m4: Remove support for building the OVS kernel module

Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been deprecated. Now is the time to fully discontinue support for building the openvswitch kernel driver.

[ovs-dev] [PATCH V2 7/8] tests: Remove support for check-kmod test

The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose --- tests/automake.mk | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index b29cb783e..3496f9002 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -343,12

[ovs-dev] [PATCH V2 3/8] rhel: Remove RHEL 6 kernel module spec

Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 poc/playbook-centos-builder.yml | 8 -- rhel/automake.mk | 10 --- rhel/kmod-openvswitch-rhel6.spec.in | 123

[ovs-dev] [PATCH V2 0/8] Remove OVS kernel driver

It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-april/393292.html Changes in V2: * Removed the Linux datapath and fixed up various Makefiles to

[ovs-dev] [PATCH V2 2/8] rhel: Remove kernel mode spec

Remove the kernel driver specification for RHEL 7.x, 8.x and Fedora. Signed-off-by: Greg Rose --- Vagrantfile | 9 +- poc/playbook-fedora-builder.yml | 13 --- rhel/.gitignore | 4 - rhel/automake.mk | 12 ---

[ovs-dev] [PATCH V2 4/8] aux:utilities: Remove references to the Linux datapath

Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux/initial-tab-allowed-files | 1 - utilities/docker/debian/build-kernel-modules.sh | 13 - utilities/ovs-dev.py

[ovs-dev] [PATCH V2 8/8] Documentation: Remove kernel module documentation

As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 5 +- .../contributing/backporting-patches.rst | 7 +++ Documentation/intro/install/fedora.rst

Re: [ovs-dev] [PATCH V2 6/8] acinclude.m4: Remove support for building the OVS kernel module

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please

Re: [ovs-dev] [PATCH V2 2/8] rhel: Remove kernel mode spec

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: echo 'VERSION = "2.17.90"' >> version.py.tmp && \ if cmp -s version.py.tmp python/ovs/version.py; then

  1   2   >