On 5/10/2023 10:57 PM, Eelco Chaudron wrote:
On 27 Apr 2023, at 3:27, Chris Mi wrote:
recirc_id(0),in_port(1),eth(src=06:9c:de:63:c9:40,dst=01:00:5e:00:00:fb),eth_type(0x0800),ipv4(tos=0/0x3,frag=no),
packets:13, bytes:1883, used:5.700s,
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
> lib/odp-util.c | 2 +-
> lib/odp-util.h | 5
On 5/10/2023 7:42 PM, Eelco Chaudron wrote:
On 26 Apr 2023, at 4:42, Chris Mi wrote:
/* DPIF_UC_ACTION only. */
struct nlattr *userdata;/* Argument to OVS_ACTION_ATTR_USERSPACE. */
-struct nlattr *out_tun_key;/* Output tunnel key. */
-struct nlattr *actions;
On 5/10/2023 8:20 PM, Eelco Chaudron wrote:
On 26 Apr 2023, at 4:44, Chris Mi wrote:
+
+static int
+offload_sample_init(struct offload_sample *sample,
+const struct nlattr *next_actions,
+size_t next_actions_len, bool tunnel,
+const
On Thu, May 25, 2023 at 6:01 PM Han Zhou wrote:
> When an address set is deleted and a new one is created immediately with
> the same name, the OVSDB deletion and creation notifications can come to
> ovn-controller within the same message, and the order of the deletion
> and addition in the IDL
On 5/10/2023 10:52 PM, Eelco Chaudron wrote:
On 26 Apr 2023, at 4:47, Chris Mi wrote:
+
+P0_IFINDEX=$(cat /sys/class/net/ovs-p0/ifindex)
+m4_define([DUMP_SFLOW], [sed -e
In the current codebase for distributed gw router port use-case,
it is not possible to add a load balancer that redirects the traffic
to a back-end if it is used as internal IP of a FIP NAT rule since
the reply traffic is never centralized. Fix the issue centralizing the
traffic if it is the reply
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
> and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
>
> To avoid adding more arguments to the function to support more vxlan
>
On Thu, May 25, 2023 at 8:29 PM Brian Haley wrote:
> DNS queries with optional records (RRs), for example, with
> cookies for EDNS, are not supported by the OVN resolver.
> Trying to reply will result in mangled responses that
> clients do not understand - the ANSWER section will
> contain an
On 5/10/2023 5:54 PM, Eelco Chaudron wrote:
On 26 Apr 2023, at 4:36, Chris Mi wrote:
On 4/12/2023 10:06 PM, Eelco Chaudron wrote:
+{
+new->type = old->type;
+new->action = xmemdup(old->action, old->action->nla_len);
+new->userspace_actions = old->userspace_actions
+
By default OVS configures 2048 descriptors for tx and rx queues
on DPDK devices. It also allows the user to configure those values.
If the values used are not acceptable to the device then queue setup
would fail.
The device exposes it's max/min/alignment requirements and OVS
applies some limits
v5:
- Moved num of descriptors validation so not dependent on flow ctrl
- Updated log message when num of descriptors adjusted
- Minor whitespace
- Kept Reviewed-by: tags as minor edits
v4:
- Fixed case where sizes change but limits are not applied (David)
- Use actual device desc sizes to decide
There is no need to display 'requested_rx/tx_descriptors' and
'configured_rx/tx_descriptors' as they will be the same.
It is simpler to just have a single 'n_rxq/txq_desc' value.
Suggested-by: Ilya Maximets
Reviewed-by: David Marchand
Reviewed-by: Simon Horman
Signed-off-by: Kevin Traynor
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
The changes look good to me.
Acked-by: Eelco
On Thu, May 25, 2023 at 04:34:54PM -0400, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
>
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Linux kernel netlink module added NLA_F_NESTED flag checking for nested
> netlink messages in 5.2. A nested message without the flag set will be
> treated as malformated one. The check is optional and is controlled by
> message
On Sat, May 13, 2023 at 2:04 AM Han Zhou wrote:
> This series implements incremental processing for VIF (regular logical
> switch
> ports of VM/pod) changes in ovn-northd. The performance gains of a single
> logical switch port creation has improved significantly.
>
> Below are the performance
On Thu, May 25, 2023 at 8:22 PM Mark Michelson wrote:
> We don't use a four-digit major version, just the final two digits of
> the year.
>
> Signed-off-by: Mark Michelson
>
Hi Mark,
> ---
> Documentation/internals/release-process.rst | 10 +-
> 1 file changed, 5 insertions(+), 5
On Fri, May 26, 2023 at 12:43:52PM +0200, Eelco Chaudron wrote:
>
>
> On 15 May 2023, at 10:23, Roi Dayan wrote:
>
> > From: Gavin Li
> >
> > Add TC offload support for filtering vxlan tunnels with gbp option
> >
> > Signed-off-by: Gavin Li
> > Reviewed-by: Gavi Teitz
> > Reviewed-by: Roi
On Fri, May 26, 2023 at 10:21:58AM +0200, Lorenzo Bianconi wrote:
> In the current codebase for distributed gw router port use-case,
> it is not possible to add a load balancer that redirects the traffic
> to a back-end if it is used as internal IP of a FIP NAT rule since
> the reply traffic is
On Fri, May 26, 2023 at 12:56 PM Simon Horman
wrote:
> On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote:
> > Sorry for the top post, but I was wondering if there was a way to
> re-trigger
> > the bot testing action on a patch? Somehow the testing on the v2 one
> failed
> > even though
Hello Eli,
On Mon, Sep 5, 2022 at 4:46 PM Eli Britstein via dev
wrote:
>
> Vport's offloads are done on the tracked orig-in-port, but the flow itself
> is associated in the vport's map.
>
> Removing the physdev will flush all the ports that are on its map, but
all the flows*
> not the ones on
On 26 May 2023, at 13:05, Simon Horman wrote:
> On Fri, May 26, 2023 at 12:43:52PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 15 May 2023, at 10:23, Roi Dayan wrote:
>>
>>> From: Gavin Li
>>>
>>> Add TC offload support for filtering vxlan tunnels with gbp option
>>>
>>> Signed-off-by: Gavin Li
On 5/26/23 13:33, Ales Musil wrote:
> We saw a lot of failures recently due to jobs timing out.
> Align the timeouts with upstream ovn-kubernetes.
Hi Ales,
Thanks for this!
Nit: I'd point to the ovn-kubernetes commit (or permalink) where
timeouts were increased.
If this passes ovn-kubernetes
The only way that stats->{n_packets,n_bytes} would decrease is due to an
overflow, or if there are bugs in how statistics are handled. In the
past, there were multiple issues that caused a jump backward. A
workaround was in place to set the statistics to 0 in that case. When
this happened while
On Fri, May 26, 2023 at 03:09:02PM +0200, Eelco Chaudron wrote:
>
>
> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>
> > The only way that stats->{n_packets,n_bytes} would decrease is due to an
> > overflow, or if there are bugs in how statistics are handled. In the
> > past, there were multiple
On Wed, May 17, 2023 at 10:50:15PM -0500, Terry Wilson wrote:
> This adds a Python version of the async DNS support added in:
>
> 771680d96 DNS: Add basic support for asynchronous DNS resolving
>
> The above version uses the unbound C library, and this
> implimentation uses the SWIG-wrapped
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
I have a couple of comments below, and some general ones.
1) Can we add some unit tests for
On 23 May 2023, at 12:39, Frode Nordahl wrote:
> The tc module combines the use of the `tc_transact` helper
> function for communication with the in-kernel tc infrastructure
> with assertions on the reply data by `ofpbuf_at_assert` on the
> received data prior to further processing.
>
>
Hi Mark,
Thanks for putting this together!
On 5/25/23 20:22, Mark Michelson wrote:
> Based on discussions that have occurred on the development mailing list
> and public IRC meetings, we have decided to reduce OVN to having two
> releases per year instead of four.
>
> When OVN initially spun
On 5/25/23 20:22, Mark Michelson wrote:
> OVN hasn't used the name "master" for quite a while, and it looks like
> we missed this document when the change to "main" was made.
>
> Signed-off-by: Mark Michelson
> ---
Acked-by: Dumitru Ceara
.. but it seems there are more places where we still
On Fri, May 26, 2023 at 4:35 PM David Marchand
wrote:
>
> Hello Eli,
>
> On Mon, Sep 5, 2022 at 4:46 PM Eli Britstein via dev
> wrote:
> >
> > Vport's offloads are done on the tracked orig-in-port, but the flow itself
> > is associated in the vport's map.
> >
> > Removing the physdev will flush
Hi Ales,
Thanks for the review and for fixing the timeout. I had tried in my own
fork and it failed in a different way, again unrelated to the change.
I'll push a v4 with an updated commit message that hopefully gets a good
run.
Thanks,
-Brian
On 5/26/23 2:41 AM, Ales Musil wrote:
On
DNS queries with optional records (RRs), for example, with
cookies for EDNS, are not supported by the OVN resolver.
Trying to reply will result in mangled responses that
clients do not understand - the ANSWER section will
contain an incorrect option.
Instead, just return early when one is
On 5/24/23 09:37, Felix Huettner wrote:
> Hi everyone,
Hi Felix,
>
> Ilya mentioned to me that you will want to bring openstack examples to
> ovn-heater.
>
Yes, we're discussing that.
> I wanted to ask how to best join this effort. It would be great for us
Everyone is welcome to contribute!
On 5/25/23 20:22, Mark Michelson wrote:
> The OVN team has had no concrete policy regarding when releases are
> made for a given version. In the past, new releases have been made only
> when something critical has been found, meaning that most bug fixes
> applied to a given OVN version never end
On 5/25/23 20:22, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> Documentation/internals/release-process.rst | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/internals/release-process.rst
> b/Documentation/internals/release-process.rst
>
On 5/25/23 20:22, Mark Michelson wrote:
> The definition of "regular releases" is being kept purposely vague in
> this commit because a later commit will define what the interval is for
> these releases.
>
> Signed-off-by: Mark Michelson
> ---
Sounds reasonable to me, thanks!
Acked-by: Dumitru
On 5/25/23 20:22, Mark Michelson wrote:
> This is based on discussions that have happened both on the ovs-dev
> mailing list as well as public IRC developer meetings.
>
> Signed-off-by: Mark Michelson
> ---
> .../contributing/backporting-patches.rst | 28 +++
> 1 file
On 5/25/23 20:22, Mark Michelson wrote:
> Upcoming changes to the documentation will add documentation for
> standard term support versions and will document a policy for when
> releases are made for these versions. Our current use of "release" in
> the documentation is interchangeable with
On 5/26/23 15:42, Eelco Chaudron wrote:
>
>
> On 17 May 2023, at 12:18, Eelco Chaudron wrote:
>
>> On 16 May 2023, at 21:48, Ilya Maximets wrote:
>>
>>> On 5/16/23 10:20, Eelco Chaudron wrote:
On 15 May 2023, at 17:47, Ilya Maximets wrote:
> On 5/15/23 16:24, Eelco
Bleep bloop. Greetings 张祖建, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch fragment without header at line 6: @@ -3967,6 +3974,13 @@
fqcodel_install__(struct netdev
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Most of the data members of struct tc_action{ } are defined as anonymous
> struct in place. Instead of passing all members of an anonymous struct,
> which is not flexible to new members being added, expose encap as named
> struct
On 5/25/23 20:22, Mark Michelson wrote:
> This document appears to be based on the OVS document, but things are
> done slightly differently in OVN.
>
> * OVN is 100% userspace, so there is no need to clarify "userspace"
> anywhere.
> * The commit message example is not how we do things in OVN.
On 5/25/23 15:20, Simon Horman wrote:
> On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote:
>> Many OVSDB tests are not checking the server log for warnings or
>> errors. Some are not even using the log file. It's mostly OK as we're
>> usually checking the user-visible behavior. But
On 26 May 2023, at 15:40, Marcelo Ricardo Leitner wrote:
> On Fri, May 26, 2023 at 03:09:02PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>>
>>> The only way that stats->{n_packets,n_bytes} would decrease is due to an
>>> overflow, or if there are bugs
On Thu, May 25, 2023 at 8:22 PM Mark Michelson wrote:
> The current state of development in OVN has resulted in many discussions
> happening about how things should change. The main points of the
> discussions have been:
>
> * Recent releases have been much more bare than releases made two or
>
On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote:
> Sorry for the top post, but I was wondering if there was a way to re-trigger
> the bot testing action on a patch? Somehow the testing on the v2 one failed
> even though v1 passed [0]. Since the only change was in the commit message
>
On 5/25/23 20:22, Mark Michelson wrote:
> We don't use a four-digit major version, just the final two digits of
> the year.
>
> Signed-off-by: Mark Michelson
> ---
Looks good to me, thanks!
Acked-by: Dumitru Ceara
___
dev mailing list
On 26 May 2023, at 14:03, Balazs Nemeth wrote:
> The only way that stats->{n_packets,n_bytes} would decrease is due to an
> overflow, or if there are bugs in how statistics are handled. In the
> past, there were multiple issues that caused a jump backward. A
> workaround was in place to set the
On Thu, May 25, 2023 at 2:23 PM Ansis wrote:
>
> On Fri, May 19, 2023 at 9:53 AM Russell Bryant wrote:
> >
> > The following document discusses emeritus committer status:
> >
> > https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/
> >
> > There are several people who I
Since on CentOS/RHEL the builds are based on stable branches and not on
tags for debugging purpose it's better to have the downstream version as
version so it's easier to know which commits are included in a build.
This commit adds --with-version-suffix as ./configure option in
order to set an
On 15 May 2023, at 10:23, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
One comment below, the rest looks good to me.
//Eelco
> ---
>
We saw a lot of failures recently due to jobs timing out.
Align the timeouts with upstream ovn-kubernetes.
Signed-off-by: Ales Musil
---
.github/workflows/ovn-kubernetes.yml | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/ovn-kubernetes.yml
On 17 May 2023, at 12:18, Eelco Chaudron wrote:
> On 16 May 2023, at 21:48, Ilya Maximets wrote:
>
>> On 5/16/23 10:20, Eelco Chaudron wrote:
>>>
>>>
>>> On 15 May 2023, at 17:47, Ilya Maximets wrote:
>>>
On 5/15/23 16:24, Eelco Chaudron wrote:
>
>
> On 4 May 2023, at 0:55,
Reported by Valgrind:
==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss
record 363 of 408
==00:00:00:46.715 951138== at 0x4848899: malloc (in
/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==00:00:00:46.715 951138== by 0x278E98: xmalloc__ (util.c:140)
The offload thread calling ufid_to_rte_flow_disassociate() may be the
last one holding a reference on the netdev and physdev.
So displaying informations about them might trigger a crash when
removing a physical port.
Fixes: faf71e492263 ("netdev-dpdk: Print port name in offload API messages.")
The current implementation used to extract PS1 prompt for ovs-vsctl is
broken on recent Bash releases.
Starting from Bash 4.4 it's possible to use @P expansion in order to get
the quoted PS1 directly.
This commit makes the 2 bash completion files to use @P expansion in order
to get the quoted PS1
In most cases, after the condition change request, the new condition
is the same as old one plus minus a few clauses. Today, ovsdb-server
will evaluate every database row against all the old clauses and then
against all the new clauses in order to tell if an update should be
generated.
For
The current implementation used to extract PS1 prompt for ovs-vsctl is
broken on recent Bash releases.
Starting from Bash 4.4 it's possible to use @P expansion in order to get
the quoted PS1 directly.
This commit makes the 2 bash completion files to use @P expansion in order
to get the quoted PS1
On 5/26/23 22:07, Ilya Maximets wrote:
> CC: Marcelo.
>
> On 5/26/23 22:02, Ilya Maximets wrote:
>> On 5/26/23 21:19, Eelco Chaudron wrote:
>>>
>>>
>>> Send from my phone
>>>
Op 26 mei 2023 om 20:52 heeft Ilya Maximets het
volgende geschreven:
On 5/26/23 20:43, Ilya
Bleep bloop. Greetings 张祖建, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch fragment without header at line 6: @@ -3967,6 +3974,13 @@
fqcodel_install__(struct netdev
Reported by Valgrind:
==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss
record 363 of 408
==00:00:00:46.715 951138== at 0x4848899: malloc (in
/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==00:00:00:46.715 951138== by 0x278E98: xmalloc__ (util.c:140)
Reported by Valgrind:
==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in
loss record 363 of 408
==00:00:00:46.715 951138== at 0x4848899: malloc (in
/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==00:00:00:46.715 951138== by 0x278E98: xmalloc__ (util.c:140)
On 5/25/23 14:27, Simon Horman wrote:
> On Thu, May 18, 2023 at 02:14:25PM +0200, Ilya Maximets wrote:
>> In most cases, after the condition change request, the new condition
>> is the same as old one plus minus a few clauses. Today, ovsdb-server
>> will evaluate every database row against all
On 5/26/23 15:09, Eelco Chaudron wrote:
>
>
> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>
>> The only way that stats->{n_packets,n_bytes} would decrease is due to an
>> overflow, or if there are bugs in how statistics are handled. In the
>> past, there were multiple issues that caused a
On 5/25/23 15:21, Simon Horman wrote:
> On Wed, May 17, 2023 at 06:51:04PM +0200, Ilya Maximets wrote:
>> OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed
>> to alert the application whenever the connection terminated without
>> a proper close_notify. And that should allow
Send from my phone
> Op 26 mei 2023 om 20:52 heeft Ilya Maximets het volgende
> geschreven:
>
> On 5/26/23 20:43, Ilya Maximets wrote:
>>> On 5/23/23 12:39, Frode Nordahl wrote:
>>> The tc module combines the use of the `tc_transact` helper
>>> function for communication with the in-kernel
On Fri, May 26, 2023 at 11:05 AM David Marchand
wrote:
>
> The offload thread calling ufid_to_rte_flow_disassociate() may be the
> last one holding a reference on the netdev and physdev.
> So displaying informations about them might trigger a crash when
> removing a physical port.
>
> Fixes:
On 5/26/23 10:57, Kevin Traynor wrote:
> v5:
> - Moved num of descriptors validation so not dependent on flow ctrl
> - Updated log message when num of descriptors adjusted
> - Minor whitespace
> - Kept Reviewed-by: tags as minor edits
>
> v4:
> - Fixed case where sizes change but limits are not
v1 -> v2:
Split if to avoid line > 79 characters
Timothy Redaelli (1):
utilities/bashcomp: Fix PS1 generation on new bash
utilities/ovs-appctl-bashcomp.bash | 7 +++
utilities/ovs-vsctl-bashcomp.bash | 7 +++
2 files changed, 14 insertions(+)
--
2.40.1
On 5/23/23 12:39, Frode Nordahl wrote:
> The tc module combines the use of the `tc_transact` helper
> function for communication with the in-kernel tc infrastructure
> with assertions on the reply data by `ofpbuf_at_assert` on the
> received data prior to further processing.
>
> `tc_transact` in
On 5/26/23 21:19, Eelco Chaudron wrote:
>
>
> Send from my phone
>
>> Op 26 mei 2023 om 20:52 heeft Ilya Maximets het
>> volgende geschreven:
>>
>> On 5/26/23 20:43, Ilya Maximets wrote:
>>> On 5/23/23 12:39, Frode Nordahl wrote:
The tc module combines the use of the `tc_transact`
Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 89 characters long (recommended limit is 79)
#31 FILE:
On 5/26/23 20:43, Ilya Maximets wrote:
> On 5/23/23 12:39, Frode Nordahl wrote:
>> The tc module combines the use of the `tc_transact` helper
>> function for communication with the in-kernel tc infrastructure
>> with assertions on the reply data by `ofpbuf_at_assert` on the
>> received data prior
CC: Marcelo.
On 5/26/23 22:02, Ilya Maximets wrote:
> On 5/26/23 21:19, Eelco Chaudron wrote:
>>
>>
>> Send from my phone
>>
>>> Op 26 mei 2023 om 20:52 heeft Ilya Maximets het
>>> volgende geschreven:
>>>
>>> On 5/26/23 20:43, Ilya Maximets wrote:
On 5/23/23 12:39, Frode Nordahl wrote:
My commit hook capitalized 'c' in the 'condition'. I can fix that
before applying.
Best regards, Ilya Maximets.
On 5/26/23 19:18, Ilya Maximets wrote:
> In most cases, after the condition change request, the new condition
> is the same as old one plus minus a few clauses. Today, ovsdb-server
>
On Thu, May 25, 2023 at 11:45 PM Ales Musil wrote:
>
>
>
> On Thu, May 25, 2023 at 6:01 PM Han Zhou wrote:
>>
>> When an address set is deleted and a new one is created immediately with
>> the same name, the OVSDB deletion and creation notifications can come to
>> ovn-controller within the same
78 matches
Mail list logo
