On Fri, Aug 25, 2023 at 2:06 PM Eelco Chaudron wrote:
> > What I think instead is that having DPDK probes all devices by default
> > is not desirable, though it has been working like this since OVS
> > integrated DPDK.
> > I have a patch in store for a long time, I just never found an
> >
On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron wrote:
> On 23 Aug 2023, at 17:34, David Marchand wrote:
>
> > As reported by Ales, net/tap has broken support for checksum offloading.
> > Fixes have been sent to the DPDK side, but waiting for the fixes, simply
> > disable all conntrack related
ovn supports creating remote logical ports. An user
can set requested-chassis option for a logical switch port
to the remote chassis and ovn-northd can bind it to that chassis.
This is required for OVN IC in ovn-k8s. Right now ovn-k8s
ovnkube-controller after creating a remote logical port, sets
On Wed, Aug 23, 2023 at 5:35 PM David Marchand
wrote:
> diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at
> index a72133fae1..de126946a0 100644
> --- a/tests/system-dpdk-macros.at
> +++ b/tests/system-dpdk-macros.at
> @@ -87,7 +87,13 @@ $1";/does not exist. The Open vSwitch
On 8/22/23 10:54, Ales Musil wrote:
> On Tue, Aug 22, 2023 at 10:40 AM Frode Nordahl
> wrote:
>
>> Some systems may provide backtrace() in libc but for some reason
>> not provide any frames when attempting to use it.
>>
>> On those systems the fatal_signal_init() function currently logs
>> this
On 8/25/23 18:52, Mark Michelson wrote:
> Hi Ilya,
>
> I merged this change into main and branch-23.06. The conflicts were easy
> to resolve in branch-23.06, but when attempting to merge to 23.03, I was
> not as comfortable trying to resolve the conflicts. Could you please
> post a version of
On 8/24/23 17:19, David Marchand wrote:
> As reported by Ales when doing some OVN integration tests with OVS 3.2,
> net/tap has broken L4 checksum offloads.
>
> Fixes are pending on DPDK side.
> Until they get in a LTS release used by OVS, disable those Tx offloads.
>
> Signed-off-by: David
Hi Ales, I applied this series to main and all branches back to 22.09.
On 8/15/23 07:03, Ales Musil wrote:
The test was assuming that the DP key and Port keys are
always fixed. Make sure that we use proper values for the
flow check.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v2:
Faicker Mo writes:
> The warning message is
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> IPIP and GRE only need the checksum recalculation of the IP header if the
> IP header is rewritten.
>
> Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags on
The daemon life cycle spans over the whole test case life time, which
significantly speeds up test cases that rely on fmt_pkt for packet byte
representations.
The speed-up comes from the fact that we no longer start a python
environment with all scapy modules imported on any fmt_pkt invocation;
I merged this change to main and all branches back to 22.03.
Thanks Ilya!
On 8/24/23 15:02, Mark Michelson wrote:
Thanks Ilya,
Acked-by: Mark Michelson
On 8/23/23 17:57, Ilya Maximets wrote:
We need to allocate memory for 'n_router_dps' pointers, but the
current code allocates space for
On 8/17/23 02:30, Antonin Bas wrote:
> From: Antonin Bas
>
> From: Antonin Bas
>
> Since Open vSwitch 2.7, the max_len option has no effect, and the full
> packet is always sent to controllers. This was confirmed with both the
> kernel and netdev datapaths.
Hi, Antonin. Thanks for the patch!
On Thu, Aug 24, 2023 at 7:52 PM Ilya Maximets wrote:
>
> On 8/24/23 17:22, Aaron Conole wrote:
> > David Marchand writes:
> >
> >> On Wed, Aug 23, 2023 at 5:35 PM David Marchand
> >> wrote:
> >>>
> >>> Integrate system-traffic.at tests as part of check-dpdk.
> >>
> >> CI (thinking of Intel
On 25 Aug 2023, at 15:46, Ilya Maximets wrote:
> On 8/24/23 17:19, David Marchand wrote:
>> As reported by Ales when doing some OVN integration tests with OVS 3.2,
>> net/tap has broken L4 checksum offloads.
>>
>> Fixes are pending on DPDK side.
>> Until they get in a LTS release used by OVS,
Faicker Mo writes:
> Add tc csum offload support of protocols IGMP/UDPLITE/SCTP
>
> Signed-off-by: Faicker Mo
> ---
Acked-by: Aaron Conole
> lib/tc.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/tc.c b/lib/tc.c
> index f49048cda..52a74d9d0 100644
> --- a/lib/tc.c
>
David Marchand writes:
> On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron wrote:
>> On 23 Aug 2023, at 17:34, David Marchand wrote:
>>
>> > As reported by Ales, net/tap has broken support for checksum offloading.
>> > Fixes have been sent to the DPDK side, but waiting for the fixes, simply
>> >
On 8/24/23 10:31, Frode Nordahl wrote:
> From: Colin Watson
>
> tbl defaults to expecting table entries to be separated by tab
> characters. However, commit 5a0e4aec1af5cf7741c490bce704577e51e536b9
> converted these to spaces and inadvertently broke the rendering. Use
> semicolons as
Hi Ilya,
Do you think we can merge this patch first as it is specific to the
controller action?
I will check the behavior of output(port=controller,max_len=X) and once I
have confirmation, I can submit a new patch.
Thanks,
Antonin
Le ven. 25 août 2023 à 07:10, Ilya Maximets a écrit :
> On
Hi Ilya,
I merged this change into main and branch-23.06. The conflicts were easy
to resolve in branch-23.06, but when attempting to merge to 23.03, I was
not as comfortable trying to resolve the conflicts. Could you please
post a version of the patch that applies to 23.03 please?
Thanks,
On 7/18/23 21:38, Mike Pattrick wrote:
Currently a bridge mirror will collect all packets and tools like
ovs-tcpdump can apply additional filters after they have already been
duplicated by vswitchd. This can result in inefficient collection.
This patch adds support to apply pre-selection to
Thanks for the changes Ales.
Acked-by: Mark Michelson
On 8/24/23 01:29, Ales Musil wrote:
Add config option called "northd-backoff-interval-ms" that allows
to delay northd engine runs capped by the config option.
When the config option is set to 0 or unspecified, the engine
will run without
James Raphael Tiovalen writes:
> This commit adds various null pointer checks to some files in the `lib`
> and the `ovsdb` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early or skipping some action if a null pointer
On 8/25/23 18:38, Antonin Bas wrote:
> Hi Ilya,
>
> Do you think we can merge this patch first as it is specific to the
> controller action?
> I will check the behavior of output(port=controller,max_len=X) and once I
> have confirmation, I can submit a new patch.
OK. I applied the change now.
On 8/23/23 16:28, Robin Jarry wrote:
> v2:
>
> * Keep code in the python dir but rename it so that it does not clash
> with `python -m build`.
> * Remove duplication in makefiles.
>
> Robin Jarry (3):
> python: Rename build related code to ovs_build_helpers.
> python: Use twine to upload
On 8/25/23 18:55, Ilya Maximets wrote:
> On 8/25/23 18:52, Mark Michelson wrote:
>> Hi Ilya,
>>
>> I merged this change into main and branch-23.06. The conflicts were easy
>> to resolve in branch-23.06, but when attempting to merge to 23.03, I was
>> not as comfortable trying to resolve the
James Raphael Tiovalen writes:
> This commit adds some `ovs_assert()` checks to some return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions since it should be impossible for
On 8/24/23 17:12, Eelco Chaudron wrote:
>
>
> On 13 Aug 2023, at 11:08, Zhiqi Chen via dev wrote:
>
>> The 'len' of a netdev_flow_key initialized by netdev_flow_key_init()
>> is always zero, which may cause errors when cloning a netdev_flow_key
>> by netdev_flow_key_clone().
>>
>> Currently the
Current implementation of 'ref_chassis' recompute is horribly slow.
For each port binding it finds LR group, then it adds a chassis of the
current port binding to each HA chassis group of this LR group.
The number of ports is much greater than number of chassis. And the
number of distinct LR
James Raphael Tiovalen writes:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc` to `xzalloc`. This is to prevent
On 8/26/23 00:51, Antonin Bas wrote:
> Hi Ilya,
>
> Thanks for applying the patch.
> I just finished testing / investigating output(port=controller,max_len=X),
> and there is no need to patch the documentation, for the following reasons:
>
> The output(port=controller,max_len=X) action is
Hi Ilya,
Thanks for applying the patch.
I just finished testing / investigating output(port=controller,max_len=X),
and there is no need to patch the documentation, for the following reasons:
The output(port=controller,max_len=X) action is rejected by OVS:
root@ovs-test-node-1:/home/vagrant#
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Let's enhance our coverage in the CI and run DPDK system tests.
>
> A few DPDK drivers are enabled in DPDK compilation.
>
> Put DPDK build in $PATH for dpdk-testpmd to be available.
> sudo drops PATH= updates and -E alone does not seem to
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Some unit tests expect that a OVS port has an associated netdevice on
> which they can hook tc or tcpdump.
> This will not be possible when testing the userspace datapath with DPDK.
> Introduce two helpers (which will be overriden in
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Align system-dpdk existing helpers to other common OVS helpers so they
> can accept some optional arguments.
>
> Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to
> catch dpdk related logs in a centralised fashion.
>
>
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Integrate system-traffic.at tests as part of check-dpdk.
>
> DPDK net/tap specific logs are added to the log exclusions.
>
> Some tests that can't work with the userspace datapath are skipped by
> overriding some OVS_CHECK_* macros.
>
> ADD_VETH
On Fri, Aug 25, 2023 at 12:57 PM Eelco Chaudron wrote:
> >
> > +m4_define([OVS_DPDK_STOP_VSWITCHD],
> > + [OVS_VSWITCHD_STOP([dnl
> > +$1";/does not exist. The Open vSwitch kernel module is probably not
> > loaded./d
> > +/does not support MTU configuration,/d
> > +/EAL: No \(available\|free\)
On 24 Aug 2023, at 17:19, David Marchand wrote:
> As reported by Ales when doing some OVN integration tests with OVS 3.2,
> net/tap has broken L4 checksum offloads.
>
> Fixes are pending on DPDK side.
> Until they get in a LTS release used by OVS, disable those Tx offloads.
>
> Signed-off-by:
On 23 Aug 2023, at 17:34, David Marchand wrote:
> As reported by Ales, net/tap has broken support for checksum offloading.
> Fixes have been sent to the DPDK side, but waiting for the fixes, simply
> disable all conntrack related tests and some IPv6 tunnel tests.
>
> Signed-off-by: David
On 23 Aug 2023, at 17:34, David Marchand wrote:
> Rather than copy/paste everywhere, introduce helpers to control
> testpmd runs.
> Rely on --stats-period (which outputs port stats every n seconds) so that
> testpmd keeps running without expecting any user input.
>
> Signed-off-by: David
On 23 Aug 2023, at 17:34, David Marchand wrote:
> dpdk-testpmd does not need hugetlbfs backing as we don't require
> multiprocess support in OVS unit tests.
> Plus, there is no need for explicitly reserving more memory than what
> testpmd would actually need at runtime.
>
> Switch to
On Thu, Aug 24, 2023 at 6:01 PM Ilya Maximets wrote:
>
> On 8/22/23 22:45, Mike Pattrick wrote:
> > When the a revalidator thread is updating statistics for an XC_LEARN
> > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> > The revalidator will update stats for rules even
On 25 Aug 2023, at 13:34, David Marchand wrote:
> On Fri, Aug 25, 2023 at 12:57 PM Eelco Chaudron wrote:
>>>
>>> +m4_define([OVS_DPDK_STOP_VSWITCHD],
>>> + [OVS_VSWITCHD_STOP([dnl
>>> +$1";/does not exist. The Open vSwitch kernel module is probably not
>>> loaded./d
>>> +/does not support
On 8/24/23 21:02, Mark Michelson wrote:
> Thanks for the change, Ilya.
>
> I'm not so sure about this. If there were other related changes in this
> region of code, then also swapping the arguments would make sense. But
> on its own, this doesn't fix anything, and it doesn't add any
>
43 matches
Mail list logo
