[ovs-dev] [PATCH v2] ofproto-dpif-rid: Fix duplicate entries.

2024-04-30 Thread wushaohua
From: Shaohua Wu In scenarios with multiple PMDs, there may be simultaneous requests for recirc_id from multiple PMD threads.In recirc_alloc_id_ctx, we first check if there is a duplicate entry in the metadata_map for the same frozen_state field. If successful, we directly retrieve the

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-30 Thread Ilya Maximets
On 4/26/24 18:35, Ilya Maximets wrote: > Cirrus CI is broken on FreeBSD 13.3 due to clang version update. > It now complains about snprintf truncation the same way GCC does: > > tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; > specified size is 5, but format

Re: [ovs-dev] [PATCH] tc: Fix -Wgnu-variable-sized-type-not-at-end warning with Clang 18.

2024-04-30 Thread Ales Musil
On Fri, Apr 26, 2024 at 7:44 PM Ilya Maximets wrote: > Clang 18.1.3-2.fc41 throws a warning: > > lib/tc.c:3060:25: error: field 'sel' with variable sized type > 'struct tc_pedit_sel' not at the end of a struct or class is a > GNU extension

Re: [ovs-dev] [PATCH ovn v2] controller: Track individual address set constants.

2024-04-30 Thread Ales Musil
On Mon, Apr 29, 2024 at 11:01 PM Han Zhou wrote: > On Fri, Apr 12, 2024 at 8:20 AM Ales Musil wrote: > > > > Instead of tracking address set per struct expr_constant_set track it > > per individual struct expr_constant. This allows more fine grained > > control for I-P processing of address

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-30 Thread Ales Musil
On Fri, Apr 26, 2024 at 6:35 PM Ilya Maximets wrote: > Cirrus CI is broken on FreeBSD 13.3 due to clang version update. > It now complains about snprintf truncation the same way GCC does: > > tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; > specified size is

[ovs-dev] [PATCH ovn] ci: Keep the Ubuntu container on 22.04.

2024-04-30 Thread Ales Musil
The Ubuntu 24.04 brought some issues that are not realyl stright forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. Signed-off-by: Ales Musil --- utilities/containers/ubuntu/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-30 Thread Eelco Chaudron
On 30 Apr 2024, at 11:53, Ilya Maximets wrote: > On 4/26/24 18:35, Ilya Maximets wrote: >> Cirrus CI is broken on FreeBSD 13.3 due to clang version update. >> It now complains about snprintf truncation the same way GCC does: >> >> tests/test-util.c:1129:16: error: 'snprintf' will always be

Re: [ovs-dev] [PATCH ovn v3] ci: Keep the container version pinned.

2024-04-30 Thread Ilya Maximets
On 4/30/24 16:44, Ales Musil wrote: > The Ubuntu 24.04 brought some issues that are not really straight > forward to fix. Keep the Ubuntu version on 22.04 for now to keep > the CI working. > > At the same time Fedora updated Clang to version 18, which is > throwing compilation error that need to

[ovs-dev] [PATCH ovn v2] ci: Keep the the container version pinned.

2024-04-30 Thread Ales Musil
The Ubuntu 24.04 brought some issues that are not realyl stright forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. At the same time Fedora updated Clang to version 18, which is throwing compilation error that need to be fixed in OvS first. Signed-off-by: Ales Musil

Re: [ovs-dev] [PATCH] sparse: Add immintrin.h header.

2024-04-30 Thread Ales Musil
On Tue, Apr 30, 2024 at 4:36 PM Ilya Maximets wrote: > Sparse doesn't understand _Float16 and some other types used by > immintrin.h from GCC 13. This breaks sparse builds with DPDK on > Fedora 38+ and Ubuntu 24.04. > > Add another sparse-specific header to workaround the problem. We do > need

[ovs-dev] [PATCH ovn v3] ci: Keep the container version pinned.

2024-04-30 Thread Ales Musil
The Ubuntu 24.04 brought some issues that are not really straight forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. At the same time Fedora updated Clang to version 18, which is throwing compilation error that need to be fixed in OvS first. Signed-off-by: Ales

Re: [ovs-dev] [PATCH ovn v2] ci: Keep the the container version pinned.

2024-04-30 Thread Ales Musil
On Tue, Apr 30, 2024 at 3:31 PM Ales Musil wrote: > The Ubuntu 24.04 brought some issues that are not realyl stright > typo: s/realyl stright/really straight :( forward to fix. Keep the Ubuntu version on 22.04 for now to keep > the CI working. > > At the same time Fedora updated Clang to

Re: [ovs-dev] [PATCH ovn v3] ci: Keep the container version pinned.

2024-04-30 Thread Mark Michelson
Acked-by: Mark Michelson I pushed this to main and branch-24.03. On 4/30/24 10:44, Ales Musil wrote: The Ubuntu 24.04 brought some issues that are not really straight forward to fix. Keep the Ubuntu version on 22.04 for now to keep the CI working. At the same time Fedora updated Clang to

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-04-30 Thread Eelco Chaudron
Greetings, Intel team! The self-test conducted as part of this patch has revealed an issue with the AVX512 checksumming code. Since it was agreed upon that your team would maintain this code upon its inclusion, could you please review the problem and provide a patch? Details on the problem

[ovs-dev] [PATCH] sparse: Add immintrin.h header.

2024-04-30 Thread Ilya Maximets
Sparse doesn't understand _Float16 and some other types used by immintrin.h from GCC 13. This breaks sparse builds with DPDK on Fedora 38+ and Ubuntu 24.04. Add another sparse-specific header to workaround the problem. We do need some of the functions and types defined in these headers, so we

Re: [ovs-dev] [PATCH net-next 6/8] net:openvswitch: add psample support

2024-04-30 Thread Dan Carpenter
-amorenoz%40redhat.com patch subject: [PATCH net-next 6/8] net:openvswitch: add psample support config: i386-randconfig-141-20240430 (https://download.01.org/0day-ci/archive/20240430/202404300611.kjozl2ki-...@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-30 Thread Ilya Maximets
On 4/30/24 13:12, Eelco Chaudron wrote: > > > On 30 Apr 2024, at 11:53, Ilya Maximets wrote: > >> On 4/26/24 18:35, Ilya Maximets wrote: >>> Cirrus CI is broken on FreeBSD 13.3 due to clang version update. >>> It now complains about snprintf truncation the same way GCC does: >>> >>>

Re: [ovs-dev] [PATCH] tc: Fix -Wgnu-variable-sized-type-not-at-end warning with Clang 18.

2024-04-30 Thread Ilya Maximets
On 4/30/24 12:41, Ales Musil wrote: > > > On Fri, Apr 26, 2024 at 7:44 PM Ilya Maximets > wrote: > > Clang 18.1.3-2.fc41 throws a warning: > >   lib/tc.c:3060:25: error: field 'sel' with variable sized type >             'struct tc_pedit_sel' not at the

[ovs-dev] [PATCH ovn v3] controller: Track individual address set constants.

2024-04-30 Thread Ales Musil
Instead of tracking address set per struct expr_constant_set track it per individual struct expr_constant. This allows more fine grained control for I-P processing of address sets in controller. It helps with scenarios like matching on two address sets in one expression e.g. "ip4.src == {$as1,

Re: [ovs-dev] [PATCH] sparse: Add immintrin.h header.

2024-04-30 Thread Ilya Maximets
On 4/30/24 16:41, Ales Musil wrote: > > > On Tue, Apr 30, 2024 at 4:36 PM Ilya Maximets > wrote: > > Sparse doesn't understand _Float16 and some other types used by > immintrin.h from GCC 13.  This breaks sparse builds with DPDK on > Fedora 38+ and Ubuntu

Re: [ovs-dev] [PATCH ovn v7 0/6] Correct tunnel ids exhaustion scenario.

2024-04-30 Thread Numan Siddique
On Fri, Apr 26, 2024 at 3:04 PM Mark Michelson wrote: > > Thanks for the update, Ihar. > > For the series, > Acked-by: Mark Michelson Thanks Ihar, Vladislav and Mark. I applied the series to the main branch. Numan > > On 4/26/24 13:54, Ihar Hrachyshka wrote: > > v2+ of the original test

Re: [ovs-dev] [PATCH v1] nedev-dpdk: Fix config with dpdk net_bonding offloads.

2024-04-30 Thread Ilya Maximets
On 4/13/24 06:56, Jun Wang wrote: >>On 4/12/24 08:29, Jun Wang wrote: >>> If it's a DPDK net_bonding, it may cause >>> offload-related configurations to take effect, >>> leading to offload failure. >>> >>> /usr/share/openvswitch/scripts/ovs-ctl restart --no-ovs-vswitchd \ >>> --system-id=test >>>