Re: [ovs-dev] [PATCH v2 1/2] ovn-northd: Add hint in lflow to link back to acl

2017-04-14 Thread Ben Pfaff
On Thu, Mar 23, 2017 at 11:43:25PM -0700, Han Zhou wrote: > It will be helpful for trouble-shooting if we can link a logical flow > back to the ACL that generated it. This patch is to add a stage-hint as > an external-id in lflow. The hint contains stage specific information. > Now only lflows in A

Re: [ovs-dev] [PATCH 1/1] dpif-netdev: The pmd-*-show commands will show info in core order

2017-04-14 Thread Ben Pfaff
On Wed, Mar 22, 2017 at 11:10:23AM +0100, Eelco Chaudron wrote: > The "ovs-appctl dpif-netdev/pmd-rxq-show" and "ovs-appctl > dpif-netdev/pmd-stats-show" commands show their output per core_id, > sorted on the hash location. My OCD was kicking in when using these > commands, hence this change to di

[ovs-dev] [PATCH] flow: Further refinements to flow_pop_vlan().

2017-04-14 Thread Ben Pfaff
This may help to suppress warnings from know-it-all compilers, and it helps to make the code clearer too. Reported-by: Darrell Ball Signed-off-by: Ben Pfaff --- Sorry, I didn't see v2 of the memset patch until I'd already applied v1. Here's my version of this patch. lib/flow.c | 17 +--

Re: [ovs-dev] [patch_v1] ovs build: Fix memset with zero size warning.

2017-04-14 Thread Ben Pfaff
On Sun, Mar 19, 2017 at 10:11:09AM -0700, Darrell Ball wrote: > In file included from /usr/include/string.h:640:0, > from ./lib/string.h:20, > from /usr/include/netinet/icmp6.h:22, > from ../lib/flow.h:21, > from ../lib/flow.c:18:

Re: [ovs-dev] [PATCH v2] netdev-dpdk: fix ARM cross compilation failure

2017-04-14 Thread Ben Pfaff
On Tue, Mar 21, 2017 at 02:56:36PM +0800, Jianbo Liu wrote: > The 03/21/2017 06:43, Hemant Agrawal wrote: > > > > > > > -Original Message- > > > From: Jianbo Liu [mailto:jianbo@arm.com] > > > Sent: Tuesday, March 21, 2017 10:55 AM > > > To: Hemant Agrawal > > > Cc: b...@ovn.org; d...@o

[ovs-dev] [PATCH] configure: Fix check for rte_config.h to handle cross-compilation.

2017-04-14 Thread Ben Pfaff
The check for rte_config.h in acinclude.m4 used AC_CHECK_FILE, but this macro is intended to check for a file on the host system, not the build system, which means that it fails unconditionally in a cross-compilation environment. However, the intended check here is for a header file, which is part

Re: [ovs-dev] [RFC] make logs readable only by owner

2017-04-14 Thread Ben Pfaff
On Thu, Mar 16, 2017 at 03:03:47PM +0100, Timothy Redaelli wrote: > The Open vSwitch log directory and files are currently set world readable. > > However, since only Open vSwitch users and processes need to access this > directory and files there is no need to allow the world to access them, > si

Re: [ovs-dev] [PATCH] ofp-parse: Fix match parsing with [x..y]=z format.

2017-04-14 Thread Ben Pfaff
On Thu, Apr 13, 2017 at 06:31:06PM -0700, Jarno Rajahalme wrote: > Commit 21b2fa617126 ("ofp-parse: Allow match field names in actions > and brackets in matches.") added support for matching a consecutive > set of bits with the [x..y]=z format, but the copying of the parsed > value ('z') to the mat

Re: [ovs-dev] [PATCH 1/2] acinclude: Allow compile with Linux 4.11.

2017-04-14 Thread Ben Pfaff
On Thu, Apr 13, 2017 at 04:47:35PM -0700, Jarno Rajahalme wrote: > Change the Linux kernel tests in OVS configuration. > > While the backports may still be a little behind, it is useful to be > able to test the OVS tree kernel module with the upstream net-next > kernel. > > Signed-off-by: Jarno R

Re: [ovs-dev] [PATCH 2/2] dpif: Log packet metadata on execute.

2017-04-14 Thread Ben Pfaff
On Thu, Apr 13, 2017 at 04:47:36PM -0700, Jarno Rajahalme wrote: > Debug log output for execute operations is missing the packet > metadata, which can be instrumental in tracing what the datapath > should be executing. No reason to have the metadata on the debug > output, so add it there. > > Sig

Re: [ovs-dev] [branch-2.7 0/4] Backport of variable length metaflow field fixes.

2017-04-14 Thread Ben Pfaff
On Wed, Mar 15, 2017 at 04:01:37PM -0700, Joe Stringer wrote: > Commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs."), on > branch-2.7 as 9554b03d6ab7, attempted to address incorrect encode and decode > of > variable length metaflow fields where the OXM/NXM encoding of the varia

Re: [ovs-dev] [PATCH 5/5] dp-packet.h: Fix comments in dp_packet_source.

2017-04-14 Thread Ben Pfaff
On Sun, Mar 12, 2017 at 05:33:28PM +, Bhanuprakash Bodireddy wrote: > Add the appropriate function and the source file. > > Signed-off-by: Bhanuprakash Bodireddy This is obviously correct even to me, so I applied it to master. Thank you! (I don't plan to review the rest of the series.) ___

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

2017-04-14 Thread Ben Pfaff
On Sun, Mar 12, 2017 at 05:33:27PM +, Bhanuprakash Bodireddy wrote: > The sorted subtable ranking patch introduced a classifier instance per > ingress port with its subtables ranked on the frequency of hits. The pmd > thread can have more classifier instances now and solely depends on the > num

Re: [ovs-dev] [PATCH 2/2] ovn-util: Allow /32 IP addresses for router ports.

2017-04-14 Thread Ben Pfaff
On Thu, Mar 09, 2017 at 11:46:38PM -0800, Gurucharan Shetty wrote: > On Google cloud, a VM gets a /32 IP address. When OVN > is deployed on such VMs, the OVN gateway router's IP > address becomes a /32 IP address. This commit allows > such a configuration. > > Signed-off-by: Gurucharan Shetty A

Re: [ovs-dev] [PATCH 08/10] windows: return NULL in xreadlink

2017-04-14 Thread Ben Pfaff
On Mon, Feb 06, 2017 at 04:41:41AM +, Alin Serdean wrote: > readlink does not exist on Windows. > > While we could skip the function all togheter on Windows, we may add > support for it later on. For the moment return change errno to ENOENT > and return NULL. > > FYI: > https://blogs.windows.

Re: [ovs-dev] [PATCH 09/10] use portable getpagesize() in system-stats

2017-04-14 Thread Ben Pfaff
On Mon, Feb 06, 2017 at 04:41:41AM +, Alin Serdean wrote: > Use the intended portable function defined above "get_page_size()" not > "getpagesize()". > > Signed-off-by: Alin Gabriel Serdean I applied this to master. Thank you! ___ dev mailing list

Re: [ovs-dev] [PATCH 10/10] build-windows: cccl fail compilation on Wimplicit-function-declaration

2017-04-14 Thread Ben Pfaff
On Mon, Feb 06, 2017 at 04:41:41AM +, Alin Serdean wrote: > Gcc compiler argument -Wall contains -Wimplicit-function-declaration which > gives warnings when a function is used before declared. > Map VStudio compiler error C4013 to it. > More info on C4013: > https://msdn.microsoft.com/en-us/lib

Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

2017-04-14 Thread Ben Pfaff
On Mon, Feb 06, 2017 at 04:41:40AM +, Alin Serdean wrote: > Add fatal-signal.h include since it uses: fatal_signal_atexit_handler > and fatal_signal_add_hook > > Use the defined getpid() function and also include since > it is defined in include/windows/unistd.h . > > Signed-off-by: Alin Gab

Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

2017-04-14 Thread Ben Pfaff
If GetCurrentProcessId() is a reasonable substitute for getpid(), but the return type is different, then I would suggest an inline function, like this: static inline pid_t getpid(void) { return GetCurrentProcessId(); } Thanks, Ben. On Tue, Mar 07, 2017 at 09:07:55AM +, Sairam Venugopal

Re: [ovs-dev] [PATCH] doc: Apply flake8 to conf.py also.

2017-04-14 Thread Ben Pfaff
On Sat, Apr 15, 2017 at 01:43:09AM +0100, Stephen Finucane wrote: > On Fri, 2017-04-14 at 14:18 -0700, Ben Pfaff wrote: > > Suggested-by: Stephen Finucane > > Signed-off-by: Ben Pfaff > > Acked-by: Stephen Finucane Thanks, applied to master. ___ dev

Re: [ovs-dev] [PATCH v4 3/3] ovn-northd: Add logical flows to support native DNS

2017-04-14 Thread Ben Pfaff
On Mon, Apr 03, 2017 at 04:10:27PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, a new table 'DNS' is added in the NB DB. A new column >

Re: [ovs-dev] [PATCH v4 2/3] ovn-controller: Add 'dns_lookup' action

2017-04-14 Thread Ben Pfaff
On Mon, Apr 03, 2017 at 04:10:15PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new OVN action 'dns_lookup' to support native DNS. > ovn-controller parses this action and adds a NXT_PACKET_IN2 > OF flow with 'pause' flag set. > > A new table 'DNS' is added in th

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

2017-04-14 Thread Wang, Yipeng1
Thank you Darrell for the comments. Please take a look at my reply inlined. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Thursday, April 13, 2017 10:36 PM > To: Wang, Yipeng1 ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo

Re: [ovs-dev] [PATCH] doc: Apply flake8 to conf.py also.

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 14:18 -0700, Ben Pfaff wrote: > Suggested-by: Stephen Finucane > Signed-off-by: Ben Pfaff Acked-by: Stephen Finucane > --- >  Documentation/automake.mk | 2 +- >  Documentation/conf.py | 4 ++-- >  2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Docum

[ovs-dev] [PATCH 3/3] ofproto-dpif: Check support for resubmit with conntrack action.

2017-04-14 Thread Jarno Rajahalme
Use the existing probed support flag for the original direction tuple to determine if resubmit(ct) can be executed or not. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 86 ++ 1 file changed, 45 insertions(+), 41 deletions(-) diff --

[ovs-dev] [PATCH 2/3] ofproto-dpif: Check if original direction matches are supported.

2017-04-14 Thread Jarno Rajahalme
Use the existing probed support flag for the original direction tuple to determine if matches on the original direction tuple can be supported. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/ofproto/ofp

[ovs-dev] [PATCH 1/3] ofproto-dpif: Check support for CT action force commit flag.

2017-04-14 Thread Jarno Rajahalme
So far the force commit feature is implemented together with the original direction tuple feature by all datapaths, so we can use the support flag for the 'ct_orig_tuple' to indicate support for the force commit feature as well. Better fail the flow install than rely on ovs-vswitchd log being fill

Re: [ovs-dev] [PATCH v4 1/3] ovn-util: Add a new util function extract_ip_addresses

2017-04-14 Thread Ben Pfaff
On Mon, Apr 03, 2017 at 04:10:00PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > An upcoming commit will use this function to extract the IP (v4 and > v6) addresses from a string without a preceding eth address. > > Signed-off-by: Numan Siddique Acked-by: Ben Pfaff

Re: [ovs-dev] Layer seven processing

2017-04-14 Thread Ben Pfaff
On Sat, Apr 08, 2017 at 06:49:38PM +0430, sougol gheissi wrote: > I have seen a video on the OVS conference 2014 named OpenvSwitch L7 > matchers & conntrack metadata, which explains the relationship between OVS > and the nfq(network filter queue). I want to know about how to connect the > OVS and t

Re: [ovs-dev] [PATCH] doc: Add back target for datapath testing section.

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 04:04:08PM -0700, Andy Zhou wrote: > On Fri, Apr 14, 2017 at 3:57 PM, Ben Pfaff wrote: > > This one really is used. I'm honestly not sure how I missed this, because > > I did test things. > > > > Fixes: 9ef589e4daf7 ("doc: Remove some link targets that aren't used > > any

[ovs-dev] [datapath backport v2 10/10] datapath: Openvswitch: Refactor sample and recirc actions implementation

2017-04-14 Thread Andy Zhou
Upstream commit: Openvswitch: Refactor sample and recirc actions implementation Added clone_execute() that both the sample and the recirc action implementation can use. Signed-off-by: Andy Zhou Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Upstream: bef7f756

[ovs-dev] [datapath backport v2 09/10] datapath: openvswitch: Optimize sample action for the clone use cases

2017-04-14 Thread Andy Zhou
Upstream commit: openvswitch: Optimize sample action for the clone use cases With the introduction of open flow 'clone' action, the OVS user space can now translate the 'clone' action into kernel datapath 'sample' action, with 100% probability, to ensure that the clone semantics,

[ovs-dev] [datapath backport v2 08/10] datapath: openvswitch: Refactor recirc key allocation.

2017-04-14 Thread Andy Zhou
Upstream commit: openvswitch: Refactor recirc key allocation. The logic of allocating and copy key for each 'exec_actions_level' was specific to execute_recirc(). However, future patches will reuse as well. Refactor the logic into its own function clone_key(). Signed-off-by:

[ovs-dev] [datapath backport v2 07/10] datapath: openvswitch: Deferred fifo API change.

2017-04-14 Thread Andy Zhou
Upstream commit: openvswitch: Deferred fifo API change. add_deferred_actions() API currently requires actions to be passed in as a fully encoded netlink message. So far both 'sample' and 'recirc' actions happens to carry actions as fully encoded netlink messages. However, this

[ovs-dev] [datapath backport v2 06/10] datapath: openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

2017-04-14 Thread Andy Zhou
From: Kris Murphy openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement in ip_tun_from_nlattr in order to prevent the default case returning an error. Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-

[ovs-dev] [datapath backport v2 05/10] datapath: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly

2017-04-14 Thread Andy Zhou
From: Or Gerlitz Upstream commit: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly When dealing with ipv6 source tunnel key address attribute (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel dst ip, fix that. Fixes: 6b26ba3a7d95 ('o

[ovs-dev] [datapath backport v2 03/10] compat: ipv6: orphan skbs in reassembly unit.

2017-04-14 Thread Andy Zhou
From: Eric Dumazet Upstream commit: ipv6: orphan skbs in reassembly unit Andrey reported a use-after-free in IPv6 stack. Issue here is that we free the socket while it still has skb in TX path and in some queues. It happens here because IPv6 reassembly unit messes skb->true

[ovs-dev] [datapath backport v2 04/10] datapath: actions: fixed a brace coding style warning.

2017-04-14 Thread Andy Zhou
From: Peter Downs Upstream commit: openvswitch: actions: fixed a brace coding style warning Fixed a brace coding style warning reported by checkpatch.pl Signed-off-by: Peter Downs Signed-off-by: David S. Miller Upstream: f1304f7ba398 ("openvswitch: actions: fixed a brace codi

[ovs-dev] [datapath backport v2 02/10] datapath: Pack struct sw_flow_key.

2017-04-14 Thread Andy Zhou
From: Jarno Rajahalme Upstream commit: openvswitch: Pack struct sw_flow_key. struct sw_flow_key has two 16-bit holes. Move the most matched conntrack match fields there. In some typical cases this reduces the size of the key that needs to be hashed into half and into one cache

[ovs-dev] [datapath backport v2 01/10] datapath: Always define NF_CT_LABELS_MAX_SIZE

2017-04-14 Thread Andy Zhou
When CONFIG_NF_CONNTRACK_LABLES is not set, upstream code still make use of NF_CT_LABLES_MAX_SIZE. Always define it in the compat code to keep back ports close to the upstream. Signed-off-by: Andy Zhou --- v1->v2: Drop the v1, change to always export NF_CT_LABELS_MAX_SIZE --- datapath/linux/co

Re: [ovs-dev] [PATCH] doc: Add back target for datapath testing section.

2017-04-14 Thread Andy Zhou
On Fri, Apr 14, 2017 at 3:57 PM, Ben Pfaff wrote: > This one really is used. I'm honestly not sure how I missed this, because > I did test things. > > Fixes: 9ef589e4daf7 ("doc: Remove some link targets that aren't used > anywhere.") > Reported-by: Andy Zhou > Signed-off-by: Ben Pfaff Thanks

[ovs-dev] [PATCH] doc: Add back target for datapath testing section.

2017-04-14 Thread Ben Pfaff
This one really is used. I'm honestly not sure how I missed this, because I did test things. Fixes: 9ef589e4daf7 ("doc: Remove some link targets that aren't used anywhere.") Reported-by: Andy Zhou Signed-off-by: Ben Pfaff --- Documentation/topics/testing.rst | 2 ++ 1 file changed, 2 insertion

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd ipam: Support IPv6 dynamic assignment

2017-04-14 Thread Ben Pfaff
On Fri, Mar 10, 2017 at 07:47:20AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN will generate the IPv6 address for a logical port if requested > using the IPv6 prefix and the MAC address (as IEEE EUI64 identifier). > To generate the IPv6 address, CMS should define the IPv6 pre

Re: [ovs-dev] [PATCH v3 1/2] ovn-northd ipam: Support 'exclude_ips' option

2017-04-14 Thread Ben Pfaff
On Fri, Mar 10, 2017 at 07:46:58AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > If the CMS wants to make use of ovn ipam it can now provide a > list of IPv4 addresses and a range of IPv4 addresses which > will be excluded from the dynamic address assignment. > To support this, a n

Re: [ovs-dev] [PATCH v4] netdev-dpdk: leverage the mempool offload support

2017-04-14 Thread Darrell Ball
Acked-by: Darrell Ball On 4/12/17, 10:31 PM, "Hemant Agrawal" wrote: DPDK 16.07 introduced the support for mempool offload support. rte_pktmbuf_pool_create is the recommended method for creating pktmbuf pools. Buffer pools created with rte_mempool_create may not get offloaded to

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-04-14 Thread Darrell Ball
Acked-by: Darrell Ball On 4/10/17, 4:21 AM, "Kevin Traynor" wrote: On 04/10/2017 08:03 AM, Darrell Ball wrote: > > > On 4/5/17, 7:52 AM, "ovs-dev-boun...@openvswitch.org on behalf of O Mahony, Billy" wrote: > > > -Original Message- > > From: Kevi

Re: [ovs-dev] [PATCH] ofproto/bond: Make bond_may_recirc() private within bond.c

2017-04-14 Thread Ben Pfaff
On Thu, Mar 09, 2017 at 04:52:27PM -0800, Andy Zhou wrote: > Minor refactoring to make the bond code easier to read. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listin

[ovs-dev] [PATCH] doc: Apply flake8 to conf.py also.

2017-04-14 Thread Ben Pfaff
Suggested-by: Stephen Finucane Signed-off-by: Ben Pfaff --- Documentation/automake.mk | 2 +- Documentation/conf.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/automake.mk b/Documentation/automake.mk index 9911668c1ca9..8d18bd9714a4 100644 --- a/Doc

Re: [ovs-dev] [PATCH] ofproto: Add support of OFPR_PACKET_OUT as packet-in reason

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 10:20:10AM -0700, Yi-Hung Wei wrote: > This patch adds support of OFPR_PACKET_OUT as the packet-in reason. > This packet-in reason is a required feature for OF1.4+, and it indicates > that the associated packet-in message to the controller is triggered when > the switch is p

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 09:00:49PM +0100, Stephen Finucane wrote: > On Fri, 2017-04-14 at 12:49 -0700, Ben Pfaff wrote: > > On Fri, Apr 14, 2017 at 06:55:38PM +0100, Stephen Finucane wrote: > > > On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > > > > Thank you!  rST is much more readable than

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 12:49 -0700, Ben Pfaff wrote: > On Fri, Apr 14, 2017 at 06:55:38PM +0100, Stephen Finucane wrote: > > On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > > > Thank you!  rST is much more readable than nroff.  I have some > > > comments > > > below. > > > > > > On Mon, Apr 1

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Add 'meter_ids' to backer

2017-04-14 Thread Andy Zhou
Please ignore this patch. On Fri, Apr 14, 2017 at 12:46 PM, Andy Zhou wrote: > Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. > provider_meter_id. > > Currently, only userspace datapath supports meter, and it implements > the provider_meter_id management. Moving this functio

Re: [ovs-dev] [PATCH 3/3] doc: Remove some link targets that aren't used anywhere.

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 07:41:24PM +0100, Stephen Finucane wrote: > On Fri, 2017-04-14 at 10:31 -0700, Ben Pfaff wrote: > > It seems that there's a style here that every title has a separate > > link > > target even if it's never used.  Maybe there is some reason for that > > (maybe > > it should b

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 06:55:38PM +0100, Stephen Finucane wrote: > On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > > Thank you!  rST is much more readable than nroff.  I have some > > comments > > below. > > > > On Mon, Apr 10, 2017 at 01:12:28PM +0100, Stephen Finucane wrote: > > > Let's s

[ovs-dev] [action upcall meters 5/5] ofproto: Meter slowpath action when action upcall meters are configured

2017-04-14 Thread Andy Zhou
If a slow path action is a controller action, meter it when the controller meter is configured. For other kinds of slow path actions, meter it when the slowpath meter is configured. Note, this patch only considers the meters configuration of the packet's input bridge, which may not be the same br

[ovs-dev] [action upcall meters 4/5] ofproto: Meter sample action when configured.

2017-04-14 Thread Andy Zhou
When slowpath meter is configured, add meter action when translate sample action. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif-xlate.c | 9 + tests/ofproto-dpif.at| 14 ++ 2 files changed, 23 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofp

[ovs-dev] [action upcall meters 3/5] ofproto: Support action upcall meters

2017-04-14 Thread Andy Zhou
Allow action upcall meters, i.e. slowpath and controller meters, to be added and displayed. Keep track of datapath meter ID of those action upcall meters in ofproto to aid action translation. Later patches will make use of them. Signed-off-by: Andy Zhou --- lib/ofp-print.c| 33 +

[ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

2017-04-14 Thread Andy Zhou
Add 'meter_ids', an id-pool object to manage datapath meter id. Currently, only userspace datapath supports meter, and it implements the provider_meter_id management. Moving this function to 'backer' allows other datapath implementation to share the same logic. Signed-off-by: Andy Zhou --- lib/

[ovs-dev] [action upcall meters 2/5] ofproto-dpif: Add 'meter_ids' to backer

2017-04-14 Thread Andy Zhou
Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. provider_meter_id. Currently, only userspace datapath supports meter, and it implements the provider_meter_id management. Moving this function to 'backer' allows other datapath implementation to share the same logic. Signed-off-

[ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-14 Thread Andy Zhou
Currently, meters are stored in a fixed pointer array. It is not very efficient since the controller, at least in theory, can pick any meter id (up to the limits to uint32_t), not necessarily within the lower end of a region, or in close range to each other. In particular, OFPM_SLOWPATH and OFPM_CO

Re: [ovs-dev] [PATCH 1/6] doc: Also delete stamp file in clean-docs target.

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 06:16:19PM +0100, Stephen Finucane wrote: > On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > > Otherwise "make docs-check" won't necessarily do anything since its > > apparent target is up to date. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Stephen Finucane Tha

Re: [ovs-dev] [PATCH 2/6] doc: Avoid need to generate conf.py.

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 06:20:43PM +0100, Stephen Finucane wrote: > On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > > It's awkward to have to at the same time generate conf.py from > > conf.py.in > > and to keep both versions in the repository.  This avoids the issue. > > > > Signed-off-by:

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Implement Tx intermediate queue for dpdk ports.

2017-04-14 Thread Bodireddy, Bhanuprakash
The latency stats published in v3(https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328363.html) seems to be erroneous due to the way the RFC2544 test was configured in IXIA. Please find below the updated latency stats. Only case 1 and Case 2 stats are published below, where the burst

Re: [ovs-dev] [PATCH 3/3] doc: Remove some link targets that aren't used anywhere.

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 10:31 -0700, Ben Pfaff wrote: > It seems that there's a style here that every title has a separate > link > target even if it's never used.  Maybe there is some reason for that > (maybe > it should be explained in the documentation style document?), but if > not > then it seem

Re: [ovs-dev] [PATCH 2/3] doc: Convert a named link into a title link.

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 10:31 -0700, Ben Pfaff wrote: > It seems like this is easier to read in the source form.  I don't > understand what is typical style here, though. > > Signed-off-by: Ben Pfaff Acked-by: Stephen Finucane ___ dev mailing list d...

Re: [ovs-dev] [PATCH 1/3] doc: Convert some bolded words into links.

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 10:31 -0700, Ben Pfaff wrote: > Seems more user-friendly. > > Signed-off-by: Ben Pfaff Acked-by: Stephen Finucane ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] lib/automake.mk: don't install runtime directories

2017-04-14 Thread Ben Pfaff
On Thu, Apr 13, 2017 at 01:51:30PM -0400, Aaron Conole wrote: > The Open vSwitch run, log, and DB directories are installed as part of the > normal `make install` process. However, this means they are created with > user and group ownership that may conflict with the desired user. For > example,

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > Thank you!  rST is much more readable than nroff.  I have some > comments > below. > > On Mon, Apr 10, 2017 at 01:12:28PM +0100, Stephen Finucane wrote: > > Let's start with a simple one that lets us focus on setting up most > > of the required

Re: [ovs-dev] [PATCH 1/2] install-doc: suggest to use ovs-ctl for start/stop

2017-04-14 Thread Ben Pfaff
On Thu, Apr 13, 2017 at 01:51:29PM -0400, Aaron Conole wrote: > The install documentation guided users to manually start/stop > daemons. This is good information to have, but with the > existence of ovs-ctl, is probably not the best way to start > guiding new users of ovs. > > Suggest that users

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

2017-04-14 Thread Greg Rose
On Fri, 2017-04-14 at 10:03 -0700, Ben Pfaff wrote: > On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote: > > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > > > does not exist") updated the RHEL logrotate

Re: [ovs-dev] [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2017 18:44:46 +0200 Matthias Schiffer wrote: > As link-local addresses are only valid for a single interface, we can allow > to use the same VNI for multiple independent VXLANs, as long as the used > interfaces are distinct. This way, VXLANs can always be used as a drop-in > replac

Re: [ovs-dev] [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2017 18:44:44 +0200 Matthias Schiffer wrote: > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c > index 07f89b037681..95a71546e8f2 100644 > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2881,11 +2881,39 @@ static int vxlan_config_validate(struct net *src_net, >

[ovs-dev] [PATCH 3/3] doc: Remove some link targets that aren't used anywhere.

2017-04-14 Thread Ben Pfaff
It seems that there's a style here that every title has a separate link target even if it's never used. Maybe there is some reason for that (maybe it should be explained in the documentation style document?), but if not then it seems reasonable to leave out the unused ones since they look to me li

[ovs-dev] [PATCH 2/3] doc: Convert a named link into a title link.

2017-04-14 Thread Ben Pfaff
It seems like this is easier to read in the source form. I don't understand what is typical style here, though. Signed-off-by: Ben Pfaff --- Documentation/topics/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topi

[ovs-dev] [PATCH 1/3] doc: Convert some bolded words into links.

2017-04-14 Thread Ben Pfaff
Seems more user-friendly. Signed-off-by: Ben Pfaff --- Documentation/intro/install/general.rst | 5 +++-- Documentation/topics/testing.rst| 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/gener

Re: [ovs-dev] [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Sergei Shtylyov
On 04/14/2017 07:44 PM, Matthias Schiffer wrote: * Multicast addresses are never valid as local address * Link-local IPv6 unicast addresses may only be used as remote when the local address is link-local as well * Don't allow link-local IPv6 local/remote addresses without interface We also st

Re: [ovs-dev] [PATCH 2/6] doc: Avoid need to generate conf.py.

2017-04-14 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > It's awkward to have to at the same time generate conf.py from > conf.py.in > and to keep both versions in the repository.  This avoids the issue. > > Signed-off-by: Ben Pfaff > --- >  Documentation/automake.mk |  10 -- >  Documentation/conf.p

[ovs-dev] [PATCH] ofproto: Add support of OFPR_PACKET_OUT as packet-in reason

2017-04-14 Thread Yi-Hung Wei
This patch adds support of OFPR_PACKET_OUT as the packet-in reason. This packet-in reason is a required feature for OF1.4+, and it indicates that the associated packet-in message to the controller is triggered when the switch is processing a packet-out message. This reason code is enabled by defaul

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

2017-04-14 Thread Greg Rose
On Fri, 2017-04-14 at 09:05 -0700, Greg Rose wrote: > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > > does not exist") updated the RHEL logrotate configuration. This commit > > makes similar changes for Debian, b

Re: [ovs-dev] [PATCH 1/6] doc: Also delete stamp file in clean-docs target.

2017-04-14 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > Otherwise "make docs-check" won't necessarily do anything since its > apparent target is up to date. > > Signed-off-by: Ben Pfaff Acked-by: Stephen Finucane ___ dev mailing list d...@openvswitch.or

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote: > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > > does not exist") updated the RHEL logrotate configuration. This commit > > makes similar changes for De

[ovs-dev] [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Matthias Schiffer
* Multicast addresses are never valid as local address * Link-local IPv6 unicast addresses may only be used as remote when the local address is link-local as well * Don't allow link-local IPv6 local/remote addresses without interface We also store in the flags field if link-local addresses are u

[ovs-dev] [PATCH net-next v2 5/6] vxlan: fix snooping for link-local IPv6 addresses

2017-04-14 Thread Matthias Schiffer
If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Signed-off-by: Matthias Schiffer --- v2: use u32 instead of __u32 drivers/net/vxlan.c | 20 ++

[ovs-dev] [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-04-14 Thread Matthias Schiffer
As link-local addresses are only valid for a single interface, we can allow to use the same VNI for multiple independent VXLANs, as long as the used interfaces are distinct. This way, VXLANs can always be used as a drop-in replacement for VLANs with greater ID space. This also extends VNI lookup t

[ovs-dev] [PATCH net-next v2 1/6] vxlan: refactor verification and application of configuration

2017-04-14 Thread Matthias Schiffer
The vxlan_dev_configure function was mixing validation and application of the vxlan configuration; this could easily lead to bugs with the changelink operation, as it was hard to see if the function wcould return an error after parts of the configuration had already been applied. This commit split

[ovs-dev] [PATCH net-next v2 3/6] vxlan: improve validation of address family configuration

2017-04-14 Thread Matthias Schiffer
Address families of source and destination addresses must match, and changelink operations can't change the address family. In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses IPv4 or IPv6. Signed-off-by: Matthias Schiffer --- v2: new patch drivers/net/vxlan.c | 39 ++

[ovs-dev] [PATCH net-next v2 2/6] vxlan: get rid of redundant vxlan_dev.flags

2017-04-14 Thread Matthias Schiffer
There is no good reason to keep the flags twice in vxlan_dev and vxlan_config. Signed-off-by: Matthias Schiffer --- v2: new patch drivers/net/vxlan.c | 76 +-- include/net/vxlan.h | 1 - net/openvswitch/vport-vxlan.c | 4 +-- 3 file

[ovs-dev] [PATCH net-next v2 0/6] vxlan: cleanup and IPv6 link-local support

2017-04-14 Thread Matthias Schiffer
Running VXLANs over IPv6 link-local addresses allows to use them as a drop-in replacement for VLANs, avoiding to allocate additional outer IP addresses to run the VXLAN over. Since v1, I have added a lot more consistency checks to the address configuration, making sure address families and scopes

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

2017-04-14 Thread Greg Rose
On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > does not exist") updated the RHEL logrotate configuration. This commit > makes similar changes for Debian, by synchronizing with the RHEL version. > > In particular: >

Re: [ovs-dev] OVN meeting report

2017-04-14 Thread Ben Pfaff
On Fri, Apr 14, 2017 at 02:48:40PM +0500, Valentine Sinitsyn wrote: > On 13.04.2017 20:53, Ben Pfaff wrote: > >On Wed, Apr 12, 2017 at 06:09:28PM +0500, Valentine Sinitsyn wrote: > >>Is there some design outline for the missing implementation bits? > >>Specifically, it would be good to know the fol

Re: [ovs-dev] Is there a non recursive version of json_destroy and json_serialize?

2017-04-14 Thread Ben Pfaff
It seems unlikely that recursion would be the problem, because OVS does not serialize deeply nested JSON. On Fri, Apr 14, 2017 at 05:50:06PM +0800, 网络尖兵 wrote: > Hello, everyone! > I am trying to port openvswitch to MIPS64 platform. A segfault problem was > occurred when it was sending a huge js

[ovs-dev] Is there a non recursive version of json_destroy and json_serialize?

2017-04-14 Thread ????????
Hello, everyone! I am trying to port openvswitch to MIPS64 platform. A segfault problem was occurred when it was sending a huge json buffer between ovsdb-server and ovsdb-client through its monitor ALL command. I found that, in the OVS version I use, the json_destroy and json_serialize functio

Re: [ovs-dev] OVN meeting report

2017-04-14 Thread Valentine Sinitsyn
Hi Ben, On 13.04.2017 20:53, Ben Pfaff wrote: On Wed, Apr 12, 2017 at 06:09:28PM +0500, Valentine Sinitsyn wrote: Hi, On 04.04.2017 15:29, Valentine Sinitsyn wrote: On 03.04.2017 20:29, Valentine Sinitsyn wrote: Hi Ben, On 23.03.2017 08:11, Ben Pfaff wrote: Hello everyone. I am not sure w