Hi Ben/Ilya,
I have addressed the comments in the below patch. Can you tell me if this is
fine?
Regards
Anju
-Original Message-
From: Anju Thomas [mailto:anju.tho...@ericsson.com]
Sent: Tuesday, January 29, 2019 5:21 PM
To: d...@openvswitch.org
Cc: Anju Thomas
Subject: [PATCHv7 1/3]
On Tue, Feb 05, 2019 at 04:26:56PM -0800, Ashish Varma wrote:
> In the parse_flow_monitor_request(), usable_protocols is an out parameter.
> (and is set in parse_flow_monitor_request() only if a match field is
> provided. )
> allowed_versions on the other hand is used only in the ofctl_monitor
>
Thanks for the review!
In the parse_flow_monitor_request(), usable_protocols is an out parameter.
(and is set in parse_flow_monitor_request() only if a match field is
provided. )
allowed_versions on the other hand is used only in the ofctl_monitor
function. That is the reason for the check in
On Tue, Feb 05, 2019 at 12:50:16PM -0800, Justin Pettit wrote:
>
> > On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
> >
> > Normally it makes sense for an active connection to be primary and a
> > passive connection to be a service connection, but I've run into a corner
> > case where it is
On Tue, Feb 05, 2019 at 12:51:12PM -0800, Justin Pettit wrote:
>
> > On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
> >
> > If a passive controller chooses to configure itself as a slave controller,
> > I don't know a reason why it should be considered "equal" for some
> > purposes.
> >
> >
On Fri, Jan 11, 2019 at 12:16:39AM +, Ankur Sharma wrote:
> This patch allows user to associate a value with acl,
> which will be assigned to ct.label of the corresponding
> connection tracking entry.
>
> This value can be used to map a ct entry with corresponding
> OVN ACL or higher level
On Fri, Jan 11, 2019 at 12:16:38AM +, Ankur Sharma wrote:
> OVN allows only an integer (or masked integer) to be assigned to
> ct_mark and ct_label.
>
> This patch, enhances the parser code to allow ct_mark and ct_label
> to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128
>
On Fri, Jan 11, 2019 at 12:16:35AM +, Ankur Sharma wrote:
> OVN ACL implementation used ct_label to indicate if a previosuly
> allowed connection shoudl not be allowed anymore and vice versa.
>
> However, ct_label is a 128 bit value and we should rather leverage
> on ct_mark which is a 32 bit
On 1/31/2019 10:38 AM, Aaron Conole wrote:
Martin Xu writes:
OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the
config file. This variable is replaced by OPTIONS in systemd service
files. This patch addes $OVS_CTL_OPTS back to be passed along with $OPTIONS
for backward
> On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
>
> If a passive controller chooses to configure itself as a slave controller,
> I don't know a reason why it should be considered "equal" for some
> purposes.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
> On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
>
> Normally it makes sense for an active connection to be primary and a
> passive connection to be a service connection, but I've run into a corner
> case where it is better for a passive connection to be a primary
> connection. This specific
Alin Gabriel Serdean writes:
> Using python `sys.exit(-1)` on Windows produces mixed results.
> Let's take the following results from different shells:
> CMD
>>python -c "import sys; sys.exit(-1)" & echo %errorlevel%
> 1
> MSYS
> $ python -c "import sys; sys.exit(-1)" && echo $?
> 0
> WSL
> $
On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote:
>
> On 2/5/2019 4:02 AM, Eli Britstein wrote:
> > On 2/4/2019 10:07 PM, David Miller wrote:
> > > From: Yi-Hung Wei
> > > Date: Mon, 4 Feb 2019 10:47:18 -0800
> > >
> > > > For example, to see how 'struct ovs_key_ipv6' is defined,
On Tue, Feb 05, 2019 at 06:43:08PM +0300, Ilya Maximets wrote:
> Hi Flavio.
> Thanks for taking a look.
>
> On 05.02.2019 15:38, Flavio Leitner wrote:
> >
> > Hi Ilya,
> >
> > Thanks for the patch and I think we knew about that pain when we
> > exposed the very first parameter. I still remember
On 2/5/2019 4:02 AM, Eli Britstein wrote:
On 2/4/2019 10:07 PM, David Miller wrote:
From: Yi-Hung Wei
Date: Mon, 4 Feb 2019 10:47:18 -0800
For example, to see how 'struct ovs_key_ipv6' is defined, now we need
to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR
and
On Mon, Feb 04, 2019 at 05:25:50PM -0800, Justin Pettit wrote:
>
> > On Jan 17, 2019, at 4:20 PM, Ben Pfaff wrote:
> >
> > ONF abandoned the OpenFlow specification, so that OpenFlow 1.6 will never
> > be completed. It did not contain much in the way of useful features, so
> > remove what
On Mon, Feb 04, 2019 at 05:51:11PM -0800, Justin Pettit wrote:
>
> > On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
> >
> > Until now, connmgr has handled active and passive OpenFlow connections in
> > quite different ways. Any active connection, whether it was currently
> > connected or not,
On Tue, Feb 05, 2019 at 05:05:19PM +0200, Alin Gabriel Serdean wrote:
> Using python `sys.exit(-1)` on Windows produces mixed results.
> Let's take the following results from different shells:
> CMD
> >python -c "import sys; sys.exit(-1)" & echo %errorlevel%
> 1
> MSYS
> $ python -c "import sys;
Hi Flavio.
Thanks for taking a look.
On 05.02.2019 15:38, Flavio Leitner wrote:
>
> Hi Ilya,
>
> Thanks for the patch and I think we knew about that pain when we
> exposed the very first parameter. I still remember Aaron struggling
> to find the best path forward. Time flies and here we are.
>
Using python `sys.exit(-1)` on Windows produces mixed results.
Let's take the following results from different shells:
CMD
>python -c "import sys; sys.exit(-1)" & echo %errorlevel%
1
MSYS
$ python -c "import sys; sys.exit(-1)" && echo $?
0
WSL
$ python -c "import sys; sys.exit(-1)"; echo $?
255
On Tue, Feb 05, 2019 at 10:16:04AM +0300, Ilya Maximets wrote:
> CDN links are much faster in average. https://www.kernel.org/
> links shows usually less than 10 MB/s, while https://cdn.kernel.org/
> could give up to 200 MB/s and usually shows speeds much higher than
> 10 MB/s. Also, 'xz' archives
On 05.02.2019 16:09, Asaf Penso wrote:
>
>
> Regards,
> Asaf Penso
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Tuesday, February 5, 2019 1:46 PM
>> To: Asaf Penso ; ovs-dev@openvswitch.org
>> Cc: Roni Bar Yanai ; Stokes, Ian
>> ; Finn Christensen
>> Subject: Re:
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, February 5, 2019 1:46 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
> ; Finn Christensen
> Subject: Re: [ovs-dev,v2] netdev-dpdk: Memset rte_flow_item on a need
> basis.
Hi Ilya,
Thanks for the patch and I think we knew about that pain when we
exposed the very first parameter. I still remember Aaron struggling
to find the best path forward. Time flies and here we are.
The problem is that this change is not friendly from the community
perspective to its users.
On 2/4/2019 10:07 PM, David Miller wrote:
> From: Yi-Hung Wei
> Date: Mon, 4 Feb 2019 10:47:18 -0800
>
>> For example, to see how 'struct ovs_key_ipv6' is defined, now we need
>> to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR
>> and OVS_KEY_FIELD defined. I think it
On 04.02.2019 19:14, Asaf Penso wrote:
> In netdev_dpdk_add_rte_flow_offload function different rte_flow_item are
> created as part of the pattern matching.
>
> For most of them, there is a check whether the wildcards are not zero.
> In case of zero, nothing is being done with the rte_flow_item.
26 matches
Mail list logo
