Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Chris Mi via dev
On 2/28/2024 8:51 PM, Ilya Maximets wrote: On 2/28/24 13:26, Chris Mi wrote: Hi Ilya, On 2/28/2024 7:56 PM, Ilya Maximets wrote: On 2/28/24 11:03, Eelco Chaudron wrote: On 28 Feb 2024, at 8:06, Chris Mi wrote: Hi Eelco, I did a rebase and pushed to github. Nothing changed, but the

Re: [ovs-dev] [PATCH v2] ovsdb: Don't iterate over rows on empty mutation.

2024-02-28 Thread Mike Pattrick
On Wed, Feb 28, 2024 at 8:41 AM Ilya Maximets wrote: > > On 2/22/24 17:37, Mike Pattrick wrote: > > Previously when an empty mutation was used to count the number of rows > > in a table, OVSDB would iterate over all rows twice. First to perform an > > RBAC check, and then to perform the

Re: [ovs-dev] [PATCH v2] ovsdb: Don't iterate over rows on empty mutation.

2024-02-28 Thread Ilya Maximets
On 2/22/24 17:37, Mike Pattrick wrote: > Previously when an empty mutation was used to count the number of rows > in a table, OVSDB would iterate over all rows twice. First to perform an > RBAC check, and then to perform the no-operation. > > This change adds a short circuit to mutate operations

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 14:07, Ilya Maximets wrote: > On 2/28/24 10:35, Eelco Chaudron wrote: >> >> >> On 28 Feb 2024, at 10:15, Simon Horman wrote: >> >>> On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: On 27 Feb 2024, at 16:36, Simon Horman wrote: > IANAL,

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Ilya Maximets
On 2/28/24 10:35, Eelco Chaudron wrote: > > > On 28 Feb 2024, at 10:15, Simon Horman wrote: > >> On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: >>> >>> >>> On 27 Feb 2024, at 16:36, Simon Horman wrote: >>> IANAL, but I think we can extend the copyright attached to

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Ilya Maximets
On 2/28/24 13:26, Chris Mi wrote: > Hi Ilya, > > On 2/28/2024 7:56 PM, Ilya Maximets wrote: >> On 2/28/24 11:03, Eelco Chaudron wrote: >>> >>> >>> On 28 Feb 2024, at 8:06, Chris Mi wrote: >>> Hi Eelco, I did a rebase and pushed to github. Nothing changed, but the actions

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Chris Mi via dev
Hi Ilya, On 2/28/2024 7:56 PM, Ilya Maximets wrote: On 2/28/24 11:03, Eelco Chaudron wrote: On 28 Feb 2024, at 8:06, Chris Mi wrote: Hi Eelco, I did a rebase and pushed to github. Nothing changed, but the actions always reported the following failure: -1000 packets transmitted, 1000

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Ilya Maximets
On 2/28/24 11:03, Eelco Chaudron wrote: > > > On 28 Feb 2024, at 8:06, Chris Mi wrote: > >> Hi Eelco, >> >> I did a rebase and pushed to github. Nothing changed, but the actions always >> reported the following failure: >> >> -1000 packets transmitted, 1000 received, 0% packet loss, time 0ms

Re: [ovs-dev] [PATCH ovn v3] ci: Update crun in GitHub actions runner.

2024-02-28 Thread Dumitru Ceara
On 2/28/24 08:18, Mohammad Heib wrote: > There are some issues with older crun and newer kernel > combination [0]. Unfortunately Ubuntu 22.04 falls into this > category and the jobs will often time fail. Temoprarily use > newer crun from git that has the fix [1]. > > [0]

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

2024-02-28 Thread Dumitru Ceara
On 2/16/24 16:34, Ales Musil wrote: > On Fri, Feb 16, 2024 at 4:27 PM Numan Siddique wrote: > >> On Fri, Feb 16, 2024 at 9:52 AM Dumitru Ceara wrote: >>> >>> On 2/16/24 14:40, Ales Musil wrote: There are some issues with older crun and newer kernel combination [0]. Unfortunately

[ovs-dev] [PATCH ovn v3] controller: Release container lport when releasing parent port.

2024-02-28 Thread Mohammad Heib
Currently if the user sets the container parent_port:requested-chassis option after the VIF/CIF is bonded to the chassis, this will migrate the VIF/CIF flows to the new chassis but will still have the container flows installed in the old chassis which can allow unwanted tagged traffic to reach

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 8:06, Chris Mi wrote: > Hi Eelco, > > I did a rebase and pushed to github. Nothing changed, but the actions always > reported the following failure: > > -1000 packets transmitted, 1000 received, 0% packet loss, time 0ms > +744 packets transmitted, 744 received, 0% packet

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 4:38, Chris Mi wrote: > On 2/28/2024 9:20 AM, Chris Mi via dev wrote: >> On 2/27/2024 6:54 PM, Eelco Chaudron wrote: >>> >>> >>> On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: >>> On 9 Jan 2024, at 10:22, Chris Mi wrote: > Hi Roi and Eelco, > > Sorry for

Re: [ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > This updates links to several upstream Kernel documents. > > 1. Lore is now the canonical archive for the netdev mailing list > > 2. net-next is now maintained by the netdev team, >of which David Miller is currently a member, >rather than

Re: [ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > Update link to OCF Resource Agents documentation as the existing link > is broken. Also, use HTTPS. > > Broken link flagged by make check-docs > > Signed-off-by: Simon Horman Thanks for checking. Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH 3/5] Documentation: Anuket project updates.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > The Anuket was formed by a merger of OPNFV and CNTT [1]. > > Also, VswitchPerf, aka vsperf, formerly an OPNFV project, > has been renamed ViNePerf [2]. > > Update links and documentation accordingly. > > The old links were broken, this was

Re: [ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-02-28 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > Correct spelling errors in .rst files flagged by codespell. Some small nits below. //Eelco > Signed-off-by: Simon Horman > --- > Documentation/howto/sflow.rst | 2 +- > Documentation/howto/tc-offload.rst| 4 ++--

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Eelco Chaudron
On 28 Feb 2024, at 10:15, Simon Horman wrote: > On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: >> >> >> On 27 Feb 2024, at 16:36, Simon Horman wrote: >> >>> IANAL, but I think we can extend the copyright attached >>> to documentation to cover the current year: we are still >>>

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-28 Thread Simon Horman
On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron wrote: > > > On 27 Feb 2024, at 16:36, Simon Horman wrote: > > > IANAL, but I think we can extend the copyright attached > > to documentation to cover the current year: we are still > > actively working on the documentation. > > > >